* [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc
@ 2018-08-13 13:45 Maarten Lankhorst
2018-08-13 13:57 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2018-08-13 13:45 UTC (permalink / raw)
To: intel-gfx; +Cc: Kristian H . Kristensen, Sean Paul
Disabling cursor does not take effect until the next vblank, but if the
pipe is shut down too quickly after a cursor disable, we will see
random corruption from where the mouse cursor used to be when the pipe
is enabled again.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106478
References: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/877396/
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Sean Paul <seanpaul@google.com>
Cc: Kristian H. Kristensen <hoegsberg@chromium.org>
---
drivers/gpu/drm/i915/intel_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a2aed7e3ed0d..a02c77a3bc7e 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12673,6 +12673,9 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
*/
intel_crtc_disable_pipe_crc(intel_crtc);
+ /* Wait a vblank for planes to actually be turned off */
+ intel_wait_for_vblank(dev_priv, intel_crtc->pipe);
+
dev_priv->display.crtc_disable(to_intel_crtc_state(old_crtc_state), state);
intel_crtc->active = false;
intel_fbc_disable(intel_crtc);
--
2.18.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Wait for vblank between disabling planes and disabling crtc
2018-08-13 13:45 [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc Maarten Lankhorst
@ 2018-08-13 13:57 ` Patchwork
2018-08-13 14:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-13 16:20 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-08-13 13:57 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Wait for vblank between disabling planes and disabling crtc
URL : https://patchwork.freedesktop.org/series/48113/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a46c5d644c7f drm/i915: Wait for vblank between disabling planes and disabling crtc
-:13: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#13:
References: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/877396/
total: 0 errors, 1 warnings, 0 checks, 9 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Wait for vblank between disabling planes and disabling crtc
2018-08-13 13:45 [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc Maarten Lankhorst
2018-08-13 13:57 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-08-13 14:14 ` Patchwork
2018-08-13 16:20 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-08-13 14:14 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Wait for vblank between disabling planes and disabling crtc
URL : https://patchwork.freedesktop.org/series/48113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4662 -> Patchwork_9930 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48113/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_9930 that come from known issues:
=== IGT changes ===
==== Issues hit ====
{igt@amdgpu/amd_prime@amd-to-i915}:
{fi-kbl-8809g}: NOTRUN -> FAIL (fdo#107341)
igt@drv_module_reload@basic-reload:
fi-ilk-650: PASS -> DMESG-WARN (fdo#106387)
==== Possible fixes ====
{igt@amdgpu/amd_basic@userptr}:
{fi-kbl-8809g}: INCOMPLETE (fdo#107402) -> PASS
igt@kms_frontbuffer_tracking@basic:
{fi-byt-clapper}: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
== Participating hosts (54 -> 49) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4662 -> Patchwork_9930
CI_DRM_4662: 3010d040760de7eb87c6eb54985ba6220447bbba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4593: c88e219c6e890d89b7836c5e248ffedf334d55a2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9930: a46c5d644c7f46d5c153a8503fa499e2ee7488b2 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a46c5d644c7f drm/i915: Wait for vblank between disabling planes and disabling crtc
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9930/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Wait for vblank between disabling planes and disabling crtc
2018-08-13 13:45 [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc Maarten Lankhorst
2018-08-13 13:57 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-13 14:14 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-08-13 16:20 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-08-13 16:20 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Wait for vblank between disabling planes and disabling crtc
URL : https://patchwork.freedesktop.org/series/48113/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4662_full -> Patchwork_9930_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9930_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9930_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9930_full:
=== IGT changes ===
==== Warnings ====
igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9930_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@kms_flip@flip-vs-expired-vblank:
shard-kbl: FAIL (fdo#102887, fdo#105363) -> PASS
igt@perf_pmu@busy-accuracy-50-bcs0:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4662 -> Patchwork_9930
CI_DRM_4662: 3010d040760de7eb87c6eb54985ba6220447bbba @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4593: c88e219c6e890d89b7836c5e248ffedf334d55a2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9930: a46c5d644c7f46d5c153a8503fa499e2ee7488b2 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9930/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-13 16:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-13 13:45 [PATCH] drm/i915: Wait for vblank between disabling planes and disabling crtc Maarten Lankhorst
2018-08-13 13:57 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-13 14:14 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-13 16:20 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).