* [CI] drm/i915: Only skip connector output for disable_display @ 2018-08-15 20:12 Chris Wilson 2018-08-15 20:36 ` ✓ Fi.CI.BAT: success for " Patchwork 2018-08-16 1:05 ` ✓ Fi.CI.IGT: " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Chris Wilson @ 2018-08-15 20:12 UTC (permalink / raw) To: intel-gfx We want to add no connectors, encoders or crtcs if the display is disabled, but we still need to hook up any existing HW so that we can power it down. Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Imre Deak <imre.deak@intel.com> --- I think it's better to trickle this one in by itself rather than send the series of 3 patches to fix the immediate issue with the set_init_power wakeref leak. -Chris --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index dd6a6b49159b..690e1e816e77 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -14130,6 +14130,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv) intel_pps_init(dev_priv); + if (INTEL_INFO(dev_priv)->num_pipes == 0) + return; + /* * intel_edp_init_connector() depends on this completing first, to * prevent the registeration of both eDP and LVDS and the incorrect @@ -15208,9 +15211,6 @@ int intel_modeset_init(struct drm_device *dev) intel_init_pm(dev_priv); - if (INTEL_INFO(dev_priv)->num_pipes == 0) - return 0; - /* * There may be no VBT; and if the BIOS enabled SSC we can * just keep using it to avoid unnecessary flicker. Whereas if the -- 2.18.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Only skip connector output for disable_display 2018-08-15 20:12 [CI] drm/i915: Only skip connector output for disable_display Chris Wilson @ 2018-08-15 20:36 ` Patchwork 2018-08-16 1:05 ` ✓ Fi.CI.IGT: " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-08-15 20:36 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Only skip connector output for disable_display URL : https://patchwork.freedesktop.org/series/48283/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673 -> Patchwork_9958 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.org/api/1.0/series/48283/revisions/1/mbox/ == Known issues == Here are the changes found in Patchwork_9958 that come from known issues: === IGT changes === ==== Issues hit ==== igt@drv_selftest@live_coherency: fi-gdg-551: PASS -> DMESG-FAIL (fdo#107164) igt@drv_selftest@live_hangcheck: fi-kbl-7560u: PASS -> DMESG-FAIL (fdo#106947, fdo#106560) igt@kms_pipe_crc_basic@read-crc-pipe-a: {fi-byt-clapper}: PASS -> FAIL (fdo#107362) {igt@kms_psr@primary_mmap_gtt}: fi-cnl-psr: PASS -> DMESG-WARN (fdo#107372) ==== Possible fixes ==== igt@debugfs_test@read_all_entries: fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS igt@drv_module_reload@basic-reload-inject: fi-hsw-4770r: DMESG-WARN (fdo#107425) -> PASS igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence: {fi-byt-clapper}: FAIL (fdo#107362, fdo#103191) -> PASS ==== Warnings ==== {igt@kms_psr@primary_page_flip}: fi-cnl-psr: DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372) {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713 fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560 fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947 fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164 fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362 fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372 fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425 == Participating hosts (53 -> 48) == Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * Linux: CI_DRM_4673 -> Patchwork_9958 CI_DRM_4673: f67334524375e4896c6fb75d28ecfa4ae3198231 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4599: 940cb5f46433a8ae48d21c6672e4d8ecd1358bbf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9958: 1b44456f2940f281cd94fc180adef075b2f07cab @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 1b44456f2940 drm/i915: Only skip connector output for disable_display == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9958/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Only skip connector output for disable_display 2018-08-15 20:12 [CI] drm/i915: Only skip connector output for disable_display Chris Wilson 2018-08-15 20:36 ` ✓ Fi.CI.BAT: success for " Patchwork @ 2018-08-16 1:05 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-08-16 1:05 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: drm/i915: Only skip connector output for disable_display URL : https://patchwork.freedesktop.org/series/48283/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4673_full -> Patchwork_9958_full = == Summary - SUCCESS == No regressions found. == Known issues == Here are the changes found in Patchwork_9958_full that come from known issues: === IGT changes === ==== Issues hit ==== igt@gem_softpin@noreloc-s3: shard-kbl: PASS -> INCOMPLETE (fdo#107556, fdo#103665) igt@kms_setmode@basic: shard-kbl: PASS -> FAIL (fdo#99912) ==== Possible fixes ==== igt@kms_color@pipe-c-ctm-max: shard-kbl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +16 igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic: shard-glk: FAIL (fdo#105454, fdo#106509) -> PASS igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes: shard-snb: DMESG-WARN (fdo#102365) -> PASS fdo#102365 https://bugs.freedesktop.org/show_bug.cgi?id=102365 fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558 fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665 fdo#105454 https://bugs.freedesktop.org/show_bug.cgi?id=105454 fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602 fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509 fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556 fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 == Participating hosts (5 -> 5) == No changes in participating hosts == Build changes == * Linux: CI_DRM_4673 -> Patchwork_9958 CI_DRM_4673: f67334524375e4896c6fb75d28ecfa4ae3198231 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4599: 940cb5f46433a8ae48d21c6672e4d8ecd1358bbf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_9958: 1b44456f2940f281cd94fc180adef075b2f07cab @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9958/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-16 1:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-08-15 20:12 [CI] drm/i915: Only skip connector output for disable_display Chris Wilson 2018-08-15 20:36 ` ✓ Fi.CI.BAT: success for " Patchwork 2018-08-16 1:05 ` ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).