✗ Fi.CI.CHECKPATCH: warning for Add Plane Color Properties (rev4)

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Uma Shankar <uma.shankar@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Add Plane Color Properties (rev4)
Date: Fri, 17 Aug 2018 14:12:29 -0000	[thread overview]
Message-ID: <20180817141229.21069.88476@emeril.freedesktop.org> (raw)
In-Reply-To: <1534515531-20599-1-git-send-email-uma.shankar@intel.com>

== Series Details ==

Series: Add Plane Color Properties (rev4)
URL   : https://patchwork.freedesktop.org/series/30875/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1676eec85114 drm: Add Enhanced Gamma LUT precision structure
e9786d7168cd drm: Add Plane Degamma properties
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/drm_atomic.c:915:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->degamma_lut,

-:135: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#135: FILE: drivers/gpu/drm/drm_plane.c:499:
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_BLOB,

-:142: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#142: FILE: drivers/gpu/drm/drm_plane.c:506:
+	prop = drm_property_create_range(dev,
+			DRM_MODE_PROP_IMMUTABLE,

total: 0 errors, 0 warnings, 3 checks, 159 lines checked
d137d6637c14 drm: Add Plane CTM property
-:43: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#43: FILE: drivers/gpu/drm/drm_atomic.c:922:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->ctm,

-:104: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#104: FILE: drivers/gpu/drm/drm_plane.c:518:
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_BLOB,

total: 0 errors, 0 warnings, 2 checks, 98 lines checked
c8285a5384fc drm: Add Plane Gamma properties
-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/drm_atomic.c:930:
+		ret = drm_atomic_replace_property_blob_from_id(dev,
+					&state->gamma_lut,

-:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#110: FILE: drivers/gpu/drm/drm_plane.c:534:
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_BLOB,

-:117: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#117: FILE: drivers/gpu/drm/drm_plane.c:541:
+	prop = drm_property_create_range(dev,
+			DRM_MODE_PROP_IMMUTABLE,

total: 0 errors, 0 warnings, 3 checks, 117 lines checked
01d5c39de12d drm: Define helper function for plane color enabling
-:41: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#41: FILE: drivers/gpu/drm/drm_plane.c:162:
+void drm_plane_enable_color_mgmt(struct drm_plane *plane,
+				uint plane_degamma_lut_size,

-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/drm_plane.c:168:
+		drm_object_attach_property(&plane->base,
+				plane->degamma_lut_property, 0);

-:49: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#49: FILE: drivers/gpu/drm/drm_plane.c:170:
+		drm_object_attach_property(&plane->base,
+				plane->degamma_lut_size_property,

-:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#55: FILE: drivers/gpu/drm/drm_plane.c:176:
+		drm_object_attach_property(&plane->base,
+				plane->ctm_property, 0);

-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/drm_plane.c:180:
+		drm_object_attach_property(&plane->base,
+				plane->gamma_lut_property, 0);

-:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#61: FILE: drivers/gpu/drm/drm_plane.c:182:
+		drm_object_attach_property(&plane->base,
+				plane->gamma_lut_size_property,

total: 0 errors, 0 warnings, 6 checks, 57 lines checked
7f5c914396f5 drm/i915: Enable plane color features
-:52: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#52: FILE: drivers/gpu/drm/i915/intel_color.c:655:
+		drm_plane_enable_color_mgmt(plane,
+		INTEL_INFO(dev_priv)->plane_color.plane_degamma_lut_size,

total: 0 errors, 0 warnings, 1 checks, 63 lines checked
60155d559b3a drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms
-:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#57: FILE: drivers/gpu/drm/i915/i915_reg.h:9706:
+#define PLANE_GAMC(pipe, plane, i)	\
+	_MMIO_PLANE_GAMC(plane, i, _PLANE_GAMC_1(pipe), _PLANE_GAMC_2(pipe))

-:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects?
#68: FILE: drivers/gpu/drm/i915/i915_reg.h:9717:
+#define PLANE_GAMC16(pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \
+				_PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe))

-:93: CHECK:SPACING: No space is necessary after a cast
#93: FILE: drivers/gpu/drm/i915/intel_color.c:506:
+			(struct drm_color_lut_ext *) state->gamma_lut->data;

-:132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#132: FILE: drivers/gpu/drm/i915/intel_color.c:545:
+	bdw_load_plane_gamma_lut(state,
+		INTEL_INFO(dev_priv)->plane_color.plane_degamma_lut_size);

-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/i915/intel_color.c:705:
+	if (IS_BROADWELL(dev_priv) || IS_GEN9_BC(dev_priv) ||
+		IS_BROXTON(dev_priv)) {

total: 0 errors, 0 warnings, 5 checks, 138 lines checked
930ad4d3044a drm/i915: Load plane color luts from atomic flip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx