From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 4/5] drm/i915/kbl+: Enable IPC only for symmetric memory configurations Date: Fri, 17 Aug 2018 11:20:20 -0700 Message-ID: <20180817182020.GC8880@intel.com> References: <20180726141410.2185-1-mahesh1.kumar@intel.com> <20180726141410.2185-5-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37DDC6E6A5 for ; Fri, 17 Aug 2018 18:20:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180726141410.2185-5-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMjYsIDIwMTggYXQgMDc6NDQ6MDlQTSArMDUzMCwgTWFoZXNoIEt1bWFyIHdy b3RlOgo+IElQQyBtYXkgY2F1c2UgdW5kZXJmbG93cyBpZiBub3QgdXNlZCB3aXRoIGR1YWwgY2hh bm5lbCBzeW1tZXRyaWMKPiBtZW1vcnkgY29uZmlndXJhdGlvbi4gRGlzYWJsZSBJUEMgZm9yIG5v biBzeW1tZXRyaWMgY29uZmlndXJhdGlvbnMgaW4KPiBhZmZlY3RlZCBwbGF0Zm9ybXMuCj4gRGlz cGxheSBXQSAjMTE0MQo+Cj4gU2lnbmVkLW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1 bWFyQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyB8 IDQzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3BtLmMgfCAgMiArLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBpbmRleCA4NmJjMmU2ODU1 MjIuLjIyNzM2NjQxNjZiYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2Rydi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IEBAIC0xMTQx LDIxICsxMTQxLDQ3IEBAIHNrbF9kcmFtX2dldF9jaGFubmVsX2luZm8oc3RydWN0IGRyYW1fY2hh bm5lbF9pbmZvICpjaCwgdTMyIHZhbCkKPiAgCXJldHVybiAwOwo+ICB9Cj4KPiArc3RhdGljIGJv b2wKPiAraW50ZWxfaXNfZHJhbV9pcGNfY2FwYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gKwkJCSAgdTMyIHZhbF9jaDAsIHUzMiB2YWxfY2gxLAo+ICsJCQkgIHN0cnVj dCBkcmFtX2NoYW5uZWxfaW5mbyAqY2gwKQoKd2hhdCBhYm91dAppbnRlbF9pc19kcmFtX3N5bW1l dHJpYygpID8KCj4gK3sKPiArCS8qIERpc3BsYXkgV0EgIzExNDE6IFNLTDphbGwgS0JMOmFsbCBD Tkw6QSBDTkw6QiAqLwoKbW92ZSB0aGlzIHRvIHRoZSB3YSBjYWxsLCBub3QgdGhlIHRoZSBmdW5j dGlvbiBjaGVjay4uLgoKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID4gOSAmJgo+ICsJICAg ICFJU19DTkxfUkVWSUQoZGV2X3ByaXYsIENOTF9SRVZJRF9BMCwgQ05MX1JFVklEX0IwKSkKCnBs ZWFzZSBkb24ndCBhZGQgQ05MIHByZS1wcm9kIHdhCgo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiAr CWlmICghSVNfS0FCWUxBS0UoZGV2X3ByaXYpICYmICFJU19TS1lMQUtFKGRldl9wcml2KSkKPiAr CQlyZXR1cm4gdHJ1ZTsKCmFjdHVhbGx5IHJlbW92ZSBhbGwgcGxhdGZvcm1zIGNoZWNrcyBoZXJl Li4uCgo+ICsKPiArCWlmICh2YWxfY2gwICE9IHZhbF9jaDEpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ ICsKPiArCWlmIChjaDAtPnNfaW5mby5zaXplID09IDApCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwlp ZiAoY2gwLT5sX2luZm8uc2l6ZSA9PSBjaDAtPnNfaW5mby5zaXplICYmCj4gKwkgICAgY2gwLT5s X2luZm8ud2lkdGggPT0gY2gwLT5zX2luZm8ud2lkdGggJiYKPiArCSAgICBjaDAtPmxfaW5mby5y YW5rID09IGNoMC0+c19pbmZvLnJhbmspCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJcmV0dXJu IGZhbHNlOwoKcmV0dXJuICh2YWxfY2gwID09IHZhbF9jaDEgJiYgKGNoMC0+c19pbmZvLnNpemUg PT0gMCB8fAogICAgICAgKGNoMC0+bF9pbmZvLnNpemUgPT0gY2gwLT5zX2luZm8uc2l6ZSAmJgog ICAgICAgICBjaDAtPmxfaW5mby53aWR0aCA9PSBjaDAtPnNfaW5mby53aWR0aCAmJgogICAgICAg ICBjaDAtPmxfaW5mby5yYW5rID09IGNoMC0+c19pbmZvLnJhbmspKSkKCj4gK30KCj4gKwo+ICBz dGF0aWMgaW50Cj4gIHNrbF9kcmFtX2dldF9jaGFubmVsc19pbmZvKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGRyYW1faW5mbyAqZHJhbV9pbmZvID0g JmRldl9wcml2LT5kcmFtX2luZm87Cj4gIAlzdHJ1Y3QgZHJhbV9jaGFubmVsX2luZm8gY2gwLCBj aDE7Cj4gLQl1MzIgdmFsOwo+ICsJdTMyIHZhbF9jaDAsIHZhbF9jaDE7Cj4gIAlpbnQgcmV0Owo+ Cj4gLQl2YWwgPSBJOTE1X1JFQUQoU0tMX01BRF9ESU1NX0NIMF8wXzBfMF9NQ0hCQVJfTUNNQUlO KTsKPiAtCXJldCA9IHNrbF9kcmFtX2dldF9jaGFubmVsX2luZm8oJmNoMCwgdmFsKTsKPiArCXZh bF9jaDAgPSBJOTE1X1JFQUQoU0tMX01BRF9ESU1NX0NIMF8wXzBfMF9NQ0hCQVJfTUNNQUlOKTsK PiArCXJldCA9IHNrbF9kcmFtX2dldF9jaGFubmVsX2luZm8oJmNoMCwgdmFsX2NoMCk7Cj4gIAlp ZiAocmV0ID09IDApCj4gIAkJZHJhbV9pbmZvLT5udW1fY2hhbm5lbHMrKzsKPgo+IC0JdmFsID0g STkxNV9SRUFEKFNLTF9NQURfRElNTV9DSDFfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gLQlyZXQg PSBza2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKCZjaDEsIHZhbCk7Cj4gKwl2YWxfY2gxID0gSTkx NV9SRUFEKFNLTF9NQURfRElNTV9DSDFfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gKwlyZXQgPSBz a2xfZHJhbV9nZXRfY2hhbm5lbF9pbmZvKCZjaDEsIHZhbF9jaDEpOwo+ICAJaWYgKHJldCA9PSAw KQo+ICAJCWRyYW1faW5mby0+bnVtX2NoYW5uZWxzKys7Cj4KPiBAQCAtMTE4NSw2ICsxMjExLDEz IEBAIHNrbF9kcmFtX2dldF9jaGFubmVsc19pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiAgCWlmIChjaDAuaXNfMTZnYl9kaW1tIHx8IGNoMS5pc18xNmdiX2RpbW0pCj4g IAkJZHJhbV9pbmZvLT5pc18xNmdiX2RpbW0gPSB0cnVlOwo+Cj4gKwlpZiAoaW50ZWxfaXNfZHJh bV9pcGNfY2FwYWJsZShkZXZfcHJpdiwgdmFsX2NoMCwgdmFsX2NoMSwgJmNoMCkpCj4gKwkJZGV2 X3ByaXYtPmlwY19jYXBhYmxlX21lbSA9IHRydWU7Cj4gKwllbHNlCj4gKwkJZGV2X3ByaXYtPmlw Y19jYXBhYmxlX21lbSA9IGZhbHNlOwo+ICsKPiArCURSTV9ERUJVR19LTVMoIm1lbW9yeSBjb25m aWd1cmF0aW9uIGlzICVzSVBDIGNhcGFibGVcbiIsCj4gKwkJICAgICAgZGV2X3ByaXYtPmlwY19j YXBhYmxlX21lbSA/ICIiIDogIm5vdCAiKTsKPiAgCXJldHVybiAwOwo+ICB9Cj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA4NTRmM2M4MjhlMDEuLjAzNmQ2NTU0YzAxNyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yMTEyLDYgKzIxMTIsNyBAQCBzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSB7Cj4gIAlib29sIGNodl9waHlfYXNzZXJ0WzJdOwo+Cj4gIAlib29sIGlw Y19lbmFibGVkOwo+ICsJYm9vbCBpcGNfY2FwYWJsZV9tZW07CgpJIGRvbid0IHRoaW5rIHdlIG5l ZWQgdG8gc3RhZ2UgdGhpcy4uLgoKPgo+ICAJLyogVXNlZCB0byBzYXZlIHRoZSBwaXBlLXRvLWVu Y29kZXIgbWFwcGluZyBmb3IgYXVkaW8gKi8KPiAgCXN0cnVjdCBpbnRlbF9lbmNvZGVyICphdl9l bmNfbWFwW0k5MTVfTUFYX1BJUEVTXTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCAy NDQ2ZjUzYWRmMjEuLjM5ZTQwMGQ1ZjU1NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ IEBAIC02MDk3LDcgKzYwOTcsNyBAQCB2b2lkIGludGVsX2VuYWJsZV9pcGMoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJdTMyIHZhbDsKPgo+ICAJLyogRGlzcGxheSBXQSAj MDQ3NyBXYURpc2FibGVJUEM6IHNrbCAqLwo+IC0JaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpKSB7 Cj4gKwlpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikgfHwgIWRldl9wcml2LT5pcGNfY2FwYWJsZV9t ZW0pIHsKPiAgCQlkZXZfcHJpdi0+aXBjX2VuYWJsZWQgPSBmYWxzZTsKClRoaXMgaXMgbm90IHRo ZSBXQSAxMTQxIGZvciBvdGhlciBwbGF0Zm9ybXMgdGhhbiBTS0wuIFBsZWFzZSBvbmx5IGtlZXAg c2tsIGhlcmUuCgpGb3IgdGhlIG90aGVyIFdBIGFkZCA0dXMgYWNyb3NzIGFsbCB3YXRlcm1hcmsg bGV2ZWxzCgovKiBEaXNwbGF5IFdBICMxMTQxOiBza2wsa2JsLGNmbCAqLwppZiAoKElTX0tBQllM QUtFKGRldl9wcml2KSB8fCBJU19DT0ZGRUVMQUtFKGRldl9wcml2KSkgJiYKICAgaW50ZWxfaXNf ZHJhbV9zeW1tZXRyaWMoKSkKICAgbGV2ZWxzICs9IDQ7Cgo+ICAJCXJldHVybjsKPiAgCX0KPiAt LQo+IDIuMTYuMgo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=