* [PATCH v2] drm/i915: Increase LSPCON timeout
@ 2018-08-17 20:07 Fredrik Schön
2018-08-17 20:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Fredrik Schön @ 2018-08-17 20:07 UTC (permalink / raw)
To: intel-gfx
Cc: Fredrik Schön, Shashank Sharma, Imre Deak, Jani Nikula,
stable
100 ms is not enough time for the LSPCON adapter on Intel NUC devices to
settle. This causes dropped display modes at boot or screen reconfiguration.
Empirical testing can reproduce the error up to a timeout of 190 ms. Basic
boot and stress testing at 200 ms has not (yet) failed.
Increase timeout to 400 ms to get some margin of error.
Changes from v1:
The initial suggestion of 1000 ms was lowered due to concerns about delaying
valid timeout cases.
Update patch metadata.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392
Fixes: 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle")
Cc: Shashank Sharma <shashank.sharma@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: <stable@vger.kernel.org> # v4.11+
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Fredrik Schön <fredrik.schon@gmail.com>
---
drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
index 8ae8f42f430a..6b6758419fb3 100644
--- a/drivers/gpu/drm/i915/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/intel_lspcon.c
@@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
DRM_DEBUG_KMS("Waiting for LSPCON mode %s to settle\n",
lspcon_mode_name(mode));
- wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 100);
+ wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
if (current_mode != mode)
DRM_ERROR("LSPCON mode hasn't settled\n");
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Increase LSPCON timeout
2018-08-17 20:07 [PATCH v2] drm/i915: Increase LSPCON timeout Fredrik Schön
@ 2018-08-17 20:16 ` Patchwork
2018-08-17 20:34 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-17 20:16 UTC (permalink / raw)
To: Fredrik Schön; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b7c954809a11 drm/i915: Increase LSPCON timeout
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
settle. This causes dropped display modes at boot or screen reconfiguration.
total: 0 errors, 1 warnings, 0 checks, 8 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Increase LSPCON timeout
2018-08-17 20:07 [PATCH v2] drm/i915: Increase LSPCON timeout Fredrik Schön
2018-08-17 20:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2018-08-17 20:34 ` Patchwork
2018-08-17 21:22 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-20 7:54 ` [PATCH v2] " Sharma, Shashank
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-17 20:34 UTC (permalink / raw)
To: Fredrik Schön; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4686 -> Patchwork_9975 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9975 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9975, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48414/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9975:
=== IGT changes ===
==== Warnings ====
igt@drv_selftest@live_guc:
fi-kbl-7567u: SKIP -> PASS +1
== Known issues ==
Here are the changes found in Patchwork_9975 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-bxt-dsi: PASS -> DMESG-FAIL (fdo#106560)
igt@kms_frontbuffer_tracking@basic:
{fi-byt-clapper}: PASS -> FAIL (fdo#103167)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-kbl-7567u: DMESG-FAIL (fdo#106947, fdo#106560) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
{fi-byt-clapper}: FAIL (fdo#107362, fdo#103191) -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (54 -> 49) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4686 -> Patchwork_9975
CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9975: b7c954809a11c4ac1bb54527b24801c08e145d89 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b7c954809a11 drm/i915: Increase LSPCON timeout
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9975/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Increase LSPCON timeout
2018-08-17 20:07 [PATCH v2] drm/i915: Increase LSPCON timeout Fredrik Schön
2018-08-17 20:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-17 20:34 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2018-08-17 21:22 ` Patchwork
2018-08-20 7:54 ` [PATCH v2] " Sharma, Shashank
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-08-17 21:22 UTC (permalink / raw)
To: Fredrik Schön; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase LSPCON timeout
URL : https://patchwork.freedesktop.org/series/48414/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4686_full -> Patchwork_9975_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9975_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9975_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9975_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9975_full that come from known issues:
=== IGT changes ===
==== Possible fixes ====
igt@drv_suspend@forcewake:
shard-glk: FAIL (fdo#103375) -> PASS
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: INCOMPLETE (fdo#106023, fdo#103665) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4686 -> Patchwork_9975
CI_DRM_4686: d8f9d99f574c7d0b6918d888071bc2f3f899b18b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9975: b7c954809a11c4ac1bb54527b24801c08e145d89 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9975/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915: Increase LSPCON timeout
2018-08-17 20:07 [PATCH v2] drm/i915: Increase LSPCON timeout Fredrik Schön
` (2 preceding siblings ...)
2018-08-17 21:22 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-08-20 7:54 ` Sharma, Shashank
2018-08-20 11:27 ` Jani Nikula
3 siblings, 1 reply; 6+ messages in thread
From: Sharma, Shashank @ 2018-08-20 7:54 UTC (permalink / raw)
To: Fredrik Schön, intel-gfx
Cc: Fredrik Schön, Imre Deak, Jani Nikula, stable
On 8/18/2018 1:37 AM, Fredrik Schön wrote:
> 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to
> settle. This causes dropped display modes at boot or screen reconfiguration.
> Empirical testing can reproduce the error up to a timeout of 190 ms. Basic
> boot and stress testing at 200 ms has not (yet) failed.
>
> Increase timeout to 400 ms to get some margin of error.
>
> Changes from v1:
> The initial suggestion of 1000 ms was lowered due to concerns about delaying
> valid timeout cases.
> Update patch metadata.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392
> Fixes: 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle")
> Cc: Shashank Sharma <shashank.sharma@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: <stable@vger.kernel.org> # v4.11+
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Fredrik Schön <fredrik.schon@gmail.com>
> ---
> drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
> index 8ae8f42f430a..6b6758419fb3 100644
> --- a/drivers/gpu/drm/i915/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
> @@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
> DRM_DEBUG_KMS("Waiting for LSPCON mode %s to settle\n",
> lspcon_mode_name(mode));
>
> - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 100);
> + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
> if (current_mode != mode)
> DRM_ERROR("LSPCON mode hasn't settled\n");
>
Looks good to me
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
- Shashank
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] drm/i915: Increase LSPCON timeout
2018-08-20 7:54 ` [PATCH v2] " Sharma, Shashank
@ 2018-08-20 11:27 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2018-08-20 11:27 UTC (permalink / raw)
To: Sharma, Shashank, Fredrik Schön, intel-gfx
Cc: Fredrik Schön, Imre Deak, stable
On Mon, 20 Aug 2018, "Sharma, Shashank" <shashank.sharma@intel.com> wrote:
> On 8/18/2018 1:37 AM, Fredrik Schön wrote:
>
>> 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to
>> settle. This causes dropped display modes at boot or screen reconfiguration.
>> Empirical testing can reproduce the error up to a timeout of 190 ms. Basic
>> boot and stress testing at 200 ms has not (yet) failed.
>>
>> Increase timeout to 400 ms to get some margin of error.
>>
>> Changes from v1:
>> The initial suggestion of 1000 ms was lowered due to concerns about delaying
>> valid timeout cases.
>> Update patch metadata.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107503
>> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1570392
>> Fixes: 357c0ae9198a ("drm/i915/lspcon: Wait for expected LSPCON mode to settle")
>> Cc: Shashank Sharma <shashank.sharma@intel.com>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: <stable@vger.kernel.org> # v4.11+
>> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Fredrik Schön <fredrik.schon@gmail.com>
>> ---
>> drivers/gpu/drm/i915/intel_lspcon.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_lspcon.c b/drivers/gpu/drm/i915/intel_lspcon.c
>> index 8ae8f42f430a..6b6758419fb3 100644
>> --- a/drivers/gpu/drm/i915/intel_lspcon.c
>> +++ b/drivers/gpu/drm/i915/intel_lspcon.c
>> @@ -74,7 +74,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
>> DRM_DEBUG_KMS("Waiting for LSPCON mode %s to settle\n",
>> lspcon_mode_name(mode));
>>
>> - wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 100);
>> + wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
>> if (current_mode != mode)
>> DRM_ERROR("LSPCON mode hasn't settled\n");
>>
> Looks good to me
> Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
Pushed to drm-intel-next-queued, thanks for the patch and review.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-20 11:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 20:07 [PATCH v2] drm/i915: Increase LSPCON timeout Fredrik Schön
2018-08-17 20:16 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-08-17 20:34 ` ✓ Fi.CI.BAT: success " Patchwork
2018-08-17 21:22 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-20 7:54 ` [PATCH v2] " Sharma, Shashank
2018-08-20 11:27 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).