[PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

[PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

[Chris Wilson]

If the display has been disabled by modparam, we still want to connect
together the HW bits and bobs with the associated drivers so that we can
continue to manage their runtime power gating.

Fixes: 108109444ff6 ("drm/i915: Check num_pipes before initializing audio component")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Elaine Wang <elaine.wang@intel.com>
---
 drivers/gpu/drm/i915/intel_audio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
index b725835b47ef..769f3f586661 100644
--- a/drivers/gpu/drm/i915/intel_audio.c
+++ b/drivers/gpu/drm/i915/intel_audio.c
@@ -962,9 +962,6 @@ void i915_audio_component_init(struct drm_i915_private *dev_priv)
 {
 	int ret;
 
-	if (INTEL_INFO(dev_priv)->num_pipes == 0)
-		return;
-
 	ret = component_add(dev_priv->drm.dev, &i915_audio_component_bind_ops);
 	if (ret < 0) {
 		DRM_ERROR("failed to add audio component (%d)\n", ret);
-- 
2.18.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/audio: Hook up component bindings even if displays are disabled

[Patchwork]

== Series Details ==

Series: drm/i915/audio: Hook up component bindings even if displays are disabled
URL   : https://patchwork.freedesktop.org/series/48387/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4685 -> Patchwork_9968 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48387/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9968:

  === IGT changes ===

    ==== Possible regressions ====

    {igt@pm_rpm@module-reload}:
      fi-byt-j1900:       NOTRUN -> DMESG-WARN

    
    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     WARN (fdo#107602) -> DMESG-WARN
      fi-bsw-n3050:       WARN (fdo#107602) -> DMESG-WARN
      fi-hsw-peppy:       DMESG-FAIL -> DMESG-WARN
      {fi-bdw-samus}:     DMESG-FAIL -> DMESG-WARN
      fi-byt-n2820:       WARN (fdo#107602) -> DMESG-WARN

    
== Known issues ==

  Here are the changes found in Patchwork_9968 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103191, fdo#107362)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-skl-guc:         DMESG-FAIL (fdo#107174) -> PASS

    igt@gem_exec_basic@readonly-blt:
      fi-byt-n2820:       FAIL (fdo#105900) -> PASS

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         DMESG-WARN (fdo#107372) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-bdw-5557u:       WARN (fdo#107602) -> PASS
      fi-skl-6600u:       WARN (fdo#107602) -> PASS
      fi-kbl-guc:         WARN (fdo#107602) -> PASS
      {fi-cfl-8109u}:     WARN (fdo#107602) -> PASS
      fi-cfl-s3:          WARN (fdo#107602) -> PASS
      fi-kbl-7500u:       WARN (fdo#107602) -> PASS
      fi-hsw-4770:        WARN (fdo#107602) -> PASS
      fi-skl-6700hq:      WARN (fdo#107602) -> PASS
      fi-cfl-guc:         WARN (fdo#107602) -> PASS
      fi-skl-guc:         WARN (fdo#107602) -> PASS
      fi-cfl-8700k:       WARN (fdo#107602) -> PASS
      {fi-icl-u}:         WARN (fdo#107602) -> PASS
      fi-skl-6770hq:      WARN (fdo#107602) -> PASS
      {fi-kbl-8809g}:     WARN (fdo#107602) -> PASS
      fi-cnl-psr:         WARN (fdo#107602) -> PASS
      fi-kbl-r:           WARN (fdo#107602) -> PASS
      fi-skl-6260u:       WARN (fdo#107602) -> PASS
      fi-bxt-j4205:       WARN (fdo#107602) -> PASS
      fi-whl-u:           WARN (fdo#107602) -> PASS
      fi-kbl-7567u:       WARN (fdo#107602) -> PASS
      fi-kbl-7560u:       WARN (fdo#107602) -> PASS
      {fi-skl-iommu}:     WARN (fdo#107602) -> PASS
      fi-hsw-4770r:       WARN (fdo#107602) -> PASS
      fi-skl-6700k2:      WARN (fdo#107602) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ivb-3770:        FAIL (fdo#104008) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602


== Participating hosts (52 -> 49) ==

  Additional (1): fi-byt-j1900 
  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-hsw-4200u 


== Build changes ==

    * Linux: CI_DRM_4685 -> Patchwork_9968

  CI_DRM_4685: df7e8eddc3830216d3fec15e2c7d0b6ec97e7bae @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9968: bd42e189678fc2286d2f232f929f49290787d515 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

bd42e189678f drm/i915/audio: Hook up component bindings even if displays are disabled

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9968/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915/audio: Hook up component bindings even if displays are disabled

[Patchwork]

== Series Details ==

Series: drm/i915/audio: Hook up component bindings even if displays are disabled
URL   : https://patchwork.freedesktop.org/series/48387/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4685_full -> Patchwork_9968_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_9968_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@debugfs-reader:
      shard-glk:          PASS -> FAIL (fdo#103375)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#105363)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-glk:          INCOMPLETE (fdo#106886, fdo#103359, k.org#198133) -> PASS

    igt@gem_ctx_isolation@rcs0-s3:
      shard-glk:          FAIL (fdo#103375) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS
      shard-kbl:          FAIL (fdo#99912) -> PASS

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4685 -> Patchwork_9968

  CI_DRM_4685: df7e8eddc3830216d3fec15e2c7d0b6ec97e7bae @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9968: bd42e189678fc2286d2f232f929f49290787d515 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9968/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915/audio: Hook up component bindings even if displays are disabled

[Patchwork]

== Series Details ==

Series: drm/i915/audio: Hook up component bindings even if displays are disabled
URL   : https://patchwork.freedesktop.org/series/48387/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4687 -> Patchwork_9977 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/48387/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_9977:

  === IGT changes ===

    ==== Warnings ====

    {igt@pm_rpm@module-reload}:
      {fi-bsw-kefka}:     WARN (fdo#107602) -> DMESG-WARN
      fi-bsw-n3050:       WARN (fdo#107602) -> DMESG-WARN
      fi-byt-j1900:       WARN (fdo#107602) -> DMESG-WARN
      fi-byt-n2820:       WARN (fdo#107602) -> DMESG-WARN

    
== Known issues ==

  Here are the changes found in Patchwork_9977 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107425)

    igt@kms_frontbuffer_tracking@basic:
      {fi-byt-clapper}:   PASS -> FAIL (fdo#103167)

    {igt@kms_psr@primary_mmap_gtt}:
      fi-cnl-psr:         PASS -> DMESG-WARN (fdo#107372)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_hangcheck:
      fi-cfl-s3:          DMESG-FAIL (fdo#106560) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-a:
      {fi-byt-clapper}:   FAIL (fdo#107362) -> PASS

    {igt@pm_rpm@module-reload}:
      fi-bdw-5557u:       WARN (fdo#107602) -> PASS
      fi-skl-6600u:       WARN (fdo#107602) -> PASS
      fi-kbl-guc:         WARN (fdo#107602) -> PASS
      {fi-cfl-8109u}:     WARN (fdo#107602) -> PASS
      fi-cfl-s3:          WARN (fdo#107602) -> PASS
      fi-kbl-7500u:       WARN (fdo#107602) -> PASS
      fi-hsw-4770:        WARN (fdo#107602) -> PASS
      fi-skl-6700hq:      WARN (fdo#107602) -> PASS
      fi-cfl-guc:         WARN (fdo#107602) -> PASS
      fi-skl-guc:         WARN (fdo#107602) -> PASS
      fi-cfl-8700k:       WARN (fdo#107602) -> PASS
      fi-skl-6770hq:      WARN (fdo#107602) -> PASS
      {fi-kbl-8809g}:     WARN (fdo#107602) -> PASS
      fi-kbl-r:           WARN (fdo#107602) -> PASS
      fi-skl-6260u:       WARN (fdo#107602) -> PASS
      fi-bxt-j4205:       WARN (fdo#107602) -> PASS
      fi-whl-u:           WARN (fdo#107602) -> PASS
      fi-kbl-7567u:       WARN (fdo#107602) -> PASS
      fi-kbl-7560u:       WARN (fdo#107602) -> PASS
      {fi-skl-iommu}:     WARN (fdo#107602) -> PASS
      fi-hsw-4770r:       WARN (fdo#107602) -> SKIP
      fi-skl-6700k2:      WARN (fdo#107602) -> PASS

    
    ==== Warnings ====

    {igt@kms_psr@primary_page_flip}:
      fi-cnl-psr:         DMESG-FAIL (fdo#107372) -> DMESG-WARN (fdo#107372)

    {igt@pm_rpm@module-reload}:
      fi-hsw-peppy:       DMESG-FAIL (fdo#107603) -> DMESG-WARN (fdo#107603)
      {fi-bdw-samus}:     DMESG-FAIL (fdo#107603) -> DMESG-WARN (fdo#107603)

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
  fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107603 https://bugs.freedesktop.org/show_bug.cgi?id=107603


== Participating hosts (53 -> 47) ==

  Missing    (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * Linux: CI_DRM_4687 -> Patchwork_9977

  CI_DRM_4687: 437b1c598624454e36690c1c56ce1a27e2ed7893 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9977: 84a790e0ab797998fa387c46ba29c42d8b05ebb3 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

84a790e0ab79 drm/i915/audio: Hook up component bindings even if displays are disabled

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9977/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915/audio: Hook up component bindings even if displays are disabled

[Patchwork]

== Series Details ==

Series: drm/i915/audio: Hook up component bindings even if displays are disabled
URL   : https://patchwork.freedesktop.org/series/48387/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4687_full -> Patchwork_9977_full =

== Summary - SUCCESS ==

  No regressions found.

  

== Known issues ==

  Here are the changes found in Patchwork_9977_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411, fdo#106886)
      shard-apl:          PASS -> INCOMPLETE (fdo#103927, fdo#106886)

    igt@gem_ctx_isolation@rcs0-s3:
      shard-glk:          PASS -> FAIL (fdo#103375) +1

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_setmode@basic:
      shard-apl:          FAIL (fdo#99912) -> PASS

    
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4687 -> Patchwork_9977

  CI_DRM_4687: 437b1c598624454e36690c1c56ce1a27e2ed7893 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4606: 38a44003774e35c587c67c8766b35e75dbb993b8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_9977: 84a790e0ab797998fa387c46ba29c42d8b05ebb3 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9977/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

[Imre Deak]

On Fri, Aug 17, 2018 at 11:02:41AM +0100, Chris Wilson wrote:
> If the display has been disabled by modparam, we still want to connect
> together the HW bits and bobs with the associated drivers so that we can
> continue to manage their runtime power gating.
> 
> Fixes: 108109444ff6 ("drm/i915: Check num_pipes before initializing audio component")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Elaine Wang <elaine.wang@intel.com>

Going through the hooks in i915_audio_component_ops, I haven't noticed
anything that would actually go wrong with num_pipes=0. Besides some
audio HW register programming from i915_audio_component_codec_wake_override(),
we'd skip doing everything else due to not reporting any active encoders
to the audio component (as we do during normal display modeset). So

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_audio.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index b725835b47ef..769f3f586661 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -962,9 +962,6 @@ void i915_audio_component_init(struct drm_i915_private *dev_priv)
>  {
>  	int ret;
>  
> -	if (INTEL_INFO(dev_priv)->num_pipes == 0)
> -		return;
> -
>  	ret = component_add(dev_priv->drm.dev, &i915_audio_component_bind_ops);
>  	if (ret < 0) {
>  		DRM_ERROR("failed to add audio component (%d)\n", ret);
> -- 
> 2.18.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

[Chris Wilson]

Quoting Imre Deak (2018-08-20 14:23:13)
> On Fri, Aug 17, 2018 at 11:02:41AM +0100, Chris Wilson wrote:
> > If the display has been disabled by modparam, we still want to connect
> > together the HW bits and bobs with the associated drivers so that we can
> > continue to manage their runtime power gating.
> > 
> > Fixes: 108109444ff6 ("drm/i915: Check num_pipes before initializing audio component")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Imre Deak <imre.deak@intel.com>
> > Cc: Takashi Iwai <tiwai@suse.de>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Elaine Wang <elaine.wang@intel.com>
> 
> Going through the hooks in i915_audio_component_ops, I haven't noticed
> anything that would actually go wrong with num_pipes=0. Besides some
> audio HW register programming from i915_audio_component_codec_wake_override(),
> we'd skip doing everything else due to not reporting any active encoders
> to the audio component (as we do during normal display modeset). So
> 
> Reviewed-by: Imre Deak <imre.deak@intel.com>

I'm confident in that we at least exercise the no-pipes case, less
confident that we test for fused-off hw. However, the audio component
simply should not find any output channels even in that case, so it
indeed should be safe.

Cross your fingers, thanks for the review,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx