* [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs
@ 2018-08-20 23:42 Azhar Shaikh
2018-08-21 0:18 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Azhar Shaikh @ 2018-08-20 23:42 UTC (permalink / raw)
To: intel-gfx; +Cc: dhinakaran.pandiyan
Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file
i915_edp_psr_status.
Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
---
Changes in v3:
- rebased
Changes in v2:
- Fix checkpatch warning.
- Add Reviewed-by: from v1
drivers/gpu/drm/i915/i915_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 26b7e5276b15..bb94ed33a7da 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2708,7 +2708,9 @@ static int i915_edp_psr_status(struct seq_file *m, void *data)
intel_runtime_pm_get(dev_priv);
mutex_lock(&dev_priv->psr.lock);
- seq_printf(m, "Enabled: %s\n", yesno(dev_priv->psr.enabled));
+ seq_printf(m, "PSR mode: %s\n",
+ dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
+ seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv->psr.enabled));
seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
dev_priv->psr.busy_frontbuffer_bits);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3)
2018-08-20 23:42 [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
@ 2018-08-21 0:18 ` Patchwork
2018-08-21 1:26 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-21 18:05 ` [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Dhinakaran Pandiyan
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-08-21 0:18 UTC (permalink / raw)
To: Azhar Shaikh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/47902/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4691 -> Patchwork_9979 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/47902/revisions/3/mbox/
== Known issues ==
Here are the changes found in Patchwork_9979 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128, fdo#107139)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-skl-guc: DMESG-FAIL (fdo#107174) -> PASS
fi-kbl-guc: DMESG-FAIL (fdo#106947) -> PASS
fi-bxt-dsi: DMESG-FAIL (fdo#106560) -> PASS
{igt@pm_rpm@module-reload}:
fi-cnl-psr: WARN (fdo#107602) -> PASS
==== Warnings ====
{igt@kms_psr@primary_page_flip}:
fi-cnl-psr: DMESG-WARN (fdo#107372) -> DMESG-FAIL (fdo#107372)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107174 https://bugs.freedesktop.org/show_bug.cgi?id=107174
fdo#107372 https://bugs.freedesktop.org/show_bug.cgi?id=107372
fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
== Participating hosts (51 -> 48) ==
Additional (1): fi-snb-2520m
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4691 -> Patchwork_9979
CI_DRM_4691: 2d75266982a5dae956c10e683a1a74d977d88e09 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4607: 6e0b3e7a2d241af36f8c6b1cc335aa1db3532d29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9979: 3b646742f6a55774f7e1ffd8ccaba13ade2a08c3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
3b646742f6a5 drm/i915/psr: Add PSR mode/revision to debugfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9979/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3)
2018-08-20 23:42 [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-21 0:18 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3) Patchwork
@ 2018-08-21 1:26 ` Patchwork
2018-08-21 18:05 ` [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Dhinakaran Pandiyan
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-08-21 1:26 UTC (permalink / raw)
To: Azhar Shaikh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev3)
URL : https://patchwork.freedesktop.org/series/47902/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4691_full -> Patchwork_9979_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9979_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9979_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9979_full:
=== IGT changes ===
==== Warnings ====
igt@pm_rc6_residency@rc6-accuracy:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9979_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-kbl: PASS -> DMESG-WARN (fdo#103313)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-glk: FAIL (fdo#106886) -> PASS
igt@gem_workarounds@suspend-resume:
shard-glk: FAIL (fdo#103375) -> PASS
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4691 -> Patchwork_9979
CI_DRM_4691: 2d75266982a5dae956c10e683a1a74d977d88e09 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4607: 6e0b3e7a2d241af36f8c6b1cc335aa1db3532d29 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9979: 3b646742f6a55774f7e1ffd8ccaba13ade2a08c3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9979/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs
2018-08-20 23:42 [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-21 0:18 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3) Patchwork
2018-08-21 1:26 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-08-21 18:05 ` Dhinakaran Pandiyan
2 siblings, 0 replies; 4+ messages in thread
From: Dhinakaran Pandiyan @ 2018-08-21 18:05 UTC (permalink / raw)
To: Azhar Shaikh, intel-gfx
On Mon, 2018-08-20 at 16:42 -0700, Azhar Shaikh wrote:
> Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file
> i915_edp_psr_status.
>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
> ---
> Changes in v3:
> - rebased
>
> Changes in v2:
> - Fix checkpatch warning.
> - Add Reviewed-by: from v1
>
> drivers/gpu/drm/i915/i915_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 26b7e5276b15..bb94ed33a7da 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2708,7 +2708,9 @@ static int i915_edp_psr_status(struct seq_file
> *m, void *data)
> intel_runtime_pm_get(dev_priv);
>
> mutex_lock(&dev_priv->psr.lock);
> - seq_printf(m, "Enabled: %s\n", yesno(dev_priv-
> >psr.enabled));
> + seq_printf(m, "PSR mode: %s\n",
> + dev_priv->psr.psr2_enabled ? "PSR2" : "PSR1");
> + seq_printf(m, "Enabled: %s\n", yesno((bool)dev_priv-
> >psr.enabled));
I'm afraid this rebase isn't correct, the patch is reverting to use a
bool typecast for no particular reason.
> seq_printf(m, "Busy frontbuffer bits: 0x%03x\n",
> dev_priv->psr.busy_frontbuffer_bits);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-21 18:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-20 23:42 [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Azhar Shaikh
2018-08-21 0:18 ` ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3) Patchwork
2018-08-21 1:26 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-21 18:05 ` [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs Dhinakaran Pandiyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).