From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Add a small wrapper to check for CCS modifiers. Date: Wed, 22 Aug 2018 12:48:32 +0300 Message-ID: <20180822094832.GV5565@intel.com> References: <20180822015053.1420-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7791F89BDB for ; Wed, 22 Aug 2018 09:48:47 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180822015053.1420-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMjEsIDIwMTggYXQgMDY6NTA6NTJQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBDb2RlIGxvb2tzIGNsZWFuZXIgd2l0aCBtb2RpZmllcnMgaGlkZGVuIGlu c2lkZSB0aGlzIHdyYXBwZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlh biA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIxICsrKysrKysrKysrLS0tLS0tLS0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmggfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Nwcml0ZS5jICB8ICAzICstLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDEzIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMKPiBpbmRleCBhZDBmMGU1Mzg5ZDkuLmI5OGVhYjExMzMzMCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMjQ3NCw2ICsyNDc0LDEyIEBAIGludGVs X2dldF9mb3JtYXRfaW5mbyhjb25zdCBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqY21kKQo+ICAJ fQo+ICB9Cj4gIAo+ICtib29sIGlzX2Njc19tb2RpZmllcihjb25zdCB1NjQgbW9kaWZpZXIpCgpj b25zdCBpcyByYXRoZXIgcG9pbnRsZXNzIGhlcmUgSU1PLgoKPiArewo+ICsJcmV0dXJuIG1vZGlm aWVyID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUyB8fAo+ICsJICAgICAgIG1vZGlmaWVy ID09IEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1M7Cj4gK30KCklJUkMgSSBoYWQgYSBzaW1p bGFyIHRoaW5nIGluIG15IGd0dCByZW1hcHBpbmcgc2VyaWVzLCB0aG91Z2ggSSBkaWRuJ3QKcGx1 ZyBpdCBpbnRvIGFsbCB0aGUgcGxhY2VzIHRoYXQgY291bGQgaGF2ZSB1c2VkIGl0LgoKUmV2aWV3 ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ ICsKPiAgc3RhdGljIGludAo+ICBpbnRlbF9maWxsX2ZiX2luZm8oc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ICAJCSAgIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiKQo+IEBA IC0yNTA0LDggKzI1MTAsNyBAQCBpbnRlbF9maWxsX2ZiX2luZm8oc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ICAJCQlyZXR1cm4gcmV0Owo+ICAJCX0KPiAgCj4gLQkJaWYgKChm Yi0+bW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTIHx8Cj4gLQkJICAgICBm Yi0+bW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUykgJiYgaSA9PSAxKSB7 Cj4gKwkJaWYgKGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpICYmIGkgPT0gMSkgewo+ICAJ CQlpbnQgaHN1YiA9IGZiLT5mb3JtYXQtPmhzdWI7Cj4gIAkJCWludCB2c3ViID0gZmItPmZvcm1h dC0+dnN1YjsKPiAgCQkJaW50IHRpbGVfd2lkdGgsIHRpbGVfaGVpZ2h0Owo+IEBAIC0zMDU0LDgg KzMwNTksNyBAQCBzdGF0aWMgaW50IHNrbF9jaGVja19tYWluX3N1cmZhY2UoY29uc3Qgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAkgKiBDQ1MgQVVYIHN1cmZhY2UgZG9l c24ndCBoYXZlIGl0cyBvd24geC95IG9mZnNldHMsIHdlIG11c3QgbWFrZSBzdXJlCj4gIAkgKiB0 aGV5IG1hdGNoIHdpdGggdGhlIG1haW4gc3VyZmFjZSB4L3kgb2Zmc2V0cy4KPiAgCSAqLwo+IC0J aWYgKGZiLT5tb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MgfHwKPiAtCSAg ICBmYi0+bW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUykgewo+ICsJaWYg KGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKSB7Cj4gIAkJd2hpbGUgKCFza2xfY2hlY2tf bWFpbl9jY3NfY29vcmRpbmF0ZXMocGxhbmVfc3RhdGUsIHgsIHksIG9mZnNldCkpIHsKPiAgCQkJ aWYgKG9mZnNldCA9PSAwKQo+ICAJCQkJYnJlYWs7Cj4gQEAgLTMxODksOCArMzE5Myw3IEBAIGlu dCBza2xfY2hlY2tfcGxhbmVfc3VyZmFjZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq Y3J0Y19zdGF0ZSwKPiAgCQlyZXQgPSBza2xfY2hlY2tfbnYxMl9hdXhfc3VyZmFjZShwbGFuZV9z dGF0ZSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJcmV0dXJuIHJldDsKPiAtCX0gZWxzZSBpZiAoZmIt Pm1vZGlmaWVyID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEX0NDUyB8fAo+IC0JCSAgIGZiLT5t b2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRURfQ0NTKSB7Cj4gKwl9IGVsc2UgaWYg KGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKSB7Cj4gIAkJcmV0ID0gc2tsX2NoZWNrX2Nj c19hdXhfc3VyZmFjZShwbGFuZV9zdGF0ZSk7Cj4gIAkJaWYgKHJldCkKPiAgCQkJcmV0dXJuIHJl dDsKPiBAQCAtMTMzOTksOCArMTM0MDIsNyBAQCBzdGF0aWMgYm9vbCBza2xfcGxhbmVfZm9ybWF0 X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAqX3BsYW5lLAo+ICAJY2FzZSBEUk1fRk9S TUFUX1hCR1I4ODg4Ogo+ICAJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+ICAJY2FzZSBEUk1f Rk9STUFUX0FCR1I4ODg4Ogo+IC0JCWlmIChtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWWZf VElMRURfQ0NTIHx8Cj4gLQkJICAgIG1vZGlmaWVyID09IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVE X0NDUykKPiArCQlpZiAoaXNfY2NzX21vZGlmaWVyKG1vZGlmaWVyKSkKPiAgCQkJcmV0dXJuIHRy dWU7Cj4gIAkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIERSTV9GT1JNQVRfUkdCNTY1Ogo+ IEBAIC0xNDU5Niw4ICsxNDU5OCw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfZnJhbWVidWZmZXJfaW5p dChzdHJ1Y3QgaW50ZWxfZnJhbWVidWZmZXIgKmludGVsX2ZiLAo+ICAJCSAqIHBvdGVudGlhbCBy dW50aW1lIGVycm9ycyBhdCBwbGFuZSBjb25maWd1cmF0aW9uIHRpbWUuCj4gIAkJICovCj4gIAkJ aWYgKElTX0dFTjkoZGV2X3ByaXYpICYmIGkgPT0gMCAmJiBmYi0+d2lkdGggPiAzODQwICYmCj4g LQkJICAgIChmYi0+bW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTIHx8Cj4g LQkJICAgICBmYi0+bW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUykpCj4g KwkJICAgIGlzX2Njc19tb2RpZmllcihmYi0+bW9kaWZpZXIpKQo+ICAJCQlzdHJpZGVfYWxpZ25t ZW50ICo9IDQ7Cj4gIAo+ICAJCWlmIChmYi0+cGl0Y2hlc1tpXSAmIChzdHJpZGVfYWxpZ25tZW50 IC0gMSkpIHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5oCj4gaW5kZXggYTA0YzVh NDk1YTJiLi5kYmQ4YjFhY2Y5ZDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5oCj4gQEAgLTM4MSw0ICszODEsNSBAQCB2b2lkIGludGVsX2xpbmtfY29tcHV0ZV9tX24oaW50 IGJwcCwgaW50IG5sYW5lcywKPiAgCQkJICAgIHN0cnVjdCBpbnRlbF9saW5rX21fbiAqbV9uLAo+ ICAJCQkgICAgYm9vbCByZWR1Y2VfbV9uKTsKPiAgCj4gK2Jvb2wgaXNfY2NzX21vZGlmaWVyKGNv bnN0IHU2NCBtb2RpZmllcik7Cj4gICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0 ZS5jCj4gaW5kZXggZjcwMjZlODg3ZmE5Li5iNDlhZGNkOTM4OTIgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0xNDA3LDggKzE0MDcsNyBAQCBzdGF0aWMgYm9vbCBz a2xfcGxhbmVfZm9ybWF0X21vZF9zdXBwb3J0ZWQoc3RydWN0IGRybV9wbGFuZSAqX3BsYW5lLAo+ ICAJY2FzZSBEUk1fRk9STUFUX1hCR1I4ODg4Ogo+ICAJY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4 Ogo+ICAJY2FzZSBEUk1fRk9STUFUX0FCR1I4ODg4Ogo+IC0JCWlmIChtb2RpZmllciA9PSBJOTE1 X0ZPUk1BVF9NT0RfWWZfVElMRURfQ0NTIHx8Cj4gLQkJICAgIG1vZGlmaWVyID09IEk5MTVfRk9S TUFUX01PRF9ZX1RJTEVEX0NDUykKPiArCQlpZiAoaXNfY2NzX21vZGlmaWVyKG1vZGlmaWVyKSkK PiAgCQkJcmV0dXJuIHRydWU7Cj4gIAkJLyogZmFsbCB0aHJvdWdoICovCj4gIAljYXNlIERSTV9G T1JNQVRfUkdCNTY1Ogo+IC0tIAo+IDIuMTcuMQoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK