From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against Date: Tue, 4 Sep 2018 20:39:53 +0300 Message-ID: <20180904173953.GI5565@intel.com> References: <20180904162902.2578-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BFF16E080 for ; Tue, 4 Sep 2018 17:40:03 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180904162902.2578-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDU6Mjk6MDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IElmIHRoZSBwcmV2aW91cyBtb2Rlc2V0IGNvbW1pdCBoYXMgY29tcGxldGVkIGFuZCBp cyBubyBsb25nZXIgcGFydCBvZgo+IHRoZSBjcnRjIHN0YXRlLCBza2lwIHdhaXRpbmcgZm9yIGl0 Lgo+IAo+IEJ1Z3ppbGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDc3OTIKPiBGaXhlczogYzQ0MzAxZmNlNjE0ICgiZHJtL2k5MTU6IEFsbG93IGNvbnRy b2wgb2YgUFNSIGF0IHJ1bnRpbWUgdGhyb3VnaCBkZWJ1Z2ZzLCB2NiIpCj4gU2lnbmVkLW9mZi1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFJvZHJp Z28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlh biA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3Bzci5jIHwgMTYgKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdl ZCwgMTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wc3IuYwo+IGluZGV4IDIxOTg0ZDRjMDhlZC4uYmRkYzljN2M2ODFlIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtODM0LDYgKzgzNCw3IEBAIGludCBpbnRlbF9wc3Jfc2V0 X2RlYnVnZnNfbW9kZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2ID0gJmRldl9wcml2LT5kcm07Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5l Y3Rvcl9zdGF0ZSAqY29ubl9zdGF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRj X3N0YXRlID0gTlVMTDsKPiArCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdCA9IE5VTEw7 Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKmNydGM7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHAgKmRwOwo+ICAJ aW50IHJldDsKPiBAQCAtODYwLDEyICs4NjEsMTUgQEAgaW50IGludGVsX3Bzcl9zZXRfZGVidWdm c19tb2RlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJcmV0dXJuIHJl dDsKPiAgCj4gIAkJY3J0Y19zdGF0ZSA9IHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+c3RhdGUp Owo+IC0JCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25faW50ZXJydXB0aWJsZSgmY3J0Y19zdGF0 ZS0+YmFzZS5jb21taXQtPmh3X2RvbmUpOwo+IC0JfSBlbHNlCj4gLQkJcmV0ID0gd2FpdF9mb3Jf Y29tcGxldGlvbl9pbnRlcnJ1cHRpYmxlKCZjb25uX3N0YXRlLT5jb21taXQtPmh3X2RvbmUpOwo+ IC0KPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiArCQljb21taXQgPSBjcnRjX3N0YXRl LT5iYXNlLmNvbW1pdDsKPiArCX0gZWxzZSB7Cj4gKwkJY29tbWl0ID0gY29ubl9zdGF0ZS0+Y29t bWl0OwoKSSBjYW4ndCBldmVuIGZpbmQgd2hlcmUgd2UgY2xlYXIgc3RhdGUtPmNvbW1pdCBhZnRl ciBpdHMgZG9uZS4KRG8gd2UganVzdCBsZWF2ZSBpdCBwb2ludGluZyBhdCBmcmVlZCBtZW1vcnkg b3Igc29tZXRoaW5nPyBBbHNvIEkKY2FuJ3QgZmlndXJlIG91dCB3aHkgZHJtX2F0b21pY19oZWxw ZXJfY29tbWl0X2h3X2RvbmUoKSBjb3BpZXMKdGhlIGNvbW1pdCBhbHNvIHRvIHRoZSBvbGQgc3Rh dGUuCgo+ICsJfQo+ICsJaWYgKGNvbW1pdCkgewo+ICsJCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRp b25faW50ZXJydXB0aWJsZSgmY29tbWl0LT5od19kb25lKTsKPiArCQlpZiAocmV0KQo+ICsJCQly ZXR1cm4gcmV0Owo+ICsJfQo+ICAKPiAgCXJldCA9IG11dGV4X2xvY2tfaW50ZXJydXB0aWJsZSgm ZGV2X3ByaXYtPnBzci5sb2NrKTsKPiAgCWlmIChyZXQpCj4gLS0gCj4gMi4xOS4wLnJjMQo+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK