From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Be defensive and don't assume PSR has any commit to sync against Date: Tue, 4 Sep 2018 20:59:32 +0300 Message-ID: <20180904175932.GJ5565@intel.com> References: <20180904162902.2578-1-chris@chris-wilson.co.uk> <20180904173953.GI5565@intel.com> <153608305453.2853.15799668426378990226@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 367066E19B for ; Tue, 4 Sep 2018 17:59:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <153608305453.2853.15799668426378990226@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDY6NDQ6MTRQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTA5LTA0IDE4OjM5OjUzKQo+ID4g T24gVHVlLCBTZXAgMDQsIDIwMTggYXQgMDU6Mjk6MDJQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+ID4gPiBJZiB0aGUgcHJldmlvdXMgbW9kZXNldCBjb21taXQgaGFzIGNvbXBsZXRlZCBh bmQgaXMgbm8gbG9uZ2VyIHBhcnQgb2YKPiA+ID4gdGhlIGNydGMgc3RhdGUsIHNraXAgd2FpdGlu ZyBmb3IgaXQuCj4gPiA+IAo+ID4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9w Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA3NzkyCj4gPiA+IEZpeGVzOiBjNDQzMDFmY2U2MTQgKCJk cm0vaTkxNTogQWxsb3cgY29udHJvbCBvZiBQU1IgYXQgcnVudGltZSB0aHJvdWdoIGRlYnVnZnMs IHY2IikKPiA+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+Cj4gPiA+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RA bGludXguaW50ZWwuY29tPgo+ID4gPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50 ZWwuY29tPgo+ID4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlh bkBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cHNyLmMgfCAxNiArKysrKysrKysrLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3Bzci5jCj4gPiA+IGluZGV4IDIxOTg0ZDRjMDhlZC4uYmRkYzljN2M2ODFlIDEwMDY0NAo+ID4g PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gPiBAQCAtODM0LDYgKzgzNCw3IEBAIGlu dCBpbnRlbF9wc3Jfc2V0X2RlYnVnZnNfbW9kZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gPiA+ICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSAmZGV2X3ByaXYtPmRy bTsKPiA+ID4gICAgICAgc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGU7Cj4g PiA+ICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0gTlVMTDsKPiA+ ID4gKyAgICAgc3RydWN0IGRybV9jcnRjX2NvbW1pdCAqY29tbWl0ID0gTlVMTDsKPiA+ID4gICAg ICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gPiAgICAgICBzdHJ1Y3QgaW50ZWxfZHAgKmRw Owo+ID4gPiAgICAgICBpbnQgcmV0Owo+ID4gPiBAQCAtODYwLDEyICs4NjEsMTUgQEAgaW50IGlu dGVsX3Bzcl9zZXRfZGVidWdmc19tb2RlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+ID4gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ICAKPiA+ID4g ICAgICAgICAgICAgICBjcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5zdGF0 ZSk7Cj4gPiA+IC0gICAgICAgICAgICAgcmV0ID0gd2FpdF9mb3JfY29tcGxldGlvbl9pbnRlcnJ1 cHRpYmxlKCZjcnRjX3N0YXRlLT5iYXNlLmNvbW1pdC0+aHdfZG9uZSk7Cj4gPiA+IC0gICAgIH0g ZWxzZQo+ID4gPiAtICAgICAgICAgICAgIHJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25faW50ZXJy dXB0aWJsZSgmY29ubl9zdGF0ZS0+Y29tbWl0LT5od19kb25lKTsKPiA+ID4gLQo+ID4gPiAtICAg ICBpZiAocmV0KQo+ID4gPiAtICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ICsgICAgICAg ICAgICAgY29tbWl0ID0gY3J0Y19zdGF0ZS0+YmFzZS5jb21taXQ7Cj4gPiA+ICsgICAgIH0gZWxz ZSB7Cj4gPiA+ICsgICAgICAgICAgICAgY29tbWl0ID0gY29ubl9zdGF0ZS0+Y29tbWl0Owo+ID4g Cj4gPiBJIGNhbid0IGV2ZW4gZmluZCB3aGVyZSB3ZSBjbGVhciBzdGF0ZS0+Y29tbWl0IGFmdGVy IGl0cyBkb25lLgo+ID4gRG8gd2UganVzdCBsZWF2ZSBpdCBwb2ludGluZyBhdCBmcmVlZCBtZW1v cnkgb3Igc29tZXRoaW5nPyBBbHNvIEkKPiA+IGNhbid0IGZpZ3VyZSBvdXQgd2h5IGRybV9hdG9t aWNfaGVscGVyX2NvbW1pdF9od19kb25lKCkgY29waWVzCj4gPiB0aGUgY29tbWl0IGFsc28gdG8g dGhlIG9sZCBzdGF0ZS4KPiAKPiBMZXQgbWUgYmUgdGhlIG1lc3NlbmdlciB0aGVuIDspIGNvbW1p dCBpcyBOVUxMIGF0IHRoaXMgcG9pbnQsIEkganVzdAo+IHByZXN1bWVkIGl0IHdhcyBpbnRlbnRp b25hbC4KCk15IGV4cGVjdGF0aW9uIHdvdWxkIGJlIHRoYXQgaXQgZ2V0cyBjbGVhcmVkIHNvbWV3 aGVyZSwgYnV0IEkgc2ltcGx5CmNhbid0IGZpbmQgYW55IHN1Y2ggY29kZS4gU28gdGhlIG9ubHkg ZXhwbGFuYXRpb24gSSBoYXZlIG5vdyBpcyB0aGF0CnRoZXJlIGhhcyBuZXZlciBiZWVuIGFueSBj b21taXRzIG9uIHRoYXQgY3J0Yy9jb25uZWN0b3IgYmVmb3JlIGFuZAp0aGF0J3Mgd2h5IGl0J3Mg TlVMTC4KCkJhc2VkIG9uIHRoYXQgdGhlb3J5IHRoaXMgZG9lcyBzZWVtIHNhbmUsIHNvClJldmll d2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoK LS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK