From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow Date: Wed, 5 Sep 2018 09:17:35 -0700 Message-ID: <20180905161733.GA1812@intel.com> References: <20180905095321.13843-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86A1D89745 for ; Wed, 5 Sep 2018 16:14:46 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180905095321.13843-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTI6NTM6MjFQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2UndmUgb3B0ZWQgdG8gdXNlIHRoZSBtYXhpbXVtIGxpbmsgcmF0ZSBhbmQgbGFuZSBj b3VudCBmb3IgZURQIHBhbmVscywKPiBiZWNhdXNlIHR5cGljYWxseSB0aGUgbWF4aW11bSBzdXBw b3J0ZWQgY29uZmlndXJhdGlvbiByZXBvcnRlZCBieSB0aGUKPiBwYW5lbCBoYXMgbWF0Y2hlZCB0 aGUgbmF0aXZlIHJlc29sdXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBwYW5lbCwgYW5kCj4gb3B0 aW1pemluZyB0aGUgbGluayBoYXMgbGVhZCB0byBwcm9ibGVtcy4KPiAKPiBXaXRoIGVEUCAxLjQg cmF0ZSBzZWxlY3QgbWV0aG9kIGFuZCBEU0MgZmVhdHVyZXMsIHRoaXMgaXMgZGVjcmVhc2luZ2x5 Cj4gdGhlIGNhc2UuIFRoZXJlJ3MgYSBuZWVkIHRvIG9wdGltaXplIHRoZSBsaW5rIHBhcmFtZXRl cnMuIE1vcmVvdmVyLAo+IGFscmVhZHkgZURQIDEuMyBzdGF0ZXMgZmFzdCBsaW5rIHdpdGggZmV3 ZXIgbGFuZXMgaXMgcHJlZmVycmVkIG92ZXIgdGhlCj4gd2lkZSBhbmQgc2xvdy4gKFdpZGUgYW5k IHNsb3cgc2hvdWxkIHN0aWxsIGJlIG1vcmUgcmVsaWFibGUgZm9yIGxvbmdlcgo+IGNhYmxlIGxl bmd0aHMuKQo+IAo+IEFkZGl0aW9uYWxseSwgdGhlcmUgaGF2ZSBiZWVuIHJlcG9ydHMgb2YgcGFu ZWxzIGZhaWxpbmcgb24gYXJiaXRyYXJ5Cj4gbGluayBjb25maWd1cmF0aW9ucywgYWx0aG91Z2gg YXJndWFibHkgYWxsIGNvbmZpZ3VyYXRpb25zIHRoZXkgY2xhaW0gdG8KPiBzdXBwb3J0IHNob3Vs ZCB3b3JrLgo+IAo+IE9wdGltaXplIGVEUCAxLjQrIGxpbmsgY29uZmlnIGZhc3QgYW5kIG5hcnJv dy4KPiAKPiBTaWRlIG5vdGU6IFRoZSBpbXBsZW1lbnRhdGlvbiBoYXMgYSBuZWFyIGR1cGxpY2F0 ZSBvZiB0aGUgbGluayBjb25maWcKPiBmdW5jdGlvbiwgd2l0aCBqdXN0IHRoZSB0d28gaW5uZXIg Zm9yIGxvb3BzIHR1cm5lZCBpbnNpZGUgb3V0LiBQZXJoYXBzCj4gdGhlcmUnZCBiZSBhIHdheSB0 byBtYWtlIHRoaXMsIHNheSwgbW9yZSB0YWJsZSBkcml2ZW4gdG8gcmVkdWNlIHRoZQo+IGR1cGxp Y2F0aW9uLCBidXQgc2VlbXMgbGlrZSB0aGF0IHdvdWxkIGxlYWQgdG8gZHVwbGljYXRpb24gaW4g dGhlIHRhYmxlCj4gZ2VuZXJhdGlvbi4gV2UnbGwgYWxzbyBoYXZlIHRvIHNlZSBob3cgdGhlIGxp bmsgY29uZmlnIG9wdGltaXphdGlvbiBmb3IKPiBEU0MgdHVybnMgb3V0LgoKSW4gY2FzZSBvZiBE U0MsIGN1cnJlbnRseSB3ZSBvbmx5IGNvbXB1dGUgRFNDIHBhcmFtcyBhbmQgZW5hYmxlIERTQyBp ZgppbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnKCkgcmV0dXJucyBhIGZhbHNlLiBTbyBzaW5j ZSB0aGUgZmFzdF9uYXJyb3cKbGluayBjYWxjdWxhdGlvbiBpcyBlbWJlZGRlZCB3aXRoaW4gdGhl IGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWcoKSwKRFNDIGNhbiBzdGlsbCBiZSBlbmFibGVk IGlmIGxpbmsgY29uZmlnIHJldHVybnMgZmFsc2Ugd2l0aCBlaXRoZXIgZmFzdF9uYXJyb3cKb3Ig d2lkZSBhcHByb2FjaC4KCkhvd2V2ZXIgaWRlYWxseSwgZm9yIHBvd2VyIHNhdmluZ3MgZm9yIGVE UCB3ZSBjb3VsZCBldmVudHVhbGx5IGVuYWJsZSBEU0MgZmlyc3QKaWYgc3VwcG9ydGVkIGJ5IHRo ZSBwYW5lbCwgZmluZCB0aGUgbW9kZSByYXRlIHdpdGggY29tcHJlc3NlZCBicHAgYW5kIHRoZW4K b3B0aW1pemUgdGhlIGxpbmsgY29uZmlnIHdpdGggdGhhdCBjb21wcmVzc2VkIGJwcC4gU28gcmV2 ZXJzZSB0aGUgb3JkZXIKb2YgZHNjX2NvbXB1dGVfY29uZmlnIGFuZCBpbnRlbF9kcF9jb21wdXRl X2xpbmtfY29uZmlnKCkKCkV2ZXJ5dGhpbmcgZWxzZSBpbiB0aGUgcGF0Y2ggbG9va3MgZ29vZCB0 byBtZS4KCkFja2VkLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29t PgoKTWFuYXNpCgoKPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNv bT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IENjOiBNYXR0 IEF0d29vZCA8bWF0dGhldy5zLmF0d29vZEBpbnRlbC5jb20+Cj4gQ2M6ICJMZWUsIFNoYXduIEMi IDxzaGF3bi5jLmxlZUBpbnRlbC5jb20+Cj4gQWNrZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjY3Cj4gU2lnbmVkLW9mZi1ieTogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KPiAKPiAtLS0KPiAKPiB2MiBvZiBodHRwOi8vcGF0Y2h3b3Jr LmZyZWVkZXNrdG9wLm9yZy9wYXRjaC9tc2dpZC8yMDE4MDUwOTA3MTMyMS4yODU2My0xLWphbmku bmlrdWxhQGludGVsLmNvbQo+IAo+IFVudGVzdGVkLiBJdCdzIHBvc3NpYmxlIHRoaXMgaGVscHMg dGhlIHJlZmVyZW5jZWQgYnVnLiBUaGUgZG93bnNpZGUgaXMKPiB0aGF0IHRoaXMgcGF0Y2ggaGFz IGEgYnVuY2ggb2YgZGVwZW5kZW5jaWVzIHRoYXQgYXJlIHRvbyBtdWNoIHRvCj4gYmFja3BvcnQg dG8gc3RhYmxlIGtlcm5lbHMuIElmIHRoZSBwYXRjaCB3b3Jrcywgd2UgbWF5IG5lZWQgdG8gY29u c2lkZXIKPiBoYWNraW5nIHRvZ2V0aGVyIGFuIHVnbGllciBiYWNrcG9ydC4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDczICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA2MiBpbnNlcnRpb25zKCspLCAx MSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCA0MzZjMjJk ZTMzYjYuLmJmN2I5MTgzMmM4YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC0x OTIxLDYgKzE5MjEsNDIgQEAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ193aWRlKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAlyZXR1cm4gZmFsc2U7Cj4gIH0KPiAgCj4gKy8qIE9w dGltaXplIGxpbmsgY29uZmlnIGluIG9yZGVyOiBtYXggYnBwLCBtaW4gbGFuZXMsIG1pbiBjbG9j ayAqLwo+ICtzdGF0aWMgYm9vbAo+ICtpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX2Zhc3Qo c3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiArCQkJCSAgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKnBpcGVfY29uZmlnLAo+ICsJCQkJICBjb25zdCBzdHJ1Y3QgbGlua19jb25maWdfbGltaXRz ICpsaW1pdHMpCj4gK3sKPiArCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICphZGp1c3RlZF9tb2Rl ID0gJnBpcGVfY29uZmlnLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gKwlpbnQgYnBwLCBjbG9jaywg bGFuZV9jb3VudDsKPiArCWludCBtb2RlX3JhdGUsIGxpbmtfY2xvY2ssIGxpbmtfYXZhaWw7Cj4g Kwo+ICsJZm9yIChicHAgPSBsaW1pdHMtPm1heF9icHA7IGJwcCA+PSBsaW1pdHMtPm1pbl9icHA7 IGJwcCAtPSAyICogMykgewo+ICsJCW1vZGVfcmF0ZSA9IGludGVsX2RwX2xpbmtfcmVxdWlyZWQo YWRqdXN0ZWRfbW9kZS0+Y3J0Y19jbG9jaywKPiArCQkJCQkJICAgYnBwKTsKPiArCj4gKwkJZm9y IChsYW5lX2NvdW50ID0gbGltaXRzLT5taW5fbGFuZV9jb3VudDsKPiArCQkgICAgIGxhbmVfY291 bnQgPD0gbGltaXRzLT5tYXhfbGFuZV9jb3VudDsKPiArCQkgICAgIGxhbmVfY291bnQgPDw9IDEp IHsKPiArCQkJZm9yIChjbG9jayA9IGxpbWl0cy0+bWluX2Nsb2NrOyBjbG9jayA8PSBsaW1pdHMt Pm1heF9jbG9jazsgY2xvY2srKykgewo+ICsJCQkJbGlua19jbG9jayA9IGludGVsX2RwLT5jb21t b25fcmF0ZXNbY2xvY2tdOwo+ICsJCQkJbGlua19hdmFpbCA9IGludGVsX2RwX21heF9kYXRhX3Jh dGUobGlua19jbG9jaywKPiArCQkJCQkJCQkgICAgbGFuZV9jb3VudCk7Cj4gKwo+ICsJCQkJaWYg KG1vZGVfcmF0ZSA8PSBsaW5rX2F2YWlsKSB7Cj4gKwkJCQkJcGlwZV9jb25maWctPmxhbmVfY291 bnQgPSBsYW5lX2NvdW50Owo+ICsJCQkJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsKPiAr CQkJCQlwaXBlX2NvbmZpZy0+cG9ydF9jbG9jayA9IGxpbmtfY2xvY2s7Cj4gKwo+ICsJCQkJCXJl dHVybiB0cnVlOwo+ICsJCQkJfQo+ICsJCQl9Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiBm YWxzZTsKPiArfQo+ICsKPiAgc3RhdGljIGJvb2wKPiAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2Nv bmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCQkJICAgICBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gQEAgLTE5NDUsMTMgKzE5ODEsMTUgQEAgaW50 ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwK PiAgCWxpbWl0cy5taW5fYnBwID0gNiAqIDM7Cj4gIAlsaW1pdHMubWF4X2JwcCA9IGludGVsX2Rw X2NvbXB1dGVfYnBwKGludGVsX2RwLCBwaXBlX2NvbmZpZyk7Cj4gIAo+IC0JaWYgKGludGVsX2Rw X2lzX2VkcChpbnRlbF9kcCkpIHsKPiArCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApICYm IGludGVsX2RwLT5lZHBfZHBjZFswXSA8IERQX0VEUF8xNCkgewo+ICAJCS8qCj4gIAkJICogVXNl IHRoZSBtYXhpbXVtIGNsb2NrIGFuZCBudW1iZXIgb2YgbGFuZXMgdGhlIGVEUCBwYW5lbAo+IC0J CSAqIGFkdmVydGl6ZXMgYmVpbmcgY2FwYWJsZSBvZi4gVGhlIHBhbmVscyBhcmUgZ2VuZXJhbGx5 Cj4gLQkJICogZGVzaWduZWQgdG8gc3VwcG9ydCBvbmx5IGEgc2luZ2xlIGNsb2NrIGFuZCBsYW5l Cj4gLQkJICogY29uZmlndXJhdGlvbiwgYW5kIHR5cGljYWxseSB0aGVzZSB2YWx1ZXMgY29ycmVz cG9uZCB0byB0aGUKPiAtCQkgKiBuYXRpdmUgcmVzb2x1dGlvbiBvZiB0aGUgcGFuZWwuCj4gKwkJ ICogYWR2ZXJ0aXplcyBiZWluZyBjYXBhYmxlIG9mLiBUaGUgZURQIDEuMyBhbmQgZWFybGllciBw YW5lbHMKPiArCQkgKiBhcmUgZ2VuZXJhbGx5IGRlc2lnbmVkIHRvIHN1cHBvcnQgb25seSBhIHNp bmdsZSBjbG9jayBhbmQKPiArCQkgKiBsYW5lIGNvbmZpZ3VyYXRpb24sIGFuZCB0eXBpY2FsbHkg dGhlc2UgdmFsdWVzIGNvcnJlc3BvbmQgdG8KPiArCQkgKiB0aGUgbmF0aXZlIHJlc29sdXRpb24g b2YgdGhlIHBhbmVsLiBXaXRoIGVEUCAxLjQgcmF0ZSBzZWxlY3QKPiArCQkgKiBhbmQgRFNDLCB0 aGlzIGlzIGRlY3JlYXNpbmdseSB0aGUgY2FzZSwgYW5kIHdlIG5lZWQgdG8gYmUKPiArCQkgKiBh YmxlIHRvIHNlbGVjdCBsZXNzIHRoYW4gbWF4aW11bSBsaW5rIGNvbmZpZy4KPiAgCQkgKi8KPiAg CQlsaW1pdHMubWluX2xhbmVfY291bnQgPSBsaW1pdHMubWF4X2xhbmVfY291bnQ7Cj4gIAkJbGlt aXRzLm1pbl9jbG9jayA9IGxpbWl0cy5tYXhfY2xvY2s7Cj4gQEAgLTE5NjUsMTIgKzIwMDMsMjUg QEAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5j b2RlciwKPiAgCQkgICAgICBpbnRlbF9kcC0+Y29tbW9uX3JhdGVzW2xpbWl0cy5tYXhfY2xvY2td LAo+ICAJCSAgICAgIGxpbWl0cy5tYXhfYnBwLCBhZGp1c3RlZF9tb2RlLT5jcnRjX2Nsb2NrKTsK PiAgCj4gLQkvKgo+IC0JICogT3B0aW1pemUgZm9yIHNsb3cgYW5kIHdpZGUuIFRoaXMgaXMgdGhl IHBsYWNlIHRvIGFkZCBhbHRlcm5hdGl2ZQo+IC0JICogb3B0aW1pemF0aW9uIHBvbGljeS4KPiAt CSAqLwo+IC0JaWYgKCFpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnX3dpZGUoaW50ZWxfZHAs IHBpcGVfY29uZmlnLCAmbGltaXRzKSkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gKwlpZiAoaW50ZWxf ZHBfaXNfZWRwKGludGVsX2RwKSkgewo+ICsJCS8qCj4gKwkJICogT3B0aW1pemUgZm9yIGZhc3Qg YW5kIG5hcnJvdy4gZURQIDEuMyBzZWN0aW9uIDMuMyBhbmQgZURQIDEuNAo+ICsJCSAqIHNlY3Rp b24gQS4xOiAiSXQgaXMgcmVjb21tZW5kZWQgdGhhdCB0aGUgbWluaW11bSBudW1iZXIgb2YKPiAr CQkgKiBsYW5lcyBiZSB1c2VkLCB1c2luZyB0aGUgbWluaW11bSBsaW5rIHJhdGUgYWxsb3dlZCBm b3IgdGhhdAo+ICsJCSAqIGxhbmUgY29uZmlndXJhdGlvbi4iCj4gKwkJICoKPiArCQkgKiBOb3Rl IHRoYXQgd2UgdXNlIHRoZSBtYXggY2xvY2sgYW5kIGxhbmUgY291bnQgZm9yIGVEUCAxLjMgYW5k Cj4gKwkJICogZWFybGllciwgYW5kIGZhc3QgdnMuIHdpZGUgaXMgaXJyZWxldmFudC4KPiArCQkg Ki8KPiArCQlpZiAoIWludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfZmFzdChpbnRlbF9kcCwg cGlwZV9jb25maWcsCj4gKwkJCQkJCSAgICAgICAmbGltaXRzKSkKPiArCQkJcmV0dXJuIGZhbHNl Owo+ICsJfSBlbHNlIHsKPiArCQkvKiBPcHRpbWl6ZSBmb3Igc2xvdyBhbmQgd2lkZS4gKi8KPiAr CQlpZiAoIWludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfd2lkZShpbnRlbF9kcCwgcGlwZV9j b25maWcsCj4gKwkJCQkJCSAgICAgICAmbGltaXRzKSkKPiArCQkJcmV0dXJuIGZhbHNlOwo+ICsJ fQo+ICAKPiAgCURSTV9ERUJVR19LTVMoIkRQIGxhbmUgY291bnQgJWQgY2xvY2sgJWQgYnBwICVk XG4iLAo+ICAJCSAgICAgIHBpcGVfY29uZmlnLT5sYW5lX2NvdW50LCBwaXBlX2NvbmZpZy0+cG9y dF9jbG9jaywKPiAtLSAKPiAyLjExLjAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==