Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Lisovskiy, Stanislav
2018-09-17T08:25:52Z

On Fri, 2018-09-14 at 20:05 +0300, Juha-Pekka Heikkilä wrote:
>
> Lisovskiy, Stanislav kirjoitti 14.9.2018 klo 17.30:
> > On Fri, 2018-09-14 at 16:47 +0300, Ville Syrjälä wrote:
> > > On Fri, Sep 14, 2018 at 01:36:32PM +0000, Lisovskiy, Stanislav
> > > wrote:
> > > > On Fri, 2018-09-07 at 11:45 +0300, Stanislav Lisovskiy wrote:
> > > > > Introduced new XYUV scan-in format for framebuffer and
> > > > > added support for it to i915(SkyLake+).
> > > > >
> > > > > Stanislav Lisovskiy (2):
> > > > > drm: Introduce new DRM_FORMAT_XYUV
> > > > > drm/i915: Adding YUV444 packed format support for skl+
> > > > >
> > > > > drivers/gpu/drm/drm_fourcc.c | 1 +
> > > > > drivers/gpu/drm/i915/i915_reg.h | 2 +-
> > > > > drivers/gpu/drm/i915/intel_display.c | 15 +++++++++++++++
> > > > > drivers/gpu/drm/i915/intel_sprite.c | 2 ++
> > > > > include/uapi/drm/drm_fourcc.h | 1 +
> > > > > 5 files changed, 20 insertions(+), 1 deletion(-)
> > > > >
> > > >
> > > > Ping. There is an IGT patch which got Reviewed-by Ville.
> > > > This one left in order to get XYUV support.
> > >
> > > Did we figure out userspace for this?
> > >
> > > Was the conflict solved with the other guy (forgot who it is)
> > > trying to add the same format with a different name?
> >
> > Currently for userspace we have VLC(checked with Juha-Pekka) and
> > also IGT test case.
>
> Hei, no. VLC was *not* showing the mode correctly back then when we
> tested. VLC kms plugin is able to initialize the mode and it's all
> stable but VLC didn't have correct video converter to reach matching
> xYUV output. You remember Stan we tried to increase the recursion
> for
> decoding in case it would help? VLC doesn't have codec which produce
> correct output, one of those xxx -> YUV plug-ins in VLC should be
> patched before VLC can be considered as userspace for this mode.

Ok, I remember we managed to make it work somehow and saw some picture,
so for some reason I thought it is working already. What is our plan
then? Should we try to improve VLC codecs/plugins or may be I should
then work with some other user space case?

>
> /Juha-Pekka
>
> >
> > I think those guys were from ARM and they were adding also support
> > for
> > XYUV. The only difference was that they called XYUV, like XYUV8888
> > something.
> > Our patches were otherwise identical regarding drm_fourcc.c part, I
> > don't see their stuff merged, but I guess it really shouldn't
> > matter,
> > who does this first. i915 specific part doesn't conflict with their
> > stuff. To be honest, I forgot the guy's name neither could find his
> > email in my mailbox.
> > So hopefully somebody shows up here.
> >
> > >
--
Best Regards,

Lisovskiy Stanislav
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org