From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/3] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse() Date: Fri, 7 Sep 2018 17:32:36 +0300 Message-ID: <20180907143236.GE5565@intel.com> References: <20180907062135.30054-1-dhinakaran.pandiyan@intel.com> <8736ul4h37.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 95B516E93F for ; Fri, 7 Sep 2018 14:32:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <8736ul4h37.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Jan-Marek Glogowski , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMDcsIDIwMTggYXQgMDM6Mzk6MjRQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAwNiBTZXAgMjAxOCwgRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJh bi5wYW5kaXlhbkBpbnRlbC5jb20+IHdyb3RlOgo+ID4gQ29tbWVudCBjbGFpbXMgbGluayBuZWVk cyB0byBiZSByZXRyYWluZWQgYmVjYXVzZSB0aGUgY29ubmVjdGVkIHNpbmsgcmFpc2VkCj4gPiBh IGxvbmcgcHVsc2UgdG8gaW5kaWNhdGUgbGluayBsb3NzLiBJZiB0aGUgc2luayBkaWQgc28sCj4g PiBpbnRlbF9kcF9ob3RwbHVnKCkgd291bGQgaGF2ZSBoYW5kbGVkIGxpbmsgcmV0cmFpbmluZy4g TG9va2luZyBhdCB0aGUKPiA+IGxvZ3MgaW4gQnVnemlsbGEgcmVmZXJlbmNlZCBpbiBjb21taXQg JzNjZjcxYmM5OTA0ZCAoImRybS9pOTE1OiBSZS1hcHBseQo+ID4gUGVyZm9ybSBsaW5rIHF1YWxp dHkgY2hlY2ssIHVuY29uZGl0aW9uYWxseSBkdXJpbmcgbG9uZyBwdWxzZSIiKScsIHRoZQo+ID4g aXNzdWUgaXMgdGhhdCB0aGUgc2luayBkb2VzIG5vdCB0cmlnZ2VyIGFuIGludGVycnVwdC4gV2Ug d2FudCB0aGUKPiA+IC0+ZGV0ZWN0KCkgZnJvbSB1c2VyIHNwYWNlIHRvIGNoZWNrIGxpbmsgc3Rh dHVzIGFuZCByZXRyYWluLiBWaWxsZSdzCj4gPiByZXZpZXcgZm9yIHRoZSBvcmlnaW5hbCBwYXRj aCBhbHNvIGluZGljYXRlcyB0aGUgc2FtZSByb290IGNhdXNlLgo+ID4KPiA+IEkgaGF2ZSBhbHNv IHJlbmFtZWQgbG9uZ19wdWxzZSgpIHRvIGZ1bGxfZGV0ZWN0KCkuCj4gCj4gU2luY2UgaW50ZWxf ZHBfZGV0ZWN0KCkgZG9lc24ndCBhY3R1YWxseSBkbyAqYW55dGhpbmcqIGV4Y2VwdCBza2lwCj4g ZGV0ZWN0IHNvbWV0aW1lcywgSSB0aGluayAiZnVsbCBkZXRlY3QiIGlzIGEgbWlzbm9tZXIuCj4g Cj4gQXJndWFibHkgeW91IGNvdWxkIG1lcmdlIGludGVsX2RwX2xvbmdfcHVsc2UoKSBpbnRvIGl0 cyBvbmx5IGNhbGxlciwKPiBpbnRlbF9kcF9kZXRlY3QoKSwgYW5kIGRvIGFuIGVhcmx5IHJldHVy biBvbiBza2lwcGluZyBkZXRlY3QuIFlvdSBoYXZlCj4gdG8gbG9vayBhdCB0aGUgZnVuY3Rpb25z LCBhbmQgd29uZGVyIGlmIHRoZSBjdXJyZW50IHNwbGl0IGlzIHRoZSByaWdodAo+IG9uZS4KClRo YXQncyBwcmV0dHkgbXVjaCB3aGF0IEkgc3VnZ2VzdGVkIGVhcmxpZXIuIEFsdGhvdWdoIHNvbWVv bmUgc2hvdWxkCmRvdWJsZSBjaGVjayB0byBtYWtlIHN1cmUgdGhlIGRldGVjdF9kb25lIGZsYWcg ZXZlbiBtYWtlcyBzZW5zZSB0aGVzZQpkYXlzLiBNYXliZSBpdCBkb2VzLCBtYXliZSBpdCBkb2Vz bid0LCBJIGRvbid0IHJlY2FsbC4KCj4gCj4gUGxlYXNlIGxldCBvdGhlcnMgY2hpbWUgaW4gdG9v IGJlZm9yZSBtYWtpbmcgY2hhbmdlcy4KPiAKPiBCUiwKPiBKYW5pLgo+IAo+IAo+ID4KPiA+IENj OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogSmFuaSBOaWt1bGEgPGphbmku bmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cj4gPiBDYzogSmFuLU1hcmVrIEdsb2dvd3NraSA8Z2xvZ293QGZiaWhvbWUu ZGU+Cj4gPiBSZWZlcmVuY2VzOiAzY2Y3MWJjOTkwNGQgKCJkcm0vaTkxNTogUmUtYXBwbHkgIlBl cmZvcm0gbGluayBxdWFsaXR5IGNoZWNrLCB1bmNvbmRpdGlvbmFsbHkgZHVyaW5nIGxvbmcgcHVs c2UiIikKPiA+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4u cGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHAuYyB8IDE3ICsrKysrLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgaW5z ZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5j Cj4gPiBpbmRleCA0MzZjMjJkZTMzYjYuLmJlZmRhYTA3NmQ4YyAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMKPiA+IEBAIC01MDEyLDcgKzUwMTIsNyBAQCBpbnRlbF9kcF91bnNldF9l ZGlkKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyBp bnQKPiA+IC1pbnRlbF9kcF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiA+ICtpbnRlbF9kcF9mdWxsX2RldGVjdChzdHJ1Y3QgaW50ZWxfY29ubmVjdG9yICpj b25uZWN0b3IsCj4gPiAgCQkgICAgc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVpcmVfY3R4ICpjdHgp Cj4gPiAgewo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1 KGNvbm5lY3Rvci0+YmFzZS5kZXYpOwo+ID4gQEAgLTUwNzQsMTYgKzUwNzQsOCBAQCBpbnRlbF9k cF9sb25nX3B1bHNlKHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiA+ICAJCWdv dG8gb3V0Owo+ID4gIAl9IGVsc2Ugewo+ID4gIAkJLyoKPiA+IC0JCSAqIElmIGRpc3BsYXkgaXMg bm93IGNvbm5lY3RlZCBjaGVjayBsaW5rcyBzdGF0dXMsCj4gPiAtCQkgKiB0aGVyZSBoYXMgYmVl biBrbm93biBpc3N1ZXMgb2YgbGluayBsb3NzIHRyaWdnZXJpbmcKPiA+IC0JCSAqIGxvbmcgcHVs c2UuCj4gPiAtCQkgKgo+ID4gLQkJICogU29tZSBzaW5rcyAoZWcuIEFTVVMgUEIyODdRKSBzZWVt IHRvIHBlcmZvcm0gc29tZQo+ID4gLQkJICogd2VpcmQgSFBEIHBpbmcgcG9uZyBkdXJpbmcgbW9k ZXNldHMuIFNvIHdlIGNhbiBhcHBhcmVudGx5Cj4gPiAtCQkgKiBlbmQgdXAgd2l0aCBIUEQgZ29p bmcgbG93IGR1cmluZyBhIG1vZGVzZXQsIGFuZCB0aGVuCj4gPiAtCQkgKiBnb2luZyBiYWNrIHVw IHNvb24gYWZ0ZXIuIEFuZCBvbmNlIHRoYXQgaGFwcGVucyB3ZSBtdXN0Cj4gPiAtCQkgKiByZXRy YWluIHRoZSBsaW5rIHRvIGdldCBhIHBpY3R1cmUuIFRoYXQncyBpbiBjYXNlIG5vCj4gPiAtCQkg KiB1c2Vyc3BhY2UgY29tcG9uZW50IHJlYWN0ZWQgdG8gaW50ZXJtaXR0ZW50IEhQRCBkaXAuCj4g PiArCQkgKiBDaGVjayBsaW5rIHN0YXR1cyBpbiBjYXNlIHRoZSBsaW5rIHdlbnQgb3V0IG9mCj4g PiArCQkgKiBzeW5jaHJvbml6YXRpb24gYW5kIHRoZSBzaW5rIGRpZCBub3QgdGVsbCB1cy4KPiA+ ICAJCSAqLwo+ID4gIAkJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIgPSAmZHBfdG9fZGln X3BvcnQoaW50ZWxfZHApLT5iYXNlOwo+ID4gIAo+ID4gQEAgLTUxNDksNyArNTE0MSw4IEBAIGlu dGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gIAkJCQly ZXR1cm4gcmV0Owo+ID4gIAkJfQo+ID4gIAo+ID4gLQkJc3RhdHVzID0gaW50ZWxfZHBfbG9uZ19w dWxzZShpbnRlbF9kcC0+YXR0YWNoZWRfY29ubmVjdG9yLCBjdHgpOwo+ID4gKwkJc3RhdHVzID0g aW50ZWxfZHBfZnVsbF9kZXRlY3QoaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3RvciwKPiA+ICsJ CQkJCSAgICAgIGN0eCk7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJaW50ZWxfZHAtPmRldGVjdF9kb25l ID0gZmFsc2U7Cj4gCj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBo aWNzIENlbnRlcgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK