From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/4] drm/i915/execlists: Use coherent writes into the context image Date: Fri, 14 Sep 2018 16:03:35 +0300 Message-ID: <20180914130335.GB5565@intel.com> References: <20180914094215.23649-1-chris@chris-wilson.co.uk> <20180914094215.23649-4-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92BD66E7BF for ; Fri, 14 Sep 2018 13:03:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180914094215.23649-4-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMTA6NDI6MTVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoYXQgd2UgdXNlIGEgV0IgbWFwcGluZyBmb3IgdXBkYXRpbmcgdGhlIFJJTkdfVEFJ TCByZWdpc3RlciBpbnNpZGUgdGhlCj4gY29udGV4dCBpbWFnZSBldmVuIG9uICFsbGMgbWFjaGlu ZXMgaGFzIGJlZW4gYSBzb3VyY2Ugb2YgY29uc3Rlcm5hdGlvbgo+IGZvciBldmVyeSByZWFkZXIu IEl0IGFwcGVhcnMgdG8gd29yayBvbiBic3crLCBidXQgaXQgbWF5IGp1c3QgaGF2ZSBiZWVuCj4g dGhhdCB3ZSBoYXZlIGJlZW4gaW5jcmVkaWJseSBiYWQgYXQgZGV0ZWN0aW5nIHRoZSBlcnJvcnMu CgpQcmVzdW1hYmx5IGl0J3MgZHVlIHRvIHRoZSAiYWxsIGdndHQgYWNjZXNzZXMgZ28gdGhyb3Vn aCBwYXRbMF0iIGFuZAp3ZSBtYWtlIHBhdFswXSBzbm9vcC4gU28gcHJlc3VtYWJseSB0aGUgaHcg c2hvdWxkIHNub29wIHdoZW4gbG9hZGluZwp0aGUgY29udGV4dC4uLiBtYXliZS4KCj4gCj4gdjI6 IFdpdGggZXh0cmEgZW50aHVzaWFzbS4KPiB2MzogRHJvcCBmb3JjZSBvZiBtYXAgdHlwZSBmb3Ig cGlubmVkIGRlZmF1bHRfc3RhdGUgYXMgYnkgdGhlIHRpbWUgd2UKPiBwaW4gaXQsIHRoZSBtYXAg dHlwZSBpcyBhbHdheXMgV0IgYW5kIGRvZXNuJ3QgY29uZmxpY3Qgd2l0aCB0aGUgZWFybGllcgo+ IHVzZSBieSBjZS0+c3RhdGUuCj4gdjQ6IFRyYW5zZmVyIGVuZ2luZS0+ZGVmYXVsdF9zdGF0ZSBm cm9tIE1BUF9XQyB0byBNQVBfV0Igb24gY3JlYXRpb24gc28KPiB3ZSBkbyBub3QgbmVlZCB0aGUg TUFQX0ZPUkNFIGxpdHRlcmVkIGFyb3VuZCB0aGUgYmFja2VuZHMKPiAKPiBTaWduZWQtb2ZmLWJ5 OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBSZXZpZXdlZC1ieTog VHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCA2ICsrKysrKwo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jICB8IDQgKysrLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Bl cmYuYyB8IDMgKystCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIHwgNiArKysr LS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IGJiNDNlNTZkZjE5Ny4uN2Q0ZGFhNzQx MmYxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gQEAgLTMwOTcsNiArMzA5NywxMiBA QCBlbnVtIGk5MTVfbWFwX3R5cGUgewo+ICAJSTkxNV9NQVBfRk9SQ0VfV0MgPSBJOTE1X01BUF9X QyB8IEk5MTVfTUFQX09WRVJSSURFLAo+ICB9Owo+ICAKPiArc3RhdGljIGlubGluZSBlbnVtIGk5 MTVfbWFwX3R5cGUKPiAraTkxNV9jb2hlcmVudF9tYXBfdHlwZShzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSkKPiArewo+ICsJcmV0dXJuIEhBU19MTEMoaTkxNSkgPyBJOTE1X01BUF9XQiA6 IEk5MTVfTUFQX1dDOwo+ICt9Cj4gKwo+ICAvKioKPiAgICogaTkxNV9nZW1fb2JqZWN0X3Bpbl9t YXAgLSByZXR1cm4gYSBjb250aWd1b3VzIG1hcHBpbmcgb2YgdGhlIGVudGlyZSBvYmplY3QKPiAg ICogQG9iajogdGhlIG9iamVjdCB0byBtYXAgaW50byBrZXJuZWwgYWRkcmVzcyBzcGFjZQo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGluZGV4IDM3MzUzYWZlYzY2ZS4uZDk0NjViZDFhMDBhIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gQEAgLTU0MjYsNiArNTQyNiw4IEBAIHN0YXRp YyBpbnQgX19pbnRlbF9lbmdpbmVzX3JlY29yZF9kZWZhdWx0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSkKPiAgCQlzdHJ1Y3QgaTkxNV92bWEgKnN0YXRlOwo+ICAJCXZvaWQgKnZhZGRy Owo+ICAKPiArCQlHRU1fQlVHX09OKHRvX2ludGVsX2NvbnRleHQoY3R4LCBlbmdpbmUpLT5waW5f Y291bnQpOwo+ICsKPiAgCQlzdGF0ZSA9IHRvX2ludGVsX2NvbnRleHQoY3R4LCBlbmdpbmUpLT5z dGF0ZTsKPiAgCQlpZiAoIXN0YXRlKQo+ICAJCQljb250aW51ZTsKPiBAQCAtNTQ1MCw3ICs1NDUy LDcgQEAgc3RhdGljIGludCBfX2ludGVsX2VuZ2luZXNfcmVjb3JkX2RlZmF1bHRzKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAKPiAgCQkvKiBDaGVjayB3ZSBjYW4gYWNxdWlyZSB0 aGUgaW1hZ2Ugb2YgdGhlIGNvbnRleHQgc3RhdGUgKi8KPiAgCQl2YWRkciA9IGk5MTVfZ2VtX29i amVjdF9waW5fbWFwKGVuZ2luZS0+ZGVmYXVsdF9zdGF0ZSwKPiAtCQkJCQkJSTkxNV9NQVBfV0Ip Owo+ICsJCQkJCQlJOTE1X01BUF9GT1JDRV9XQik7Cj4gIAkJaWYgKElTX0VSUih2YWRkcikpIHsK PiAgCQkJZXJyID0gUFRSX0VSUih2YWRkcik7Cj4gIAkJCWdvdG8gZXJyX2FjdGl2ZTsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3BlcmYuYwo+IGluZGV4IDNkN2EwNTJiNGNjYS4uNjY0Yjk2YmI2NWEzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMKPiBAQCAtMTcwNyw2ICsxNzA3LDcgQEAgc3Rh dGljIGludCBnZW44X2NvbmZpZ3VyZV9hbGxfY29udGV4dHMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ICAJCQkJICAgICAgIGNvbnN0IHN0cnVjdCBpOTE1X29hX2NvbmZpZyAq b2FfY29uZmlnKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUgPSBkZXZf cHJpdi0+ZW5naW5lW1JDU107Cj4gKwl1bnNpZ25lZCBpbnQgbWFwX3R5cGUgPSBpOTE1X2NvaGVy ZW50X21hcF90eXBlKGRldl9wcml2KTsKPiAgCXN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHg7 Cj4gIAlzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycTsKPiAgCWludCByZXQ7Cj4gQEAgLTE3NDEsNyAr MTc0Miw3IEBAIHN0YXRpYyBpbnQgZ2VuOF9jb25maWd1cmVfYWxsX2NvbnRleHRzKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlpZiAoIWNlLT5zdGF0ZSkKPiAgCQkJY29u dGludWU7Cj4gIAo+IC0JCXJlZ3MgPSBpOTE1X2dlbV9vYmplY3RfcGluX21hcChjZS0+c3RhdGUt Pm9iaiwgSTkxNV9NQVBfV0IpOwo+ICsJCXJlZ3MgPSBpOTE1X2dlbV9vYmplY3RfcGluX21hcChj ZS0+c3RhdGUtPm9iaiwgbWFwX3R5cGUpOwo+ICAJCWlmIChJU19FUlIocmVncykpCj4gIAkJCXJl dHVybiBQVFJfRVJSKHJlZ3MpOwo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4 IGQ3ZmNiYmE4ZTk4Mi4uYTUxYmUxNmRkYWFjIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMKPiBAQCAtMTI5NCw3ICsxMjk0LDcgQEAgc3RhdGljIGludCBfX2NvbnRleHRfcGluKHN0cnVj dCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsIHN0cnVjdCBpOTE1X3ZtYSAqdm1hKQo+ICAJICogb24g YW4gYWN0aXZlIGNvbnRleHQgKHdoaWNoIGJ5IG5hdHVyZSBpcyBhbHJlYWR5IG9uIHRoZSBHUFUp Lgo+ICAJICovCj4gIAlpZiAoISh2bWEtPmZsYWdzICYgSTkxNV9WTUFfR0xPQkFMX0JJTkQpKSB7 Cj4gLQkJZXJyID0gaTkxNV9nZW1fb2JqZWN0X3NldF90b19ndHRfZG9tYWluKHZtYS0+b2JqLCB0 cnVlKTsKPiArCQllcnIgPSBpOTE1X2dlbV9vYmplY3Rfc2V0X3RvX3djX2RvbWFpbih2bWEtPm9i aiwgdHJ1ZSk7Cj4gIAkJaWYgKGVycikKPiAgCQkJcmV0dXJuIGVycjsKPiAgCX0KPiBAQCAtMTMy Miw3ICsxMzIyLDkgQEAgX19leGVjbGlzdHNfY29udGV4dF9waW4oc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lLAo+ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVycjsKPiAgCj4gLQl2YWRkciA9 IGk5MTVfZ2VtX29iamVjdF9waW5fbWFwKGNlLT5zdGF0ZS0+b2JqLCBJOTE1X01BUF9XQik7Cj4g Kwl2YWRkciA9IGk5MTVfZ2VtX29iamVjdF9waW5fbWFwKGNlLT5zdGF0ZS0+b2JqLAo+ICsJCQkJ CWk5MTVfY29oZXJlbnRfbWFwX3R5cGUoY3R4LT5pOTE1KSB8Cj4gKwkJCQkJSTkxNV9NQVBfT1ZF UlJJREUpOwo+ICAJaWYgKElTX0VSUih2YWRkcikpIHsKPiAgCQlyZXQgPSBQVFJfRVJSKHZhZGRy KTsKPiAgCQlnb3RvIHVucGluX3ZtYTsKPiAtLSAKPiAyLjE5LjAKPiAKPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==