From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/6] drm/i915: Unset reset pch handshake when PCH is not present in one place Date: Fri, 14 Sep 2018 17:54:08 +0300 Message-ID: <20180914145408.GH5565@intel.com> References: <20180914141849.2046-1-jose.souza@intel.com> <20180914141849.2046-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2CC46E7B6 for ; Fri, 14 Sep 2018 14:56:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180914141849.2046-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMDc6MTg6NDVBTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBSaWdodCBub3cgUkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEUgaXMg ZW5hYmxlZCBhbGwgdGhlIHRpbWVzIGluc2lkZQo+IG9mIGludGVsX3Bvd2VyX2RvbWFpbnNfaW5p dF9odygpIGFuZCBpZiBQQ0ggaXMgTk9QIGl0IGlzIHVuc2VkIGluCj4gaTkxNV9nZW1faW5pdF9o dygpLgo+IFNvIG1ha2luZyBza2xfcGNoX3Jlc2V0X2hhbmRzaGFrZSgpIGhhbmRsZSBib3RoIGNh c2VzIGFuZCBjYWxsaW5nCj4gaXQgZm9yIHRoZSBtaXNzaW5nIGdlbnMgaW4gaW50ZWxfcG93ZXJf ZG9tYWluc19pbml0X2h3KCkuCj4gSXZ5YnJpZGdlIGhhdmUgYSBkaWZmZXJlbnQgcmVnaXN0ZXIg YW5kIGJpdHMgYnV0IHdpdGggdGhlIHNhbWUKPiBvYmplY3RpdmUgc28gbW92aW5nIGl0IHRvby4K PiAKPiB2MihSb2RyaWdvKToKPiAtIGhhbmRsaW5nIElWWUJSSURHRSBjYXNlIGluc2lkZSBpbnRl bF9wY2hfcmVzZXRfaGFuZHNoYWtlKCkKPiAKPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZp dmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8OpIFJvYmVydG8gZGUgU291emEgPGpv c2Uuc291emFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jICAgICAgICAgfCAxMiAtLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcnVudGltZV9wbS5jIHwgMTkgKysrKysrKysrKysrKysrKy0tLQo+ICAyIGZpbGVzIGNoYW5n ZWQsIDE2IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+IGluZGV4IDg5ODM0Y2UxOWFjZC4uYjM4OWUwODRjOGM2IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCj4gQEAgLTUyOTYsMTggKzUyOTYsNiBAQCBpbnQgaTkxNV9nZW1faW5p dF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJSTkxNV9XUklURShN SV9QUkVESUNBVEVfUkVTVUxUXzIsIElTX0hTV19HVDMoZGV2X3ByaXYpID8KPiAgCQkJICAgTE9X RVJfU0xJQ0VfRU5BQkxFRCA6IExPV0VSX1NMSUNFX0RJU0FCTEVEKTsKPiAgCj4gLQlpZiAoSEFT X1BDSF9OT1AoZGV2X3ByaXYpKSB7Cj4gLQkJaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikpIHsK PiAtCQkJdTMyIHRlbXAgPSBJOTE1X1JFQUQoR0VON19NU0dfQ1RMKTsKPiAtCQkJdGVtcCAmPSB+ KFdBSVRfRk9SX1BDSF9GTFJfQUNLIHwgV0FJVF9GT1JfUENIX1JFU0VUX0FDSyk7Cj4gLQkJCUk5 MTVfV1JJVEUoR0VON19NU0dfQ1RMLCB0ZW1wKTsKPiAtCQl9IGVsc2UgaWYgKElOVEVMX0dFTihk ZXZfcHJpdikgPj0gNykgewo+IC0JCQl1MzIgdGVtcCA9IEk5MTVfUkVBRChIU1dfTkRFX1JTVFdS Tl9PUFQpOwo+IC0JCQl0ZW1wICY9IH5SRVNFVF9QQ0hfSEFORFNIQUtFX0VOQUJMRTsKPiAtCQkJ STkxNV9XUklURShIU1dfTkRFX1JTVFdSTl9PUFQsIHRlbXApOwo+IC0JCX0KPiAtCX0KPiAtCj4g IAlpbnRlbF9ndF93b3JrYXJvdW5kc19hcHBseShkZXZfcHJpdik7Cj4gIAo+ICAJaTkxNV9nZW1f aW5pdF9zd2l6emxpbmcoZGV2X3ByaXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50 aW1lX3BtLmMKPiBpbmRleCAxYmNkMGU1MWZjYTEuLmJjYTE5NzZmZGIxZCAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAtMzI0MSwxMCArMzI0MSwyMiBA QCBzdGF0aWMgdm9pZCBpY2xfbWJ1c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiAgCj4gIHN0YXRpYyB2b2lkIGludGVsX3BjaF9yZXNldF9oYW5kc2hha2Uoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gLQl1MzIgdmFsID0gSTkxNV9SRUFE KEhTV19OREVfUlNUV1JOX09QVCk7Cj4gKwl1MzIgdmFsOwo+ICsKPiArCWlmIChJU19JVllCUklE R0UoZGV2X3ByaXYpKSB7Cj4gKwkJaWYgKEhBU19QQ0hfTk9QKGRldl9wcml2KSkgewo+ICsJCQl2 YWwgPSBJOTE1X1JFQUQoR0VON19NU0dfQ1RMKTsKPiArCQkJdmFsICY9IH4oV0FJVF9GT1JfUENI X0ZMUl9BQ0sgfCBXQUlUX0ZPUl9QQ0hfUkVTRVRfQUNLKTsKPiArCQkJSTkxNV9XUklURShHRU43 X01TR19DVEwsIHZhbCk7Cj4gKwkJfQo+ICsKPiArCQlyZXR1cm47Cj4gKwl9CgpJJ2QgZ28gd2l0 aCBpZi1lbHNlIHNpbmNlIGJvdGggc2lkZXMgYXJlIHByZXR0eSBtdWNoIGVxdWFsLgoKPiArCj4g Kwl2YWwgPSBJOTE1X1JFQUQoSFNXX05ERV9SU1RXUk5fT1BUKTsKPiAgCj4gIAkvKiBCWFQgZG9u J3QgaGF2ZSBQQ0ggYW5kIGl0IHJlcXVpcmVzIHRoYXQgdGhpcyBiaXQgaXMgYWx3YXlzIHVuc2V0 ICovCj4gLQlpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikpCj4gKwlpZiAoSEFTX1BDSF9TUExJ VChkZXZfcHJpdikgJiYgIUhBU19QQ0hfTk9QKGRldl9wcml2KSkKPiAgCQl2YWwgfD0gUkVTRVRf UENIX0hBTkRTSEFLRV9FTkFCTEU7Cj4gIAllbHNlCj4gIAkJdmFsICY9IH5SRVNFVF9QQ0hfSEFO RFNIQUtFX0VOQUJMRTsKPiBAQCAtMzc1Niw3ICszNzY4LDggQEAgdm9pZCBpbnRlbF9wb3dlcl9k b21haW5zX2luaXRfaHcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBib29sIHJl c3VtZSkKPiAgCQltdXRleF9sb2NrKCZwb3dlcl9kb21haW5zLT5sb2NrKTsKPiAgCQl2bHZfY21u bGFuZV93YShkZXZfcHJpdik7Cj4gIAkJbXV0ZXhfdW5sb2NrKCZwb3dlcl9kb21haW5zLT5sb2Nr KTsKPiAtCX0KPiArCX0gZWxzZSBpZiAoSVNfSVZZQlJJREdFKGRldl9wcml2KSB8fCBJTlRFTF9H RU4oZGV2X3ByaXYpID49IDcpCj4gKwkJaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFrZShkZXZfcHJp dik7Cj4gIAo+ICAJLyoKPiAgCSAqIEtlZXAgYWxsIHBvd2VyIHdlbGxzIGVuYWJsZWQgZm9yIGFu eSBkZXBlbmRlbnQgSFcgYWNjZXNzIGR1cmluZwo+IC0tIAo+IDIuMTkuMAo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5 cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK