From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/6] drm/i915: Do not modifiy reserved bit in gens that do not have IPC
Date: Fri, 14 Sep 2018 08:36:41 -0700 [thread overview]
Message-ID: <20180914153641.GA2246@intel.com> (raw)
In-Reply-To: <20180914141849.2046-3-jose.souza@intel.com>
On Fri, Sep 14, 2018 at 07:18:46AM -0700, José Roberto de Souza wrote:
> IPC was only added in SKL+(actually we don't even enable for SKL due
> WA) so without this change, driver was writing to a reserved bit.
>
> Also removing the uncessary dev_priv->ipc_enabled = false; as now
> gens without IPC will not have IPC enabled.
>
> v2(Rodrigo):
> - moved the new handling of WA #0477 to the next patch
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 1db9b8328275..e2ca04534e23 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6117,6 +6117,9 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv)
> {
> u32 val;
>
> + if (!HAS_IPC(dev_priv))
> + return;
> +
> /* Display WA #0477 WaDisableIPC: skl */
> if (IS_SKYLAKE(dev_priv))
> dev_priv->ipc_enabled = false;
> @@ -6138,7 +6141,6 @@ void intel_enable_ipc(struct drm_i915_private *dev_priv)
>
> void intel_init_ipc(struct drm_i915_private *dev_priv)
> {
> - dev_priv->ipc_enabled = false;
> if (!HAS_IPC(dev_priv))
> return;
>
> --
> 2.19.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-14 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 14:18 [PATCH v2 1/6] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake José Roberto de Souza
2018-09-14 14:18 ` [PATCH v2 2/6] drm/i915: Unset reset pch handshake when PCH is not present in one place José Roberto de Souza
2018-09-14 14:54 ` Ville Syrjälä
2018-09-14 14:18 ` [PATCH v2 3/6] drm/i915: Do not modifiy reserved bit in gens that do not have IPC José Roberto de Souza
2018-09-14 15:36 ` Rodrigo Vivi [this message]
2018-09-14 14:52 ` [PATCH v2 1/6] drm/i915/runtime_pm: Share code to enable/disable PCH reset handshake Ville Syrjälä
2018-09-14 15:37 ` Rodrigo Vivi
2018-09-17 21:28 ` Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914153641.GA2246@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).