intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
Date: Fri, 14 Sep 2018 08:54:10 -0700	[thread overview]
Message-ID: <20180914155410.GF2246@intel.com> (raw)
In-Reply-To: <20180913230537.1272-1-anusha.srivatsa@intel.com>

On Thu, Sep 13, 2018 at 04:05:37PM -0700, Anusha Srivatsa wrote:
> Add missing MODULE_FIRMWARE while loading DMC ICL.
> 
> v2: Add Fixes tag. (Rodrigo)
> 
> Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 4aa8f3d6b64c..d48186e9ddad 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -35,6 +35,7 @@
>   */
>  
>  #define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_ICL);
>  #define ICL_CSR_VERSION_REQUIRED	CSR_VERSION(1, 7)
>  
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> -- 
> 2.17.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2018-09-14 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 23:05 [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Anusha Srivatsa
2018-09-13 23:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-14 15:54 ` Rodrigo Vivi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-04 21:59 [PATCH] " Rodrigo Vivi
2018-10-04 22:14 ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) Patchwork
2018-10-04 22:36 ` [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Rodrigo Vivi
2018-10-04 23:23   ` Paulo Zanoni
2018-10-05 22:09     ` Rodrigo Vivi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914155410.GF2246@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anusha.srivatsa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).