* [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
@ 2018-09-13 23:05 Anusha Srivatsa
2018-09-13 23:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-14 15:54 ` [PATCH] " Rodrigo Vivi
0 siblings, 2 replies; 7+ messages in thread
From: Anusha Srivatsa @ 2018-09-13 23:05 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index 4aa8f3d6b64c..d48186e9ddad 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -35,6 +35,7 @@
*/
#define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
+MODULE_FIRMWARE(I915_CSR_ICL);
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✗ Fi.CI.BAT: failure for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
2018-09-13 23:05 [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Anusha Srivatsa
@ 2018-09-13 23:46 ` Patchwork
2018-09-14 15:54 ` [PATCH] " Rodrigo Vivi
1 sibling, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-09-13 23:46 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
URL : https://patchwork.freedesktop.org/series/49678/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4820 -> Patchwork_10183 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10183 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10183, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49678/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10183:
=== IGT changes ===
==== Possible regressions ====
igt@drv_selftest@mock_hugepages:
fi-bwr-2160: PASS -> DMESG-FAIL
== Known issues ==
Here are the changes found in Patchwork_10183 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-byt-clapper: PASS -> FAIL (fdo#103191, fdo#107362) +1
igt@kms_psr@primary_page_flip:
fi-icl-u: PASS -> FAIL (fdo#107336)
==== Possible fixes ====
igt@drv_module_reload@basic-reload:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-WARN (fdo#102614) -> PASS
igt@kms_pipe_crc_basic@read-crc-pipe-a:
fi-ilk-650: DMESG-WARN (fdo#106387) -> PASS
igt@pm_rpm@module-reload:
{fi-cnl-u}: FAIL -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (49 -> 45) ==
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4820 -> Patchwork_10183
CI_DRM_4820: a804643cba4646e18e0e31c9363fdd3c92dca3c0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4640: 9a8da36e708f9ed15b20689dfe305e41f9a19008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10183: f589e94944f7721bb3e8ff37600ca79c18d9795e @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f589e94944f7 firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10183/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
2018-09-13 23:05 [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Anusha Srivatsa
2018-09-13 23:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-09-14 15:54 ` Rodrigo Vivi
1 sibling, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-09-14 15:54 UTC (permalink / raw)
To: Anusha Srivatsa; +Cc: intel-gfx
On Thu, Sep 13, 2018 at 04:05:37PM -0700, Anusha Srivatsa wrote:
> Add missing MODULE_FIRMWARE while loading DMC ICL.
>
> v2: Add Fixes tag. (Rodrigo)
>
> Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 4aa8f3d6b64c..d48186e9ddad 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -35,6 +35,7 @@
> */
>
> #define I915_CSR_ICL "i915/icl_dmc_ver1_07.bin"
> +MODULE_FIRMWARE(I915_CSR_ICL);
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
>
> #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
@ 2018-10-04 21:59 Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-10-04 21:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Paulo Zanoni, Rodrigo Vivi
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR
firmware definition macros")
Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (v2)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index e4e310b0ef78..fc7bd21fa586 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,6 +37,7 @@
#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define ICL_CSR_MAX_FW_SIZE 0x6000
+MODULE_FIRMWARE(ICL_CSR_PATH);
#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
2018-10-04 21:59 Rodrigo Vivi
@ 2018-10-04 22:14 Patchwork
2018-10-04 22:36 ` [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Rodrigo Vivi
-1 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2018-10-04 22:14 UTC (permalink / raw)
To: Srivatsa, Anusha; +Cc: intel-gfx
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros")'
#9:
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR
total: 1 errors, 0 warnings, 0 checks, 7 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
2018-10-04 22:14 ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) Patchwork
@ 2018-10-04 22:36 ` Rodrigo Vivi
2018-10-04 23:23 ` Paulo Zanoni
0 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Vivi @ 2018-10-04 22:36 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Paulo Zanoni, Rodrigo Vivi
From: Anusha Srivatsa <anusha.srivatsa@intel.com>
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
restructure CSR firmware definition macros")
v4: Rodrigo fixing his own mess on commit mentioning on v3
comment above.
Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (v2)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_csr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index e4e310b0ef78..fc7bd21fa586 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -37,6 +37,7 @@
#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
#define ICL_CSR_MAX_FW_SIZE 0x6000
+MODULE_FIRMWARE(ICL_CSR_PATH);
#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"
#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
2018-10-04 22:36 ` [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Rodrigo Vivi
@ 2018-10-04 23:23 ` Paulo Zanoni
2018-10-05 22:09 ` Rodrigo Vivi
0 siblings, 1 reply; 7+ messages in thread
From: Paulo Zanoni @ 2018-10-04 23:23 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx; +Cc: Jani Nikula
Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
> From: Anusha Srivatsa <anusha.srivatsa@intel.com>
>
> Add missing MODULE_FIRMWARE while loading DMC ICL.
>
> v2: Add Fixes tag. (Rodrigo)
> v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
> restructure CSR firmware definition macros")
> v4: Rodrigo fixing his own mess on commit mentioning on v3
> comment above.
>
> Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Yes, please. I wasted time because I lacked this commit.
Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (v2)
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/intel_csr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c
> b/drivers/gpu/drm/i915/intel_csr.c
> index e4e310b0ef78..fc7bd21fa586 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -37,6 +37,7 @@
> #define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bi
> n"
> #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> #define ICL_CSR_MAX_FW_SIZE 0x6000
> +MODULE_FIRMWARE(ICL_CSR_PATH);
>
> #define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bi
> n"
> #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
2018-10-04 23:23 ` Paulo Zanoni
@ 2018-10-05 22:09 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-10-05 22:09 UTC (permalink / raw)
To: Paulo Zanoni; +Cc: Jani Nikula, intel-gfx
On Thu, Oct 04, 2018 at 04:23:45PM -0700, Paulo Zanoni wrote:
> Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
> > From: Anusha Srivatsa <anusha.srivatsa@intel.com>
> >
> > Add missing MODULE_FIRMWARE while loading DMC ICL.
> >
> > v2: Add Fixes tag. (Rodrigo)
> > v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
> > restructure CSR firmware definition macros")
> > v4: Rodrigo fixing his own mess on commit mentioning on v3
> > comment above.
> >
> > Fixes: 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
>
> Yes, please. I wasted time because I lacked this commit.
>
> Tested-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
pushed, thanks
>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (v2)
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_csr.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_csr.c
> > b/drivers/gpu/drm/i915/intel_csr.c
> > index e4e310b0ef78..fc7bd21fa586 100644
> > --- a/drivers/gpu/drm/i915/intel_csr.c
> > +++ b/drivers/gpu/drm/i915/intel_csr.c
> > @@ -37,6 +37,7 @@
> > #define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bi
> > n"
> > #define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> > #define ICL_CSR_MAX_FW_SIZE 0x6000
> > +MODULE_FIRMWARE(ICL_CSR_PATH);
> >
> > #define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bi
> > n"
> > #define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-10-05 22:10 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-13 23:05 [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Anusha Srivatsa
2018-09-13 23:46 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-14 15:54 ` [PATCH] " Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2018-10-04 21:59 Rodrigo Vivi
2018-10-04 22:14 ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2) Patchwork
2018-10-04 22:36 ` [PATCH] firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake Rodrigo Vivi
2018-10-04 23:23 ` Paulo Zanoni
2018-10-05 22:09 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).