From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v4 2/6] drm/i915: Unset reset pch handshake when PCH is not present in one place Date: Tue, 18 Sep 2018 14:48:13 -0700 Message-ID: <20180918214813.GU2674@intel.com> References: <20180918204714.27306-1-jose.souza@intel.com> <20180918204714.27306-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20DE96E04D for ; Tue, 18 Sep 2018 21:48:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180918204714.27306-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTgsIDIwMTggYXQgMDE6NDc6MTBQTSAtMDcwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBSaWdodCBub3cgUkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEUgaXMg ZW5hYmxlZCBhbGwgdGhlIHRpbWVzIGluc2lkZQo+IG9mIGludGVsX3Bvd2VyX2RvbWFpbnNfaW5p dF9odygpIGFuZCBpZiBQQ0ggaXMgTk9QIGl0IGlzIHVuc2VkIGluCj4gaTkxNV9nZW1faW5pdF9o dygpLgo+IFNvIG1ha2luZyBza2xfcGNoX3Jlc2V0X2hhbmRzaGFrZSgpIGhhbmRsZSBib3RoIGNh c2VzIGFuZCBjYWxsaW5nCj4gaXQgZm9yIHRoZSBtaXNzaW5nIGdlbnMgaW4gaW50ZWxfcG93ZXJf ZG9tYWluc19pbml0X2h3KCkuCj4gSXZ5YnJpZGdlIGhhdmUgYSBkaWZmZXJlbnQgcmVnaXN0ZXIg YW5kIGJpdHMgYnV0IHdpdGggdGhlIHNhbWUKPiBvYmplY3RpdmUgc28gbW92aW5nIGl0IHRvby4K PiAKPiB2MihSb2RyaWdvKToKPiAtIGhhbmRsaW5nIElWWUJSSURHRSBjYXNlIGluc2lkZSBpbnRl bF9wY2hfcmVzZXRfaGFuZHNoYWtlKCkKPiAKPiB2NChSb2RyaWdvIGFuZCBWaWxsZSk6Cj4gLSBt b3ZpbmcgdGhlIGVuYWJsZS9kaXNhYmxlIGRlY2lzaW9uIHRvIGNhbGxlcnMKPiAKPiBDYzogUm9k cmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEpvc8Op IFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgoKSSB3YXMgZ29pbmcgdG8g Y293YXJkbHkgd2FpdCBmb3IgQ0ksIGJ1dCBJIHdpbGwgZW5kIHVwCmZvcmdldHRpbmcgdGhlIHJl dmlldyBhbmQgY29kZSBsb29rcyByaWdodCB0byBteSBodW1hbiBleWVzLApzbyBiZWZvcmUgSSBm b3JnZXQ6CgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29t PgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgIHwgMTIg LS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIHwg MjggKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDIwIGluc2Vy dGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IGlu ZGV4IGE5NGQ1YTMwOGM0ZC4uM2ZlNWQ0ZjA1OGVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dl bS5jCj4gQEAgLTUyOTksMTggKzUyOTksNiBAQCBpbnQgaTkxNV9nZW1faW5pdF9odyhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJSTkxNV9XUklURShNSV9QUkVESUNBVEVf UkVTVUxUXzIsIElTX0hTV19HVDMoZGV2X3ByaXYpID8KPiAgCQkJICAgTE9XRVJfU0xJQ0VfRU5B QkxFRCA6IExPV0VSX1NMSUNFX0RJU0FCTEVEKTsKPiAgCj4gLQlpZiAoSEFTX1BDSF9OT1AoZGV2 X3ByaXYpKSB7Cj4gLQkJaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikpIHsKPiAtCQkJdTMyIHRl bXAgPSBJOTE1X1JFQUQoR0VON19NU0dfQ1RMKTsKPiAtCQkJdGVtcCAmPSB+KFdBSVRfRk9SX1BD SF9GTFJfQUNLIHwgV0FJVF9GT1JfUENIX1JFU0VUX0FDSyk7Cj4gLQkJCUk5MTVfV1JJVEUoR0VO N19NU0dfQ1RMLCB0ZW1wKTsKPiAtCQl9IGVsc2UgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g Nykgewo+IC0JCQl1MzIgdGVtcCA9IEk5MTVfUkVBRChIU1dfTkRFX1JTVFdSTl9PUFQpOwo+IC0J CQl0ZW1wICY9IH5SRVNFVF9QQ0hfSEFORFNIQUtFX0VOQUJMRTsKPiAtCQkJSTkxNV9XUklURShI U1dfTkRFX1JTVFdSTl9PUFQsIHRlbXApOwo+IC0JCX0KPiAtCX0KPiAtCj4gIAlpbnRlbF9ndF93 b3JrYXJvdW5kc19hcHBseShkZXZfcHJpdik7Cj4gIAo+ICAJaTkxNV9nZW1faW5pdF9zd2l6emxp bmcoZGV2X3ByaXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y dW50aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBp bmRleCBhYTBmZjRjMDhiYWQuLjMwOGQwNjk3MTQzNSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAtMzI0MiwxNCArMzI0MiwyNSBAQCBzdGF0aWMgdm9p ZCBpY2xfbWJ1c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgc3Rh dGljIHZvaWQgaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFrZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gIAkJCQkgICAgICBib29sIGVuYWJsZSkKPiAgewo+IC0JdTMyIHZhbCA9 IEk5MTVfUkVBRChIU1dfTkRFX1JTVFdSTl9PUFQpOwo+ICsJaTkxNV9yZWdfdCByZWc7Cj4gKwl1 MzIgcmVzZXRfYml0cywgdmFsOwo+ICsKPiArCWlmIChJU19JVllCUklER0UoZGV2X3ByaXYpKSB7 Cj4gKwkJcmVnID0gR0VON19NU0dfQ1RMOwo+ICsJCXJlc2V0X2JpdHMgPSBXQUlUX0ZPUl9QQ0hf RkxSX0FDSyB8IFdBSVRfRk9SX1BDSF9SRVNFVF9BQ0s7Cj4gKwl9IGVsc2Ugewo+ICsJCXJlZyA9 IEhTV19OREVfUlNUV1JOX09QVDsKPiArCQlyZXNldF9iaXRzID0gUkVTRVRfUENIX0hBTkRTSEFL RV9FTkFCTEU7Cj4gKwl9Cj4gKwo+ICsJdmFsID0gSTkxNV9SRUFEKHJlZyk7Cj4gIAo+ICAJaWYg KGVuYWJsZSkKPiAtCQl2YWwgfD0gUkVTRVRfUENIX0hBTkRTSEFLRV9FTkFCTEU7Cj4gKwkJdmFs IHw9IHJlc2V0X2JpdHM7Cj4gIAllbHNlCj4gLQkJdmFsICY9IH5SRVNFVF9QQ0hfSEFORFNIQUtF X0VOQUJMRTsKPiArCQl2YWwgJj0gfnJlc2V0X2JpdHM7Cj4gIAo+IC0JSTkxNV9XUklURShIU1df TkRFX1JTVFdSTl9PUFQsIHZhbCk7Cj4gKwlJOTE1X1dSSVRFKHJlZywgdmFsKTsKPiAgfQo+ICAK PiAgc3RhdGljIHZvaWQgc2tsX2Rpc3BsYXlfY29yZV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiBAQCAtMzI2MSw3ICszMjcyLDcgQEAgc3RhdGljIHZvaWQgc2tsX2Rp c3BsYXlfY29yZV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWdl bjlfc2V0X2RjX3N0YXRlKGRldl9wcml2LCBEQ19TVEFURV9ESVNBQkxFKTsKPiAgCj4gIAkvKiBl bmFibGUgUENIIHJlc2V0IGhhbmRzaGFrZSAqLwo+IC0JaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFr ZShkZXZfcHJpdiwgdHJ1ZSk7Cj4gKwlpbnRlbF9wY2hfcmVzZXRfaGFuZHNoYWtlKGRldl9wcml2 LCAhSEFTX1BDSF9OT1AoZGV2X3ByaXYpKTsKPiAgCj4gIAkvKiBlbmFibGUgUEcxIGFuZCBNaXNj IEkvTyAqLwo+ICAJbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gQEAgLTM0NDcs NyArMzQ1OCw3IEBAIHN0YXRpYyB2b2lkIGNubF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgcmVzdW1lCj4gIAlnZW45X3NldF9kY19zdGF0 ZShkZXZfcHJpdiwgRENfU1RBVEVfRElTQUJMRSk7Cj4gIAo+ICAJLyogMS4gRW5hYmxlIFBDSCBS ZXNldCBIYW5kc2hha2UgKi8KPiAtCWludGVsX3BjaF9yZXNldF9oYW5kc2hha2UoZGV2X3ByaXYs IHRydWUpOwo+ICsJaW50ZWxfcGNoX3Jlc2V0X2hhbmRzaGFrZShkZXZfcHJpdiwgIUhBU19QQ0hf Tk9QKGRldl9wcml2KSk7Cj4gIAo+ICAJLyogMi4gRW5hYmxlIENvbXAgKi8KPiAgCXZhbCA9IEk5 MTVfUkVBRChDSElDS0VOX01JU0NfMik7Cj4gQEAgLTM1MzAsNyArMzU0MSw3IEBAIHN0YXRpYyB2 b2lkIGljbF9kaXNwbGF5X2NvcmVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gIAlnZW45X3NldF9kY19zdGF0ZShkZXZfcHJpdiwgRENfU1RBVEVfRElTQUJMRSk7Cj4g IAo+ICAJLyogMS4gRW5hYmxlIFBDSCByZXNldCBoYW5kc2hha2UuICovCj4gLQlpbnRlbF9wY2hf cmVzZXRfaGFuZHNoYWtlKGRldl9wcml2LCB0cnVlKTsKPiArCWludGVsX3BjaF9yZXNldF9oYW5k c2hha2UoZGV2X3ByaXYsICFIQVNfUENIX05PUChkZXZfcHJpdikpOwo+ICAKPiAgCWZvciAocG9y dCA9IFBPUlRfQTsgcG9ydCA8PSBQT1JUX0I7IHBvcnQrKykgewo+ICAJCS8qIDIuIEVuYWJsZSBE REkgY29tYm8gUEhZIGNvbXAuICovCj4gQEAgLTM3NjIsNyArMzc3Myw4IEBAIHZvaWQgaW50ZWxf cG93ZXJfZG9tYWluc19pbml0X2h3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg Ym9vbCByZXN1bWUpCj4gIAkJbXV0ZXhfbG9jaygmcG93ZXJfZG9tYWlucy0+bG9jayk7Cj4gIAkJ dmx2X2NtbmxhbmVfd2EoZGV2X3ByaXYpOwo+ICAJCW11dGV4X3VubG9jaygmcG93ZXJfZG9tYWlu cy0+bG9jayk7Cj4gLQl9Cj4gKwl9IGVsc2UgaWYgKElTX0lWWUJSSURHRShkZXZfcHJpdikgfHwg SU5URUxfR0VOKGRldl9wcml2KSA+PSA3KQo+ICsJCWludGVsX3BjaF9yZXNldF9oYW5kc2hha2Uo ZGV2X3ByaXYsICFIQVNfUENIX05PUChkZXZfcHJpdikpOwo+ICAKPiAgCS8qCj4gIAkgKiBLZWVw IGFsbCBwb3dlciB3ZWxscyBlbmFibGVkIGZvciBhbnkgZGVwZW5kZW50IEhXIGFjY2VzcyBkdXJp bmcKPiAtLSAKPiAyLjE5LjAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==