From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 2/2] drm: Fix syncobj handing of schedule() returning 0 Date: Fri, 21 Sep 2018 11:15:41 +0200 Message-ID: <20180921091541.GZ11082@phenom.ffwll.local> References: <20180918100720.8357-1-chris@chris-wilson.co.uk> <20180918100720.8357-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180918100720.8357-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMTgsIDIwMTggYXQgMTE6MDc6MjBBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEFmdGVyIHNjaGVkdWxlKCkgcmV0dXJucyAwLCB3ZSBtdXN0IGRvIG9uZSBsYXN0IGNo ZWNrIG9mIENPTkQgdG8KPiBkZXRlcm1pbmUgdGhlIHJlYXNvbiBmb3IgdGhlIHdha2V1cCB3aXRo IDAgamlmZmllcyByZW1haW5pbmcgYmVmb3JlCj4gcmVwb3J0aW5nIHRoZSB0aW1lb3V0IC0tIG90 aGVyd2lzZSB3ZSBtYXkgbG9zZSB0aGUgc2lnbmFsIGR1ZSB0bwo+IHNjaGVkdWxlciBkZWxheXMu CgpBaCBjbGFzc2ljIQoKUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJA ZmZ3bGwuY2g+Cgo+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNjY5MAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNA Y2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmou YyB8IDQxICsrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFu Z2VkLCAxNSBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNv YmouYwo+IGluZGV4IGUyNTRmOTdmZWQ3ZC4uNWJjYjNlZjliMjU2IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9z eW5jb2JqLmMKPiBAQCAtNjcyLDcgKzY3Miw2IEBAIHN0YXRpYyBzaWduZWQgbG9uZyBkcm1fc3lu Y29ial9hcnJheV93YWl0X3RpbWVvdXQoc3RydWN0IGRybV9zeW5jb2JqICoqc3luY29ianMsCj4g IHsKPiAgCXN0cnVjdCBzeW5jb2JqX3dhaXRfZW50cnkgKmVudHJpZXM7Cj4gIAlzdHJ1Y3QgZG1h X2ZlbmNlICpmZW5jZTsKPiAtCXNpZ25lZCBsb25nIHJldDsKPiAgCXVpbnQzMl90IHNpZ25hbGVk X2NvdW50LCBpOwo+ICAKPiAgCWVudHJpZXMgPSBrY2FsbG9jKGNvdW50LCBzaXplb2YoKmVudHJp ZXMpLCBHRlBfS0VSTkVMKTsKPiBAQCAtNjkyLDcgKzY5MSw3IEBAIHN0YXRpYyBzaWduZWQgbG9u ZyBkcm1fc3luY29ial9hcnJheV93YWl0X3RpbWVvdXQoc3RydWN0IGRybV9zeW5jb2JqICoqc3lu Y29ianMsCj4gIAkJCWlmIChmbGFncyAmIERSTV9TWU5DT0JKX1dBSVRfRkxBR1NfV0FJVF9GT1Jf U1VCTUlUKSB7Cj4gIAkJCQljb250aW51ZTsKPiAgCQkJfSBlbHNlIHsKPiAtCQkJCXJldCA9IC1F SU5WQUw7Cj4gKwkJCQl0aW1lb3V0ID0gLUVJTlZBTDsKPiAgCQkJCWdvdG8gY2xlYW51cF9lbnRy aWVzOwo+ICAJCQl9Cj4gIAkJfQo+IEBAIC03MDQsMTIgKzcwMyw2IEBAIHN0YXRpYyBzaWduZWQg bG9uZyBkcm1fc3luY29ial9hcnJheV93YWl0X3RpbWVvdXQoc3RydWN0IGRybV9zeW5jb2JqICoq c3luY29ianMsCj4gIAkJfQo+ICAJfQo+ICAKPiAtCS8qIEluaXRpYWxpemUgcmV0IHRvIHRoZSBt YXggb2YgdGltZW91dCBhbmQgMS4gIFRoYXQgd2F5LCB0aGUKPiAtCSAqIGRlZmF1bHQgcmV0dXJu IHZhbHVlIGluZGljYXRlcyBhIHN1Y2Nlc3NmdWwgd2FpdCBhbmQgbm90IGEKPiAtCSAqIHRpbWVv dXQuCj4gLQkgKi8KPiAtCXJldCA9IG1heF90KHNpZ25lZCBsb25nLCB0aW1lb3V0LCAxKTsKPiAt Cj4gIAlpZiAoc2lnbmFsZWRfY291bnQgPT0gY291bnQgfHwKPiAgCSAgICAoc2lnbmFsZWRfY291 bnQgPiAwICYmCj4gIAkgICAgICEoZmxhZ3MgJiBEUk1fU1lOQ09CSl9XQUlUX0ZMQUdTX1dBSVRf QUxMKSkpCj4gQEAgLTc2MCwxOCArNzUzLDE3IEBAIHN0YXRpYyBzaWduZWQgbG9uZyBkcm1fc3lu Y29ial9hcnJheV93YWl0X3RpbWVvdXQoc3RydWN0IGRybV9zeW5jb2JqICoqc3luY29ianMsCj4g IAkJCWdvdG8gZG9uZV93YWl0aW5nOwo+ICAKPiAgCQlpZiAodGltZW91dCA9PSAwKSB7Cj4gLQkJ CS8qIElmIHdlIGFyZSBkb2luZyBhIDAgdGltZW91dCB3YWl0IGFuZCB3ZSBnb3QKPiAtCQkJICog aGVyZSwgdGhlbiB3ZSBqdXN0IHRpbWVkIG91dC4KPiAtCQkJICovCj4gLQkJCXJldCA9IDA7Cj4g KwkJCXRpbWVvdXQgPSAtRVRJTUU7Cj4gIAkJCWdvdG8gZG9uZV93YWl0aW5nOwo+ICAJCX0KPiAg Cj4gLQkJcmV0ID0gc2NoZWR1bGVfdGltZW91dChyZXQpOwo+ICsJCWlmIChzaWduYWxfcGVuZGlu ZyhjdXJyZW50KSkgewo+ICsJCQl0aW1lb3V0ID0gLUVSRVNUQVJUU1lTOwo+ICsJCQlnb3RvIGRv bmVfd2FpdGluZzsKPiArCQl9Cj4gIAo+IC0JCWlmIChyZXQgPiAwICYmIHNpZ25hbF9wZW5kaW5n KGN1cnJlbnQpKQo+IC0JCQlyZXQgPSAtRVJFU1RBUlRTWVM7Cj4gLQl9IHdoaWxlIChyZXQgPiAw KTsKPiArCQl0aW1lb3V0ID0gc2NoZWR1bGVfdGltZW91dCh0aW1lb3V0KTsKPiArCX0gd2hpbGUg KDEpOwo+ICAKPiAgZG9uZV93YWl0aW5nOgo+ICAJX19zZXRfY3VycmVudF9zdGF0ZShUQVNLX1JV Tk5JTkcpOwo+IEBAIC03ODgsNyArNzgwLDcgQEAgc3RhdGljIHNpZ25lZCBsb25nIGRybV9zeW5j b2JqX2FycmF5X3dhaXRfdGltZW91dChzdHJ1Y3QgZHJtX3N5bmNvYmogKipzeW5jb2JqcywKPiAg CX0KPiAgCWtmcmVlKGVudHJpZXMpOwo+ICAKPiAtCXJldHVybiByZXQ7Cj4gKwlyZXR1cm4gdGlt ZW91dDsKPiAgfQo+ICAKPiAgLyoqCj4gQEAgLTgyOSwxOSArODIxLDE2IEBAIHN0YXRpYyBpbnQg ZHJtX3N5bmNvYmpfYXJyYXlfd2FpdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJCQkJICBz dHJ1Y3QgZHJtX3N5bmNvYmogKipzeW5jb2JqcykKPiAgewo+ICAJc2lnbmVkIGxvbmcgdGltZW91 dCA9IGRybV90aW1lb3V0X2Fic190b19qaWZmaWVzKHdhaXQtPnRpbWVvdXRfbnNlYyk7Cj4gLQlz aWduZWQgbG9uZyByZXQgPSAwOwo+ICAJdWludDMyX3QgZmlyc3QgPSB+MDsKPiAgCj4gLQlyZXQg PSBkcm1fc3luY29ial9hcnJheV93YWl0X3RpbWVvdXQoc3luY29ianMsCj4gLQkJCQkJICAgICB3 YWl0LT5jb3VudF9oYW5kbGVzLAo+IC0JCQkJCSAgICAgd2FpdC0+ZmxhZ3MsCj4gLQkJCQkJICAg ICB0aW1lb3V0LCAmZmlyc3QpOwo+IC0JaWYgKHJldCA8IDApCj4gLQkJcmV0dXJuIHJldDsKPiAr CXRpbWVvdXQgPSBkcm1fc3luY29ial9hcnJheV93YWl0X3RpbWVvdXQoc3luY29ianMsCj4gKwkJ CQkJCSB3YWl0LT5jb3VudF9oYW5kbGVzLAo+ICsJCQkJCQkgd2FpdC0+ZmxhZ3MsCj4gKwkJCQkJ CSB0aW1lb3V0LCAmZmlyc3QpOwo+ICsJaWYgKHRpbWVvdXQgPCAwKQo+ICsJCXJldHVybiB0aW1l b3V0Owo+ICAKPiAgCXdhaXQtPmZpcnN0X3NpZ25hbGVkID0gZmlyc3Q7Cj4gLQlpZiAocmV0ID09 IDApCj4gLQkJcmV0dXJuIC1FVElNRTsKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+IC0tIAo+IDIu MTkuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0 aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=