From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/7] drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v3. Date: Fri, 21 Sep 2018 22:31:22 +0300 Message-ID: <20180921193122.GL5565@intel.com> References: <20180921173945.6276-1-maarten.lankhorst@linux.intel.com> <20180921173945.6276-3-maarten.lankhorst@linux.intel.com> <20180921183552.GH5565@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2DD3D89395 for ; Fri, 21 Sep 2018 19:31:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180921183552.GH5565@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBTZXAgMjEsIDIwMTggYXQgMDk6MzU6NTJQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgU2VwIDIxLCAyMDE4IGF0IDA3OjM5OjQwUE0gKzAyMDAsIE1hYXJ0 ZW4gTGFua2hvcnN0IHdyb3RlOgo+ID4gVG8gbWFrZSBOVjEyIHdvcmtpbmcgb24gaWNsLCB3ZSBu ZWVkIHRvIHVwZGF0ZSAyIHBsYW5lcyBzaW11bHRhbmVvdXNseS4KPiA+IEkndmUgY2hvc2VuIHRv IGRvIHRoaXMgaW4gdGhlIENSVEMgc3RlcCBhZnRlciBwbGFuZSB2YWxpZGF0aW9uIGlzIGRvbmUs Cj4gPiBzbyB3ZSBrbm93IHdoYXQgcGxhbmVzIGFyZSAoaW4pdmlzaWJsZS4gVGhlIGxpbmtlZCBZ IHBsYW5lIHdpbGwgZ2V0Cj4gPiB1cGRhdGVkIGluIGludGVsX3BsYW5lX3VwZGF0ZV9wbGFuZXNf b25fY3J0YygpLCBieSB0aGUgY2FsbCB0bwo+ID4gdXBkYXRlX3NsYXZlLCB3aGljaCBnZXRzIHRo ZSBtYXN0ZXIncyBwbGFuZV9zdGF0ZSBhcyBhcmd1bWVudC4KPiA+IAo+ID4gVGhlIGxpbmsgcmVx dWlyZXMgYm90aCBwbGFuZXMgZm9yIGF0b21pY191cGRhdGUgdG8gd29yaywKPiA+IHNvIG1ha2Ug c3VyZSBza2xfZGRiX2FkZF9hZmZlY3RlZF9wbGFuZXMoKSBhZGRzIGJvdGggc3RhdGVzLgo+ID4g Cj4gPiBDaGFuZ2VzIHNpbmNlIHYxOgo+ID4gLSBJbnRyb2R1Y2UgaWNsX2lzX252MTJfeV9wbGFu ZSgpLCBpbnN0ZWFkIG9mIGhhcmRjb2Rpbmcgc3ByaXRlIG51bWJlcnMuCj4gPiAtIFB1dCBhbGwg dGhlIHN0YXRlIHVwZGF0aW5nIGxvZ2luIGluIGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRo X3N0YXRlKCkuCj4gPiAtIENsZWFuIHVwIGNoYW5nZXMgaW4gaW50ZWxfcGxhbmVfYXRvbWljX2No ZWNrKCkuCj4gPiBDaGFuZ2VzIHNpbmNlIHYyOgo+ID4gLSBGaXggaW50ZWxfYXRvbWljX2dldF9v bGRfcGxhbmVfc3RhdGUoKSB0byBhY3R1YWxseSByZXR1cm4gb2xkIHN0YXRlLgo+ID4gLSBNb3Zl IHZpc2liaWxpdHkgY2hhbmdlcyB0byBwcmVwYXJhdGlvbiBwYXRjaC4KPiA+IC0gT25seSB0cnkg dG8gZmluZCBhIFkgcGxhbmUgb24gZ2VuMTEsIGVhcmxpZXIgcGxhdGZvcm1zIG9ubHkgcmVxdWly ZSBhIHNpbmdsZSBwbGFuZS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gZml4dXAgWS9V ViBMaW5rYWdlCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyB8IDEwNiArKysrKysrKysrKysrKysrKystLS0t Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICAgfCAgNTcgKysr KysrKysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgICAgICAg fCAgNTMgKysrKysrKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jICAg ICAgICAgICB8ICAxMiArKy0KPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDIxMCBpbnNlcnRpb25zKCsp LCAxOCBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F0b21pY19wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv bWljX3BsYW5lLmMKPiA+IGluZGV4IDk4NGJjMWYyNjYyNS4uNTIyNjk5MDg1YTU5IDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiBAQCAtMTIx LDcgKzEyMSwxMSBAQCBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrX3dpdGhfc3RhdGUoY29u c3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjXwo+ID4gIAljcnRjX3N0YXRlLT5u djEyX3BsYW5lcyAmPSB+QklUKGludGVsX3BsYW5lLT5pZCk7Cj4gPiAgCWludGVsX3N0YXRlLT5i YXNlLnZpc2libGUgPSBmYWxzZTsKPiA+ICAKPiA+IC0JLyogSWYgdGhpcyBpcyBhIGN1cnNvciBw bGFuZSwgbm8gZnVydGhlciBjaGVja3MgYXJlIG5lZWRlZC4gKi8KPiA+ICsJLyogRGVzdHJveSB0 aGUgbGluayAqLwo+ID4gKwlpbnRlbF9zdGF0ZS0+bGlua2VkX3BsYW5lID0gTlVMTDsKPiA+ICsJ aW50ZWxfc3RhdGUtPnNsYXZlID0gZmFsc2U7Cj4gPiArCj4gPiArCS8qIElmIHRoaXMgaXMgYSBj dXJzb3Igb3IgWSBwbGFuZSwgbm8gZnVydGhlciBjaGVja3MgYXJlIG5lZWRlZC4gKi8KPiA+ICAJ aWYgKCFpbnRlbF9zdGF0ZS0+YmFzZS5jcnRjICYmICFvbGRfcGxhbmVfc3RhdGUtPmJhc2UuY3J0 YykKPiA+ICAJCXJldHVybiAwOwo+ID4gIAo+ID4gQEAgLTE0MiwyNyArMTQ2LDc2IEBAIGludCBp bnRlbF9wbGFuZV9hdG9taWNfY2hlY2tfd2l0aF9zdGF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0 Y19zdGF0ZSAqb2xkX2NydGNfCj4gPiAgCQkJCQkgICAgICAgc3RhdGUpOwo+ID4gIH0KPiA+ICAK PiA+IC1zdGF0aWMgaW50IGludGVsX3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5l ICpwbGFuZSwKPiA+IC0JCQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm5ld19wbGFuZV9z dGF0ZSkKPiA+ICtzdGF0aWMgaW50IGludGVsX3BsYW5lX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJt X3BsYW5lICpkcm1fcGxhbmUsCj4gPiArCQkJCSAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpu ZXdfZHJtX3BsYW5lX3N0YXRlKQo+ID4gIHsKPiA+IC0Jc3RydWN0IGRybV9hdG9taWNfc3RhdGUg KnN0YXRlID0gbmV3X3BsYW5lX3N0YXRlLT5zdGF0ZTsKPiA+IC0JY29uc3Qgc3RydWN0IGRybV9w bGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlID0KPiA+IC0JCWRybV9hdG9taWNfZ2V0X29sZF9w bGFuZV9zdGF0ZShzdGF0ZSwgcGxhbmUpOwo+ID4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNydGMgPSBu ZXdfcGxhbmVfc3RhdGUtPmNydGMgPzogb2xkX3BsYW5lX3N0YXRlLT5jcnRjOwo+ID4gLQljb25z dCBzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlOwo+ID4gLQlzdHJ1Y3QgZHJt X2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlOwo+ID4gLQo+ID4gLQluZXdfcGxhbmVfc3RhdGUt PnZpc2libGUgPSBmYWxzZTsKPiA+ICsJc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3RhdGUg PQo+ID4gKwkJdG9faW50ZWxfYXRvbWljX3N0YXRlKG5ld19kcm1fcGxhbmVfc3RhdGUtPnN0YXRl KTsKPiA+ICsJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSA9IHRvX2ludGVsX3BsYW5lKGRybV9w bGFuZSk7Cj4gPiArCWNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0 YXRlID0KPiA+ICsJCWludGVsX2F0b21pY19nZXRfb2xkX3BsYW5lX3N0YXRlKHN0YXRlLCBwbGFu ZSk7Cj4gPiArCXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqbmV3X3BsYW5lX3N0YXRlID0KPiA+ ICsJCXRvX2ludGVsX3BsYW5lX3N0YXRlKG5ld19kcm1fcGxhbmVfc3RhdGUpOwo+ID4gKwlzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMoCj4gPiArCQluZXdfcGxhbmVfc3Rh dGUtPmJhc2UuY3J0YyA/Ogo+ID4gKwkJb2xkX3BsYW5lX3N0YXRlLT5iYXNlLmNydGMpOwo+ID4g Kwljb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGU7Cj4gPiArCXN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPiA+ICsJc3RydWN0IGludGVs X3BsYW5lICpsaW5rZWQgPSBvbGRfcGxhbmVfc3RhdGUtPmxpbmtlZF9wbGFuZTsKPiA+ICsJaW50 IHJldDsKPiA+ICsJY29uc3Qgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpvbGRfbGlua2VkX3N0 YXRlOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm5ld19saW5rZWRfc3RhdGUgPSBO VUxMOwo+ID4gKwo+ID4gKwlpZiAobGlua2VkKSB7Cj4gPiArCQkvKgo+ID4gKwkJKiBNYWtlIHN1 cmUgYSBwcmV2aW91c2x5IGxpbmtlZCBwbGFuZSAoYW5kIGltcGxpY2l0bHksIHRoZSBDUlRDKQo+ ID4gKwkJKiBpcyBwYXJ0IG9mIHRoZSBhdG9taWMgY29tbWl0Lgo+ID4gKwkJKi8KPiA+ICsJCWlm ICghaW50ZWxfYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RhdGUsIGxpbmtlZCkpIHsKPiA+ ICsJCQluZXdfbGlua2VkX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0 ZSwgbGlua2VkKTsKPiA+ICsJCQlpZiAoSVNfRVJSKG5ld19saW5rZWRfc3RhdGUpKQo+ID4gKwkJ CQlyZXR1cm4gUFRSX0VSUihuZXdfbGlua2VkX3N0YXRlKTsKPiA+ICsJCX0KPiA+ICsKPiA+ICsJ CW9sZF9saW5rZWRfc3RhdGUgPQo+ID4gKwkJCWludGVsX2F0b21pY19nZXRfb2xkX3BsYW5lX3N0 YXRlKHN0YXRlLCBsaW5rZWQpOwo+ID4gKwo+ID4gKwkJLyoKPiA+ICsJCSAqIFRoaXMgd2lsbCBo YXBwZW4gd2hlbiB3ZSdyZSB0aGUgWSBwbGFuZS4gSW4gd2hpY2ggY2FzZQo+ID4gKwkJICogb2xk L25ld19zdGF0ZS0+Y3J0YyBhcmUgYm90aCBOVUxMLiBXZSBzdGlsbCBuZWVkIHRvIHBlcmZvcm0K PiA+ICsJCSAqIHVwZGF0ZXMgb24gdGhlIGxpbmtlZCBwbGFuZS4KPiA+ICsJCSAqLwo+ID4gKwkJ aWYgKCFjcnRjKQo+ID4gKwkJCWNydGMgPSB0b19pbnRlbF9jcnRjKG9sZF9saW5rZWRfc3RhdGUt PmJhc2UuY3J0Yyk7Cj4gPiArCj4gPiArCQlXQVJOX09OKCFjcnRjKTsKPiA+ICsJfQo+ID4gKwo+ ID4gKwluZXdfcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSA9IGZhbHNlOwo+ID4gIAlpZiAoIWNy dGMpCj4gPiAgCQlyZXR1cm4gMDsKPiA+ICAKPiA+IC0Jb2xkX2NydGNfc3RhdGUgPSBkcm1fYXRv bWljX2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gPiAtCW5ld19jcnRjX3N0YXRl ID0gZHJtX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ID4gKwlvbGRf Y3J0Y19zdGF0ZSA9IGludGVsX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUoc3RhdGUsIGNydGMp Owo+ID4gKwluZXdfY3J0Y19zdGF0ZSA9IGludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUo c3RhdGUsIGNydGMpOwo+ID4gKwo+ID4gKwlpZiAobmV3X2xpbmtlZF9zdGF0ZSAmJgo+ID4gKwkg ICAgZHJtX3BsYW5lX2luZGV4KCZsaW5rZWQtPmJhc2UpIDwgZHJtX3BsYW5lX2luZGV4KCZwbGFu ZS0+YmFzZSkpIHsKPiA+ICsJCS8qCj4gPiArCQkgKiBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCBm cm9tIGRybV9hdG9taWNfaGVscGVyX2NoZWNrX3BsYW5lcygpLCB3aGljaAo+ID4gKwkJICogd2ls bCBub3JtYWxseSBjaGVjayB0aGUgbmV3bHkgYWRkZWQgcGxhbmUgZm9yIHVzLCBidXQgc2luY2Ug d2UncmUKPiA+ICsJCSAqIGFscmVhZHkgaW4gdGhhdCBmdW5jdGlvbiwgaXQgd29uJ3QgY2hlY2sg dGhlIHBsYW5lIGlmIG91ciBpbmRleAo+ID4gKwkJICogaXMgYmlnZ2VyIHRoYW4gdGhlIGxpbmtl ZCBpbmRleCBiZWNhdXNlIG9mIHRoZQo+ID4gKwkJICogZm9yX2VhY2hfb2xkbmV3X3BsYW5lX2lu X3N0YXRlKCkgY2FsbC4KPiA+ICsJCSAqLwo+ID4gKwkJbmV3X2NydGNfc3RhdGUtPmJhc2UucGxh bmVzX2NoYW5nZWQgPSB0cnVlOwo+ID4gKwkJcmV0ID0gaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNr X3dpdGhfc3RhdGUob2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLAo+ID4gKwkJCQkJCQkg IG9sZF9saW5rZWRfc3RhdGUsIG5ld19saW5rZWRfc3RhdGUpOwo+ID4gKwkJaWYgKHJldCkKPiA+ ICsJCQlyZXR1cm4gcmV0Owo+ID4gKwl9Cj4gCj4gVGhpcyBpcyBhbGwgcmF0aGVyIGNvbmZ1c2lu Zy4gQ2FuJ3Qgd2UganVzdCBkbyBhIHByZXByb2Nlc3Npbmcgc3RlcAo+IGJlZm9yZSBjaGVja19w bGFuZXMoKSB0byBhZGQgdGhlIGxpbmtlZCBwbGFuZXMgYXMgbmVlZGVkLCBhbmQgdGhlbgo+IGxl dCB0aGUgbm9ybWFsIGNoZWNrX3BsYW5lcygpIGRvIGl0cyB0aGluZz8KCkFsc28gb25lIHRoaW5n IHRoYXQgc2xpZ2h0bHkgd29ycmllcyBtZSBpcyB3aGF0IGhhcHBlbnMgaWYgc29tZW9uZSBhZGRz Cm1vcmUgcGxhbmVzIHRvIHRoZSBzdGF0ZSBhZnRlciB0aGlzIGhhcyBhbGwgYmVlbiBkb25lLiBJ IGd1ZXNzCmN1cnJlbnRseSB0aG9zZSBjYXNlcyB3b3VsZCBlaXRoZXIgY29tZSBmcm9tIHRoZSB0 YWlsIGVuZCBvZgppbnRlbF9hdG9taWNfY2hlY2soKSBvciBmcm9tIGludGVsX2NydGNfYXRvbWlj X2NoZWNrKCkuIEN1cnJlbnRseSBpdAp3b3VsZCBhcHBlYXIgdGhhdCB3bS9kZGIgaXMgdGhlIG9u bHkgcGllY2Ugb2YgY29kZSB0aGF0IGNhbiBkbyB0aGlzCnNvcnQgb2YgdGhpbmcuCgpTb21lIGlk ZWFzIGhvdyB0byBzb2x2ZSBpdCBwZXJoYXBzOgotIE1vdmUgdGhlIGxpbmtlZCBwbGFuZSBwb2lu dGVyIHRvIHRoZSBjb3JlIHNvIHRoYXQgZ2V0X3BsYW5lX3N0YXRlKCkKICBjYW4gaW1tZWRpYXRl bHkgcGljayB1cCBib3RoIHBsYW5lcwotIEFkZCBzb21lIGtpbmQgb2YgZmxhZyBpbnRvIHRoZSB0 b3AgbGV2ZWwgYXRvbWljIHN0YXRlIHRoYXQgYWZ0ZXIgdGhpcwogIHBvaW50IG5vIG5ldyBwbGFu ZXMuIEJ1dCBJIGd1ZXNzIGR1cGxpY2F0ZV9zdGF0ZSgpIGlzIHRoZSBvbmx5IHRoaW5nCiAgd2Ug aGF2ZSBhbmQgdGhhdCBkb2Vzbid0IGtub3cgYW55dGhpbmcgYWJvdXQgdGhlIHRoZSB0b3AgbGV2 ZWwgc3RhdGUKLSBMaXZlIHdpdGggaXQgYW5kIHRlbGwgZXZlcnlvbmUgdG8gYmUgY2FyZWZ1bD8g U29tZSBraW5kIG9mCiAgaW50ZWxfYWRkX2FmZmVjdGVkX3BsYW5lcygpIG1pZ2h0IGJlIGhlbHBm dWwgaGVyZSB0byBhdCBsZWFzdCBnaXZlCiAgcGVvcGxlIG9uZSB0aGluZyB0byBjYWxsIGluIHRo ZSBsYXRlIHN0YWdlcy4gV291bGRuJ3QgaGVscCBpZiB0aGUKICBjYWxsIGNvbWVzIGZyb20gc29t ZSBoZWxwZXIvY29yZSBmdW5jdGlvbiB0aG91Z2guIEFuZCBhcyB0aGVyZSBpcwogIG5vIHVzZSBm b3Igc3VjaCBhIGZ1bmN0aW9uIGN1cnJlbnRseSBubyBwb2ludCBhZGRpbmcgaXQgSSBzdXBwb3Nl LgogIFRoZSB3bSBzdHVmZiBoYXMgaXRzIG93biB0aGluZywgd2hpY2ggeW91IGNvdmVyZWQgYWxy ZWFkeS4KCkR1bm5vLCBtYXliZSBJJ20ganVzdCBhIGJpdCB0b28gcGFyYW5vaWQgaGVyZS4KCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cg==