intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors
@ 2018-09-25  1:16 José Roberto de Souza
  2018-09-25  1:16 ` [PATCH 2/2] drm/i915: Do not get aux power for disconnected DP ports José Roberto de Souza
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: José Roberto de Souza @ 2018-09-25  1:16 UTC (permalink / raw)
  To: intel-gfx; +Cc: Hans Verkuil, dri-devel

drm_dp_cec_register_connector() is called when registering each DP
connector in DRM, while sounds a good idea register CEC adapters as
earlier as possible, it causes some driver initialization delay
trying to do DPCD transactions in disconnected connectors.

This change will cause no regressions as drm_dp_cec_set_edid() will
still be called in further detection of connected connectors with a
valid edid parameter.

This change reduced the module load of i915 by average 0.5sec in a
machine with just one DP port disconnected while reducing more than
3sec in a machine with 4 DP ports disconnected.

Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/drm_dp_cec.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c
index 8a718f85079a..b15cee85b702 100644
--- a/drivers/gpu/drm/drm_dp_cec.c
+++ b/drivers/gpu/drm/drm_dp_cec.c
@@ -424,8 +424,6 @@ void drm_dp_cec_register_connector(struct drm_dp_aux *aux, const char *name,
 	aux->cec.parent = parent;
 	INIT_DELAYED_WORK(&aux->cec.unregister_work,
 			  drm_dp_cec_unregister_work);
-
-	drm_dp_cec_set_edid(aux, NULL);
 }
 EXPORT_SYMBOL(drm_dp_cec_register_connector);
 
-- 
2.19.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-10-17  1:38 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-25  1:16 [PATCH 1/2] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors José Roberto de Souza
2018-09-25  1:16 ` [PATCH 2/2] drm/i915: Do not get aux power for disconnected DP ports José Roberto de Souza
2018-09-25  8:16   ` Jani Nikula
2018-09-26 22:44     ` Souza, Jose
2018-09-25 12:17   ` Ville Syrjälä
2018-09-26 22:42     ` [Intel-gfx] " Souza, Jose
2018-10-02  9:52       ` Imre Deak
2018-10-17  1:38   ` [LKP] [drm/i915] e44058ef12: WARNING:at_drivers/gpu/drm/i915/intel_drv.h:#gen6_read32[i915] kernel test robot
2018-09-25  2:04 ` ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors Patchwork
2018-09-25  7:51 ` [PATCH 1/2] " Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).