From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Wed, 26 Sep 2018 17:26:30 +0300
Message-ID: <20180926142630.GV9144@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
 <20180914160655.GJ5565@intel.com>
 <57510F3E2013164E925CD03ED7512A3B7F3F78FD@BGSMSX107.gar.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0E97689948
 for <intel-gfx@lists.freedesktop.org>; Wed, 26 Sep 2018 14:26:44 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <57510F3E2013164E925CD03ED7512A3B7F3F78FD@BGSMSX107.gar.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "Kulkarni, Vandita" <vandita.kulkarni@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Zanoni,
 Paulo R" <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBTZXAgMTksIDIwMTggYXQgMDU6MzE6MzdQTSArMDAwMCwgS3Vsa2FybmksIFZhbmRp
dGEgd3JvdGU6Cj4gCj4gCj4gPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+ID4gRnJvbTog
VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IFNlbnQ6
IEZyaWRheSwgU2VwdGVtYmVyIDE0LCAyMDE4IDk6MzcgUE0KPiA+IFRvOiBLdWxrYXJuaSwgVmFu
ZGl0YSA8dmFuZGl0YS5rdWxrYXJuaUBpbnRlbC5jb20+Cj4gPiBDYzogaW50ZWwtZ2Z4QGxpc3Rz
LmZyZWVkZXNrdG9wLm9yZzsgTmlrdWxhLCBKYW5pIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Owo+
ID4gWmFub25pLCBQYXVsbyBSIDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+Cj4gPiBTdWJqZWN0
OiBSZTogW0ludGVsLWdmeF0gW1JGQyAxLzNdIGRybS9pOTE1L2ljbDogUmVzdHJ1Y3R1cmUgSUNM
IERQTEwgZW5hYmxlCj4gPiBmdW5jdGlvbmFsaXR5Cj4gPiAKPiA+IE9uIEZyaSwgU2VwIDE0LCAy
MDE4IGF0IDEyOjI0OjEyUE0gKzA1MzAsIFZhbmRpdGEgS3Vsa2Fybmkgd3JvdGU6Cj4gPiA+IEZy
b206IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYuY2hhdWhhbkBpbnRlbC5jb20+Cj4gPiA+Cj4gPiA+
IEluIEdlbjExLCBEUExMIDAgYW5kIDEgYXJlIHNoYXJlZCBiZXR3ZWVuIERESSBhbmQgRFNJLgo+
ID4gPiBNb3N0IG9mIHRoZSBzdGVwcyBmb3IgZW5hYmxpbmcgRFBMTCBhcmUgY29tbW9uIGFjcm9z
cyBEREkgYW5kIERTSS4KPiA+ID4gVGhpcyBwYXRjaCBtYWtlcyBpY2xfZHBsbF9lbmFibGUoKSBn
ZW5lcmljIHdoaWNoIHdpbGwgYmUgdXNlZCBieSBhbGwKPiA+ID4gdGhlIGVuY29kZXJzLgo+ID4g
Pgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYWRoYXYgQ2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50
ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBWYW5kaXRhIEt1bGthcm5pIDx2YW5kaXRhLmt1
bGthcm5pQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kZGkuYyAgICAgIHwgMTIgKysrKysrKysrKysrCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcGxsX21nci5jIHwgMTkgKystLS0tLS0tLS0tLS0tLS0tLQo+ID4gPiBkcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIHwgIDIgKy0KPiA+ID4gIDMgZmlsZXMg
Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRp
ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IGluZGV4IGNkMDFhMDkuLjI5NDJhMjQg
MTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+
ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IEBAIC0yODEwLDYg
KzI4MTAsMTggQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX2Nsa19zZWxlY3Qoc3RydWN0Cj4gPiBp
bnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5kcGxs
X2xvY2spOwo+ID4gPgo+ID4gPiAgCWlmIChJU19JQ0VMQUtFKGRldl9wcml2KSkgewo+ID4gPiAr
CQllbnVtIGludGVsX2RwbGxfaWQgaWQgPSBwbGwtPmluZm8tPmlkOwo+ID4gPiArCQlpOTE1X3Jl
Z190IGVuYWJsZV9yZWcgPSBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWcoaWQpOwo+ID4gPiArCj4g
PiA+ICsJCXZhbCA9IEk5MTVfUkVBRChlbmFibGVfcmVnKTsKPiA+ID4gKwkJdmFsIHw9IFBMTF9F
TkFCTEU7Cj4gPiA+ICsJCUk5MTVfV1JJVEUoZW5hYmxlX3JlZywgdmFsKTsKPiA+ID4gKwo+ID4g
PiArCQkvKiBUT0RPOiB3YWl0IHRpbWVzIG1pc3NpbmcgZnJvbSB0aGUgc3BlYy4gKi8KPiA+ID4g
KwkJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVyKGRldl9wcml2LCBlbmFibGVfcmVnLCBQTExf
TE9DSywKPiA+ID4gKwkJCQkJICAgIFBMTF9MT0NLLCA1KSkKPiA+ID4gKwkJCURSTV9FUlJPUigi
UExMICVkIG5vdCBsb2NrZWRcbiIsIGlkKTsKPiA+ID4gKwo+ID4gCj4gPiBJIGRvbid0IHJlYWxs
eSBzZWUgd2h5IHRoaXMgY2FuJ3Qgc3RheSBpbiB0aGUgZHBsbCBtZ3IuCj4gVGhpcyB3YXMgcGFy
dCBvZiBpY2xfcGxsX2VuYWJsZSwgd2hpY2ggZ2V0cyBjYWxsZWQgZm9yIGFsbCBoZG1pLCBkcCBh
bmQgbWlwaSBkc2kuCj4gQnV0IGZvciBtaXBpIGRzaSB3ZSBoYXZlIGNvdXBsZSBvZiBtb3JlIHRo
aW5ncyB0byBkbyBiZWZvcmUgd2UgZW5hYmxlIHBsbC4KPiAKPiBJbiBvcmRlciB0byBrZWVwIGl0
IHVuY2hhbmdlZCBmb3Igb3RoZXIgZW5jb2RlcnMgLCBwbGwgZW5hYmxlIHdhcyBtb3ZlZCBoZXJl
Lgo+IEFub3RoZXIgd2F5IGNvdWxkIGJlIGhhdmUgYW4gZW5jb2RlciBjaGVjayBpbiBpY2xfcGxs
X2VuYWJsZSBmdW5jdGlvbiBhbmQgZG8gdGhvc2UgZXh0cmEgc3RlcHMgZm9yIG1pcGkgZHNpIGFu
ZCB0aGVuIGVuYWJsZSB0aGUgcGxsLgo+IFBsZWFzZSBsZXQgbWUga25vdyB3aGF0IHlvdSB0aGlu
ayB3b3VsZCBiZSBhIGJldHRlciB3YXkgdG8gZG8uCgpIYXJkIHRvIGp1ZGdlIHdoYXQgaXMgYmVz
dCB3aXRob3V0IGtub3dpbmcgd2hhdCB0aGUgZGlmZmVyZW5jZXMgYXJlLgoKPiAKPiBUaGFua3Ms
Cj4gVmFuZGl0YSAKPiA+IAo+ID4gPiAgCQlpZiAocG9ydCA+PSBQT1JUX0MpCj4gPiA+ICAJCQlJ
OTE1X1dSSVRFKERESV9DTEtfU0VMKHBvcnQpLAo+ID4gPiAgCQkJCSAgIGljbF9wbGxfdG9fZGRp
X3BsbF9zZWwoZW5jb2RlciwgcGxsKSk7IGRpZmYgLS1naXQKPiA+ID4gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZHBsbF9tZ3IuYwo+ID4gPiBpbmRleCBlNmNhYzkyLi4zNmVkMTU1IDEwMDY0NAo+ID4gPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiA+ICsrKyBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiA+ID4gQEAgLTI5MzAsNyArMjkz
MCw3IEBAIHN0YXRpYyBib29sIGljbF9jYWxjX21nX3BsbF9zdGF0ZShzdHJ1Y3QKPiA+IGludGVs
X2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPiA+ICAJcmV0dXJuIHBsbDsKPiA+ID4gIH0KPiA+
ID4KPiA+ID4gLXN0YXRpYyBpOTE1X3JlZ190IGljbF9wbGxfaWRfdG9fZW5hYmxlX3JlZyhlbnVt
IGludGVsX2RwbGxfaWQgaWQpCj4gPiA+ICtpOTE1X3JlZ190IGljbF9wbGxfaWRfdG9fZW5hYmxl
X3JlZyhlbnVtIGludGVsX2RwbGxfaWQgaWQpCj4gPiA+ICB7Cj4gPiA+ICAJc3dpdGNoIChpZCkg
ewo+ID4gPiAgCWRlZmF1bHQ6Cj4gPiA+IEBAIC0zMTE5LDIyICszMTE5LDcgQEAgc3RhdGljIHZv
aWQgaWNsX3BsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiA+ICpkZXZfcHJpdiwK
PiA+ID4gIAlkZWZhdWx0Ogo+ID4gPiAgCQlNSVNTSU5HX0NBU0UoaWQpOwo+ID4gPiAgCX0KPiA+
ID4gLQo+ID4gPiAtCS8qCj4gPiA+IC0JICogRFZGUyBwcmUgc2VxdWVuY2Ugd291bGQgYmUgaGVy
ZSwgYnV0IGluIG91ciBkcml2ZXIgdGhlIGNkY2xrIGNvZGUKPiA+ID4gLQkgKiBwYXRocyBzaG91
bGQgYWxyZWFkeSBiZSBzZXR0aW5nIHRoZSBhcHByb3ByaWF0ZSB2b2x0YWdlLCBoZW5jZSB3ZSBk
bwo+ID4gPiAtCSAqIG5vdGhpZ24gaGVyZS4KPiA+ID4gLQkgKi8KPiA+ID4gLQo+ID4gPiAtCXZh
bCA9IEk5MTVfUkVBRChlbmFibGVfcmVnKTsKPiA+ID4gLQl2YWwgfD0gUExMX0VOQUJMRTsKPiA+
ID4gLQlJOTE1X1dSSVRFKGVuYWJsZV9yZWcsIHZhbCk7Cj4gPiA+IC0KPiA+ID4gLQlpZiAoaW50
ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIGVuYWJsZV9yZWcsIFBMTF9MT0NLLCBQTExf
TE9DSywKPiA+ID4gLQkJCQkgICAgMSkpIC8qIDYwMHVzIGFjdHVhbGx5LiAqLwo+ID4gPiAtCQlE
Uk1fRVJST1IoIlBMTCAlZCBub3QgbG9ja2VkXG4iLCBpZCk7Cj4gPiA+IC0KPiA+ID4gLQkvKiBE
VkZTIHBvc3Qgc2VxdWVuY2Ugd291bGQgYmUgaGVyZS4gU2VlIHRoZSBjb21tZW50IGFib3ZlLiAq
Lwo+ID4gPiArCS8qIEVuY29kZXIgc3BlY2lmaWMgUExMIGVuYWJsZSBzdGVwcyBhcmUgYWRkZWQg
aW4gZW5jb2RlciBmaWxlICovCj4gPiA+ICB9Cj4gPiA+Cj4gPiA+ICBzdGF0aWMgdm9pZCBpY2xf
cGxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBkaWZmCj4gPiA+
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+ID4gPiBiL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiA+ID4gaW5kZXggYmYwZGU4YS4u
OWU4OTI2NSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBs
bF9tZ3IuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5o
Cj4gPiA+IEBAIC0zNDUsNSArMzQ1LDUgQEAgdm9pZCBpbnRlbF9kcGxsX2R1bXBfaHdfc3RhdGUo
c3RydWN0Cj4gPiA+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCAgaW50IGljbF9jYWxjX2Rw
X2NvbWJvX3BsbF9saW5rKHN0cnVjdAo+ID4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
PiA+ICAJCQkgICAgICAgdWludDMyX3QgcGxsX2lkKTsKPiA+ID4gIGludCBjbmxfaGRtaV9wbGxf
cmVmX2Nsb2NrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gPiA+IC0KPiA+
ID4gK2k5MTVfcmVnX3QgaWNsX3BsbF9pZF90b19lbmFibGVfcmVnKGVudW0gaW50ZWxfZHBsbF9p
ZCBpZCk7Cj4gPiA+ICAjZW5kaWYgLyogX0lOVEVMX0RQTExfTUdSX0hfICovCj4gPiA+IC0tCj4g
PiA+IDEuOS4xCj4gPiA+Cj4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCj4gPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+ID4gSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4gCj4gPiAtLQo+ID4gVmlsbGUgU3lyasOk
bMOkCj4gPiBJbnRlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu
dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v
cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK