From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow Date: Thu, 27 Sep 2018 03:10:46 -0700 Message-ID: <20180927101045.GA3651@intel.com> References: <20180905095321.13843-1-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5726E6E571 for ; Thu, 27 Sep 2018 10:17:42 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180905095321.13843-1-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTI6NTM6MjFQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gV2UndmUgb3B0ZWQgdG8gdXNlIHRoZSBtYXhpbXVtIGxpbmsgcmF0ZSBhbmQgbGFuZSBj b3VudCBmb3IgZURQIHBhbmVscywKPiBiZWNhdXNlIHR5cGljYWxseSB0aGUgbWF4aW11bSBzdXBw b3J0ZWQgY29uZmlndXJhdGlvbiByZXBvcnRlZCBieSB0aGUKPiBwYW5lbCBoYXMgbWF0Y2hlZCB0 aGUgbmF0aXZlIHJlc29sdXRpb24gcmVxdWlyZW1lbnRzIG9mIHRoZSBwYW5lbCwgYW5kCj4gb3B0 aW1pemluZyB0aGUgbGluayBoYXMgbGVhZCB0byBwcm9ibGVtcy4KPiAKPiBXaXRoIGVEUCAxLjQg cmF0ZSBzZWxlY3QgbWV0aG9kIGFuZCBEU0MgZmVhdHVyZXMsIHRoaXMgaXMgZGVjcmVhc2luZ2x5 Cj4gdGhlIGNhc2UuIFRoZXJlJ3MgYSBuZWVkIHRvIG9wdGltaXplIHRoZSBsaW5rIHBhcmFtZXRl cnMuIE1vcmVvdmVyLAo+IGFscmVhZHkgZURQIDEuMyBzdGF0ZXMgZmFzdCBsaW5rIHdpdGggZmV3 ZXIgbGFuZXMgaXMgcHJlZmVycmVkIG92ZXIgdGhlCj4gd2lkZSBhbmQgc2xvdy4gKFdpZGUgYW5k IHNsb3cgc2hvdWxkIHN0aWxsIGJlIG1vcmUgcmVsaWFibGUgZm9yIGxvbmdlcgo+IGNhYmxlIGxl bmd0aHMuKQo+IAo+IEFkZGl0aW9uYWxseSwgdGhlcmUgaGF2ZSBiZWVuIHJlcG9ydHMgb2YgcGFu ZWxzIGZhaWxpbmcgb24gYXJiaXRyYXJ5Cj4gbGluayBjb25maWd1cmF0aW9ucywgYWx0aG91Z2gg YXJndWFibHkgYWxsIGNvbmZpZ3VyYXRpb25zIHRoZXkgY2xhaW0gdG8KPiBzdXBwb3J0IHNob3Vs ZCB3b3JrLgo+IAo+IE9wdGltaXplIGVEUCAxLjQrIGxpbmsgY29uZmlnIGZhc3QgYW5kIG5hcnJv dy4KPiAKPiBTaWRlIG5vdGU6IFRoZSBpbXBsZW1lbnRhdGlvbiBoYXMgYSBuZWFyIGR1cGxpY2F0 ZSBvZiB0aGUgbGluayBjb25maWcKPiBmdW5jdGlvbiwgd2l0aCBqdXN0IHRoZSB0d28gaW5uZXIg Zm9yIGxvb3BzIHR1cm5lZCBpbnNpZGUgb3V0LiBQZXJoYXBzCj4gdGhlcmUnZCBiZSBhIHdheSB0 byBtYWtlIHRoaXMsIHNheSwgbW9yZSB0YWJsZSBkcml2ZW4gdG8gcmVkdWNlIHRoZQo+IGR1cGxp Y2F0aW9uLCBidXQgc2VlbXMgbGlrZSB0aGF0IHdvdWxkIGxlYWQgdG8gZHVwbGljYXRpb24gaW4g dGhlIHRhYmxlCj4gZ2VuZXJhdGlvbi4gV2UnbGwgYWxzbyBoYXZlIHRvIHNlZSBob3cgdGhlIGxp bmsgY29uZmlnIG9wdGltaXphdGlvbiBmb3IKPiBEU0MgdHVybnMgb3V0Lgo+IAo+IENjOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBNYW5hc2kg TmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJv ZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IE1hdHQgQXR3b29kIDxtYXR0aGV3LnMuYXR3b29k QGludGVsLmNvbT4KPiBDYzogIkxlZSwgU2hhd24gQyIgPHNoYXduLmMubGVlQGludGVsLmNvbT4K PiBBY2tlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IEJ1Z3pp bGxhOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDUyNjcK PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IAo+ IC0tLQo+IAo+IHYyIG9mIGh0dHA6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21z Z2lkLzIwMTgwNTA5MDcxMzIxLjI4NTYzLTEtamFuaS5uaWt1bGFAaW50ZWwuY29tCj4gCj4gVW50 ZXN0ZWQuIEl0J3MgcG9zc2libGUgdGhpcyBoZWxwcyB0aGUgcmVmZXJlbmNlZCBidWcuIFRoZSBk b3duc2lkZSBpcwo+IHRoYXQgdGhpcyBwYXRjaCBoYXMgYSBidW5jaCBvZiBkZXBlbmRlbmNpZXMg dGhhdCBhcmUgdG9vIG11Y2ggdG8KPiBiYWNrcG9ydCB0byBzdGFibGUga2VybmVscy4gSWYgdGhl IHBhdGNoIHdvcmtzLCB3ZSBtYXkgbmVlZCB0byBjb25zaWRlcgo+IGhhY2tpbmcgdG9nZXRoZXIg YW4gdWdsaWVyIGJhY2twb3J0Lgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jIHwgNzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDYyIGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDQzNmMyMmRlMzNiNi4uYmY3YjkxODMyYzhhIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gQEAgLTE5MjEsNiArMTkyMSw0MiBAQCBpbnRlbF9k cF9jb21wdXRlX2xpbmtfY29uZmlnX3dpZGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAg CXJldHVybiBmYWxzZTsKPiAgfQo+ICAKPiArLyogT3B0aW1pemUgbGluayBjb25maWcgaW4gb3Jk ZXI6IG1heCBicHAsIG1pbiBsYW5lcywgbWluIGNsb2NrICovCj4gK3N0YXRpYyBib29sCj4gK2lu dGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfZmFzdChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw LAo+ICsJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gKwkJCQkg IGNvbnN0IHN0cnVjdCBsaW5rX2NvbmZpZ19saW1pdHMgKmxpbWl0cykKPiArewo+ICsJc3RydWN0 IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPSAmcGlwZV9jb25maWctPmJhc2UuYWRq dXN0ZWRfbW9kZTsKPiArCWludCBicHAsIGNsb2NrLCBsYW5lX2NvdW50Owo+ICsJaW50IG1vZGVf cmF0ZSwgbGlua19jbG9jaywgbGlua19hdmFpbDsKPiArCj4gKwlmb3IgKGJwcCA9IGxpbWl0cy0+ bWF4X2JwcDsgYnBwID49IGxpbWl0cy0+bWluX2JwcDsgYnBwIC09IDIgKiAzKSB7Cj4gKwkJbW9k ZV9yYXRlID0gaW50ZWxfZHBfbGlua19yZXF1aXJlZChhZGp1c3RlZF9tb2RlLT5jcnRjX2Nsb2Nr LAo+ICsJCQkJCQkgICBicHApOwo+ICsKPiArCQlmb3IgKGxhbmVfY291bnQgPSBsaW1pdHMtPm1p bl9sYW5lX2NvdW50Owo+ICsJCSAgICAgbGFuZV9jb3VudCA8PSBsaW1pdHMtPm1heF9sYW5lX2Nv dW50Owo+ICsJCSAgICAgbGFuZV9jb3VudCA8PD0gMSkgewo+ICsJCQlmb3IgKGNsb2NrID0gbGlt aXRzLT5taW5fY2xvY2s7IGNsb2NrIDw9IGxpbWl0cy0+bWF4X2Nsb2NrOyBjbG9jaysrKSB7Cj4g KwkJCQlsaW5rX2Nsb2NrID0gaW50ZWxfZHAtPmNvbW1vbl9yYXRlc1tjbG9ja107Cj4gKwkJCQls aW5rX2F2YWlsID0gaW50ZWxfZHBfbWF4X2RhdGFfcmF0ZShsaW5rX2Nsb2NrLAo+ICsJCQkJCQkJ CSAgICBsYW5lX2NvdW50KTsKPiArCj4gKwkJCQlpZiAobW9kZV9yYXRlIDw9IGxpbmtfYXZhaWwp IHsKPiArCQkJCQlwaXBlX2NvbmZpZy0+bGFuZV9jb3VudCA9IGxhbmVfY291bnQ7Cj4gKwkJCQkJ cGlwZV9jb25maWctPnBpcGVfYnBwID0gYnBwOwo+ICsJCQkJCXBpcGVfY29uZmlnLT5wb3J0X2Ns b2NrID0gbGlua19jbG9jazsKPiArCj4gKwkJCQkJcmV0dXJuIHRydWU7Cj4gKwkJCQl9Cj4gKwkJ CX0KPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBzdGF0aWMg Ym9vbAo+ICBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVy ICplbmNvZGVyLAo+ICAJCQkgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZp ZykKPiBAQCAtMTk0NSwxMyArMTk4MSwxNSBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmln KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJbGltaXRzLm1pbl9icHAgPSA2ICog MzsKPiAgCWxpbWl0cy5tYXhfYnBwID0gaW50ZWxfZHBfY29tcHV0ZV9icHAoaW50ZWxfZHAsIHBp cGVfY29uZmlnKTsKPiAgCj4gLQlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkgewo+ICsJ aWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkgJiYgaW50ZWxfZHAtPmVkcF9kcGNkWzBdIDwg RFBfRURQXzE0KSB7Cj4gIAkJLyoKPiAgCQkgKiBVc2UgdGhlIG1heGltdW0gY2xvY2sgYW5kIG51 bWJlciBvZiBsYW5lcyB0aGUgZURQIHBhbmVsCj4gLQkJICogYWR2ZXJ0aXplcyBiZWluZyBjYXBh YmxlIG9mLiBUaGUgcGFuZWxzIGFyZSBnZW5lcmFsbHkKPiAtCQkgKiBkZXNpZ25lZCB0byBzdXBw b3J0IG9ubHkgYSBzaW5nbGUgY2xvY2sgYW5kIGxhbmUKPiAtCQkgKiBjb25maWd1cmF0aW9uLCBh bmQgdHlwaWNhbGx5IHRoZXNlIHZhbHVlcyBjb3JyZXNwb25kIHRvIHRoZQo+IC0JCSAqIG5hdGl2 ZSByZXNvbHV0aW9uIG9mIHRoZSBwYW5lbC4KPiArCQkgKiBhZHZlcnRpemVzIGJlaW5nIGNhcGFi bGUgb2YuIFRoZSBlRFAgMS4zIGFuZCBlYXJsaWVyIHBhbmVscwo+ICsJCSAqIGFyZSBnZW5lcmFs bHkgZGVzaWduZWQgdG8gc3VwcG9ydCBvbmx5IGEgc2luZ2xlIGNsb2NrIGFuZAo+ICsJCSAqIGxh bmUgY29uZmlndXJhdGlvbiwgYW5kIHR5cGljYWxseSB0aGVzZSB2YWx1ZXMgY29ycmVzcG9uZCB0 bwo+ICsJCSAqIHRoZSBuYXRpdmUgcmVzb2x1dGlvbiBvZiB0aGUgcGFuZWwuIFdpdGggZURQIDEu NCByYXRlIHNlbGVjdAo+ICsJCSAqIGFuZCBEU0MsIHRoaXMgaXMgZGVjcmVhc2luZ2x5IHRoZSBj YXNlLCBhbmQgd2UgbmVlZCB0byBiZQo+ICsJCSAqIGFibGUgdG8gc2VsZWN0IGxlc3MgdGhhbiBt YXhpbXVtIGxpbmsgY29uZmlnLgo+ICAJCSAqLwo+ICAJCWxpbWl0cy5taW5fbGFuZV9jb3VudCA9 IGxpbWl0cy5tYXhfbGFuZV9jb3VudDsKPiAgCQlsaW1pdHMubWluX2Nsb2NrID0gbGltaXRzLm1h eF9jbG9jazsKPiBAQCAtMTk2NSwxMiArMjAwMywyNSBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtf Y29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCSAgICAgIGludGVsX2Rw LT5jb21tb25fcmF0ZXNbbGltaXRzLm1heF9jbG9ja10sCj4gIAkJICAgICAgbGltaXRzLm1heF9i cHAsIGFkanVzdGVkX21vZGUtPmNydGNfY2xvY2spOwo+ICAKPiAtCS8qCj4gLQkgKiBPcHRpbWl6 ZSBmb3Igc2xvdyBhbmQgd2lkZS4gVGhpcyBpcyB0aGUgcGxhY2UgdG8gYWRkIGFsdGVybmF0aXZl Cj4gLQkgKiBvcHRpbWl6YXRpb24gcG9saWN5Lgo+IC0JICovCj4gLQlpZiAoIWludGVsX2RwX2Nv bXB1dGVfbGlua19jb25maWdfd2lkZShpbnRlbF9kcCwgcGlwZV9jb25maWcsICZsaW1pdHMpKQo+ IC0JCXJldHVybiBmYWxzZTsKPiArCWlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKSB7CgpO aXRwaWNrIGJlbG93OgpDYW4gd2UgbmVzdCB0aGUgZWRwX3JldiA8IERQX0VEUF8xNCBjb25kaXRp b24gd2l0aGluIHRoaXMgaWYgY29uZGl0aW9uPyBMaWtlIGJlbG93OgoKCQlpZiAoaW50ZWxfZHAt PmVkcF9kcGNkWzBdIDwgRFBfRURQXzE0KSB7CgkJCWxpbWl0cy5taW5fbGFuZV9jb3VudCA9IGxp bWl0cy5tYXhfbGFuZV9jb3VudDsKCQkJbGltaXRzLm1pbl9jbG9jayA9IGxpbWl0cy5tYXhfY2xv Y2s7CgkJfQoKV2l0aCB0aGF0LAoKUmV2aWV3ZWQtYnk6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5k Lm5hdmFyZUBpbnRlbC5jb20+CgpNYW5hc2kKCj4gKwkJLyoKPiArCQkgKiBPcHRpbWl6ZSBmb3Ig ZmFzdCBhbmQgbmFycm93LiBlRFAgMS4zIHNlY3Rpb24gMy4zIGFuZCBlRFAgMS40Cj4gKwkJICog c2VjdGlvbiBBLjE6ICJJdCBpcyByZWNvbW1lbmRlZCB0aGF0IHRoZSBtaW5pbXVtIG51bWJlciBv Zgo+ICsJCSAqIGxhbmVzIGJlIHVzZWQsIHVzaW5nIHRoZSBtaW5pbXVtIGxpbmsgcmF0ZSBhbGxv d2VkIGZvciB0aGF0Cj4gKwkJICogbGFuZSBjb25maWd1cmF0aW9uLiIKPiArCQkgKgo+ICsJCSAq IE5vdGUgdGhhdCB3ZSB1c2UgdGhlIG1heCBjbG9jayBhbmQgbGFuZSBjb3VudCBmb3IgZURQIDEu MyBhbmQKPiArCQkgKiBlYXJsaWVyLCBhbmQgZmFzdCB2cy4gd2lkZSBpcyBpcnJlbGV2YW50Lgo+ ICsJCSAqLwo+ICsJCWlmICghaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ19mYXN0KGludGVs X2RwLCBwaXBlX2NvbmZpZywKPiArCQkJCQkJICAgICAgICZsaW1pdHMpKQo+ICsJCQlyZXR1cm4g ZmFsc2U7Cj4gKwl9IGVsc2Ugewo+ICsJCS8qIE9wdGltaXplIGZvciBzbG93IGFuZCB3aWRlLiAq Lwo+ICsJCWlmICghaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ193aWRlKGludGVsX2RwLCBw aXBlX2NvbmZpZywKPiArCQkJCQkJICAgICAgICZsaW1pdHMpKQo+ICsJCQlyZXR1cm4gZmFsc2U7 Cj4gKwl9Cj4gIAo+ICAJRFJNX0RFQlVHX0tNUygiRFAgbGFuZSBjb3VudCAlZCBjbG9jayAlZCBi cHAgJWRcbiIsCj4gIAkJICAgICAgcGlwZV9jb25maWctPmxhbmVfY291bnQsIHBpcGVfY29uZmln LT5wb3J0X2Nsb2NrLAo+IC0tIAo+IDIuMTEuMAo+IApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK