From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v10 2/2] drm/i915: Allow "max bpc" property to limit
 pipe_bpp
Date: Mon, 1 Oct 2018 16:48:01 +0300
Message-ID: <20181001134801.GG9144@intel.com>
References: <20180924210815.21815-1-radhakrishna.sripada@intel.com>
 <20180924210815.21815-2-radhakrishna.sripada@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Content-Disposition: inline
In-Reply-To: <20180924210815.21815-2-radhakrishna.sripada@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Kishore Kadiyala <kishore.kadiyala@intel.com>, Manasi Navare <manasi.d.navare@intel.com>, dri-devel@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMDI6MDg6MTVQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy
aXBhZGEgd3JvdGU6Cj4gVXNlIHRoZSBuZXdseSBhZGRlZCAibWF4IGJwYyIgY29ubmVjdG9yIHBy
b3BlcnR5IHRvIGxpbWl0IHBpcGUgYnBwLgo+IAo+IFYzOiBVc2UgZHJtX2Nvbm5lY3Rvcl9zdGF0
ZSB0byBhY2Nlc3MgdGhlICJtYXggYnBjIiBwcm9wZXJ0eQo+IFY0OiBJbml0aWFsaXplIHRoZSBk
cm0gcHJvcGVydHksIGFkZCBzdXVwb3J0IHRvIERQKFZpbGxlKQo+IFY1OiBVc2UgdGhlIHByb3Bl
cnR5IGluIHRoZSBjb25uZWN0b3IgYW5kIGZpeCBDSSBmYWlsdXJlKFZpbGxlKQo+IFY2OiBVc2Ug
dGhlIGNvcmUgZnVuY3Rpb24gdG8gYXR0YWNoIG1heF9icGMgcHJvcGVydHksIHJlbW92ZSB0aGUg
cmVkdW5kYW50Cj4gICAgIGNsYW1waW5nIG9mIHBpcGUgYnBwIGJhc2VkIG9uIGNvbm5lY3RvciBp
bmZvCj4gVjc6IEZpeCBDaGVja3BhdGNoIHdhcm5pbmdzCj4gVjk6IENsZWFudXAgY29ubmVjdGVk
X3NpbmtfbWF4X2JwcCBhbmQgZml4IGluaXRpYWwgdmFsdWUgaW4gRFAoVmlsbGUpCj4gCj4gQ2M6
IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IERh
bmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gQ2M6IFJvZHJpZ28gVml2aSA8
cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogS2lzaG9yZSBLYWRpeWFsYSA8a2lzaG9yZS5r
YWRpeWFsYUBpbnRlbC5jb20+Cj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBp
bnRlbC5jb20+Cj4gQ2M6IFN0YW5pc2xhdiBMaXNvdnNraXkgPHN0YW5pc2xhdi5saXNvdnNraXlA
aW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFJhZGhha3Jpc2huYSBTcmlwYWRhIDxyYWRoYWty
aXNobmEuc3JpcGFkYUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2Rpc3BsYXkuYyB8IDQ4ICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgfCAgNCArKysKPiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jICAgIHwgIDUgKysrKwo+ICAzIGZpbGVzIGNoYW5n
ZWQsIDM3IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA5MzE4OTgwMTM1MDYuLjA1N2FiZmQ3N2NjMyAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTA4MzksMzAgKzEwODM5
LDM4IEBAIHN0YXRpYyB2b2lkIGludGVsX21vZGVzZXRfdXBkYXRlX2Nvbm5lY3Rvcl9hdG9taWNf
c3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCWRybV9jb25uZWN0b3JfbGlzdF9pdGVy
X2VuZCgmY29ubl9pdGVyKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQKPiAtY29ubmVjdGVkX3Np
bmtfY29tcHV0ZV9icHAoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+IC0JCQkg
ICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gK3N0YXRpYyBpbnQKPiAr
Y29ubmVjdGVkX3NpbmtfbWF4X2JwcChjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAq
Y29ubl9zdGF0ZSwKPiArCQkgICAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29u
ZmlnKQo+ICB7Cj4gLQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfaW5mbyAqaW5mbyA9ICZjb25u
ZWN0b3ItPmJhc2UuZGlzcGxheV9pbmZvOwo+IC0JaW50IGJwcCA9IHBpcGVfY29uZmlnLT5waXBl
X2JwcDsKPiArCWludCBicHA7Cj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfaW5mbyAqaW5mbyA9ICZj
b25uX3N0YXRlLT5jb25uZWN0b3ItPmRpc3BsYXlfaW5mbzsKPiAgCj4gLQlEUk1fREVCVUdfS01T
KCJbQ09OTkVDVE9SOiVkOiVzXSBjaGVja2luZyBmb3Igc2luayBicHAgY29uc3RyYWluc1xuIiwK
PiAtCQkgICAgICBjb25uZWN0b3ItPmJhc2UuYmFzZS5pZCwKPiAtCQkgICAgICBjb25uZWN0b3It
PmJhc2UubmFtZSk7Cj4gKwlicHAgPSBtaW4ocGlwZV9jb25maWctPnBpcGVfYnBwLCBjb25uX3N0
YXRlLT5tYXhfYnBjICogMyk7CgpOZWVkcyBhIGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGUgY29ubmVj
dG9yIGhhcyB0aGUgcHJvcGVydHkuCgo+ICAKPiAtCS8qIERvbid0IHVzZSBhbiBpbnZhbGlkIEVE
SUQgYnBjIHZhbHVlICovCj4gLQlpZiAoaW5mby0+YnBjICE9IDAgJiYgaW5mby0+YnBjICogMyA8
IGJwcCkgewo+IC0JCURSTV9ERUJVR19LTVMoImNsYW1waW5nIGRpc3BsYXkgYnBwICh3YXMgJWQp
IHRvIEVESUQgcmVwb3J0ZWQgbWF4IG9mICVkXG4iLAo+IC0JCQkgICAgICBicHAsIGluZm8tPmJw
YyAqIDMpOwo+IC0JCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGluZm8tPmJwYyAqIDM7Cj4gKwlz
d2l0Y2ggKGNvbm5fc3RhdGUtPm1heF9icGMpIHsKPiArCWNhc2UgNiAuLi4gNzoKPiArCQlwaXBl
X2NvbmZpZy0+cGlwZV9icHAgPSA2ICogMzsKPiArCWNhc2UgOCAuLi4gOToKPiArCQlwaXBlX2Nv
bmZpZy0+cGlwZV9icHAgPSA4ICogMzsKPiArCQlicmVhazsKPiArCWNhc2UgMTAgLi4uIDExOgo+
ICsJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IDEwICogMzsKPiArCQlicmVhazsKPiArCWNhc2Ug
MTI6Cj4gKwkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMTIgKiAzOwo+ICsJCWJyZWFrOwo+ICsJ
ZGVmYXVsdDoKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAgCX0KPiAgCj4gLQkvKiBDbGFtcCBicHAg
dG8gOCBvbiBzY3JlZW5zIHdpdGhvdXQgRURJRCAxLjQgKi8KPiAtCWlmIChpbmZvLT5icGMgPT0g
MCAmJiBicHAgPiAyNCkgewo+IC0JCURSTV9ERUJVR19LTVMoImNsYW1waW5nIGRpc3BsYXkgYnBw
ICh3YXMgJWQpIHRvIGRlZmF1bHQgbGltaXQgb2YgMjRcbiIsCj4gLQkJCSAgICAgIGJwcCk7Cj4g
LQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMjQ7Cj4gKwlpZiAoYnBwICE9IHBpcGVfY29uZmln
LT5waXBlX2JwcCkgewo+ICsJCURSTV9ERUJVR19LTVMoIkxpbWl0aW5nIGRpc3BsYXkgYnBwIHRv
ICVkIGluc3RlYWQgb2YgcmVxdWVzdGVkICIKPiArCQkJICAgICAgImJwcCAlZCwgRWRpZCBicHAg
JWRcbiIsIGJwcCwgMyAqIGluZm8tPmJwYywKPiArCQkJICAgICAgMyAqIGNvbm5fc3RhdGUtPm1h
eF9yZXF1ZXN0ZWRfYnBjKTsKClRoZSBmb3JtYXQgc3RyaW5nIGRvZXNuJ3Qgc2VlbSB0byBtYXRj
aCB0aGUgYXJndW1lbnRzLgoKPiArCQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSBicHA7Cj4gIAl9
Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3RhdGljIGludAo+IEBAIC0xMDg5Myw4ICsxMDkw
MSw4IEBAIGNvbXB1dGVfYmFzZWxpbmVfcGlwZV9icHAoc3RydWN0IGludGVsX2NydGMgKmNydGMs
Cj4gIAkJaWYgKGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0YyAhPSAmY3J0Yy0+YmFzZSkKPiAgCQkJY29u
dGludWU7Cj4gIAo+IC0JCWNvbm5lY3RlZF9zaW5rX2NvbXB1dGVfYnBwKHRvX2ludGVsX2Nvbm5l
Y3Rvcihjb25uZWN0b3IpLAo+IC0JCQkJCSAgIHBpcGVfY29uZmlnKTsKPiArCQlpZiAoY29ubmVj
dGVkX3NpbmtfbWF4X2JwcChjb25uZWN0b3Jfc3RhdGUsIHBpcGVfY29uZmlnKSA8IDApCj4gKwkJ
CXJldHVybiAtRUlOVkFMOwo+ICAJfQo+ICAKPiAgCXJldHVybiBicHA7Cj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcC5jCj4gaW5kZXggNmI0YzE5MTIzZjJhLi5kOGUxMjhlNzcxYTEgMTAwNjQ0Cj4gLS0t
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtNTcxOSw2ICs1NzE5LDEwIEBAIGludGVsX2RwX2FkZF9w
cm9wZXJ0aWVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHN0cnVjdCBkcm1fY29ubmVjdG9y
ICpjb25uZWN0Cj4gIAkJaW50ZWxfYXR0YWNoX2ZvcmNlX2F1ZGlvX3Byb3BlcnR5KGNvbm5lY3Rv
cik7Cj4gIAo+ICAJaW50ZWxfYXR0YWNoX2Jyb2FkY2FzdF9yZ2JfcHJvcGVydHkoY29ubmVjdG9y
KTsKPiArCWlmIChIQVNfR01DSF9ESVNQTEFZKGRldl9wcml2KSkKPiArCQlkcm1fY29ubmVjdG9y
X2F0dGFjaF9tYXhfYnBjX3Byb3BlcnR5KGNvbm5lY3RvciwgNiwgMTApOwo+ICsJZWxzZSBpZiAo
SU5URUxfR0VOKGRldl9wcml2KSA+PSA1KQo+ICsJCWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9i
cGNfcHJvcGVydHkoY29ubmVjdG9yLCA2LCAxMik7Cj4gIAo+ICAJaWYgKGludGVsX2RwX2lzX2Vk
cChpbnRlbF9kcCkpIHsKPiAgCQl1MzIgYWxsb3dlZF9zY2FsZXJzOwo+IGRpZmYgLS1naXQgYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9oZG1pLmMKPiBpbmRleCBhMmRhYjBiNmJkZTYuLjJiNDMyYzdlNGY4YSAxMDA2NDQKPiAt
LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiArKysgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMKPiBAQCAtMjEwOSwxMSArMjEwOSwxNiBAQCBzdGF0aWMg
Y29uc3Qgc3RydWN0IGRybV9lbmNvZGVyX2Z1bmNzIGludGVsX2hkbWlfZW5jX2Z1bmNzID0gewo+
ICBzdGF0aWMgdm9pZAo+ICBpbnRlbF9oZG1pX2FkZF9wcm9wZXJ0aWVzKHN0cnVjdCBpbnRlbF9o
ZG1pICppbnRlbF9oZG1pLCBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICB7Cj4g
KwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5lY3Rvci0+
ZGV2KTsKPiArCj4gIAlpbnRlbF9hdHRhY2hfZm9yY2VfYXVkaW9fcHJvcGVydHkoY29ubmVjdG9y
KTsKPiAgCWludGVsX2F0dGFjaF9icm9hZGNhc3RfcmdiX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4g
IAlpbnRlbF9hdHRhY2hfYXNwZWN0X3JhdGlvX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gIAlkcm1f
Y29ubmVjdG9yX2F0dGFjaF9jb250ZW50X3R5cGVfcHJvcGVydHkoY29ubmVjdG9yKTsKPiAgCWNv
bm5lY3Rvci0+c3RhdGUtPnBpY3R1cmVfYXNwZWN0X3JhdGlvID0gSERNSV9QSUNUVVJFX0FTUEVD
VF9OT05FOwo+ICsKPiArCWlmICghSEFTX0dNQ0hfRElTUExBWShkZXZfcHJpdikpCj4gKwkJZHJt
X2Nvbm5lY3Rvcl9hdHRhY2hfbWF4X2JwY19wcm9wZXJ0eShjb25uZWN0b3IsIDgsIDEyKTsKPiAg
fQo+ICAKPiAgLyoKPiAtLSAKPiAyLjkuMwoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp
bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK