From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v3 4/6] drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect() Date: Mon, 1 Oct 2018 16:22:41 -0700 Message-ID: <20181001232241.GC2801@intel.com> References: <20180924224528.4744-4-dhinakaran.pandiyan@intel.com> <20180926025422.2154-1-dhinakaran.pandiyan@intel.com> <20181001194828.GB12538@intel.com> <20181001201006.GP9144@intel.com> <582e9d724154736dc40bdc04e56d70067ff01bc9.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C35FB89BBD for ; Mon, 1 Oct 2018 23:22:41 +0000 (UTC) Content-Disposition: inline In-Reply-To: <582e9d724154736dc40bdc04e56d70067ff01bc9.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMDEsIDIwMTggYXQgMDM6MDE6MThQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBPbiBNb24sIDIwMTgtMTAtMDEgYXQgMjM6MTAgKzAzMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+IE9uIE1vbiwgT2N0IDAxLCAyMDE4IGF0IDEyOjQ4OjI4UE0gLTA3 MDAsIFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gT24gVHVlLCBTZXAgMjUsIDIwMTggYXQgMDc6 NTQ6MjJQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5kaXlhbgo+ID4gPiB3cm90ZToKPiA+ID4gPiBB IGNydGMgbW9kZXNldCBsb2NrIHdhcyBhZGRlZCBmb3IgbGluayByZXRyYWluaW5nIGJ1dAo+ID4g PiA+IGludGVsX2RwX3JldHJhaW5fbGluaygpIGtub3dzIHRvIHRha2UgdGhlIG5lY2Vzc2FyeSBs b2NrcyBzaW5jZQo+ID4gPiA+IGNvbW1pdCBjODVkMjAwZTgzMjEgKCJkcm0vaTkxNTogTW92ZSBT U1QgRFAgbGluayByZXRyYWluaW5nIGludG8KPiA+ID4gPiB0aGUKPiA+ID4gPiAtPnBvc3RfaG90 cGx1ZygpIGhvb2siKQo+ID4gPiA+IHYyOiBEcm9wIEFVWCBwb3dlciBkb21haW4gcmVmZXJlbmNl IGluIHRoZSBlYXJseSByZXR1cm4gcGF0aAo+ID4gPiA+IAo+ID4gPiA+IEZpeGVzOiBjODVkMjAw ZTgzMjEgKCJkcm0vaTkxNTogTW92ZSBTU1QgRFAgbGluayByZXRyYWluaW5nIGludG8KPiA+ID4g PiB0aGUgLT5wb3N0X2hvdHBsdWcoKSBob29rIikKPiA+ID4gCj4gPiA+IFRoaXMgcGF0Y2ggZmFp bGVkIG9uIGNoZXJyeS1waWNrIGZvciBkcm0taW50ZWwtZml4ZXMgdGFyZ2V0aW5nCj4gPiA+IDQu MTkuCj4gPiA+IAo+ID4gPiBJZiBpdCBzdGlsbCBtYWtlcyBzZW5zZSB0byBoYXZlIGl0IHRoZXJl IHBsZWFzZSBwcm92aWRlIGEKPiA+ID4gYmFja3BvcnRlZCB2ZXJzaW9uCj4gPiA+IHRvIGRybS1p bnRlbC1maXhlcyBvciBsZXQgbWUga25vdyBpZiBpdCBoYXMgZGVwZW5kZW5jeSBvbiBvdGhlcgo+ ID4gPiBwYXRjaGVzPwo+ID4gCj4gPiBUaGlzIGlzIG1vcmUgb2YgYW4gb3B0aW1pemF0aW9uIHRv IG5vdCBkaXN0dXJiIHBhZ2UgZmxpcHMgYW5kIHdoYXRub3QKPiA+IHNvIG11Y2ggd2l0aCBkZXRl Y3QuIFRoZSBkb3VibGUgbG9jayBpcyBvdGhlcndpc2UgaGFybWxlc3MgZHVlIHRvCj4gPiB3d19t dXRleC4KPiA+IAo+IFllYWgsIGxldCdzIG5vdCBiYWNrcG9ydCB0aGlzLgoKY29vbCwgdGhhbmtz LgoKPiAKPiAtREsKPiAKPiA+ID4gCj4gPiA+IFRoYW5rcywKPiA+ID4gUm9kcmlnby4KPiA+ID4g Cj4gPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJh bi5wYW5kaXlhbkBpbnRlbC5jb20KPiA+ID4gPiA+Cj4gPiA+ID4gLS0tCj4gPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgfCAyNCArKysrKysrKysrLS0tLS0tLS0tLS0tLS0K PiA+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygt KQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ID4g aW5kZXggMDkyMjlmYzY2ZGVjLi5lZjI4Y2MwZjEyMmMgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gPiBAQCAtNTA3OSw4ICs1MDc5LDE1IEBAIGludGVsX2Rw X2xvbmdfcHVsc2Uoc3RydWN0IGludGVsX2Nvbm5lY3Rvcgo+ID4gPiA+ICpjb25uZWN0b3IsCj4g PiA+ID4gIAkgKiBTb21lIGV4dGVybmFsIG1vbml0b3JzIGRvIG5vdCBzaWduYWwgbG9zcyBvZiBs aW5rCj4gPiA+ID4gc3luY2hyb25pemF0aW9uCj4gPiA+ID4gIAkgKiB3aXRoIGFuIElSUV9IUEQs IHNvIGZvcmNlIGEgbGluayBzdGF0dXMgY2hlY2suCj4gPiA+ID4gIAkgKi8KPiA+ID4gPiAtCWlm ICghaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSkKPiA+ID4gPiAtCQlpbnRlbF9kcF9yZXRyYWlu X2xpbmsoZW5jb2RlciwgY3R4KTsKPiA+ID4gPiArCWlmICghaW50ZWxfZHBfaXNfZWRwKGludGVs X2RwKSkgewo+ID4gPiA+ICsJCWludCByZXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCXJldCA9IGlu dGVsX2RwX3JldHJhaW5fbGluayhlbmNvZGVyLCBjdHgpOwo+ID4gPiA+ICsJCWlmIChyZXQpIHsK PiA+ID4gPiArCQkJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoZGV2X3ByaXYsIGludGVsX2RwLQo+ ID4gPiA+ID5hdXhfcG93ZXJfZG9tYWluKTsKPiA+ID4gPiArCQkJcmV0dXJuIHJldDsKPiA+ID4g PiArCQl9Cj4gPiA+ID4gKwl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJLyoKPiA+ID4gPiAgCSAqIENs ZWFyaW5nIE5BQ0sgYW5kIGRlZmVyIGNvdW50cyB0byBnZXQgdGhlaXIgZXhhY3QgdmFsdWVzCj4g PiA+ID4gQEAgLTUxMzAsMTkgKzUxMzcsOCBAQCBpbnRlbF9kcF9kZXRlY3Qoc3RydWN0IGRybV9j b25uZWN0b3IKPiA+ID4gPiAqY29ubmVjdG9yLAo+ID4gPiA+ICAJCSAgICAgIGNvbm5lY3Rvci0+ YmFzZS5pZCwgY29ubmVjdG9yLT5uYW1lKTsKPiA+ID4gPiAgCj4gPiA+ID4gIAkvKiBJZiBmdWxs IGRldGVjdCBpcyBub3QgcGVyZm9ybWVkIHlldCwgZG8gYSBmdWxsIGRldGVjdCAqLwo+ID4gPiA+ IC0JaWYgKCFpbnRlbF9kcC0+ZGV0ZWN0X2RvbmUpIHsKPiA+ID4gPiAtCQlzdHJ1Y3QgZHJtX2Ny dGMgKmNydGM7Cj4gPiA+ID4gLQkJaW50IHJldDsKPiA+ID4gPiAtCj4gPiA+ID4gLQkJY3J0YyA9 IGNvbm5lY3Rvci0+c3RhdGUtPmNydGM7Cj4gPiA+ID4gLQkJaWYgKGNydGMpIHsKPiA+ID4gPiAt CQkJcmV0ID0gZHJtX21vZGVzZXRfbG9jaygmY3J0Yy0+bXV0ZXgsIGN0eCk7Cj4gPiA+ID4gLQkJ CWlmIChyZXQpCj4gPiA+ID4gLQkJCQlyZXR1cm4gcmV0Owo+ID4gPiA+IC0JCX0KPiA+ID4gPiAt Cj4gPiA+ID4gKwlpZiAoIWludGVsX2RwLT5kZXRlY3RfZG9uZSkKPiA+ID4gPiAgCQlzdGF0dXMg PSBpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLQo+ID4gPiA+ID5hdHRhY2hlZF9jb25uZWN0 b3IsIGN0eCk7Cj4gPiA+ID4gLQl9Cj4gPiA+ID4gIAo+ID4gPiA+ICAJaW50ZWxfZHAtPmRldGVj dF9kb25lID0gZmFsc2U7Cj4gPiA+ID4gIAo+ID4gPiA+IC0tIAo+ID4gPiA+IDIuMTQuMQo+ID4g PiA+IAo+ID4gPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4gPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiA+IEludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ID4gPiAKPiA+ID4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPiAKPiA+IAo+ IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK