From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/13] drm/i915: Make shared dpll functions take crtc_state Date: Wed, 3 Oct 2018 17:15:22 +0300 Message-ID: <20181003141522.GA9144@intel.com> References: <20181003133715.3713-1-maarten.lankhorst@linux.intel.com> <20181003133715.3713-9-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90C526E4C8 for ; Wed, 3 Oct 2018 14:15:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181003133715.3713-9-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMDM6Mzc6MTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gRG8gbm90IHJlbHkgb24gY3J0Yy0+Y29uZmlnIGFueSBtb3JlLiBSZW1vdmUg dGhlIGFzc2VydGlvbiBmcm9tCj4gaWJ4X3BjaF9kcGxsX2Rpc2FibGUsIGJlY2F1c2Ugd2UgdGhl IGRwbGwgc3RhdGUgdHJhY2tpbmcgc2hvdWxkCj4gYWxyZWFkeSBoYW5kbGUgdGhpcyBjYXNlIGNv cnJlY3RseS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgIHwgMTQgKysrKysrLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwbGxfbWdyLmMgfCAzMSArKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCB8ICA2ICsrKy0tLQo+ICAzIGZpbGVz IGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDI5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCA1N2M4MWU4ZTQ0YmUuLjIyZjU1NmI4MjRm OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtNDc0OSw3ICs0 NzQ5LDcgQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfcGNoX2VuYWJsZShjb25zdCBzdHJ1Y3QgaW50 ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCSAqIE5vdGUgdGhhdCBlbmFibGVfc2hhcmVkX2Rw bGwgdHJpZXMgdG8gZG8gdGhlIHJpZ2h0IHRoaW5nLCBidXQKPiAgCSAqIGdldF9zaGFyZWRfZHBs bCB1bmNvbmRpdGlvbmFsbHkgcmVzZXRzIHRoZSBwbGwgLSB3ZSBuZWVkIHRoYXQgdG8gaGF2ZQo+ ICAJICogdGhlIHJpZ2h0IExWRFMgZW5hYmxlIHNlcXVlbmNlLiAqLwo+IC0JaW50ZWxfZW5hYmxl X3NoYXJlZF9kcGxsKGNydGMpOwo+ICsJaW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKGNydGNfc3Rh dGUpOwo+ICAKPiAgCS8qIHNldCB0cmFuc2NvZGVyIHRpbWluZywgcGFuZWwgbXVzdCBhbGxvdyBp dCAqLwo+ICAJYXNzZXJ0X3BhbmVsX3VubG9ja2VkKGRldl9wcml2LCBwaXBlKTsKPiBAQCAtNTU5 MSw4ICs1NTkxLDggQEAgc3RhdGljIHZvaWQgaXJvbmxha2VfY3J0Y19lbmFibGUoc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJaW50ZWxfc2V0X2NwdV9maWZvX3VuZGVy cnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgcGlwZSwgZmFsc2UpOwo+ICAJaW50ZWxfc2V0X3BjaF9m aWZvX3VuZGVycnVuX3JlcG9ydGluZyhkZXZfcHJpdiwgcGlwZSwgZmFsc2UpOwo+ICAKPiAtCWlm IChpbnRlbF9jcnRjLT5jb25maWctPmhhc19wY2hfZW5jb2RlcikKPiAtCQlpbnRlbF9wcmVwYXJl X3NoYXJlZF9kcGxsKGludGVsX2NydGMpOwo+ICsJaWYgKHBpcGVfY29uZmlnLT5oYXNfcGNoX2Vu Y29kZXIpCj4gKwkJaW50ZWxfcHJlcGFyZV9zaGFyZWRfZHBsbChwaXBlX2NvbmZpZyk7Cj4gIAo+ ICAJaWYgKGludGVsX2NydGNfaGFzX2RwX2VuY29kZXIoaW50ZWxfY3J0Yy0+Y29uZmlnKSkKPiAg CQlpbnRlbF9kcF9zZXRfbV9uKGludGVsX2NydGMsIE0xX04xKTsKPiBAQCAtNTcxMCw4ICs1NzEw LDggQEAgc3RhdGljIHZvaWQgaGFzd2VsbF9jcnRjX2VuYWJsZShzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqcGlwZV9jb25maWcsCj4gIAo+ICAJaW50ZWxfZW5jb2RlcnNfcHJlX3BsbF9lbmFibGUo Y3J0YywgcGlwZV9jb25maWcsIG9sZF9zdGF0ZSk7Cj4gIAo+IC0JaWYgKGludGVsX2NydGMtPmNv bmZpZy0+c2hhcmVkX2RwbGwpCj4gLQkJaW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKGludGVsX2Ny dGMpOwo+ICsJaWYgKHBpcGVfY29uZmlnLT5zaGFyZWRfZHBsbCkKPiArCQlpbnRlbF9lbmFibGVf c2hhcmVkX2RwbGwocGlwZV9jb25maWcpOwo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYp ID49IDExKQo+ICAJCWljbF9tYXBfcGxsc190b19wb3J0cyhjcnRjLCBwaXBlX2NvbmZpZywgb2xk X3N0YXRlKTsKPiBAQCAtNjI4Niw3ICs2Mjg2LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfY3J0Y19k aXNhYmxlX25vYXRvbWljKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4gIAlpbnRlbF9mYmNf ZGlzYWJsZShpbnRlbF9jcnRjKTsKPiAgCWludGVsX3VwZGF0ZV93YXRlcm1hcmtzKGludGVsX2Ny dGMpOwo+IC0JaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChpbnRlbF9jcnRjKTsKPiArCWludGVs X2Rpc2FibGVfc2hhcmVkX2RwbGwoY3J0Y19zdGF0ZSk7Cj4gIAo+ICAJZG9tYWlucyA9IGludGVs X2NydGMtPmVuYWJsZWRfcG93ZXJfZG9tYWluczsKPiAgCWZvcl9lYWNoX3Bvd2VyX2RvbWFpbihk b21haW4sIGRvbWFpbnMpCj4gQEAgLTEyNzM1LDcgKzEyNzM1LDcgQEAgc3RhdGljIHZvaWQgaW50 ZWxfYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAg CQkJZGV2X3ByaXYtPmRpc3BsYXkuY3J0Y19kaXNhYmxlKG9sZF9pbnRlbF9jcnRjX3N0YXRlLCBz dGF0ZSk7Cj4gIAkJCWludGVsX2NydGMtPmFjdGl2ZSA9IGZhbHNlOwo+ICAJCQlpbnRlbF9mYmNf ZGlzYWJsZShpbnRlbF9jcnRjKTsKPiAtCQkJaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChpbnRl bF9jcnRjKTsKPiArCQkJaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChvbGRfaW50ZWxfY3J0Y19z dGF0ZSk7Cj4gIAo+ICAJCQkvKgo+ICAJCQkgKiBVbmRlcnJ1bnMgZG9uJ3QgYWx3YXlzIHJhaXNl Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gaW5kZXggZTZjYWM5MjI1NTM2 Li41NDY2MmM5NzRjMGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBsbF9tZ3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMK PiBAQCAtMTMxLDEzICsxMzEsMTMgQEAgdm9pZCBhc3NlcnRfc2hhcmVkX2RwbGwoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAgKiBUaGlzIGNhbGxzIHRoZSBQTEwncyBwcmVw YXJlIGhvb2sgaWYgaXQgaGFzIG9uZSBhbmQgaWYgdGhlIFBMTCBpcyBub3QKPiAgICogYWxyZWFk eSBlbmFibGVkLiBUaGUgcHJlcGFyZSBob29rIGlzIHBsYXRmb3JtIHNwZWNpZmljLgo+ICAgKi8K PiAtdm9pZCBpbnRlbF9wcmVwYXJlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRj KQo+ICt2b2lkIGludGVsX3ByZXBhcmVfc2hhcmVkX2RwbGwoY29uc3Qgc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBj cnRjLT5iYXNlLmRldjsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRv X2k5MTUoZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsID0gY3J0Yy0+Y29u ZmlnLT5zaGFyZWRfZHBsbDsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxf Y3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gKwlzdHJ1Y3QgaW50ZWxfc2hh cmVkX2RwbGwgKnBsbCA9IGNydGNfc3RhdGUtPnNoYXJlZF9kcGxsOwo+ICAKPiAtCWlmIChXQVJO X09OKHBsbCA9PSBOVUxMKSkKPiArCWlmICghV0FSTl9PTighcGxsKSkKPiAgCQlyZXR1cm47Cj4g IAo+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gQEAgLTE1OCwxMSArMTU4 LDExIEBAIHZvaWQgaW50ZWxfcHJlcGFyZV9zaGFyZWRfZHBsbChzdHJ1Y3QgaW50ZWxfY3J0YyAq Y3J0YykKPiAgICoKPiAgICogRW5hYmxlIHRoZSBzaGFyZWQgRFBMTCB1c2VkIGJ5IEBjcnRjLgo+ ICAgKi8KPiAtdm9pZCBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoc3RydWN0IGludGVsX2NydGMg KmNydGMpCj4gK3ZvaWQgaW50ZWxfZW5hYmxlX3NoYXJlZF9kcGxsKGNvbnN0IHN0cnVjdCBpbnRl bF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gLQlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+YmFzZS5kZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGRldik7Cj4gLQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnBsbCA9IGNydGMt PmNvbmZpZy0+c2hhcmVkX2RwbGw7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IHRvX2lu dGVsX2NydGMoY3J0Y19zdGF0ZS0+YmFzZS5jcnRjKTsKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY3J0Yy0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGludGVs X3NoYXJlZF9kcGxsICpwbGwgPSBjcnRjX3N0YXRlLT5zaGFyZWRfZHBsbDsKPiAgCXVuc2lnbmVk IGludCBjcnRjX21hc2sgPSBkcm1fY3J0Y19tYXNrKCZjcnRjLT5iYXNlKTsKPiAgCXVuc2lnbmVk IGludCBvbGRfbWFzazsKPiAgCj4gQEAgLTIwMywxMCArMjAzLDExIEBAIHZvaWQgaW50ZWxfZW5h YmxlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAgKgo+ICAgKiBEaXNh YmxlIHRoZSBzaGFyZWQgRFBMTCB1c2VkIGJ5IEBjcnRjLgo+ICAgKi8KPiAtdm9pZCBpbnRlbF9k aXNhYmxlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICt2b2lkIGludGVs X2Rpc2FibGVfc2hhcmVkX2RwbGwoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNf c3RhdGUpCj4gIHsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gdG9faW50ZWxfY3J0Yyhj cnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gLQlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2Rw bGwgKnBsbCA9IGNydGMtPmNvbmZpZy0+c2hhcmVkX2RwbGw7Cj4gKwlzdHJ1Y3QgaW50ZWxfc2hh cmVkX2RwbGwgKnBsbCA9IGNydGNfc3RhdGUtPnNoYXJlZF9kcGxsOwo+ICAJdW5zaWduZWQgaW50 IGNydGNfbWFzayA9IGRybV9jcnRjX21hc2soJmNydGMtPmJhc2UpOwo+ICAKPiAgCS8qIFBDSCBv bmx5IGF2YWlsYWJsZSBvbiBJTEsrICovCj4gQEAgLTQwOSwxNCArNDEwLDYgQEAgc3RhdGljIHZv aWQgaWJ4X3BjaF9kcGxsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ICAJCQkJIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsKQo+ICB7Cj4gIAljb25zdCBl bnVtIGludGVsX2RwbGxfaWQgaWQgPSBwbGwtPmluZm8tPmlkOwo+IC0Jc3RydWN0IGRybV9kZXZp Y2UgKmRldiA9ICZkZXZfcHJpdi0+ZHJtOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4g LQo+IC0JLyogTWFrZSBzdXJlIG5vIHRyYW5zY29kZXIgaXNuJ3Qgc3RpbGwgZGVwZW5kaW5nIG9u IHVzLiAqLwo+IC0JZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsKPiAtCQlpZiAoY3J0 Yy0+Y29uZmlnLT5zaGFyZWRfZHBsbCA9PSBwbGwpCj4gLQkJCWFzc2VydF9wY2hfdHJhbnNjb2Rl cl9kaXNhYmxlZChkZXZfcHJpdiwgY3J0Yy0+cGlwZSk7Cj4gLQl9CgpZZWFoIEkgZ3Vlc3MgdGhp cyBjYW4gZ28uIElmIHdlIHJlYWxseSB3YW50ZWQgdG8ga2VlcCBpdCB3ZSBzaG91bGQKcHJvYmFi bHkgbWFrZSBpdCBub3QgZGVwZW5kIG9uIGFueSBzb2Z0d2FyZSBzdGF0ZSBhbmQganVzdCByZWFk IG91dApldmVyeXRoaW5nIGZyb20gdGhlIGh3LgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICAKPiAgCUk5MTVfV1JJVEUoUENI X0RQTEwoaWQpLCAwKTsKPiAgCVBPU1RJTkdfUkVBRChQQ0hfRFBMTChpZCkpOwo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAo+IGluZGV4IGJmMGRlOGE0ZGM2My4uOWMwMzMyMzZm MmJhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCj4gQEAgLTMzNCw5 ICszMzQsOSBAQCBzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKmludGVsX2dldF9zaGFyZWRfZHBs bChzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgdm9pZCBpbnRlbF9yZWxlYXNlX3NoYXJlZF9k cGxsKHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqZHBsbCwKPiAgCQkJICAgICAgIHN0cnVjdCBp bnRlbF9jcnRjICpjcnRjLAo+ICAJCQkgICAgICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlKTsKPiAtdm9pZCBpbnRlbF9wcmVwYXJlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjKTsKPiAtdm9pZCBpbnRlbF9lbmFibGVfc2hhcmVkX2RwbGwoc3RydWN0IGludGVsX2Ny dGMgKmNydGMpOwo+IC12b2lkIGludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwoc3RydWN0IGludGVs X2NydGMgKmNydGMpOwo+ICt2b2lkIGludGVsX3ByZXBhcmVfc2hhcmVkX2RwbGwoY29uc3Qgc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICt2b2lkIGludGVsX2VuYWJsZV9z aGFyZWRfZHBsbChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSk7Cj4g K3ZvaWQgaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbChjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqY3J0Y19zdGF0ZSk7Cj4gIHZvaWQgaW50ZWxfc2hhcmVkX2RwbGxfc3dhcF9zdGF0ZShz dHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpOwo+ICB2b2lkIGludGVsX3NoYXJlZF9kcGxs X2luaXQoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gIAo+IC0tIAo+IDIuMTkuMAo+IAo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZp bGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK