From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v10 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp Date: Wed, 3 Oct 2018 21:48:44 +0300 Message-ID: <20181003184844.GK9144@intel.com> References: <20180924210815.21815-1-radhakrishna.sripada@intel.com> <20180924210815.21815-2-radhakrishna.sripada@intel.com> <20181001134801.GG9144@intel.com> <20181003184214.7hcinrwpihc6q7ly@InViCtUs> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181003184214.7hcinrwpihc6q7ly@InViCtUs> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Radhakrishna Sripada Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Kishore Kadiyala , dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMDMsIDIwMTggYXQgMTE6NDI6MTRBTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNy aXBhZGEgd3JvdGU6Cj4gT24gTW9uLCBPY3QgMDEsIDIwMTggYXQgMDQ6NDg6MDFQTSArMDMwMCwg VmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+ID4gT24gTW9uLCBTZXAgMjQsIDIwMTggYXQgMDI6MDg6 MTVQTSAtMDcwMCwgUmFkaGFrcmlzaG5hIFNyaXBhZGEgd3JvdGU6Cj4gPiA+IFVzZSB0aGUgbmV3 bHkgYWRkZWQgIm1heCBicGMiIGNvbm5lY3RvciBwcm9wZXJ0eSB0byBsaW1pdCBwaXBlIGJwcC4K PiA+ID4gCj4gPiA+IFYzOiBVc2UgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSB0byBhY2Nlc3MgdGhlICJt YXggYnBjIiBwcm9wZXJ0eQo+ID4gPiBWNDogSW5pdGlhbGl6ZSB0aGUgZHJtIHByb3BlcnR5LCBh ZGQgc3V1cG9ydCB0byBEUChWaWxsZSkKPiA+ID4gVjU6IFVzZSB0aGUgcHJvcGVydHkgaW4gdGhl IGNvbm5lY3RvciBhbmQgZml4IENJIGZhaWx1cmUoVmlsbGUpCj4gPiA+IFY2OiBVc2UgdGhlIGNv cmUgZnVuY3Rpb24gdG8gYXR0YWNoIG1heF9icGMgcHJvcGVydHksIHJlbW92ZSB0aGUgcmVkdW5k YW50Cj4gPiA+ICAgICBjbGFtcGluZyBvZiBwaXBlIGJwcCBiYXNlZCBvbiBjb25uZWN0b3IgaW5m bwo+ID4gPiBWNzogRml4IENoZWNrcGF0Y2ggd2FybmluZ3MKPiA+ID4gVjk6IENsZWFudXAgY29u bmVjdGVkX3NpbmtfbWF4X2JwcCBhbmQgZml4IGluaXRpYWwgdmFsdWUgaW4gRFAoVmlsbGUpCj4g PiA+IAo+ID4gPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVs LmNvbT4KPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4g PiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+IENjOiBL aXNob3JlIEthZGl5YWxhIDxraXNob3JlLmthZGl5YWxhQGludGVsLmNvbT4KPiA+ID4gQ2M6IE1h bmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiA+IENjOiBTdGFuaXNs YXYgTGlzb3Zza2l5IDxzdGFuaXNsYXYubGlzb3Zza2l5QGludGVsLmNvbT4KPiA+ID4gU2lnbmVk LW9mZi1ieTogUmFkaGFrcmlzaG5hIFNyaXBhZGEgPHJhZGhha3Jpc2huYS5zcmlwYWRhQGludGVs LmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMgfCA0OCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgICAgICB8ICA0ICsrKwo+ID4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jICAgIHwgIDUgKysrKwo+ID4gPiAgMyBmaWxlcyBjaGFu Z2VkLCAzNyBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ID4gaW5kZXggOTMxODk4MDEzNTA2Li4wNTdh YmZkNzdjYzMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK PiA+ID4gQEAgLTEwODM5LDMwICsxMDgzOSwzOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0 X3VwZGF0ZV9jb25uZWN0b3JfYXRvbWljX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g PiA+ICAJZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXJfZW5kKCZjb25uX2l0ZXIpOwo+ID4gPiAgfQo+ ID4gPiAgCj4gPiA+IC1zdGF0aWMgdm9pZAo+ID4gPiAtY29ubmVjdGVkX3NpbmtfY29tcHV0ZV9i cHAoc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ID4gPiAtCQkJICAgc3RydWN0 IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+ID4gPiArc3RhdGljIGludAo+ID4gPiAr Y29ubmVjdGVkX3NpbmtfbWF4X2JwcChjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAq Y29ubl9zdGF0ZSwKPiA+ID4gKwkJICAgICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl X2NvbmZpZykKPiA+ID4gIHsKPiA+ID4gLQljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfaW5mbyAq aW5mbyA9ICZjb25uZWN0b3ItPmJhc2UuZGlzcGxheV9pbmZvOwo+ID4gPiAtCWludCBicHAgPSBw aXBlX2NvbmZpZy0+cGlwZV9icHA7Cj4gPiA+ICsJaW50IGJwcDsKPiA+ID4gKwlzdHJ1Y3QgZHJt X2Rpc3BsYXlfaW5mbyAqaW5mbyA9ICZjb25uX3N0YXRlLT5jb25uZWN0b3ItPmRpc3BsYXlfaW5m bzsKPiA+ID4gIAo+ID4gPiAtCURSTV9ERUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIGNoZWNr aW5nIGZvciBzaW5rIGJwcCBjb25zdHJhaW5zXG4iLAo+ID4gPiAtCQkgICAgICBjb25uZWN0b3It PmJhc2UuYmFzZS5pZCwKPiA+ID4gLQkJICAgICAgY29ubmVjdG9yLT5iYXNlLm5hbWUpOwo+ID4g PiArCWJwcCA9IG1pbihwaXBlX2NvbmZpZy0+cGlwZV9icHAsIGNvbm5fc3RhdGUtPm1heF9icGMg KiAzKTsKPiA+IAo+ID4gTmVlZHMgYSBjaGVjayB0byBtYWtlIHN1cmUgdGhlIGNvbm5lY3RvciBo YXMgdGhlIHByb3BlcnR5Lgo+IFdlIGRvIG1ha2UgYSBjaGVjayBmb3IgdGhlIGNvbm5lY3RvciBw cm9wZXJ0eSBpbiB0aGUgZHJtIGNvcmUuIEluIHRoZSBhYnNlbmNlIAo+IG9mIHRoZSBwcm9wZXJ0 eSwgY29ubl9zdGF0ZS0+bWF4X2JwYyBjYXJyaWVzIHRoZSBsaW1pdCBpbXBvc2VkIGZyb20gCj4g Y29ubmVjdG9yLT5kaXNwbGF5X2luZm8uYnBjIGFuZCB3b3VsZCBiZSByZXF1aXJpbmcgdGhlIGNv ZGVwYXRoIGJlbG93LgoKQWggeWVzLiBUaGF0IHBhcnQgaXMgcGVyZmVjdGx5IGdvb2QgdGhlbi4K Cj4gCj4gVGhvdWdodHM/Cj4gCj4gLS0gUmFkaGFrcmlzaG5hIFNyaXBhZGEKPiA+IAo+ID4gPiAg Cj4gPiA+IC0JLyogRG9uJ3QgdXNlIGFuIGludmFsaWQgRURJRCBicGMgdmFsdWUgKi8KPiA+ID4g LQlpZiAoaW5mby0+YnBjICE9IDAgJiYgaW5mby0+YnBjICogMyA8IGJwcCkgewo+ID4gPiAtCQlE Uk1fREVCVUdfS01TKCJjbGFtcGluZyBkaXNwbGF5IGJwcCAod2FzICVkKSB0byBFRElEIHJlcG9y dGVkIG1heCBvZiAlZFxuIiwKPiA+ID4gLQkJCSAgICAgIGJwcCwgaW5mby0+YnBjICogMyk7Cj4g PiA+IC0JCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGluZm8tPmJwYyAqIDM7Cj4gPiA+ICsJc3dp dGNoIChjb25uX3N0YXRlLT5tYXhfYnBjKSB7Cj4gPiA+ICsJY2FzZSA2IC4uLiA3Ogo+ID4gPiAr CQlwaXBlX2NvbmZpZy0+cGlwZV9icHAgPSA2ICogMzsKPiA+ID4gKwljYXNlIDggLi4uIDk6Cj4g PiA+ICsJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IDggKiAzOwo+ID4gPiArCQlicmVhazsKPiA+ ID4gKwljYXNlIDEwIC4uLiAxMToKPiA+ID4gKwkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMTAg KiAzOwo+ID4gPiArCQlicmVhazsKPiA+ID4gKwljYXNlIDEyOgo+ID4gPiArCQlwaXBlX2NvbmZp Zy0+cGlwZV9icHAgPSAxMiAqIDM7Cj4gPiA+ICsJCWJyZWFrOwo+ID4gPiArCWRlZmF1bHQ6Cj4g PiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAtCS8qIENsYW1w IGJwcCB0byA4IG9uIHNjcmVlbnMgd2l0aG91dCBFRElEIDEuNCAqLwo+ID4gPiAtCWlmIChpbmZv LT5icGMgPT0gMCAmJiBicHAgPiAyNCkgewo+ID4gPiAtCQlEUk1fREVCVUdfS01TKCJjbGFtcGlu ZyBkaXNwbGF5IGJwcCAod2FzICVkKSB0byBkZWZhdWx0IGxpbWl0IG9mIDI0XG4iLAo+ID4gPiAt CQkJICAgICAgYnBwKTsKPiA+ID4gLQkJcGlwZV9jb25maWctPnBpcGVfYnBwID0gMjQ7Cj4gPiA+ ICsJaWYgKGJwcCAhPSBwaXBlX2NvbmZpZy0+cGlwZV9icHApIHsKPiA+ID4gKwkJRFJNX0RFQlVH X0tNUygiTGltaXRpbmcgZGlzcGxheSBicHAgdG8gJWQgaW5zdGVhZCBvZiByZXF1ZXN0ZWQgIgo+ ID4gPiArCQkJICAgICAgImJwcCAlZCwgRWRpZCBicHAgJWRcbiIsIGJwcCwgMyAqIGluZm8tPmJw YywKPiA+ID4gKwkJCSAgICAgIDMgKiBjb25uX3N0YXRlLT5tYXhfcmVxdWVzdGVkX2JwYyk7Cj4g PiAKPiA+IFRoZSBmb3JtYXQgc3RyaW5nIGRvZXNuJ3Qgc2VlbSB0byBtYXRjaCB0aGUgYXJndW1l bnRzLgo+ID4gCj4gPiA+ICsJCXBpcGVfY29uZmlnLT5waXBlX2JwcCA9IGJwcDsKPiA+ID4gIAl9 Cj4gPiA+ICsJcmV0dXJuIDA7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyBpbnQKPiA+ ID4gQEAgLTEwODkzLDggKzEwOTAxLDggQEAgY29tcHV0ZV9iYXNlbGluZV9waXBlX2JwcChzdHJ1 Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiA+ID4gIAkJaWYgKGNvbm5lY3Rvcl9zdGF0ZS0+Y3J0YyAh PSAmY3J0Yy0+YmFzZSkKPiA+ID4gIAkJCWNvbnRpbnVlOwo+ID4gPiAgCj4gPiA+IC0JCWNvbm5l Y3RlZF9zaW5rX2NvbXB1dGVfYnBwKHRvX2ludGVsX2Nvbm5lY3Rvcihjb25uZWN0b3IpLAo+ID4g PiAtCQkJCQkgICBwaXBlX2NvbmZpZyk7Cj4gPiA+ICsJCWlmIChjb25uZWN0ZWRfc2lua19tYXhf YnBwKGNvbm5lY3Rvcl9zdGF0ZSwgcGlwZV9jb25maWcpIDwgMCkKPiA+ID4gKwkJCXJldHVybiAt RUlOVkFMOwo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAgCXJldHVybiBicHA7Cj4gPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBpbmRleCA2YjRjMTkxMjNmMmEuLmQ4ZTEyOGU3NzFhMSAx MDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IEBAIC01NzE5LDYgKzU3 MTksMTAgQEAgaW50ZWxfZHBfYWRkX3Byb3BlcnRpZXMoc3RydWN0IGludGVsX2RwICppbnRlbF9k cCwgc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3QKPiA+ID4gIAkJaW50ZWxfYXR0YWNoX2Zv cmNlX2F1ZGlvX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gPiA+ICAKPiA+ID4gIAlpbnRlbF9hdHRh Y2hfYnJvYWRjYXN0X3JnYl9wcm9wZXJ0eShjb25uZWN0b3IpOwo+ID4gPiArCWlmIChIQVNfR01D SF9ESVNQTEFZKGRldl9wcml2KSkKPiA+ID4gKwkJZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfbWF4X2Jw Y19wcm9wZXJ0eShjb25uZWN0b3IsIDYsIDEwKTsKPiA+ID4gKwllbHNlIGlmIChJTlRFTF9HRU4o ZGV2X3ByaXYpID49IDUpCj4gPiA+ICsJCWRybV9jb25uZWN0b3JfYXR0YWNoX21heF9icGNfcHJv cGVydHkoY29ubmVjdG9yLCA2LCAxMik7Cj4gPiA+ICAKPiA+ID4gIAlpZiAoaW50ZWxfZHBfaXNf ZWRwKGludGVsX2RwKSkgewo+ID4gPiAgCQl1MzIgYWxsb3dlZF9zY2FsZXJzOwo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPiA+IGluZGV4IGEyZGFiMGI2YmRlNi4uMmI0MzJjN2U0 ZjhhIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9oZG1pLmMK PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaGRtaS5jCj4gPiA+IEBAIC0y MTA5LDExICsyMTA5LDE2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2VuY29kZXJfZnVuY3Mg aW50ZWxfaGRtaV9lbmNfZnVuY3MgPSB7Cj4gPiA+ICBzdGF0aWMgdm9pZAo+ID4gPiAgaW50ZWxf aGRtaV9hZGRfcHJvcGVydGllcyhzdHJ1Y3QgaW50ZWxfaGRtaSAqaW50ZWxfaGRtaSwgc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiA+ID4gIHsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNvbm5lY3Rvci0+ZGV2KTsKPiA+ID4gKwo+ ID4gPiAgCWludGVsX2F0dGFjaF9mb3JjZV9hdWRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+ID4g PiAgCWludGVsX2F0dGFjaF9icm9hZGNhc3RfcmdiX3Byb3BlcnR5KGNvbm5lY3Rvcik7Cj4gPiA+ ICAJaW50ZWxfYXR0YWNoX2FzcGVjdF9yYXRpb19wcm9wZXJ0eShjb25uZWN0b3IpOwo+ID4gPiAg CWRybV9jb25uZWN0b3JfYXR0YWNoX2NvbnRlbnRfdHlwZV9wcm9wZXJ0eShjb25uZWN0b3IpOwo+ ID4gPiAgCWNvbm5lY3Rvci0+c3RhdGUtPnBpY3R1cmVfYXNwZWN0X3JhdGlvID0gSERNSV9QSUNU VVJFX0FTUEVDVF9OT05FOwo+ID4gPiArCj4gPiA+ICsJaWYgKCFIQVNfR01DSF9ESVNQTEFZKGRl dl9wcml2KSkKPiA+ID4gKwkJZHJtX2Nvbm5lY3Rvcl9hdHRhY2hfbWF4X2JwY19wcm9wZXJ0eShj b25uZWN0b3IsIDgsIDEyKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAgLyoKPiA+ID4gLS0gCj4g PiA+IDIuOS4zCj4gPiAKPiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK