From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Lyude <cpaul@redhat.com>,
intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter
Date: Thu, 4 Oct 2018 08:54:05 -0700 [thread overview]
Message-ID: <20181004155405.GA2611@intel.com> (raw)
In-Reply-To: <20181004105952.GO9144@intel.com>
On Thu, Oct 04, 2018 at 01:59:52PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 04, 2018 at 10:03:39AM +0300, Jani Nikula wrote:
> > On Wed, 03 Oct 2018, Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> wrote:
> > > MST is enabled by default on all platforms that support it. I don't think
> > > we should be providing a switch to work around MST issues as the feature
> > > has been supported for a while now. Let's kill this module parameter
> > > that we also do not test in CI.
> >
> > I agree we don't want to provide this to users to *work around*
> > issues. But maybe we want something like this to *debug* issues?
>
> Yes. I was using it for that just a few days ago when looking at a bug.
so it seems useful and it means that we need to move to debugfs :)
>
> Also the mst code lacks a bunch of features I think we'd want (remote dpcd,
> remote i2c write, maybe others). It's still the unloved stepchild with no
> one really focusing on improving it.
>
> So I think it's way too early to think about removing this outright.
> Not sure we should ever remove it really. What happens if in the future
> most of our ci displays are mst capable? Do we just not test sst at all?
> Granted a modparam is a probably a bit too coarse for that, but I think
> we may want *something* to force sst.
>
> --
> Ville Syrjälä
> Intel
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-04 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 19:36 [RFC] drm/i915/dp: Remove i915.enable_dp_mst module parameter Dhinakaran Pandiyan
2018-10-03 20:04 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-10-03 20:29 ` [RFC] " Rodrigo Vivi
2018-10-04 7:03 ` Jani Nikula
2018-10-04 10:59 ` Ville Syrjälä
2018-10-04 15:54 ` Rodrigo Vivi [this message]
2018-10-04 17:36 ` Dhinakaran Pandiyan
2018-10-04 8:58 ` ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004155405.GA2611@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=cpaul@redhat.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).