From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4 09/11] drm/i915: Extract skl_universal_plane_init()
Date: Wed, 10 Oct 2018 13:18:12 +0300 [thread overview]
Message-ID: <20181010101812.GL9144@intel.com> (raw)
In-Reply-To: <878t36nrrc.fsf@intel.com>
On Wed, Oct 10, 2018 at 11:13:43AM +0300, Jani Nikula wrote:
> On Fri, 05 Oct 2018, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index 0e0f763907ef..7a9f5ee4604f 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -2124,25 +2124,14 @@ int intel_sprite_set_colorkey_ioctl(struct drm_device *dev, void *data,
> > struct drm_file *file_priv);
> > void intel_pipe_update_start(const struct intel_crtc_state *new_crtc_state);
> > void intel_pipe_update_end(struct intel_crtc_state *new_crtc_state);
> > -void skl_update_plane(struct intel_plane *plane,
> > - const struct intel_crtc_state *crtc_state,
> > - const struct intel_plane_state *plane_state);
>
>
> Sparse says you can make this static now.
Yeah. Actually I'm pretty sure it was static before the
last rebase.
Anyways, I snuck that change in when pushing O:)
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-10 10:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 12:58 [PATCH v4 00/11] drm/i915: Some plane init cleanups Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 01/11] drm/i915: Constify all plane_funcs structs Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 02/11] drm/i915: Populate possible_crtcs for primary/cursor planes Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 03/11] drm/i915: Don't populate plane->i9xx_plane for sprites Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 04/11] drm/i915: Allow horizontal mirroring for cnl+ "sprite" planes Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 05/11] drm/i915: Disallow plane scaling with specific pixel formats Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 06/11] drm/i915: Add missing pixel formats for skl+ "sprites" Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 07/11] drm/i915: Move plane_state->scaler_id initialization into intel_create_plane_state() Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 08/11] drm/i915: Introduce intel_plane_alloc() Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 09/11] drm/i915: Extract skl_universal_plane_init() Ville Syrjala
2018-10-10 8:13 ` Jani Nikula
2018-10-10 10:18 ` Ville Syrjälä [this message]
2018-10-05 12:58 ` [PATCH v4 10/11] drm/i915: s/intel_plane/plane/ in sprite init Ville Syrjala
2018-10-05 12:58 ` [PATCH v4 11/11] drm/i915: Rename variables in intel_primary_plane_create() Ville Syrjala
2018-10-05 13:48 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Some plane init cleanups Patchwork
2018-10-05 13:51 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-10-05 14:08 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-05 20:40 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010101812.GL9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).