From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas De Marchi Subject: Re: [PATCH v3 2/4] drm/i915/perf: remove redundant oa buffer initialization Date: Mon, 15 Oct 2018 11:48:46 -0700 Message-ID: <20181015184844.GB4402@ldmartin-desk.jf.intel.com> References: <20181015155959.28038-1-lionel.g.landwerlin@intel.com> <20181015155959.28038-3-lionel.g.landwerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2807F6E059 for ; Mon, 15 Oct 2018 18:48:50 +0000 (UTC) Received: by mail-pl1-x641.google.com with SMTP id v5-v6so9720970plz.13 for ; Mon, 15 Oct 2018 11:48:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20181015155959.28038-3-lionel.g.landwerlin@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMTUsIDIwMTggYXQgMDQ6NTk6NTdQTSArMDEwMCwgTGlvbmVsIExhbmR3ZXJs aW4gd3JvdGU6Cj4gV2UgaW5pdGlhbGl6ZSB0aGUgT0EgYnVmZmVyIGV2ZXJ5dGltZSB3ZSBlbmFi bGUgdGhlIE9BIHVuaXQgKGZpcnN0IGNhbGwgaW4KPiBnZW5bNzhdX29hX2VuYWJsZSksIHNvIHdl IGRvbid0IG5lZWQgdG8gaW5pdGlhbGl6ZSB3aGVuIHByZXBhcmluZyB0aGUgbWV0cmljCj4gc2V0 Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwuZy5sYW5kd2Vy bGluQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogTWF0dGhldyBBdWxkIDxtYXR0aGV3LmF1bGRA aW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlA aW50ZWwuY29tPgoKdGhhbmtzCkx1Y2FzIERlIE1hcmNoaQoKPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAxNyAtLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3BlcmYuYyB8ICA2ICstLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDEg aW5zZXJ0aW9uKCspLCAyMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgK PiBpbmRleCA2M2NlMGRhNGU3MjMuLmVlZjdjODExYmQ4ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+IEBAIC0xNTI5LDIzICsxNTI5LDYgQEAgc3RydWN0IGk5MTVfb2Ffb3BzIHsKPiAg CSAqLwo+ICAJYm9vbCAoKmlzX3ZhbGlkX2ZsZXhfcmVnKShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsIHUzMiBhZGRyKTsKPiAgCj4gLQkvKioKPiAtCSAqIEBpbml0X29hX2J1ZmZl cjogUmVzZXRzIHRoZSBoZWFkIGFuZCB0YWlsIHBvaW50ZXJzIG9mIHRoZQo+IC0JICogY2lyY3Vs YXIgYnVmZmVyIGZvciBwZXJpb2RpYyBPQSByZXBvcnRzLgo+IC0JICoKPiAtCSAqIENhbGxlZCB3 aGVuIGZpcnN0IG9wZW5pbmcgYSBzdHJlYW0gZm9yIE9BIG1ldHJpY3MsIGJ1dCBhbHNvIG1heSBi ZQo+IC0JICogY2FsbGVkIGluIHJlc3BvbnNlIHRvIGFuIE9BIGJ1ZmZlciBvdmVyZmxvdyBvciBv dGhlciBlcnJvcgo+IC0JICogY29uZGl0aW9uLgo+IC0JICoKPiAtCSAqIE5vdGUgaXQgbWF5IGJl IG5lY2Vzc2FyeSB0byBjbGVhciB0aGUgZnVsbCBPQSBidWZmZXIgaGVyZSBhcyBwYXJ0IG9mCj4g LQkgKiBtYWludGFpbmluZyB0aGUgaW52YXJpYWJsZSB0aGF0IG5ldyByZXBvcnRzIG11c3QgYmUg d3JpdHRlbiB0bwo+IC0JICogemVyb2VkIG1lbW9yeSBmb3IgdXMgdG8gYmUgYWJsZSB0byByZWxp YWJsZSBkZXRlY3QgaWYgYW4gZXhwZWN0ZWQKPiAtCSAqIHJlcG9ydCBoYXMgbm90IHlldCBsYW5k ZWQgaW4gbWVtb3J5LiAgKEF0IGxlYXN0IG9uIEhhc3dlbGwgdGhlIE9BCj4gLQkgKiBidWZmZXIg dGFpbCBwb2ludGVyIGlzIG5vdCBzeW5jaHJvbml6ZWQgd2l0aCByZXBvcnRzIGJlaW5nIHZpc2li bGUKPiAtCSAqIHRvIHRoZSBDUFUpCj4gLQkgKi8KPiAtCXZvaWQgKCppbml0X29hX2J1ZmZlciko c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAtCj4gIAkvKioKPiAgCSAqIEBl bmFibGVfbWV0cmljX3NldDogU2VsZWN0cyBhbmQgYXBwbGllcyBhbnkgTVVYIGNvbmZpZ3VyYXRp b24gdG8gc2V0Cj4gIAkgKiB1cCB0aGUgQm9vbGVhbiBhbmQgQ3VzdG9tIChCL0MpIGNvdW50ZXJz IHRoYXQgYXJlIHBhcnQgb2YgdGhlCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcGVyZi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wZXJmLmMKPiBpbmRleCAz MDkxMWVmZDJjZjcuLjE0ZjdkMDNhYWJjZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X3BlcmYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcGVyZi5j Cj4gQEAgLTE1MzAsOCArMTUzMCw2IEBAIHN0YXRpYyBpbnQgYWxsb2Nfb2FfYnVmZmVyKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlnb3RvIGVycl91bnBpbjsKPiAgCX0K PiAgCj4gLQlkZXZfcHJpdi0+cGVyZi5vYS5vcHMuaW5pdF9vYV9idWZmZXIoZGV2X3ByaXYpOwo+ IC0KPiAgCURSTV9ERUJVR19EUklWRVIoIk9BIEJ1ZmZlciBpbml0aWFsaXplZCwgZ3R0IG9mZnNl dCA9IDB4JXgsIHZhZGRyID0gJXBcbiIsCj4gIAkJCSBpOTE1X2dndHRfb2Zmc2V0KGRldl9wcml2 LT5wZXJmLm9hLm9hX2J1ZmZlci52bWEpLAo+ICAJCQkgZGV2X3ByaXYtPnBlcmYub2Eub2FfYnVm ZmVyLnZhZGRyKTsKPiBAQCAtMjAwMCw3ICsxOTk4LDcgQEAgc3RhdGljIGludCBpOTE1X29hX3N0 cmVhbV9pbml0KHN0cnVjdCBpOTE1X3BlcmZfc3RyZWFtICpzdHJlYW0sCj4gIAkJcmV0dXJuIC1F SU5WQUw7Cj4gIAl9Cj4gIAo+IC0JaWYgKCFkZXZfcHJpdi0+cGVyZi5vYS5vcHMuaW5pdF9vYV9i dWZmZXIpIHsKPiArCWlmICghZGV2X3ByaXYtPnBlcmYub2Eub3BzLmVuYWJsZV9tZXRyaWNfc2V0 KSB7Cj4gIAkJRFJNX0RFQlVHKCJPQSB1bml0IG5vdCBzdXBwb3J0ZWRcbiIpOwo+ICAJCXJldHVy biAtRU5PREVWOwo+ICAJfQo+IEBAIC0zMzg5LDcgKzMzODcsNiBAQCB2b2lkIGk5MTVfcGVyZl9p bml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlkZXZfcHJpdi0+cGVy Zi5vYS5vcHMuaXNfdmFsaWRfbXV4X3JlZyA9Cj4gIAkJCWhzd19pc192YWxpZF9tdXhfYWRkcjsK PiAgCQlkZXZfcHJpdi0+cGVyZi5vYS5vcHMuaXNfdmFsaWRfZmxleF9yZWcgPSBOVUxMOwo+IC0J CWRldl9wcml2LT5wZXJmLm9hLm9wcy5pbml0X29hX2J1ZmZlciA9IGdlbjdfaW5pdF9vYV9idWZm ZXI7Cj4gIAkJZGV2X3ByaXYtPnBlcmYub2Eub3BzLmVuYWJsZV9tZXRyaWNfc2V0ID0gaHN3X2Vu YWJsZV9tZXRyaWNfc2V0Owo+ICAJCWRldl9wcml2LT5wZXJmLm9hLm9wcy5kaXNhYmxlX21ldHJp Y19zZXQgPSBoc3dfZGlzYWJsZV9tZXRyaWNfc2V0Owo+ICAJCWRldl9wcml2LT5wZXJmLm9hLm9w cy5vYV9lbmFibGUgPSBnZW43X29hX2VuYWJsZTsKPiBAQCAtMzQwOCw3ICszNDA1LDYgQEAgdm9p ZCBpOTE1X3BlcmZfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJ ICovCj4gIAkJZGV2X3ByaXYtPnBlcmYub2Eub2FfZm9ybWF0cyA9IGdlbjhfcGx1c19vYV9mb3Jt YXRzOwo+ICAKPiAtCQlkZXZfcHJpdi0+cGVyZi5vYS5vcHMuaW5pdF9vYV9idWZmZXIgPSBnZW44 X2luaXRfb2FfYnVmZmVyOwo+ICAJCWRldl9wcml2LT5wZXJmLm9hLm9wcy5vYV9lbmFibGUgPSBn ZW44X29hX2VuYWJsZTsKPiAgCQlkZXZfcHJpdi0+cGVyZi5vYS5vcHMub2FfZGlzYWJsZSA9IGdl bjhfb2FfZGlzYWJsZTsKPiAgCQlkZXZfcHJpdi0+cGVyZi5vYS5vcHMucmVhZCA9IGdlbjhfb2Ff cmVhZDsKPiAtLSAKPiAyLjE5LjEKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==