From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 7/8] drm/i915/gen11: Program the Y and UV plane for planar mode correctly, v3. Date: Thu, 18 Oct 2018 17:51:28 +0300 Message-ID: <20181018145128.GI9144@intel.com> References: <20181018115134.9061-1-maarten.lankhorst@linux.intel.com> <20181018115134.9061-8-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E7EC892B9 for ; Thu, 18 Oct 2018 14:51:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181018115134.9061-8-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTgsIDIwMTggYXQgMDE6NTE6MzNQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhlIFVWIHBsYW5lIGlzIHRoZSBtYXN0ZXIgcGxhbmUgdGhhdCBkb2VzIGFs bCBjb2xvciBjb3JyZWN0aW9uIGV0Yy4KPiBJdCBuZWVkcyB0byBiZSBwcm9ncmFtbWVkIHdpdGgg dGhlIGRpbWVuc2lvbnMgZm9yIGNvbG9yIHBsYW5lIDEgKFVWKS4KPiAKPiBUaGUgWSBwbGFuZSBq dXN0IGZlZWRzIHRoZSBZIHBpeGVscyB0byBpdC4gUHJvZ3JhbSB0aGUgc2NhbGVyIGZyb20gdGhl Cj4gbWFzdGVyIG9ubHksIGFuZCBzZXQgUExBTkVfQ1RMX1lVVjQyMF9ZX1BMQU5FIG9uIHRoZSBz bGF2ZSBwbGFuZS4KPiAKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gTWFrZSBhIGNvbW1vbiBza2xf cHJvZ3JhbV9wbGFuZSwgYW5kIHVzZSBpdCBmb3IgYm90aCBwbGFuZSB1cGRhdGVzLgo+IENoYW5n ZXMgc2luY2UgdjI6Cj4gLSBNYWtlIGNvbG9yX3BsYW5lIGV4cGxpY2l0LCB0byBjbGFyaWZ5IHNr bF91cGRhdGVfcGxhbmUoKS4gKFZpbGxlKQo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFu a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+CgpSZXZpZXdlZC1ieTog VmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgIHwgIDEgKwo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysrLS0t LS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCAxN2IzOGNjYmZmNmUuLmY4ZTY4ZTg4 Zjk4ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC02NDczLDYgKzY0NzMsNyBA QCBlbnVtIHsKPiAgI2RlZmluZSAgIFBMQU5FX0NUTF9LRVlfRU5BQkxFX0RFU1RJTkFUSU9OCSgy IDw8IDIxKQo+ICAjZGVmaW5lICAgUExBTkVfQ1RMX09SREVSX0JHUlgJCQkoMCA8PCAyMCkKPiAg I2RlZmluZSAgIFBMQU5FX0NUTF9PUkRFUl9SR0JYCQkJKDEgPDwgMjApCj4gKyNkZWZpbmUgICBQ TEFORV9DVExfWVVWNDIwX1lfUExBTkUJCSgxIDw8IDE5KQo+ICAjZGVmaW5lICAgUExBTkVfQ1RM X1lVVl9UT19SR0JfQ1NDX0ZPUk1BVF9CVDcwOQkoMSA8PCAxOCkKPiAgI2RlZmluZSAgIFBMQU5F X0NUTF9ZVVY0MjJfT1JERVJfTUFTSwkJKDB4MyA8PCAxNikKPiAgI2RlZmluZSAgIFBMQU5FX0NU TF9ZVVY0MjJfWVVZVgkJCSgwIDw8IDE2KQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Nwcml0ZS5j Cj4gaW5kZXggMmVjNWM1ZGYwZDI0Li41ZDA0OTgzYTI4ZWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0zNjIsMjIgKzM2MiwyMiBAQCBza2xfcHJvZ3JhbV9zY2Fs ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICB9Cj4gIAo+ICBzdGF0aWMg dm9pZAo+IC1za2xfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gLQkJ IGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+IC0JCSBjb25zdCBz dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICtza2xfcHJvZ3JhbV9wbGFu ZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICsJCSAgY29uc3Qgc3RydWN0IGludGVsX2Ny dGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gKwkJICBjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3Rh dGUgKnBsYW5lX3N0YXRlLAo+ICsJCSAgaW50IGNvbG9yX3BsYW5lLCBib29sIHNsYXZlLCB1MzIg cGxhbmVfY3RsKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0 b19pOTE1KHBsYW5lLT5iYXNlLmRldik7Cj4gIAllbnVtIHBsYW5lX2lkIHBsYW5lX2lkID0gcGxh bmUtPmlkOwo+ICAJZW51bSBwaXBlIHBpcGUgPSBwbGFuZS0+cGlwZTsKPiAtCXUzMiBwbGFuZV9j dGwgPSBwbGFuZV9zdGF0ZS0+Y3RsOwo+ICAJY29uc3Qgc3RydWN0IGRybV9pbnRlbF9zcHJpdGVf Y29sb3JrZXkgKmtleSA9ICZwbGFuZV9zdGF0ZS0+Y2tleTsKPiAtCXUzMiBzdXJmX2FkZHIgPSBw bGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0ub2Zmc2V0Owo+IC0JdTMyIHN0cmlkZSA9IHNrbF9w bGFuZV9zdHJpZGUocGxhbmVfc3RhdGUsIDApOwo+ICsJdTMyIHN1cmZfYWRkciA9IHBsYW5lX3N0 YXRlLT5jb2xvcl9wbGFuZVtjb2xvcl9wbGFuZV0ub2Zmc2V0Owo+ICsJdTMyIHN0cmlkZSA9IHNr bF9wbGFuZV9zdHJpZGUocGxhbmVfc3RhdGUsIGNvbG9yX3BsYW5lKTsKPiAgCXUzMiBhdXhfc3Ry aWRlID0gc2tsX3BsYW5lX3N0cmlkZShwbGFuZV9zdGF0ZSwgMSk7Cj4gIAlpbnQgY3J0Y194ID0g cGxhbmVfc3RhdGUtPmJhc2UuZHN0LngxOwo+ICAJaW50IGNydGNfeSA9IHBsYW5lX3N0YXRlLT5i YXNlLmRzdC55MTsKPiAtCXVpbnQzMl90IHggPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0u eDsKPiAtCXVpbnQzMl90IHkgPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbMF0ueTsKPiArCXVp bnQzMl90IHggPSBwbGFuZV9zdGF0ZS0+Y29sb3JfcGxhbmVbY29sb3JfcGxhbmVdLng7Cj4gKwl1 aW50MzJfdCB5ID0gcGxhbmVfc3RhdGUtPmNvbG9yX3BsYW5lW2NvbG9yX3BsYW5lXS55Owo+ICAJ dWludDMyX3Qgc3JjX3cgPSBkcm1fcmVjdF93aWR0aCgmcGxhbmVfc3RhdGUtPmJhc2Uuc3JjKSA+ PiAxNjsKPiAgCXVpbnQzMl90IHNyY19oID0gZHJtX3JlY3RfaGVpZ2h0KCZwbGFuZV9zdGF0ZS0+ YmFzZS5zcmMpID4+IDE2Owo+ICAJc3RydWN0IGludGVsX3BsYW5lICpsaW5rZWQgPSBwbGFuZV9z dGF0ZS0+bGlua2VkX3BsYW5lOwo+IEBAIC00NDEsNyArNDQxLDkgQEAgc2tsX3VwZGF0ZV9wbGFu ZShzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ICAKPiAgCS8qIHByb2dyYW0gcGxhbmUgc2Nh bGVyICovCj4gIAlpZiAocGxhbmVfc3RhdGUtPnNjYWxlcl9pZCA+PSAwKSB7Cj4gLQkJc2tsX3By b2dyYW1fc2NhbGVyKGRldl9wcml2LCBwbGFuZSwgY3J0Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+ ICsJCWlmICghc2xhdmUpCj4gKwkJCXNrbF9wcm9ncmFtX3NjYWxlcihkZXZfcHJpdiwgcGxhbmUs Cj4gKwkJCQkJICAgY3J0Y19zdGF0ZSwgcGxhbmVfc3RhdGUpOwo+ICAKPiAgCQlJOTE1X1dSSVRF X0ZXKFBMQU5FX1BPUyhwaXBlLCBwbGFuZV9pZCksIDApOwo+ICAJfSBlbHNlIHsKPiBAQCAtNDU2 LDcgKzQ1OCwzMiBAQCBza2xfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUs Cj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZs YWdzKTsKPiAgfQo+ICAKPiArdm9pZAo+ICtza2xfdXBkYXRlX3BsYW5lKHN0cnVjdCBpbnRlbF9w bGFuZSAqcGxhbmUsCj4gKwkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlLAo+ICsJCSBjb25zdCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ ICt7Cj4gKwlpbnQgY29sb3JfcGxhbmUgPSAwOwo+ICsKPiArCWlmIChwbGFuZV9zdGF0ZS0+bGlu a2VkX3BsYW5lKSB7Cj4gKwkJLyogUHJvZ3JhbSB0aGUgVVYgcGxhbmUgKi8KPiArCQljb2xvcl9w bGFuZSA9IDE7Cj4gKwl9Cj4gKwo+ICsJc2tsX3Byb2dyYW1fcGxhbmUocGxhbmUsIGNydGNfc3Rh dGUsIHBsYW5lX3N0YXRlLAo+ICsJCQkgIGNvbG9yX3BsYW5lLCBmYWxzZSwgcGxhbmVfc3RhdGUt PmN0bCk7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkCj4gK2ljbF91cGRhdGVfc2xhdmUoc3RydWN0 IGludGVsX3BsYW5lICpwbGFuZSwKPiArCQkgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUsCj4gKwkJIGNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVf c3RhdGUpCj4gK3sKPiArCXNrbF9wcm9ncmFtX3BsYW5lKHBsYW5lLCBjcnRjX3N0YXRlLCBwbGFu ZV9zdGF0ZSwgMCwgdHJ1ZSwKPiArCQkJICBwbGFuZV9zdGF0ZS0+Y3RsIHwgUExBTkVfQ1RMX1lV VjQyMF9ZX1BMQU5FKTsKPiArfQo+ICsKPiArdm9pZAo+ICBza2xfZGlzYWJsZV9wbGFuZShzdHJ1 Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLCBzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgewo+ICAJ c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5k ZXYpOwo+IEBAIC0xOTA5LDYgKzE5MzYsOCBAQCBza2xfdW5pdmVyc2FsX3BsYW5lX2NyZWF0ZShz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlwbGFuZS0+ZGlzYWJsZV9wbGFu ZSA9IHNrbF9kaXNhYmxlX3BsYW5lOwo+ICAJcGxhbmUtPmdldF9od19zdGF0ZSA9IHNrbF9wbGFu ZV9nZXRfaHdfc3RhdGU7Cj4gIAlwbGFuZS0+Y2hlY2tfcGxhbmUgPSBza2xfcGxhbmVfY2hlY2s7 Cj4gKwlpZiAoaWNsX2lzX252MTJfeV9wbGFuZShwbGFuZV9pZCkpCj4gKwkJcGxhbmUtPnVwZGF0 ZV9zbGF2ZSA9IGljbF91cGRhdGVfc2xhdmU7Cj4gIAo+ICAJaWYgKHNrbF9wbGFuZV9oYXNfcGxh bmFyKGRldl9wcml2LCBwaXBlLCBwbGFuZV9pZCkpIHsKPiAgCQlmb3JtYXRzID0gc2tsX3BsYW5h cl9mb3JtYXRzOwo+IC0tIAo+IDIuMTkuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK