From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks Date: Thu, 18 Oct 2018 19:18:45 +0300 Message-ID: <20181018161845.GO9144@intel.com> References: <20181016220133.26991-1-paulo.r.zanoni@intel.com> <20181016220133.26991-9-paulo.r.zanoni@intel.com> <20181018135552.GC9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F23789D44 for ; Thu, 18 Oct 2018 16:18:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181018135552.GC9144@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTgsIDIwMTggYXQgMDQ6NTU6NTJQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgT2N0IDE2LCAyMDE4IGF0IDAzOjAxOjMwUE0gLTA3MDAsIFBhdWxv IFphbm9uaSB3cm90ZToKPiA+IFByaW50IGEgbW9yZSBnZW5lcmljICJmYWlsZWQgdG8gY29tcHV0 ZSB3YXRlcm1hcmsgbGV2ZWxzIiB3aGVuZXZlciBhbnkKPiA+IG9mIHNrbF9jb21wdXRlX3dtX2xl dmVscygpIGZhaWwsIGFuZCBwcmludCBvbmx5IHRoZSBzcGVjaWZpYyBlcnJvcgo+ID4gbWVzc2Fn ZSBmb3IgdGhlIHNwZWNpZmljIGNhc2VzLiBUaGlzIGFsbG93cyB1cyB0byBzdG9wIHBhc3Npbmcg cHN0YXRlCj4gPiBldmVyeXdoZXJlLCBtYWtpbmcgdGhlIHdhdGVybWFya3MgY29tcHV0YXRpb24g Y29kZSBhIGxpdHRsZSBsZXNzCj4gPiBkZXBlbmRlbnQgb24gcmFuZG9tIGludGVsIHN0YXRlIHN0 cnVjdHMuCj4gCj4gTm90aGluZyByYW5kb20gYWJvdXQgdGhvc2Ugc3RydWN0cy4gVGhleSBhcmUg KnRoZSogc3RhdGUuCj4gVXNpbmcgdGhlbSBkaXJlY3RseSByYXRoZXIgdGhhbiBkdXBsaWNhdGlu ZyBpbmZvcm1hdGlvbmEgaW4gdGhlCj4gd21fcGFyYW1zIHN0cnVjdCB3b3VsZCBwcm9iYWJseSBt YWtlIHRoZSBjb2RlIGxvb2sgYSBiaXQgbGVzcyBhbGllbi4KPiAKPiBCdXQgZ2l2ZW4gdGhhdCB0 aGUgaW5mb3JtYXRpb24gaXMgZHVwbGljYXRlZCBJIGd1ZXNzIHdlIGRvbid0IGhhdmUgdG8KPiBw YXNzIGluIHRoZSBwbGFuZSBzdGF0ZS4gU28gdGhlIHBhdGNoIHNlZW1zIGZpbmUgaW4gdGhhdCBz ZW5zZS4KPiAKPiBSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KCkFuZCB0aGlzIHdpbGwgZGVmaW5pdGVseSBjb25mbGljdCB3aXRoIE1h YXJ0ZW4ncyBOVjEyIHdvcmsuIEVpdGhlciB3ZQpuZWVkIHRvIGR1cGxpY2F0ZSBldmVuIG1vcmUg c3R1ZmYgb3IganVzdCBwYXNzIHRoZSBwcm9wZXIgc3RhdGVzIGFyb3VuZC4KCj4gCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+ ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDI3ICsrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCsp LCAxNSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiBpbmRl eCA0MDUzZjRhNjg2NTcuLjEyOTBlZmM2NDg2OSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X3BtLmMKPiA+IEBAIC00NjM1LDEzICs0NjM1LDExIEBAIHNrbF9jb21wdXRlX3BsYW5lX3dtX3Bh cmFtcyhjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCj4gPiAg c3RhdGljIGludCBza2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gPiAgCQkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUs Cj4gPiAtCQkJCWNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqaW50ZWxfcHN0YXRlLAo+ ID4gIAkJCQlpbnQgbGV2ZWwsCj4gPiAgCQkJCWNvbnN0IHN0cnVjdCBza2xfd21fcGFyYW1zICp3 cCwKPiA+ICAJCQkJY29uc3Qgc3RydWN0IHNrbF93bV9sZXZlbCAqcmVzdWx0X3ByZXYsCj4gPiAg CQkJCXN0cnVjdCBza2xfd21fbGV2ZWwgKnJlc3VsdCAvKiBvdXQgKi8pCj4gPiAgewo+ID4gLQlj b25zdCBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwc3RhdGUgPSAmaW50ZWxfcHN0YXRlLT5iYXNl Owo+ID4gIAl1aW50MzJfdCBsYXRlbmN5ID0gZGV2X3ByaXYtPndtLnNrbF9sYXRlbmN5W2xldmVs XTsKPiA+ICAJdWludF9maXhlZF8xNl8xNl90IG1ldGhvZDEsIG1ldGhvZDI7Cj4gPiAgCXVpbnRf Zml4ZWRfMTZfMTZfdCBzZWxlY3RlZF9yZXN1bHQ7Cj4gPiBAQCAtNDc2MywxMSArNDc2MSw3IEBA IHN0YXRpYyBpbnQgc2tsX2NvbXB1dGVfcGxhbmVfd20oY29uc3Qgc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ID4gIAkJaWYgKGxldmVsKSB7Cj4gPiAgCQkJcmV0dXJuIDA7Cj4g PiAgCQl9IGVsc2Ugewo+ID4gLQkJCXN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lID0gcHN0YXRlLT5w bGFuZTsKPiA+IC0KPiA+IC0JCQlEUk1fREVCVUdfS01TKCJSZXF1ZXN0ZWQgZGlzcGxheSBjb25m aWd1cmF0aW9uIGV4Y2VlZHMgc3lzdGVtIHdhdGVybWFyayBsaW1pdGF0aW9uc1xuIik7Cj4gPiAt CQkJRFJNX0RFQlVHX0tNUygiW1BMQU5FOiVkOiVzXSBibG9ja3MgcmVxdWlyZWQgPSAldS8ldSwg bGluZXMgcmVxdWlyZWQgPSAldS8zMVxuIiwKPiA+IC0JCQkJICAgICAgcGxhbmUtPmJhc2UuaWQs IHBsYW5lLT5uYW1lLAo+ID4gKwkJCURSTV9ERUJVR19LTVMoIlJlcXVlc3RlZCBkaXNwbGF5IGNv bmZpZ3VyYXRpb24gZXhjZWVkcyBzeXN0ZW0gd2F0ZXJtYXJrIGxpbWl0YXRpb25zOiBibG9ja3Mg cmVxdWlyZWQgPSAldS8ldSwgbGluZXMgcmVxdWlyZWQgPSAldS8zMVxuIiwKPiA+ICAJCQkJICAg ICAgcmVzX2Jsb2Nrcywgd3AtPmRkYl9ibG9ja3MsIHJlc19saW5lcyk7Cj4gPiAgCQkJcmV0dXJu IC1FSU5WQUw7Cj4gPiAgCQl9Cj4gPiBAQCAtNDc5NSw3ICs0Nzg5LDYgQEAgc3RhdGljIGludCBz a2xfY29tcHV0ZV9wbGFuZV93bShjb25zdCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gPiAgc3RhdGljIGludAo+ID4gIHNrbF9jb21wdXRlX3dtX2xldmVscyhjb25zdCBzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCQkgICAgICBzdHJ1Y3QgaW50ZWxf Y3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4gLQkJICAgICAgY29uc3Qgc3RydWN0IGludGVsX3BsYW5l X3N0YXRlICppbnRlbF9wc3RhdGUsCj4gPiAgCQkgICAgICBjb25zdCBzdHJ1Y3Qgc2tsX3dtX3Bh cmFtcyAqd21fcGFyYW1zLAo+ID4gIAkJICAgICAgc3RydWN0IHNrbF9wbGFuZV93bSAqd20sCj4g PiAgCQkgICAgICBpbnQgcGxhbmVfaWQpCj4gPiBAQCAtNDgxNiw3ICs0ODA5LDYgQEAgc2tsX2Nv bXB1dGVfd21fbGV2ZWxzKGNvbnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK PiA+ICAKPiA+ICAJCXJldCA9IHNrbF9jb21wdXRlX3BsYW5lX3dtKGRldl9wcml2LAo+ID4gIAkJ CQkJICAgY3N0YXRlLAo+ID4gLQkJCQkJICAgaW50ZWxfcHN0YXRlLAo+ID4gIAkJCQkJICAgbGV2 ZWwsCj4gPiAgCQkJCQkgICB3bV9wYXJhbXMsCj4gPiAgCQkJCQkgICByZXN1bHRfcHJldiwKPiA+ IEBAIC00OTUxLDEwICs0OTQzLDEzIEBAIHN0YXRpYyBpbnQgc2tsX2J1aWxkX3BpcGVfd20oc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKmNzdGF0ZSwKPiA+ICAJCWlmICghd21fcGFyYW1zLnBsYW5l X3Zpc2libGUpCj4gPiAgCQkJY29udGludWU7Cj4gPiAgCj4gPiAtCQlyZXQgPSBza2xfY29tcHV0 ZV93bV9sZXZlbHMoZGV2X3ByaXYsIGNzdGF0ZSwKPiA+IC0JCQkJCSAgICBpbnRlbF9wc3RhdGUs ICZ3bV9wYXJhbXMsIHdtLCAwKTsKPiA+IC0JCWlmIChyZXQpCj4gPiArCQlyZXQgPSBza2xfY29t cHV0ZV93bV9sZXZlbHMoZGV2X3ByaXYsIGNzdGF0ZSwgJndtX3BhcmFtcywgd20sCj4gPiArCQkJ CQkgICAgMCk7Cj4gPiArCQlpZiAocmV0KSB7Cj4gPiArCQkJRFJNX0RFQlVHX0tNUygiW1BMQU5F OiVkOiVzXSBmYWlsZWQgdG8gY29tcHV0ZSB3YXRlcm1hcmsgbGV2ZWxzXG4iLAo+ID4gKwkJCQkg ICAgICBwbGFuZS0+YmFzZS5pZCwgcGxhbmUtPm5hbWUpOwo+ID4gIAkJCXJldHVybiByZXQ7Cj4g PiArCQl9Cj4gPiAgCj4gPiAgCQlza2xfY29tcHV0ZV90cmFuc2l0aW9uX3dtKGNzdGF0ZSwgJndt X3BhcmFtcywgJndtLT53bVswXSwKPiA+ICAJCQkJCSAgJndtLT50cmFuc193bSk7Cj4gPiBAQCAt NDk2OCwxMCArNDk2MywxMiBAQCBzdGF0aWMgaW50IHNrbF9idWlsZF9waXBlX3dtKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPiAgCQkJCXJldHVybiByZXQ7Cj4gPiAgCj4gPiAg CQkJcmV0ID0gc2tsX2NvbXB1dGVfd21fbGV2ZWxzKGRldl9wcml2LCBjc3RhdGUsCj4gPiAtCQkJ CQkJICAgIGludGVsX3BzdGF0ZSwgJndtX3BhcmFtcywKPiA+IC0JCQkJCQkgICAgd20sIDEpOwo+ ID4gLQkJCWlmIChyZXQpCj4gPiArCQkJCQkJICAgICZ3bV9wYXJhbXMsIHdtLCAxKTsKPiA+ICsJ CQlpZiAocmV0KSB7Cj4gPiArCQkJCURSTV9ERUJVR19LTVMoIltQTEFORTolZDolc10gZmFpbGVk IHRvIGNvbXB1dGUgcGxhbmFyIHdhdGVybWFyayBsZXZlbHNcbiIsCj4gPiArCQkJCQkgICAgICBw bGFuZS0+YmFzZS5pZCwgcGxhbmUtPm5hbWUpOwo+ID4gIAkJCQlyZXR1cm4gcmV0Owo+ID4gKwkJ CX0KPiA+ICAJCX0KPiA+ICAJfQo+ID4gIAo+ID4gLS0gCj4gPiAyLjE0LjQKPiA+IAo+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4g Cj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50 ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==