From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [RFC 2/8] drm/i915: Use the ddi_ports info to kill ugly CNL_WITH_PORT_F. Date: Fri, 19 Oct 2018 10:40:52 -0700 Message-ID: <20181019174052.GB3397@intel.com> References: <20181018233447.5187-1-rodrigo.vivi@intel.com> <20181018233447.5187-3-rodrigo.vivi@intel.com> <87woqegzb1.fsf@intel.com> <20181019164612.GA4548@ldmartin-desk.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A24F6E501 for ; Fri, 19 Oct 2018 17:40:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181019164612.GA4548@ldmartin-desk.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTksIDIwMTggYXQgMDk6NDY6MTNBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp IHdyb3RlOgo+IE9uIEZyaSwgT2N0IDE5LCAyMDE4IGF0IDEwOjM5OjQ2QU0gKzAzMDAsIEphbmkg TmlrdWxhIHdyb3RlOgo+ID4gT24gVGh1LCAxOCBPY3QgMjAxOCwgUm9kcmlnbyBWaXZpIDxyb2Ry aWdvLnZpdmlAaW50ZWwuY29tPiB3cm90ZToKPiA+ID4gTm93IHRoYXQgd2UgaGF2ZSB0aGUgbnVt YmVyIG9mIGRkaSBwb3J0cyBpbmZvcm1hdGlvbiBhdmFpbGFibGUKPiA+ID4gbGV0J3MgdXNlIGl0 IGluc3RlYWQgb2YgdGhhdCB1Z2x5IHBsYXRmb3JtIG1hY3JvLgo+ID4gPgo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgICAgIHwgMTAgKysrKysr KysrKwo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICAgICAgIHwgIDIg LS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgICAgICAgICB8ICA1ICsr LS0tCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICAgICAgICAgfCAgMiAr LQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jICAgIHwgIDIgKy0K PiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0uYyB8ICAyICstCj4g PiA+ICA2IGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4g PiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gPiBpbmRleCBiYWFjMzVmNjk4Zjku LjgzYWIzMjVjNjY3NSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiA+ IEBAIC0yMzksNiArMjM5LDE0IEBAIGludGVsX3ZpcnRfZGV0ZWN0X3BjaChjb25zdCBzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ICAJcmV0dXJuIGlkOwo+ID4gPiAgfQo+ ID4gPiAgCj4gPiA+ICtzdGF0aWMgdm9pZCBpbnRlbF9hZGp1c3Rfc2t1c19kaWZmZXJlbmNlcyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ICt7Cj4gPiA+ICsJLyogU29t ZSBDYW5ub25sYWtlIFNLVXMgaGF2ZSBQb3J0IEYgKi8KPiA+ID4gKwlpZiAoSVNfQ0FOTk9OTEFL RShkZXZfcHJpdikgJiYKPiA+ID4gKwkgICAgKElOVEVMX0RFVklEKGRldl9wcml2KSAmIDB4MDAw NCkgPT0gMHgwMDA0KQo+ID4gPiArCQlta3dyaXRlX2RldmljZV9pbmZvKGRldl9wcml2KS0+ZGRp X3BvcnRzID0gNjsKPiA+ID4gK30KPiA+IAo+ID4gSSdkIGxpa2UgcmVkdWNlIHRoZSBhbW91bnQg b2YgZGV2aWNlIGluZm8gc3R1ZmYgd2UgYWRqdXN0IGF0IHByb2JlLCBub3QKPiA+IGluY3JlYXNl Lgo+ID4gCj4gPiBMb25nIHRlcm0sIEknZCBsaWtlIHRvIG1ha2UgZGV2X3ByaXYtPmluZm8gYSBj b25zdCBwb2ludGVyIHRvIHRoZSBjb25zdAo+ID4gZGF0YSBpbiBpOTE1X3BjaS5jLCBhbmQgbWFr ZSBpdCB0cnVseSBpbW11dGFibGUuIFdlIGNvdWxkIGhhdmUgYW4KPiA+IGFkZGl0aW9uYWwgcnVu dGltZSBkZXZpY2UgaW5mbyB0byBjb21wbGVtZW50IHRoYXQsIGJ1dCB0aGlzIGFwcHJvYWNoCj4g PiBjYWxscyBmb3IgYSBtb3JlIGNvbmNyZXRlIHNwbGl0IGluIGNvbnN0IGFuZCBub24tY29uc3Qg ZGF0YSwgbm90ICJtb3N0bHkKPiA+IGNvbnN0IGJ1dCBzb21ldGltZXMgbXV0YWJsZSIuCj4gCj4g SSBhZ3JlZSB3aXRoIHRoaXMuIEknZCBhbHNvIGxpa2UgdG8gaGF2ZSBhIGNvbnN0IGRldl9pbmZv LiBXaGF0IEkgdGhpbmsgd2UgbmVlZCBpcyB0byBzcGxpdAo+IGluIHdoYXQgaXMgY29uc3Qgd2hh dCBjYW4gYmUgY2hhbmdlZCBpbiBydW50aW1lL2luaXRpYWxpemF0aW9uLgo+IAo+IEhvd2V2ZXIs IEknbSBub3QgZm9uZCBvbiB1c2luZyB0aGUgbnVtYmVyIG9mIGRkaSBwb3J0cyB0byB0YWtlIGRl Y2lzaW9ucyBpbiB0aGUgY29kZSBub3QKPiByZWxhdGVkIHRvIHRoZSBudW1iZXIgb2YgcG9ydHMs IGJ1dCByYXRoZXIgd2l0aCBvdGhlciB0aGluZ3Mgb2YgdGhhdCBza3UuIFNlZSBiZWxvdy4KPiAK PiA+IAo+ID4gSSB0aGluayBJJ3ZlIGNoYXR0ZWQgYWJvdXQgdGhpcyB3aXRoIENocmlzIHRvby4K PiA+IAo+ID4gQlIsCj4gPiBKYW5pLgo+ID4gCj4gPiA+ICsKPiA+ID4gIHN0YXRpYyB2b2lkIGlu dGVsX2RldGVjdF9wY2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAg ewo+ID4gPiAgCXN0cnVjdCBwY2lfZGV2ICpwY2ggPSBOVUxMOwo+ID4gPiBAQCAtOTA0LDYgKzkx Miw4IEBAIHN0YXRpYyBpbnQgaTkxNV9kcml2ZXJfaW5pdF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiA+ICAJaWYgKHJldCA8IDApCj4gPiA+ICAJCWdvdG8gZXJy X3dvcmtxdWV1ZXM7Cj4gPiA+ICAKPiA+ID4gKwlpbnRlbF9hZGp1c3Rfc2t1c19kaWZmZXJlbmNl cyhkZXZfcHJpdik7Cj4gPiA+ICsKPiA+ID4gIAkvKiBUaGlzIG11c3QgYmUgY2FsbGVkIGJlZm9y ZSBhbnkgY2FsbHMgdG8gSEFTX1BDSF8qICovCj4gPiA+ICAJaW50ZWxfZGV0ZWN0X3BjaChkZXZf cHJpdik7Cj4gPiA+ICAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiA+IGluZGV4IDdh ZDIzMjg0OTI2OC4uOTllNDJkZjc5ZWQ4IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmgKPiA+ID4gQEAgLTI0ODUsOCArMjQ4NSw2IEBAIGludGVsX2luZm8oY29uc3Qgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAgCQkJCSAoZGV2X3ByaXYpLT5pbmZv Lmd0ID09IDIpCj4gPiA+ICAjZGVmaW5lIElTX0NGTF9HVDMoZGV2X3ByaXYpCShJU19DT0ZGRUVM QUtFKGRldl9wcml2KSAmJiBcCj4gPiA+ICAJCQkJIChkZXZfcHJpdiktPmluZm8uZ3QgPT0gMykK PiA+ID4gLSNkZWZpbmUgSVNfQ05MX1dJVEhfUE9SVF9GKGRldl9wcml2KSAgIChJU19DQU5OT05M QUtFKGRldl9wcml2KSAmJiBcCj4gPiA+IC0JCQkJCShJTlRFTF9ERVZJRChkZXZfcHJpdikgJiAw eDAwMDQpID09IDB4MDAwNCkKPiA+ID4gIAo+ID4gPiAgI2RlZmluZSBJU19BTFBIQV9TVVBQT1JU KGludGVsX2luZm8pICgoaW50ZWxfaW5mbyktPmlzX2FscGhhX3N1cHBvcnQpCj4gPiA+ICAKPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiA+IGluZGV4IDVkMWY1MzcyMzM4OC4uNjNkNjc2 ZGUzODQwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiA+ID4gQEAgLTI3 ODIsOCArMjc4Miw3IEBAIGdlbjhfZGVfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LCB1MzIgbWFzdGVyX2N0bCkKPiA+ID4gIAkJCWlmIChJTlRFTF9HRU4oZGV2 X3ByaXYpID49IDExKQo+ID4gPiAgCQkJCXRtcF9tYXNrIHw9IElDTF9BVVhfQ0hBTk5FTF9FOwo+ ID4gPiAgCj4gPiA+IC0JCQlpZiAoSVNfQ05MX1dJVEhfUE9SVF9GKGRldl9wcml2KSB8fAo+ID4g PiAtCQkJICAgIElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gPiA+ICsJCQlpZiAoSU5URUxf SU5GTyhkZXZfcHJpdiktPmRkaV9wb3J0cyA+PSA2KQo+ID4gPiAgCQkJCXRtcF9tYXNrIHw9IENO TF9BVVhfQ0hBTk5FTF9GOwo+IAo+IG9rLCB0aGlzIGlzIGRpcmVjdGx5IHJlbGF0ZWQgdG8gdGhl IG51bWJlciBvZiBwb3J0cwo+IAo+ID4gPiAgCj4gPiA+ICAJCQlpZiAoaWlyICYgdG1wX21hc2sp IHsKPiA+ID4gQEAgLTQyMjAsNyArNDIxOSw3IEBAIHN0YXRpYyB2b2lkIGdlbjhfZGVfaXJxX3Bv c3RpbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ID4gIAlpZiAo SU5URUxfR0VOKGRldl9wcml2KSA+PSAxMSkKPiA+ID4gIAkJZGVfcG9ydF9tYXNrZWQgfD0gSUNM X0FVWF9DSEFOTkVMX0U7Cj4gPiA+ICAKPiA+ID4gLQlpZiAoSVNfQ05MX1dJVEhfUE9SVF9GKGRl dl9wcml2KSB8fCBJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ID4gPiArCWlmIChJTlRFTF9J TkZPKGRldl9wcml2KS0+ZGRpX3BvcnRzID49IDYpCj4gPiA+ICAJCWRlX3BvcnRfbWFza2VkIHw9 IENOTF9BVVhfQ0hBTk5FTF9GOwo+ID4gPiAgCj4gPiA+ICAJZGVfcGlwZV9lbmFibGVzID0gZGVf cGlwZV9tYXNrZWQgfCBHRU44X1BJUEVfVkJMQU5LIHwKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cC5jCj4gPiA+IGluZGV4IDMzODRhOWJiZGFmZC4uMGVhMDQxNGNjZWY0IDEwMDY0NAo+ID4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gQEAgLTQwMiw3ICs0MDIsNyBAQCBzdGF0aWMg aW50IGNubF9tYXhfc291cmNlX3JhdGUoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ID4g IAkJcmV0dXJuIDU0MDAwMDsKPiA+ID4gIAo+ID4gPiAgCS8qIEZvciB0aGlzIFNLVSA4LjFHIGlz IHN1cHBvcnRlZCBpbiBhbGwgcG9ydHMgKi8KPiA+ID4gLQlpZiAoSVNfQ05MX1dJVEhfUE9SVF9G KGRldl9wcml2KSkKPiA+ID4gKwlpZiAoSU5URUxfSU5GTyhkZXZfcHJpdiktPmRkaV9wb3J0cyA9 PSA2KQo+IAo+IHRoaXMgaXMgbm90LiBBbmQgYW55b25lIHJlYWRpbmcgdGhpcyB3aWxsIGhhdmUg dG8gY2hhc2UgYmFjayB3aGF0IGl0IG1lYW5zIHRvIGhhdmUgNiBkZGkgcG9ydHMgaGVyZS4KPiBT byB3ZSBtYXkgbmVlZCB0byBjcmVhdGUgYSBtb3JlIHVzZWZ1bCBtYWNybyAodGhhdCBjYW4gaW4g ZmFjdCBjaGVjayBieSB0aGUgbnVtYmVyIG9mIHBvcnRzKS4KPiBQbGFjZXMgaW4gd2hpY2ggdGhl IG51bWJlciBvZiBwb3J0cyBpcyBub3QgcmVsYXRlZCB0byB3aGF0J3MgYmVpbmcgY2hlY2tlZCB3 aWxsIGJlIG11Y2ggbW9yZQo+IGRpZmZpY3VsdCB0byBjaGVjayB0byBzdXBwb3J0IG5ld2VyIHBs YXRmb3Jtcy4gRXhwbGljaXQgdmFyaWFibGVzIGluIGRldl9pbmZvIHdvbid0LgoKbWFrZXMgc2Vu c2UuIEkgd2lsbCBjaGFuZ2UuCgo+IAo+IAo+ID4gPiAgCQlyZXR1cm4gODEwMDAwOwo+ID4gPiAg Cj4gPiA+ICAJLyogRm9yIG90aGVyIFNLVXMsIG1heCByYXRlIG9uIHBvcnRzIEEgYW5kIEQgaXMg NS40RyAqLwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90 cGx1Zy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gPiA+IGluZGV4 IDY0OGExM2M2MDQzYy4uMDVkMWZhZjc3MDQ4IDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfaG90cGx1Zy5jCj4gPiA+IEBAIC0xMDEsNyArMTAxLDcgQEAgZW51bSBocGRfcGlu IGludGVsX2hwZF9waW5fZGVmYXVsdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gPiA+ICAJY2FzZSBQT1JUX0U6Cj4gPiA+ICAJCXJldHVybiBIUERfUE9SVF9FOwo+ID4gPiAg CWNhc2UgUE9SVF9GOgo+ID4gPiAtCQlpZiAoSVNfQ05MX1dJVEhfUE9SVF9GKGRldl9wcml2KSkK PiA+ID4gKwkJaWYgKElTX0dFTjEwKGRldl9wcml2KSkKPiAKPiB0aGlzIHNlZW1zIHdyb25nLCBu bz8gbWlzc2luZyBhICYmIGRkaV9wb3J0cyA9PSA2PwoKbWF5YmUgcHJvYmFibHkgZGVzZXJ2ZXMg YSBzZXBhcmF0ZWQgcGF0Y2ggd2l0aCBwcm9wZXIgZXhwbGFuYXRpb24/CgpidXQgdGhlIG9ubHkg Y2FzZSB3ZXJlIHRoaXMgY2FzZSBQT1JUX0YgY2FuIGJlIHJlYWNoZWQKaXMgdGhhdCB0aGlzIGlz IGEgQ05MX1dJVEhfUE9SVF9GIG9yIHRoaXMgaXMgYW4gSUNFTEFLRS4uLgoKU28gdGhlIElTX0NB Tk5PTkxBS0Ugb3IgSVNfR0VOMTAgaXMgZW5vdWdoIGhlcmUuCgpJZiByZWd1bGFyIENOTCB3YXMg dGFraW5nIHRoaXMgcGF0aCBiZWZvcmUgdGhpcyBwYXRjaCBpdAp3b3VsZCBlbmQgd2l0aCBIUERf UE9SVF9GIHdoaWNoIGRvZXNuJ3QgZXhpc3QgaW4gYW55IGNubAphbnl3YXkuCgo+IAo+IEx1Y2Fz IERlIE1hcmNoaQo+IAo+ID4gPiAgCQkJcmV0dXJuIEhQRF9QT1JUX0U7Cj4gPiA+ICAJCXJldHVy biBIUERfUE9SVF9GOwo+ID4gPiAgCWRlZmF1bHQ6Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9ydW50aW1lX3BtLmMKPiA+ID4gaW5kZXggMzFhNDliZGNmMTkzLi44MGUxNGJlMTEyNzkg MTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3J1bnRpbWVfcG0u Ywo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiA+ ID4gQEAgLTMwOTksNyArMzA5OSw3IEBAIGludCBpbnRlbF9wb3dlcl9kb21haW5zX2luaXQoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAgCQkgKiB0aW1lb3V0cywgbGV0 cyByZW1vdmUgdGhlbSBmcm9tIHRoZSBsaXN0Cj4gPiA+ICAJCSAqIGZvciB0aGUgU0tVcyB3aXRo b3V0IHBvcnQgRi4KPiA+ID4gIAkJICovCj4gPiA+IC0JCWlmICghSVNfQ05MX1dJVEhfUE9SVF9G KGRldl9wcml2KSkKPiA+ID4gKwkJaWYgKElOVEVMX0lORk8oZGV2X3ByaXYpLT5kZGlfcG9ydHMg PT0gNSkKPiA+ID4gIAkJCXBvd2VyX2RvbWFpbnMtPnBvd2VyX3dlbGxfY291bnQgLT0gMjsKPiA+ ID4gIAo+ID4gPiAgCX0gZWxzZSBpZiAoSVNfQlJPWFRPTihkZXZfcHJpdikpIHsKPiA+IAo+ID4g LS0gCj4gPiBKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=