From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks Date: Tue, 23 Oct 2018 15:02:01 +0300 Message-ID: <20181023120201.GQ9144@intel.com> References: <20181016220133.26991-1-paulo.r.zanoni@intel.com> <20181016220133.26991-9-paulo.r.zanoni@intel.com> <20181018135552.GC9144@intel.com> <1540246947.2734.31.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDFFE6E1A2 for ; Tue, 23 Oct 2018 12:02:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1540246947.2734.31.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjIsIDIwMTggYXQgMDM6MjI6MjdQTSAtMDcwMCwgUGF1bG8gWmFub25pIHdy b3RlOgo+IEVtIFF1aSwgMjAxOC0xMC0xOCDDoHMgMTY6NTUgKzAzMDAsIFZpbGxlIFN5cmrDpGzD pCBlc2NyZXZldToKPiA+IE9uIFR1ZSwgT2N0IDE2LCAyMDE4IGF0IDAzOjAxOjMwUE0gLTA3MDAs IFBhdWxvIFphbm9uaSB3cm90ZToKPiA+ID4gUHJpbnQgYSBtb3JlIGdlbmVyaWMgImZhaWxlZCB0 byBjb21wdXRlIHdhdGVybWFyayBsZXZlbHMiIHdoZW5ldmVyCj4gPiA+IGFueQo+ID4gPiBvZiBz a2xfY29tcHV0ZV93bV9sZXZlbHMoKSBmYWlsLCBhbmQgcHJpbnQgb25seSB0aGUgc3BlY2lmaWMg ZXJyb3IKPiA+ID4gbWVzc2FnZSBmb3IgdGhlIHNwZWNpZmljIGNhc2VzLiBUaGlzIGFsbG93cyB1 cyB0byBzdG9wIHBhc3NpbmcKPiA+ID4gcHN0YXRlCj4gPiA+IGV2ZXJ5d2hlcmUsIG1ha2luZyB0 aGUgd2F0ZXJtYXJrcyBjb21wdXRhdGlvbiBjb2RlIGEgbGl0dGxlIGxlc3MKPiA+ID4gZGVwZW5k ZW50IG9uIHJhbmRvbSBpbnRlbCBzdGF0ZSBzdHJ1Y3RzLgo+ID4gCj4gPiBOb3RoaW5nIHJhbmRv bSBhYm91dCB0aG9zZSBzdHJ1Y3RzLiBUaGV5IGFyZSAqdGhlKiBzdGF0ZS4KPiAKPiBXaGF0IEkn bSBhYm91dCB0byBzYXkgaXMgYWxsIHByb2JhYmx5IGEgcmVmbGV4IG9mIG15IG93biBpbmNvbXBl dGVuY2UKPiB0byB1bmRlcnN0YW5kIHRoZSBmbG93cyBvZiBvdXIgY29kZSwgYnV0IGhlcmUgaXQg Z29lcy4KPiAKPiAxLiBUaGVyZSdzIGR1cGxpY2F0aW9uIGluIHRob3NlIHN0cnVjdHMuIEF0IGFu eSBnaXZlbiBwb2ludCBvZiBvdXIKPiBzb3VyY2UgY29kZSwgc2hvdWxkIHlvdSB1c2Ugc3RhdGUg c3RydWN0cyBwYXNzZWQgYXMgcGFyYW1ldGVycywgb3IKPiBzaG91bGQgeW91IHVzZSBvYmplY3Qt PnN0YXRlIChlLmcuLCBpbnRlbF9jcnRjLT5zdGF0ZSk/IFNvbWV0aW1lcyBvbmUKPiB0aGluZyBp cyB0aGUgbmV3IHN0YXRlIGFuZCB0aGUgb3RoZXIgdGhpbmcgaXMgdGhlIG9sZCBzdGF0ZSwgc29t ZXRpbWVzCj4gaXQgaXMgdGhlIG9wcG9zaXRlLCBhbmQgY2hlY2tpbmcgd2hpY2ggb25lIGlzIHdo aWNoIGlzIG5ldmVyIHRyaXZpYWwuCgpUaGF0IHdhcyBzb2x2ZWQgd2l0aCB0aGUgbWxhbmtob3Jz dCBpdGVyYXRvcnMuIFNvIG5vIG1vcmUgZm9vLT5zdGF0ZSwKZXhjZXB0IGR1cmluZyByZWFkb3V0 IHNpbmNlIHdlIGRvbid0IGN1cnJlbnRseSBhbGxvY2F0ZSBuZXcgc3RhdGVzCmZvciB0aGF0LgoK PiBJCj4gYWx3YXlzIGhhdmUgdG8gZ28gYmFjayB0byBpbnRlbF9kaXNwbGF5LmMgYW5kIHRyeSB0 byBmaW5kIHRoYXQgcG9pbnQgaW4KPiB0aGUgbW9kZXNldCB3aGVyZSB3ZSBhc3NpZ24gY3J0Y19j b25maWcgdG8gY3J0Yy0+Y29uZmlnIGFuZCB0aGVuIHRyeSB0bwo+IGZpZ3VyZSBvdXQgaWYgbXkg Y29kZSBydW5zIGJlZm9yZSBvciBhZnRlciB0aGF0IHBvaW50LiBBbmQgSSdtIG5ldmVyCj4gMTAw JSBjb25maWRlbnQgSSdtIHVzaW5nIHRoZSBjb3JyZWN0IHN0cnVjdC4KCkFuZCBNYWFydGVuIGhh cyBiZWVuIGJ1c3kgZWxpbW5pbmF0aW5nIGNydGMtPmNvbmZpZyBhcyB3ZWxsLiBOb3QgdG9vCm1h bnkgdXNlcyBsZWZ0IEkgaG9wZS4KCj4gCj4gMi4gVGhlcmUncyBhIGxvdCBvZiBkdXBsaWNhdGlv biBpbiBtZW1iZXJzIG9mIHRob3NlIHN0cnVjdHMuIFRoZXJlIGFyZQo+IGxpa2UgNSBkaWZmZXJl bnQgdGhpbmdzIHRoYXQgY291bGQgbWVhbiAicGl4ZWwgcmF0ZSIgKGZvciByZWFsIG1vZGUsCj4g Zm9yIGFkanVzdGVkIG1vZGUsIGNvbnNpZGVyaW5nL25vdC1jb25zaWRlcmluZyBzY2FsaW5nLCBy b3RhdGlvbiwgZXRjKSwKPiB0aGVyZSBhcmUgbWFueSB0aGluZ3MgdGhhdCBjb3VsZCBtZWFuICJz b3VyY2Ugd2lkdGgiLCBldGMuIFNvIHdoZW4geW91Cj4gbmVlZCBhIHNwZWNpZmljIHZhbHVlLCBp dCdzIG5vdCBhbHdheXMgY2xlYXIgd2hlcmUgdG8gZ2V0IGl0IGZyb20gaW4KPiBvdXIgZHJpdmVy Lgo+IAo+IDMuIFRoZSBuYW1lcyBpbnNpZGUgdGhlIHdhdGVybWFya3MgY2FsY3VsYXRpb24gcGFn ZSAob3IgYW55d2hlcmUgZWxzZQo+IGluIG91ciBzcGVjKSBkb24ndCBlYXNpbHkgdHJhbnNsYXRl IHRvIGFueSBvZiB0aG9zZSBzdHJ1Y3QgbWVtYmVycwo+IG1lbnRpb25lZCBpbiBpdGVtIDIuIEUu Zy4sIHBsYW5lIHBpeGVsIHJhdGUuCj4gCj4gSSBtZWFuLCBsb29rIGF0IGhvdyBtYW55IHRpbWVz IHRoZSBzcGVjIChub3Qgb25seSBmb3Igd2F0ZXJtYXJrcywgYnV0Cj4gZm9yIG90aGVyIHN0dWZm IHRvbywgbGlrZSBGQkMgYW5kIFBTUikgaGFkIHdvcmRpbmcgbGlrZSAic291cmNlIHNpemUiCj4g YW5kIHdlIGZldGNoZWQgdGhlIHZhbHVlIGZyb20gb25lIHBsYWNlLCBidXQgdGhlbiB3ZSBsZWFy bmVkIHRoYXQgd2UKPiBuZWVkZWQgdG8gZmV0Y2ggdGhlIHZhbHVlIGZyb20gdGhpcyBvdGhlciBw bGFjZSB0aGF0IHdhcyB0aGUgc2FtZSBpbgo+IG1vc3QgY2FzZXMgZXhjZXB0IGZvciB0aGVzZSBY IGFuZCBZIGNvcm5lciBjYXNlcy4gWW91IHJldmlld2VkIHNvbWUgb2YKPiB0aG9zZSBwYXRjaGVz LgoKSSBkb24ndCByZWNhbGwgbWFueSBjb3JuZXIgY2FzZXMuIFdlbGwsIEkgZ3Vlc3MgeW91IGNh biBjb3VudCB0aGUKY3Vyc29yIGFzIG9uZS4gQnV0IHRoYXQncyBhYm91dCBpdCBJIHRoaW5rLgoK Um90YXRpb24gd2FzIG1heWJlIHRoZSBvbmUgdGhhdCBjYXVzZWQgdGhlIG1vc3QgY29uZnVzaW9u IGJ1dCBJIHRoaW5rCnRoYXQgd2FzIGJlY2F1c2UgdGhlIHNwZWMgd2FzIHZlcnkgdmFndWUuIE9u ZSBhY3R1YWxseSBoYXMgdG8gdGhpbmsKYSBiaXQgdG8gZmlndXJlIG91dCBpZiBpdCdzIHJlZmVy cmluZyB0byB0aGUgZmIgb3JpZW50YXRpb24gb3IgdGhlCnNjYW5vdXQgb3JpZW50YXRpb24uCgo+ IAo+IFNvLCB0byBjb25jbHVkZSB0aGUgYXJndW1lbnQsIHRoZSBuaWNlIHRoaW5nIGFib3V0IHN0 cnVjdCBza2xfd21fcGFyYW1zCj4gaXMgdGhhdCBpdCBhbGxvd3MgdXMgdG8gaGF2ZSBhIHNpbmds ZSBwb2ludCB3aGVyZSB3ZSB0cmFuc2xhdGUgImk5MTUKPiB0ZXJtaW5vbG9neSIgdG8gIndhdGVy bWFya3MgY2FsY3VsYXRpb24gYWxnb3JpdGhtIHRlcm1pbm9sb2d5Iiwgc28gd2UKPiBjYW4gZml4 IHRoYXQgc2luZ2xlIHBsYWNlIGlmL3doZW4gbmVlZGVkLgoKVGhhdCBjYW4gdXN1YWxseSBiZSBz b2x2ZWQgd2l0aCBmdW5jdGlvbnMgYXMgd2VsbC4KCj4gQW5kIHRoZW4gZXZlcnl3aGVyZSBlbHNl IGluCj4gd2F0ZXJtYXJrcyBjb2RlIHdlIGp1c3QgZmV0Y2ggdGhlIHZhbHVlIGZyb20gdGhpcyBz dHJ1Y3Qgd2l0aG91dCBoYXZpbmcKPiB0byB3b3JyeSAiYXQgdGhpcyBwb2ludCBpbiB0aGUgc2Vx dWVuY2UsIHdoZXJlIHNob3VsZCB0aGlzIHZhbHVlIGNvbWUKPiBmcm9tPyIsIGFsbG93aW5nIHVz IHRvIGZvY3VzIG9uIHRoZSBhbGdvcml0aG0gc3BlY2lmaWNhbGx5LiBPbiB0b3Agb2YKPiB0aGF0 LCB0aGVyZSdzIHRoZSBmYWN0IHRoYXQgd2Ugb25seSBjb21wdXRlIHRoaW5ncyBvbmNlIGluc3Rl YWQgb2YgdXAKPiB0byA4IHRpbWVzIHBlciBwbGFuZSAoNyBsZXZlbHMgKyB0cmFuc2l0aW9uIHdh dGVybWFya3MpLgo+IAo+IE9mIGNvdXJzZSwgdGhlIGRvd25zaWRlIGlzIHRoYXQgd2UgYWRkcmVz cyB0aGUgcHJvYmxlbSBvZiAidG9vIG1hbnkKPiBwbGFjZXMgdG8gZmV0Y2ggaW5mb3JtYXRpb24g ZnJvbSIgYnkgaW50cm9kdWNpbmcgYSBuZXcgcGxhY2Ugd2hlcmUKPiBpbmZvcm1hdGlvbiBpcyBm ZXRjaGVkIGZyb20sIHNvIEkgZGVmaW5pdGVseSBjYW4ndCBhcmd1ZSB0aGF0IHRoZQo+IGN1cnJl bnQgc29sdXRpb24gaXMgZ29vZCBlaXRoZXIuIEkgd291bGQgcmVhbGx5IGxpa2UgdG8ga25vdyB3 aGF0IGFyZQo+IHlvdXIgcHJvcG9zYWxzIGhlcmU6IGlmIHdlIGRlY2lkZSB0byByZW1vdmUgdGhl IHBhcmFtcyBzdHJ1Y3QsIHdvdWxkCj4geW91IHN1Z2dlc3Qgd2Ugc2ltcGx5IGZldGNoIGV2ZXJ5 dGhpbmcgZGlyZWN0bHkgZnJvbSB0aGUgcGFzc2VkIHN0cnVjdHMKPiBhbmQgcmVjb21wdXRlIGFs bCB0aGUgdmFsdWVzIHRoYXQgYXJlIGNvbXB1dGVkIG11bHRpcGxlIHRpbWVzPyBJJ20KPiB0b3Rh bGx5IHdpbGxpbmcgdG8gaW1wbGVtZW50IHNvbWV0aGluZyBiZXR0ZXIgaWYgeW91IGhhdmUgaXQg aW4geW91cgo+IGhlYWQuCgpUaGUgImxldCdzIG5vdCByZWNvbXB1dGUgdGhlIHNhbWUgdGhpbmcg bWFueSB0aW1lcyIgYXJndW1lbnQgbWF5CmhhdmUgc29tZSBtZXJpdC4gVGhvdWdoIG1vc3QgdGhp bmdzIGFyZSBwZXJoYXBzIGNoZWFwIGVub3VnaCB0byBub3QKbWF0dGVyIG11Y2guIEFuZCB3ZSBj b3VsZCBhbHdheXMgc3RpY2sgbW9yZSBzdHVmZiBpbnRvIHRoZSBwbGFuZS9jcnRjCnN0YXRlcy4K CkJ1dCBJIGRvbid0IGhhdmUgYW55IGNvbmNyZXRlIHByb3Bvc2FscyBhdCB0aGlzIHRpbWUuIEkn dmUgdHJpZWQgdG8Kc3RheSBhd2F5IGZyb20gdGhlIHNrbCB3bSBjb2RlIGFzIG11Y2ggYXMgcG9z c2libGUgc28gYXMgdG8gbm90IGdldAphbiB1cmdlIHRvIHJld3JpdGUgaXQgOlAKCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==