From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [RFC 2/3] drm/i915: Prefer IS_GEN<n> check with
 bitmask.
Date: Fri, 26 Oct 2018 12:55:43 -0700
Message-ID: <20181026195543.GJ2232@intel.com>
References: <20181023233620.10159-1-rodrigo.vivi@intel.com>
 <20181023233620.10159-2-rodrigo.vivi@intel.com>
 <20181024102257.GZ9144@intel.com> <20181024234106.GK3942@intel.com>
 <20181025105903.GI9144@intel.com>
 <alpine.DEB.2.21.1810251210240.2640@hadrien>
 <20181026194055.GI2232@intel.com>
 <alpine.DEB.2.21.1810262146220.2791@hadrien>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 67E886E54E
 for <intel-gfx@lists.freedesktop.org>; Fri, 26 Oct 2018 19:55:47 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1810262146220.2791@hadrien>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBPY3QgMjYsIDIwMTggYXQgMDk6NDc6MDVQTSArMDIwMCwgSnVsaWEgTGF3YWxsIHdy
b3RlOgo+IAo+IAo+IE9uIEZyaSwgMjYgT2N0IDIwMTgsIFJvZHJpZ28gVml2aSB3cm90ZToKPiAK
PiA+IE9uIFRodSwgT2N0IDI1LCAyMDE4IGF0IDEyOjExOjU3UE0gKzAxMDAsIEp1bGlhIExhd2Fs
bCB3cm90ZToKPiA+ID4KPiA+ID4KPiA+ID4gT24gVGh1LCAyNSBPY3QgMjAxOCwgVmlsbGUgU3ly
asOkbMOkIHdyb3RlOgo+ID4gPgo+ID4gPiA+IE9uIFdlZCwgT2N0IDI0LCAyMDE4IGF0IDA0OjQx
OjA2UE0gLTA3MDAsIFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gPiA+IE9uIFdlZCwgT2N0IDI0
LCAyMDE4IGF0IDAxOjIyOjU3UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4g
PiA+ID4gT24gVHVlLCBPY3QgMjMsIDIwMTggYXQgMDQ6MzY6MTlQTSAtMDcwMCwgUm9kcmlnbyBW
aXZpIHdyb3RlOgo+ID4gPiA+ID4gPiA+IFdoZW5ldmVyIHBvc3NpYmxlIHdlIHNob3VsZCBzdGlj
ayB3aXRoIElTX0dFTjxuPiBjaGVja3MuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBCaXRt
YWtzIGhhcyBiZWVuIGludHJvZHVjZWQgb24gY29tbWl0IGFlNzYxN2YwZWYxOCAoImRybS9pOTE1
Ogo+ID4gPiA+ID4gPiA+IEFsbG93IG9wdGltaXplZCBwbGF0Zm9ybSBjaGVja3MiKSBmb3IgZWZm
aWNpZW5jeS4KPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IExldCdzIHN0aWNrIHdpdGggaXQg
d2hlbmV2ZXIgcG9zc2libGUuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBUaGlzIHBhdGNo
IHdhcyBnZW5lcmF0ZWQgd2l0aCBjb2NjaW5lbGxlOgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+
ID4gc3BhdGNoIC1zcF9maWxlIGlzX2dlbi5jb2NjaSAqe2MsaH0gLS1pbi1wbGFjZQo+ID4gPiA+
ID4gPiA+Cj4gPiA+ID4gPiA+ID4gaXNfZ2VuLmNvY2NpOgo+ID4gPiA+ID4gPiA+IEBnZW4yQCBl
eHByZXNzaW9uIGU7IEBACj4gPiA+ID4gPiA+ID4gLUlOVEVMX0dFTihlKSA9PSAyCj4gPiA+ID4g
PiA+ID4gK0lTX0dFTjIoZSkKPiA+ID4gPiA+ID4gPiBAZ2VuM0AgZXhwcmVzc2lvbiBlOyBAQAo+
ID4gPiA+ID4gPiA+IC1JTlRFTF9HRU4oZSkgPT0gMwo+ID4gPiA+ID4gPiA+ICtJU19HRU4zKGUp
Cj4gPiA+ID4gPiA+ID4gQGdlbjRAIGV4cHJlc3Npb24gZTsgQEAKPiA+ID4gPiA+ID4gPiAtSU5U
RUxfR0VOKGUpID09IDQKPiA+ID4gPiA+ID4gPiArSVNfR0VONChlKQo+ID4gPiA+ID4gPiA+IEBn
ZW41QCBleHByZXNzaW9uIGU7IEBACj4gPiA+ID4gPiA+ID4gLUlOVEVMX0dFTihlKSA9PSA1Cj4g
PiA+ID4gPiA+ID4gK0lTX0dFTjUoZSkKPiA+ID4gPiA+ID4gPiBAZ2VuNkAgZXhwcmVzc2lvbiBl
OyBAQAo+ID4gPiA+ID4gPiA+IC1JTlRFTF9HRU4oZSkgPT0gNgo+ID4gPiA+ID4gPiA+ICtJU19H
RU42KGUpCj4gPiA+ID4gPiA+ID4gQGdlbjdAIGV4cHJlc3Npb24gZTsgQEAKPiA+ID4gPiA+ID4g
PiAtSU5URUxfR0VOKGUpID09IDcKPiA+ID4gPiA+ID4gPiArSVNfR0VONyhlKQo+ID4gPiA+ID4g
PiA+IEBnZW44QCBleHByZXNzaW9uIGU7IEBACj4gPiA+ID4gPiA+ID4gLUlOVEVMX0dFTihlKSA9
PSA4Cj4gPiA+ID4gPiA+ID4gK0lTX0dFTjgoZSkKPiA+ID4gPiA+ID4gPiBAZ2VuOUAgZXhwcmVz
c2lvbiBlOyBAQAo+ID4gPiA+ID4gPiA+IC1JTlRFTF9HRU4oZSkgPT0gOQo+ID4gPiA+ID4gPiA+
ICtJU19HRU45KGUpCj4gPiA+ID4gPiA+ID4gQGdlbjEwQCBleHByZXNzaW9uIGU7IEBACj4gPiA+
ID4gPiA+ID4gLUlOVEVMX0dFTihlKSA9PSAxMAo+ID4gPiA+ID4gPiA+ICtJU19HRU4xMChlKQo+
ID4gPiA+ID4gPiA+IEBnZW4xMUAgZXhwcmVzc2lvbiBlOyBAQAo+ID4gPiA+ID4gPiA+IC1JTlRF
TF9HRU4oZSkgPT0gMTEKPiA+ID4gPiA+ID4gPiArSVNfR0VOMTEoZSkKPiA+ID4gPiA+ID4KPiA+
ID4gPiA+ID4gU2xpZ2h0bHkgbGVzcyByZXBldGl0aXZlIHZlcnNpb24uCj4gPiA+ID4gPgo+ID4g
PiA+ID4gVGhhbmtzLiBJJ20gc3VwcGVyIG5ld2JpZSBvbiBjb2NjaW5lbGxlIGFuZCBpdCB3YXMK
PiA+ID4gPiA+IGVhc2llciB0byBkdXBsaWNhdGUgdGhlbiB0cnlpbmcgdG8gbGVhcm4gYWxsIHRo
aXMgbmV3IGxhbmcuCj4gPiA+ID4gPgo+ID4gPiA+ID4gQnV0IEkgcmVhbGx5IGFwcHJlY2lhdGUg
eW91IHNoYXJpbmcgdGhpcy4gSSdkIGxpa2UKPiA+ID4gPiA+IHRvIGdvIHdpdGggdGhpcyBzbyB0
aGUgYmV0dGVyIHJ1bGUga2VlcHMgb24gY29tbWl0IG1lc3NhZ2UuCj4gPiA+ID4gPgo+ID4gPiA+
ID4gPiBTYWRseSBub3Qgc3VwZXIgbmVhdCBvbgo+ID4gPiA+ID4gPiBhY2NvdW50IG9mIGhhdmlu
ZyB0byB1c2UgdGhlIHB5dGhvbiBzdHVmZi4KPiA+ID4gPiA+Cj4gPiA+ID4gPiBob3dldmVyIGl0
IHNlZW1zIHB5dGhvbiB2ZXJzaW9uIGRpZG4ndCB3b3JrIHNvIHdlbGwgaGVyZToKPiA+ID4gPiA+
Cj4gPiA+ID4gPiBpbml0X2RlZnNfYnVpbHRpbnM6IC91c3IvbGliNjQvY29jY2luZWxsZS9zdGFu
ZGFyZC5oCj4gPiA+ID4gPiBQeXRob24gZXJyb3I6IE5vIG1vZHVsZSBuYW1lZCBjb2NjaWxpYi5l
bGVtcwo+ID4gPiA+ID4KPiA+ID4gPiA+IGRvIHlvdSBoYXZlIGFueSBpZGVhIGFib3V0IGl0Pwo+
ID4gPiA+Cj4gPiA+ID4gTmV2ZXIgc2VlbiBpdC4gT24gZ2VudG9vIGl0IGp1c3Qgd29ya3Mgd2hl
biBJIGhhdmUgdGhlIHB5dGhvbgo+ID4gPiA+IHVzZSBmbGFnIGVuYWJsZWQuCj4gPiA+ID4KPiA+
ID4gPiBNYXliZSB5b3VyIGRpc3RybyBkb2Vzbid0IGluY2x1ZGUgdGhlIHB5dGhvbiBzdXBwb3J0
IGluIHRoZQo+ID4gPiA+IGJ1aWxkLCBvciBtYXliZSBzb21lIGtpbmQgb2YgcHl0aG9uIHZlcnNp
b24gaXNzdWU/Cj4gPiA+Cj4gPiA+IFRoYW5rcyBmb3IgdGhlIHJlcG9ydC4gIEkgd2lsbCBoYXZl
IHNvbWVvbmUgbG9vayBpbnRvIGl0LiAgSXQncyBhbgo+ID4gPiBpbnRlcm5hbCBDb2NjaW5lbGxl
IHRoaW5nLiAgUGVyaGFwcyBweXRob24gaXMgbm90IGVuYWJsZWQuICBEbyB5b3UgaGF2ZQo+ID4g
PiB0aGUgdmVyc2lvbiBvZiBDb2NjaW5lbGxlIGZyb20gZ2l0aHViPwo+ID4KPiA+IEkganVzdCB0
cmllZCB3aXRoIGNvY2NpbmVsbGUgZnJvbSBnaXRodWIgYnV0IGdvdCBzYW1lIHJlc3VsdC4KPiA+
Cj4gPiBCdXQgd2l0aCB0aGlzIGNvbW1pdCBiZWZvcmUgdGhlIGJ1bXAgdG8gYXV0b21ha2UxLjE2
Ogo+ID4KPiA+IGNvbW1pdCA0ZGI5NTk5ODc2ODU1N2M2NmQ2ZTMzN2JlMjI1MzAzMmI1ZDgxMGJj
IChIRUFEIC0+IG1hc3RlcikKPiA+IEF1dGhvcjogVGhpZXJyeSBNYXJ0aW5leiA8dGhpZXJyeS5t
YXJ0aW5lekBpbnJpYS5mcj4KPiA+IERhdGU6ICAgV2VkIFNlcCAxMiAxNDo0Mzo0MSAyMDE4ICsw
MjAwCj4gPgo+ID4gICAgIENvbXB1dGUgZGVwZW5kIGJ5IGNhbGxpbmcgbWFrZSByZWN1cnNpbGV2
eQo+ID4KPiA+ICAgICBUaGUgc2V0IG9mIGZpbGVzIGluICQoc291cmNlX2ZpbGVzKSBtYXkgY2hh
bmdlIHdoZW4gdGhlIHRhcmJhbGwgaXMKPiA+ICAgICB1bnBhY2tlZC4KPiA+Cj4gPiAtLS0tCj4g
Pgo+ID4gJCBweXRob24gLS12ZXJzaW9uCj4gPiBQeXRob24gMi43LjE1Cj4gPiAkIHB5dGhvbjMg
LS12ZXJzaW9uCj4gPiBQeXRob24gMy42LjYKPiA+Cj4gPiAtLS0tCj4gPgo+ID4gSSBiZWxpZXZl
IEknbSBtb3ZpbmcgdGhpcyBwYXRjaCB3aXRoIHRoZSByZXBldGl0aXZlIGJhZAo+ID4gcnVsZSBm
b3Igbm93IHRoYXQgSSdtIHN1cmUgaXQgd29ya3MgaW4gbW9zdCBvZiB0aGUgZGlzdHJvcy4KPiAK
PiBTb3JyeSwgSSdtIG5vdCBzdXJlIHRvIHVuZGVyc3RhbmQgdGhlIGxhc3Qgc2VudGVuY2UuIEFy
ZSB0aGluZ3Mgb2sgbm93LCBvcgo+IG5vdD8KCldlbGwsIEknZCBsaWtlIHRvIGxlYXJuIG1vcmUg
YW5kIGJlIGFibGUgdG8gcnVuIHRoZSBweXRob24gcnVsZXMKb24gbXkgc3lzdGVtLiBTbyBpZiB5
b3Ugc3RpbGwgaGF2ZSBhbnkgaWRlYSBJJ2QgbGlrZSB0byBsaXN0ZW4uCgpCdXQgSSBkb24ndCBz
ZWUgYW55IHJ1c2ggb24gdGhhdCBzaW5jZSBmb3IgdGhpcyBwYXRjaAp3ZSBjYW4gZ28gd2l0aCB0
aGUgc2ltcGxlIHJlcGV0aXRpdmUgcnVsZSB0aGF0IHdvcmtzIG9uIGRlZmF1bHQKY29jY2luZWxs
ZSB0aGF0IGNvbWVzIHdpdGggZmVkb3JhIDI4LgoKSW4gb3RoZXIgd29yZHMsIGZvciB0aGlzIHBh
dGNoIHdlIGFyZSBnb29kLgoKRm9yIHRoZSBmdXR1cmUgSSdkIGxpa2UgdG8gbGVhcm4sIGJ1dCB3
aXRoIG5vIHByZXNzdXJlIG9yIHJ1c2ghCgpJIHJlYWxseSBhcHByZWNpYXRlIHlvdXIgc3VwcG9y
dAoKVGhhbmtzIGEgbG90LApSb2RyaWdvLgoKPiAKPiB0aGFua3MsCj4ganVsaWEKCl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n
IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk
ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=