From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Switch the order of function parameters Date: Mon, 29 Oct 2018 16:18:58 +0200 Message-ID: <20181029141858.GM9144@intel.com> References: <20181026195342.16828-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECB3F89F6D for ; Mon, 29 Oct 2018 14:19:01 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181026195342.16828-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMjYsIDIwMTggYXQgMTI6NTM6NDJQTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBpbnRlbF9mYl9waXRjaF9saW1pdCgpIGhhcyB0aGUgcGFyYW1ldGVycyBw aXhlbF9mb3JtYXQgYW5kIGZiX21vZGlmaWVyCj4gc3dpdGNoZWQgaW4gdGhlaXIgcG9zaXRpb25z LiBUaGUgcGFyYW1ldGVycyBhcmUgaG93ZXZlciB1c2VkIGNvcnJlY3RseSwKPiBidXQgY2hhbmdl IHRoZSBvcmRlciBmb3IgY29uc2lzdGVuY3kuCj4gCj4gQWxzbyB1c2Uga2VybmVsIGRhdGEgdHlw ZXMgZm9yIGJvdGggcGFyYW1ldGVycy4KPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRp eWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KClJldmlld2VkLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNiArKystLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCj4gaW5kZXggZmUwNDVhYmI2NDcyLi5lNzUyMTY2NGE3MjQgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTE0MzQ2LDcgKzE0MzQ2LDcg QEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZnJhbWVidWZmZXJfZnVuY3MgaW50ZWxfZmJfZnVu Y3MgPSB7Cj4gIAo+ICBzdGF0aWMKPiAgdTMyIGludGVsX2ZiX3BpdGNoX2xpbWl0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJIHVpbnQ2NF90IGZiX21vZGlmaWVyLCB1 aW50MzJfdCBwaXhlbF9mb3JtYXQpCj4gKwkJCSB1MzIgcGl4ZWxfZm9ybWF0LCB1NjQgZmJfbW9k aWZpZXIpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICAJc3RydWN0IGludGVs X3BsYW5lICpwbGFuZTsKPiBAQCAtMTQ0NDYsOCArMTQ0NDYsOCBAQCBzdGF0aWMgaW50IGludGVs X2ZyYW1lYnVmZmVyX2luaXQoc3RydWN0IGludGVsX2ZyYW1lYnVmZmVyICppbnRlbF9mYiwKPiAg CQlnb3RvIGVycjsKPiAgCX0KPiAgCj4gLQlwaXRjaF9saW1pdCA9IGludGVsX2ZiX3BpdGNoX2xp bWl0KGRldl9wcml2LCBtb2RlX2NtZC0+bW9kaWZpZXJbMF0sCj4gLQkJCQkJICAgbW9kZV9jbWQt PnBpeGVsX2Zvcm1hdCk7Cj4gKwlwaXRjaF9saW1pdCA9IGludGVsX2ZiX3BpdGNoX2xpbWl0KGRl dl9wcml2LCBtb2RlX2NtZC0+cGl4ZWxfZm9ybWF0LAo+ICsJCQkJCSAgIG1vZGVfY21kLT5tb2Rp ZmllclswXSk7Cj4gIAlpZiAobW9kZV9jbWQtPnBpdGNoZXNbMF0gPiBwaXRjaF9saW1pdCkgewo+ ICAJCURSTV9ERUJVR19LTVMoIiVzIHBpdGNoICgldSkgbXVzdCBiZSBhdCBtb3N0ICVkXG4iLAo+ ICAJCQkgICAgICBtb2RlX2NtZC0+bW9kaWZpZXJbMF0gIT0gRFJNX0ZPUk1BVF9NT0RfTElORUFS ID8KPiAtLSAKPiAyLjE0LjEKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==