From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v6 27/28] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable Date: Tue, 30 Oct 2018 13:26:42 +0200 Message-ID: <20181030112642.GR9144@intel.com> References: <20181024222840.25683-1-manasi.d.navare@intel.com> <20181024222840.25683-28-manasi.d.navare@intel.com> <20181029203921.GQ9144@intel.com> <20181029213536.GB27040@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181029213536.GB27040@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjksIDIwMTggYXQgMDI6MzU6MzZQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBPbiBNb24sIE9jdCAyOSwgMjAxOCBhdCAxMDozOToyMVBNICswMjAwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPiBPbiBXZWQsIE9jdCAyNCwgMjAxOCBhdCAwMzoyODozOVBNIC0w NzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ID4gPiBEU0MgY2FuIGJlIHN1cHBvcnRlZCBwZXIg RFAgY29ubmVjdG9yLiBUaGlzIHBhdGNoIGFkZHMgYSBwZXIgY29ubmVjdG9yCj4gPiA+IGRlYnVn ZnMgbm9kZSB0byBleHBvc2UgRFNDIHN1cHBvcnQgY2FwYWJpbGl0eSBieSB0aGUga2VybmVsLgo+ ID4gPiBUaGUgc2FtZSBub2RlIGNhbiBiZSB1c2VkIGZyb20gdXNlcnNwYWNlIHRvIGZvcmNlIERT QyBlbmFibGUuCj4gPiAKPiA+IFdoeSBpcyB0aGUgZm9yY2VfZHNjIHRoaW5nIHNwbGl0IGJldHdl ZW4gdHdvIHBhdGNoZXMgc28gc3RyYW5nZWx5Pwo+IAo+IFRoaXMgcGF0Y2gganVzdCBkZWZpbmVz IHRoZSBmb3JjZV9kc2MgYW5kIHNldHMgaXQgdGhyb3VnaCB0aGUgZGVidWdmcwo+IG5vZGUuIEJ1 dCBob3cgaXQgY29uZmlndXJlcyBEU0MgZHVyaW5nIGF0b21pYyBjaGVjayBpcyBtb3ZlZCB0byBh Cj4gc2VwYXJhdGUgcGF0Y2guIAo+IFdvdWxkIHlvdSBwcmVmZXIgaGF2aW5nIHRoYXQgaW50ZWdy YXRlZCB3aXRoIHRoaXMgcGF0Y2ggaXRzZWxmPwoKRWl0aGVyIHRoYXQgb3Igc3BsaXQgaXQgaW4g aW50byAicmVhZCBvbmx5IGRlYnVnZnMgc3RhdHVzIiArCiJhZGQgZHNjX2ZvcmNlIiBwYXRjaGVz LgoKPiAKPiBNYW5hc2kKPiAKPiA+IAo+ID4gPiAKPiA+ID4gdjI6Cj4gPiA+ICogVXNlIGtzdHJ0 b2Jvb2xfZnJvbV91c2VyIHRvIGF2b2lkIGV4cGxpY2l0IGVycm9yIGNoZWNraW5nIChMeXVkZSkK PiA+ID4gKiBSZWJhc2Ugb24gZHJtLXRpcCAoTWFuYXNpKQo+ID4gPiAKPiA+ID4gQ2M6IFJvZHJp Z28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+ID4gQ2M6IFZpbGxlIFN5cmphbGEg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiBDYzogQW51c2hhIFNyaXZhdHNh IDxhbnVzaGEuc3JpdmF0c2FAaW50ZWwuY29tPgo+ID4gPiBDYzogTHl1ZGUgUGF1bCA8bHl1ZGVA cmVkaGF0LmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQu bmF2YXJlQGludGVsLmNvbT4KPiA+ID4gUmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJl ZGhhdC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1 Z2ZzLmMgfCA3MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ID4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgfCAgMSArCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCAgICB8ICAzICsrCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDc0IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZGVidWdmcy5jCj4gPiA+IGluZGV4IDVjYWRmY2QwM2VhOS4uNmU2MzFmMDhkZDRiIDEwMDY0 NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ID4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ID4gPiBAQCAtNDk5OSw2 ICs0OTk5LDcyIEBAIHN0YXRpYyBpbnQgaTkxNV9oZGNwX3NpbmtfY2FwYWJpbGl0eV9zaG93KHN0 cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkKPiA+ID4gIH0KPiA+ID4gIERFRklORV9TSE9X X0FUVFJJQlVURShpOTE1X2hkY3Bfc2lua19jYXBhYmlsaXR5KTsKPiA+ID4gIAo+ID4gPiArc3Rh dGljIGludCBpOTE1X2RzY19zdXBwb3J0X3Nob3coc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpk YXRhKQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IgPSBt LT5wcml2YXRlOwo+ID4gPiArCXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0gaW50ZWxf YXR0YWNoZWRfZW5jb2Rlcihjb25uZWN0b3IpOwo+ID4gPiArCXN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAgPQo+ID4gPiArCQllbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJhc2UpOwo+ID4gPiAr CXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ID4gPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlOwo+ID4gPiArCj4gPiA+ICsJY3J0YyA9IHRvX2ludGVsX2NydGMoZW5jb2Rl ci0+YmFzZS5jcnRjKTsKPiA+ID4gKwljcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShj cnRjLT5iYXNlLnN0YXRlKTsKPiA+ID4gKwlkcm1fbW9kZXNldF9sb2NrKCZjcnRjLT5iYXNlLm11 dGV4LCBOVUxMKTsKPiA+ID4gKwlzZXFfcHJpbnRmKG0sICJFbmFibGVkOiAlc1xuIiwKPiA+ID4g KwkJICAgeWVzbm8oY3J0Y19zdGF0ZS0+ZHNjX3BhcmFtcy5jb21wcmVzc2lvbl9lbmFibGUpKTsK PiA+ID4gKwlzZXFfcHJpbnRmKG0sICJTdXBwb3J0ZWQ6ICVzXG4iLAo+ID4gPiArCQkgICB5ZXNu byhkcm1fZHBfc2lua19zdXBwb3J0c19kc2MoaW50ZWxfZHAtPmRzY19kcGNkKSkpOwo+ID4gPiAr CWRybV9tb2Rlc2V0X3VubG9jaygmY3J0Yy0+YmFzZS5tdXRleCk7Cj4gPiA+ICsKPiA+ID4gKwly ZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGljIHNzaXplX3QgaTkxNV9kc2Nf c3VwcG9ydF93cml0ZShzdHJ1Y3QgZmlsZSAqZmlsZSwKPiA+ID4gKwkJCQkgICAgICBjb25zdCBj aGFyIF9fdXNlciAqdWJ1ZiwKPiA+ID4gKwkJCQkgICAgICBzaXplX3QgbGVuLCBsb2ZmX3QgKm9m ZnApCj4gPiA+ICt7Cj4gPiA+ICsJYm9vbCBkc2NfZW5hYmxlID0gZmFsc2U7Cj4gPiA+ICsJaW50 IHJldDsKPiA+ID4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0KPiA+ID4gKwkJ KChzdHJ1Y3Qgc2VxX2ZpbGUgKilmaWxlLT5wcml2YXRlX2RhdGEpLT5wcml2YXRlOwo+ID4gPiAr CXN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyID0gaW50ZWxfYXR0YWNoZWRfZW5jb2Rlcihj b25uZWN0b3IpOwo+ID4gPiArCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50 ZWxfZHAoJmVuY29kZXItPmJhc2UpOwo+ID4gPiArCj4gPiA+ICsJaWYgKGxlbiA9PSAwKQo+ID4g PiArCQlyZXR1cm4gMDsKPiA+ID4gKwo+ID4gPiArCURSTV9ERUJVR19EUklWRVIoIkNvcGllZCAl ZCBieXRlcyBmcm9tIHVzZXIgdG8gZm9yY2UgRFNDXG4iLAo+ID4gPiArCQkJICh1bnNpZ25lZCBp bnQpbGVuKTsKPiA+ID4gKwo+ID4gPiArCXJldCA9IGtzdHJ0b2Jvb2xfZnJvbV91c2VyKHVidWYs IGxlbiwgJmRzY19lbmFibGUpOwo+ID4gPiArCWlmIChyZXQgPCAwKQo+ID4gPiArCQlyZXR1cm4g cmV0Owo+ID4gPiArCj4gPiA+ICsJRFJNX0RFQlVHX0RSSVZFUigiR290ICVzIGZvciBEU0MgRW5h YmxlXG4iLAo+ID4gPiArCQkJIChkc2NfZW5hYmxlKSA/ICJ0cnVlIiA6ICJmYWxzZSIpOwo+ID4g PiArCWludGVsX2RwLT5mb3JjZV9kc2NfZW4gPSBkc2NfZW5hYmxlOwo+ID4gPiArCj4gPiA+ICsJ Km9mZnAgKz0gbGVuOwo+ID4gPiArCXJldHVybiBsZW47Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4g K3N0YXRpYyBpbnQgaTkxNV9kc2Nfc3VwcG9ydF9vcGVuKHN0cnVjdCBpbm9kZSAqaW5vZGUsCj4g PiA+ICsJCQkJIHN0cnVjdCBmaWxlICpmaWxlKQo+ID4gPiArewo+ID4gPiArCXJldHVybiBzaW5n bGVfb3BlbihmaWxlLCBpOTE1X2RzY19zdXBwb3J0X3Nob3csCj4gPiA+ICsJCQkgICBpbm9kZS0+ aV9wcml2YXRlKTsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBm aWxlX29wZXJhdGlvbnMgaTkxNV9kc2Nfc3VwcG9ydF9mb3BzID0gewo+ID4gPiArCS5vd25lciA9 IFRISVNfTU9EVUxFLAo+ID4gPiArCS5vcGVuID0gaTkxNV9kc2Nfc3VwcG9ydF9vcGVuLAo+ID4g PiArCS5yZWFkID0gc2VxX3JlYWQsCj4gPiA+ICsJLmxsc2VlayA9IHNlcV9sc2VlaywKPiA+ID4g KwkucmVsZWFzZSA9IHNpbmdsZV9yZWxlYXNlLAo+ID4gPiArCS53cml0ZSA9IGk5MTVfZHNjX3N1 cHBvcnRfd3JpdGUKPiA+ID4gK307Cj4gPiA+ICsKPiA+ID4gIC8qKgo+ID4gPiAgICogaTkxNV9k ZWJ1Z2ZzX2Nvbm5lY3Rvcl9hZGQgLSBhZGQgaTkxNSBzcGVjaWZpYyBjb25uZWN0b3IgZGVidWdm cyBmaWxlcwo+ID4gPiAgICogQGNvbm5lY3RvcjogcG9pbnRlciB0byBhIHJlZ2lzdGVyZWQgZHJt X2Nvbm5lY3Rvcgo+ID4gPiBAQCAtNTAxNyw5ICs1MDgzLDEyIEBAIGludCBpOTE1X2RlYnVnZnNf Y29ubmVjdG9yX2FkZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ID4gPiAgCQly ZXR1cm4gLUVOT0RFVjsKPiA+ID4gIAo+ID4gPiAgCWlmIChjb25uZWN0b3ItPmNvbm5lY3Rvcl90 eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9EaXNwbGF5UG9ydCB8fAo+ID4gPiAtCSAgICBjb25u ZWN0b3ItPmNvbm5lY3Rvcl90eXBlID09IERSTV9NT0RFX0NPTk5FQ1RPUl9lRFApCj4gPiA+ICsJ ICAgIGNvbm5lY3Rvci0+Y29ubmVjdG9yX3R5cGUgPT0gRFJNX01PREVfQ09OTkVDVE9SX2VEUCkg ewo+ID4gPiAgCQlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJpOTE1X2RwY2QiLCBTX0lSVUdPLCByb290 LAo+ID4gPiAgCQkJCSAgICBjb25uZWN0b3IsICZpOTE1X2RwY2RfZm9wcyk7Cj4gPiA+ICsJCWRl YnVnZnNfY3JlYXRlX2ZpbGUoImk5MTVfZHNjX3N1cHBvcnQiLCBTX0lSVUdPLCByb290LAo+ID4g PiArCQkJCSAgICBjb25uZWN0b3IsICZpOTE1X2RzY19zdXBwb3J0X2ZvcHMpOwo+ID4gPiArCX0K PiA+ID4gIAo+ID4gPiAgCWlmIChjb25uZWN0b3ItPmNvbm5lY3Rvcl90eXBlID09IERSTV9NT0RF X0NPTk5FQ1RPUl9lRFApIHsKPiA+ID4gIAkJZGVidWdmc19jcmVhdGVfZmlsZSgiaTkxNV9wYW5l bF90aW1pbmdzIiwgU19JUlVHTywgcm9vdCwKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4g PiA+IGluZGV4IDcyZTY2MDVmMGVkNy4uMGI1OTM5OTkyYzJiIDEwMDY0NAo+ID4gPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gQEAgLTIyODcsNiArMjI4Nyw3IEBAIGludGVsX2RwX2Nv bXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gPiAgCWlmIChh ZGp1c3RlZF9tb2RlLT5mbGFncyAmIERSTV9NT0RFX0ZMQUdfREJMQ0xLKQo+ID4gPiAgCQlyZXR1 cm4gZmFsc2U7Cj4gPiA+ICAKPiA+ID4gKwlEUk1fREVCVUdfS01TKCJGb3JjZSBEU0MgZW4gPSAl ZFxuIiwgaW50ZWxfZHAtPmZvcmNlX2RzY19lbik7Cj4gPiA+ICAJaWYgKCFpbnRlbF9kcF9jb21w dXRlX2xpbmtfY29uZmlnKGVuY29kZXIsIHBpcGVfY29uZmlnKSkKPiA+ID4gIAkJcmV0dXJuIGZh bHNlOwo+ID4gPiAgCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiA+IGluZGV4IDRm NWQxN2JjZDU0ZS4uMTZiYmMzNzY4ZTAyIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcnYuaAo+ID4gPiBAQCAtMTE5Niw2ICsxMTk2LDkgQEAgc3RydWN0IGludGVsX2RwIHsKPiA+ ID4gIAo+ID4gPiAgCS8qIERpc3BsYXlwb3J0IGNvbXBsaWFuY2UgdGVzdGluZyAqLwo+ID4gPiAg CXN0cnVjdCBpbnRlbF9kcF9jb21wbGlhbmNlIGNvbXBsaWFuY2U7Cj4gPiA+ICsKPiA+ID4gKwkv KiBEaXNwbGF5IHN0cmVhbSBjb21wcmVzc2lvbiB0ZXN0aW5nICovCj4gPiA+ICsJYm9vbCBmb3Jj ZV9kc2NfZW47Cj4gPiA+ICB9Owo+ID4gPiAgCj4gPiA+ICBlbnVtIGxzcGNvbl92ZW5kb3Igewo+ ID4gPiAtLSAKPiA+ID4gMi4xOC4wCj4gPiAKPiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4g PiBJbnRlbAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK