From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v4 4/5] drm/i915: Clarify flow for disabling IRQs on storms Date: Tue, 6 Nov 2018 15:51:07 +0200 Message-ID: <20181106135107.GT9144@intel.com> References: <20181105222011.2913-1-lyude@redhat.com> <20181105222011.2913-5-lyude@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181105222011.2913-5-lyude@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude Paul Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDU6MjA6MTBQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBUaGlzIGlzIHJhdGhlciBjb25mdXNpbmcgdG8gbG9vayBhdCBhcy1pczoKPiBkZXZfcHJp di0+ZGlzcGxheS5ocGRfaXJxX3NldHVwKGRldl9wcml2KTsgaW4gaW50ZWxfaHBkX2lycV9oYW5k bGVyKCkKPiBoYW5kbGVzIGRpc2FibGluZyB0aGUgYWN0dWFsIEhQRCBJUlEsIHdoaWxlCj4gaW50 ZWxfaHBkX2lycV9zdG9ybV9kaXNhYmxlKCkgaGFuZGxlcyBtb3ZpbmcgdGhlIEhQRCBwaW4gc3Rh dGUgb3ZlciBmcm9tCj4gTUFSS19ESVNBQkxFRCB0byBESVNBQkxFRCBhbG9uZyB3aXRoIGVuYWJs aW5nIHBvbGxpbmcgZm9yIGl0Lgo+IAo+IENoYW5nZXMgc2luY2UgdjM6Cj4gLSBSZW5hbWUgaTkx NV9ocGRfaXJxX3N0b3JtX2Rpc2FibGUoKSB0bwo+ICAgaTkxNV9ocGRfaXJxX3N0b3JtX3N3aXRj aF90b19wb2xsaW5nKCkgLSBSb2RyaWdvIFZpdmkKPiAKPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVs IDxseXVkZUByZWRoYXQuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl bC5jb20+CgpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hvdHBsdWcu YyB8IDExICsrKysrKysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2hvdHBsdWcuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hvdHBsdWcuYwo+IGluZGV4 IGMxMWQ3M2RlMTZmMi4uZDY0MmMwNzk1NDUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2hvdHBsdWcuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2hvdHBsdWcuYwo+IEBAIC0xNjEsNyArMTYxLDggQEAgc3RhdGljIGJvb2wgaW50ZWxfaHBkX2ly cV9zdG9ybV9kZXRlY3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJcmV0 dXJuIHN0b3JtOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBpbnRlbF9ocGRfaXJxX3N0b3JtX2Rp c2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtzdGF0aWMgdm9pZAo+ ICtpbnRlbF9ocGRfaXJxX3N0b3JtX3N3aXRjaF90b19wb2xsaW5nKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZf cHJpdi0+ZHJtOwo+ICAJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqaW50ZWxfY29ubmVjdG9yOwo+ IEBAIC0zNTEsOCArMzUyLDggQEAgc3RhdGljIHZvaWQgaTkxNV9ob3RwbHVnX3dvcmtfZnVuYyhz dHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAlocGRfZXZlbnRfYml0cyA9IGRldl9wcml2LT5o b3RwbHVnLmV2ZW50X2JpdHM7Cj4gIAlkZXZfcHJpdi0+aG90cGx1Zy5ldmVudF9iaXRzID0gMDsK PiAgCj4gLQkvKiBEaXNhYmxlIGhvdHBsdWcgb24gY29ubmVjdG9ycyB0aGF0IGhpdCBhbiBpcnEg c3Rvcm0uICovCj4gLQlpbnRlbF9ocGRfaXJxX3N0b3JtX2Rpc2FibGUoZGV2X3ByaXYpOwo+ICsJ LyogRW5hYmxlIHBvbGxpbmcgZm9yIGNvbm5lY3RvcnMgd2hpY2ggaGFkIEhQRCBJUlEgc3Rvcm1z ICovCj4gKwlpbnRlbF9ocGRfaXJxX3N0b3JtX3N3aXRjaF90b19wb2xsaW5nKGRldl9wcml2KTsK PiAgCj4gIAlzcGluX3VubG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gIAo+IEBAIC00 NTgsNiArNDU5LDEwIEBAIHZvaWQgaW50ZWxfaHBkX2lycV9oYW5kbGVyKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQl9Cj4gIAl9Cj4gIAo+ICsJLyoKPiArCSAqIERpc2Fi bGUgYW55IElSUXMgdGhhdCBzdG9ybXMgd2VyZSBkZXRlY3RlZCBvbi4gUG9sbGluZyBlbmFibGVt ZW50Cj4gKwkgKiBoYXBwZW5zIGxhdGVyIGluIG91ciBob3RwbHVnIHdvcmsuCj4gKwkgKi8KPiAg CWlmIChzdG9ybV9kZXRlY3RlZCAmJiBkZXZfcHJpdi0+ZGlzcGxheV9pcnFzX2VuYWJsZWQpCj4g IAkJZGV2X3ByaXYtPmRpc3BsYXkuaHBkX2lycV9zZXR1cChkZXZfcHJpdik7Cj4gIAlzcGluX3Vu bG9jaygmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiAtLSAKPiAyLjE5LjEKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg==