From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/14] drm/i915: Introduce crtc_state->update_planes bitmask Date: Thu, 8 Nov 2018 13:32:02 +0200 Message-ID: <20181108113202.GR9144@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-10-ville.syrjala@linux.intel.com> <20181107214939.GL2237@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FB3C6E605 for ; Thu, 8 Nov 2018 11:32:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181107214939.GL2237@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDcsIDIwMTggYXQgMDE6NDk6MzlQTSAtMDgwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjA2OjAwUE0gKzAyMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBLZWVwIHRyYWNrIHdoaWNoIHBsYW5lcyBuZWVkIHVwZGF0 aW5nIGR1cmluZyB0aGUgY29tbWl0LiBGb3Igbm93IHRoaXMKPiA+IGlzIGp1c3QgKHdhc192aXNp YmxlIHx8IGlzX3Zpc2libGUpIGJ1dCBJJ2xsIGhhdmUgbmVlZCB0byB1cGRhdGUKPiA+IGludmlz aWJsZSBwbGFuZXMgbGF0ZXIgb24gZm9yIHNrbCBwbGFuZSBkZGJzIGFuZCBmb3IgcHJlLXNrbCBw aXBlCj4gPiBnYW1tYS9jc2MgY29udHJvbCAod2hpY2ggbGl2ZXMgaW4gdGhlIHByaW1hcnkgcGxh bmUgY29udHJvbCByZWdpc3RlcikuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYyAgICAgICB8IDEgKwo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgICAgIHwgNSArKysrLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgICAgIHwgMyArKysKPiA+ICA0IGZpbGVzIGNo YW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPiBpbmRleCBhNWEyYzhmZTU4YTcuLjhjYjAyZjI4ZDMw YyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWMuYwo+ID4gQEAgLTE4NCw2 ICsxODQsNyBAQCBpbnRlbF9jcnRjX2R1cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNy dGMpCj4gPiAgCWNydGNfc3RhdGUtPmZpZm9fY2hhbmdlZCA9IGZhbHNlOwo+ID4gIAljcnRjX3N0 YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBkYXRlID0gZmFsc2U7Cj4gPiAgCWNydGNfc3RhdGUtPmZi X2JpdHMgPSAwOwo+ID4gKwljcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzID0gMDsKPiA+ICAKPiA+ ICAJcmV0dXJuICZjcnRjX3N0YXRlLT5iYXNlOwo+ID4gIH0KPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiBpbmRleCA3ZDM2ODUwNzUyMDEuLjAxMDI2OWEx MjM5MCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19w bGFuZS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUu Ywo+ID4gQEAgLTEzNyw2ICsxMzcsOSBAQCBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrX3dp dGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjXwo+ID4gIAlp ZiAoc3RhdGUtPnZpc2libGUgJiYgc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCA9PSBEUk1fRk9S TUFUX05WMTIpCj4gPiAgCQljcnRjX3N0YXRlLT5udjEyX3BsYW5lcyB8PSBCSVQoaW50ZWxfcGxh bmUtPmlkKTsKPiA+ICAKPiA+ICsJaWYgKHN0YXRlLT52aXNpYmxlIHx8IG9sZF9wbGFuZV9zdGF0 ZS0+YmFzZS52aXNpYmxlKQo+ID4gKwkJY3J0Y19zdGF0ZS0+dXBkYXRlX3BsYW5lcyB8PSBCSVQo aW50ZWxfcGxhbmUtPmlkKTsKPiA+ICsKPiA+ICAJcmV0dXJuIGludGVsX3BsYW5lX2F0b21pY19j YWxjX2NoYW5nZXMob2xkX2NydGNfc3RhdGUsCj4gPiAgCQkJCQkgICAgICAgJmNydGNfc3RhdGUt PmJhc2UsCj4gPiAgCQkJCQkgICAgICAgb2xkX3BsYW5lX3N0YXRlLAo+ID4gQEAgLTE3MSwxNCAr MTc0LDExIEBAIHZvaWQgaW50ZWxfdXBkYXRlX3BsYW5lc19vbl9jcnRjKHN0cnVjdCBpbnRlbF9h dG9taWNfc3RhdGUgKm9sZF9zdGF0ZSwKPiA+ICAJCQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpvbGRfY3J0Y19zdGF0ZSwKPiA+ICAJCQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdf Y3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiArCXUzMiB1cGRhdGVfbWFzayA9IG5ld19jcnRjX3N0YXRl LT51cGRhdGVfcGxhbmVzOwo+ID4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm5ld19wbGFu ZV9zdGF0ZTsKPiA+ICAJc3RydWN0IGludGVsX3BsYW5lICpwbGFuZTsKPiA+IC0JdTMyIHVwZGF0 ZV9tYXNrOwo+ID4gIAlpbnQgaTsKPiA+ICAKPiA+IC0JdXBkYXRlX21hc2sgPSBvbGRfY3J0Y19z dGF0ZS0+YWN0aXZlX3BsYW5lczsKPiA+IC0JdXBkYXRlX21hc2sgfD0gbmV3X2NydGNfc3RhdGUt PmFjdGl2ZV9wbGFuZXM7Cj4gPiAtCj4gCj4gbWF5YmUgdGhpcyB1c2VsZXNzIHVwZGF0ZV9tYXNr IHJlbW92YWwgZGVzZXJ2ZWQgYSBzZXBhcmF0ZWQgcGF0Y2gsCj4gYnV0IG5vdCBhIGJpZyBkZWFs Li4uCgpJdCdzIHN0aWxsIHRoZXJlLCBqdXN0IHBvcHVsYXRlZCBkaWZmZXJlbnRseS4KCj4gCj4g PiAgCWZvcl9lYWNoX25ld19pbnRlbF9wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5lLCBu ZXdfcGxhbmVfc3RhdGUsIGkpIHsKPiA+ICAJCWlmIChjcnRjLT5waXBlICE9IHBsYW5lLT5waXBl IHx8Cj4gPiAgCQkgICAgISh1cGRhdGVfbWFzayAmIEJJVChwbGFuZS0+aWQpKSkKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDg1MmI1ODk3ZTgwYi4uMzNkNzM5 MTViNzNlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBA IC0xMDc5Nyw4ICsxMDc5NywxMCBAQCBzdGF0aWMgaW50IGljbF9jaGVja19udjEyX3BsYW5lcyhz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJCQljb250aW51ZTsKPiA+ ICAKPiA+ICAJCXBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmUgPSBOVUxMOwo+ID4gLQkJaWYgKHBs YW5lX3N0YXRlLT5zbGF2ZSAmJiAhcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSkKPiA+ICsJCWlm IChwbGFuZV9zdGF0ZS0+c2xhdmUgJiYgIXBsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUpIHsKPiA+ ICAJCQljcnRjX3N0YXRlLT5hY3RpdmVfcGxhbmVzICY9IH5CSVQocGxhbmUtPmlkKTsKPiA+ICsJ CQljcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9IEJJVChwbGFuZS0+aWQpOwo+ID4gKwkJfQo+ ID4gIAo+ID4gIAkJcGxhbmVfc3RhdGUtPnNsYXZlID0gZmFsc2U7Cj4gPiAgCX0KPiA+IEBAIC0x MDgzOSw2ICsxMDg0MSw3IEBAIHN0YXRpYyBpbnQgaWNsX2NoZWNrX252MTJfcGxhbmVzKHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gIAkJbGlua2VkX3N0YXRlLT5zbGF2 ZSA9IHRydWU7Cj4gPiAgCQlsaW5rZWRfc3RhdGUtPmxpbmtlZF9wbGFuZSA9IHBsYW5lOwo+ID4g IAkJY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyB8PSBCSVQobGlua2VkLT5pZCk7Cj4gPiArCQlj cnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9IEJJVChsaW5rZWQtPmlkKTsKPiA+ICAJCURSTV9E RUJVR19LTVMoIlVzaW5nICVzIGFzIFkgcGxhbmUgZm9yICVzXG4iLCBsaW5rZWQtPmJhc2UubmFt ZSwgcGxhbmUtPmJhc2UubmFtZSk7Cj4gPiAgCX0KPiA+ICAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rydi5oCj4gPiBpbmRleCA1MzMxYmJlZDVlOGMuLjdhNTVmNTkyMWQzNCAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ID4gQEAgLTkyNSw2ICs5MjUsOSBAQCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSB7Cj4gPiAgCXU4IGFjdGl2ZV9wbGFuZXM7Cj4gPiAgCXU4IG52MTJfcGxh bmVzOwo+ID4gIAo+ID4gKwkvKiBiaXRtYXNrIG9mIHBsYW5lcyB0aGF0IHdpbGwgYmUgdXBkYXRl ZCBkdXJpbmcgdGhlIGNvbW1pdCAqLwo+IAo+IEkgbm90aWNlZCBob3cgYmFkIHdlIGFyZSB3aXRo IGRvY3VtZW50YXRpb24gY29tcGFyZWQgdG8gdGhlIHJlc3Qgb2YgZHJtCj4gc3RydWN0cyA6Lwo+ IAo+IGJ1dCBJJ20gZ2xhZCB5b3UgYWRkZWQgdGhlIGV4cGxhbmF0aW9uIGluIHRoZSBjb21tZW50 IGhlcmUuCj4gCj4gUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVs LmNvbT4KPiAKPiA+ICsJdTggdXBkYXRlX3BsYW5lczsKPiA+ICsKPiA+ICAJLyogSERNSSBzY3Jh bWJsaW5nIHN0YXR1cyAqLwo+ID4gIAlib29sIGhkbWlfc2NyYW1ibGluZzsKPiA+ICAKPiA+IC0t IAo+ID4gMi4xOC4xCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK