From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/14] drm/i915: Introduce crtc_state->update_planes bitmask Date: Fri, 9 Nov 2018 15:57:01 +0200 Message-ID: <20181109135701.GH9144@intel.com> References: <20181101150605.18235-1-ville.syrjala@linux.intel.com> <20181101150605.18235-10-ville.syrjala@linux.intel.com> <20181108232227.GG27871@mdroper-desk.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 491E56E535 for ; Fri, 9 Nov 2018 13:57:05 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20181108232227.GG27871@mdroper-desk.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDgsIDIwMTggYXQgMDM6MjI6MjdQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBPbiBUaHUsIE5vdiAwMSwgMjAxOCBhdCAwNTowNjowMFBNICswMjAwLCBWaWxsZSBTeXJq YWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiA+IAo+ID4gS2VlcCB0cmFjayB3aGljaCBwbGFuZXMgbmVlZCB1cGRhdGlu ZyBkdXJpbmcgdGhlIGNvbW1pdC4gRm9yIG5vdyB0aGlzCj4gPiBpcyBqdXN0ICh3YXNfdmlzaWJs ZSB8fCBpc192aXNpYmxlKSBidXQgSSdsbCBoYXZlIG5lZWQgdG8gdXBkYXRlCj4gCj4gV2hlbiBn ZW4xMSBudjEyIGlzIGluIHVzZSwgaXQgYWxzbyBjb250YWlucyB3YXNfc2xhdmUgfHwgaXNfc2xh dmUgYXMKPiB3ZWxsLCByaWdodD8KPiAKPiA+IGludmlzaWJsZSBwbGFuZXMgbGF0ZXIgb24gZm9y IHNrbCBwbGFuZSBkZGJzIGFuZCBmb3IgcHJlLXNrbCBwaXBlCj4gPiBnYW1tYS9jc2MgY29udHJv bCAod2hpY2ggbGl2ZXMgaW4gdGhlIHByaW1hcnkgcGxhbmUgY29udHJvbCByZWdpc3RlcikuCj4g PiAKPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9t aWMuYyAgICAgICB8IDEgKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19w bGFuZS5jIHwgOCArKysrLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyAgICAgIHwgNSArKysrLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o ICAgICAgICAgIHwgMyArKysKPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4g PiBpbmRleCBhNWEyYzhmZTU4YTcuLjhjYjAyZjI4ZDMwYyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pYy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9hdG9taWMuYwo+ID4gQEAgLTE4NCw2ICsxODQsNyBAQCBpbnRlbF9jcnRjX2R1 cGxpY2F0ZV9zdGF0ZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gPiAgCWNydGNfc3RhdGUtPmZp Zm9fY2hhbmdlZCA9IGZhbHNlOwo+ID4gIAljcnRjX3N0YXRlLT53bS5uZWVkX3Bvc3R2YmxfdXBk YXRlID0gZmFsc2U7Cj4gPiAgCWNydGNfc3RhdGUtPmZiX2JpdHMgPSAwOwo+ID4gKwljcnRjX3N0 YXRlLT51cGRhdGVfcGxhbmVzID0gMDsKPiA+ICAKPiA+ICAJcmV0dXJuICZjcnRjX3N0YXRlLT5i YXNlOwo+ID4gIH0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9h dG9taWNfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5j Cj4gPiBpbmRleCA3ZDM2ODUwNzUyMDEuLjAxMDI2OWExMjM5MCAxMDA2NDQKPiA+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ID4gQEAgLTEzNyw2ICsxMzcsOSBA QCBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGlu dGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjXwo+ID4gIAlpZiAoc3RhdGUtPnZpc2libGUgJiYgc3Rh dGUtPmZiLT5mb3JtYXQtPmZvcm1hdCA9PSBEUk1fRk9STUFUX05WMTIpCj4gPiAgCQljcnRjX3N0 YXRlLT5udjEyX3BsYW5lcyB8PSBCSVQoaW50ZWxfcGxhbmUtPmlkKTsKPiA+ICAKPiA+ICsJaWYg KHN0YXRlLT52aXNpYmxlIHx8IG9sZF9wbGFuZV9zdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gKwkJ Y3J0Y19zdGF0ZS0+dXBkYXRlX3BsYW5lcyB8PSBCSVQoaW50ZWxfcGxhbmUtPmlkKTsKPiA+ICsK PiA+ICAJcmV0dXJuIGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMob2xkX2NydGNfc3Rh dGUsCj4gPiAgCQkJCQkgICAgICAgJmNydGNfc3RhdGUtPmJhc2UsCj4gPiAgCQkJCQkgICAgICAg b2xkX3BsYW5lX3N0YXRlLAo+ID4gQEAgLTE3MSwxNCArMTc0LDExIEBAIHZvaWQgaW50ZWxfdXBk YXRlX3BsYW5lc19vbl9jcnRjKHN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSwK PiA+ICAJCQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiA+ICAJ CQkJIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiAr CXUzMiB1cGRhdGVfbWFzayA9IG5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzOwo+ID4gIAlz dHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKm5ld19wbGFuZV9zdGF0ZTsKPiA+ICAJc3RydWN0IGlu dGVsX3BsYW5lICpwbGFuZTsKPiA+IC0JdTMyIHVwZGF0ZV9tYXNrOwo+ID4gIAlpbnQgaTsKPiA+ ICAKPiA+IC0JdXBkYXRlX21hc2sgPSBvbGRfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lczsKPiA+ IC0JdXBkYXRlX21hc2sgfD0gbmV3X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXM7Cj4gPiAtCj4g PiAgCWZvcl9lYWNoX25ld19pbnRlbF9wbGFuZV9pbl9zdGF0ZShvbGRfc3RhdGUsIHBsYW5lLCBu ZXdfcGxhbmVfc3RhdGUsIGkpIHsKPiA+ICAJCWlmIChjcnRjLT5waXBlICE9IHBsYW5lLT5waXBl IHx8Cj4gPiAgCQkgICAgISh1cGRhdGVfbWFzayAmIEJJVChwbGFuZS0+aWQpKSkKPiA+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IDg1MmI1ODk3ZTgwYi4uMzNkNzM5 MTViNzNlIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBA IC0xMDc5Nyw4ICsxMDc5NywxMCBAQCBzdGF0aWMgaW50IGljbF9jaGVja19udjEyX3BsYW5lcyhz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJCQljb250aW51ZTsKPiA+ ICAKPiA+ICAJCXBsYW5lX3N0YXRlLT5saW5rZWRfcGxhbmUgPSBOVUxMOwo+ID4gLQkJaWYgKHBs YW5lX3N0YXRlLT5zbGF2ZSAmJiAhcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSkKPiA+ICsJCWlm IChwbGFuZV9zdGF0ZS0+c2xhdmUgJiYgIXBsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUpIHsKPiA+ ICAJCQljcnRjX3N0YXRlLT5hY3RpdmVfcGxhbmVzICY9IH5CSVQocGxhbmUtPmlkKTsKPiA+ICsJ CQljcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9IEJJVChwbGFuZS0+aWQpOwo+IAo+IEp1c3Qg dG8gY2xhcmlmeSwgdGhpcyBpcyB0byBlbnN1cmUgdGhhdCB3ZSBjbGVhciBvdXQgdGhlIHJlZ2lz dGVyCj4gcHJvZ3JhbW1pbmcgb2YgYSBwbGFuZSB0aGF0IHdhcyBhbiBudjEyIHNsYXZlIG9uIHRo ZSBwcmV2aW91cyBmcmFtZSwgYnV0Cj4gaXNuJ3QgYW55IGxvbmdlciBvbiB0aGUgY3VycmVudCBm cmFtZSwgYW5kIC4uLgo+IAo+IAo+ID4gKwkJfQo+ID4gIAo+ID4gIAkJcGxhbmVfc3RhdGUtPnNs YXZlID0gZmFsc2U7Cj4gPiAgCX0KPiA+IEBAIC0xMDgzOSw2ICsxMDg0MSw3IEBAIHN0YXRpYyBp bnQgaWNsX2NoZWNrX252MTJfcGxhbmVzKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQo+ID4gIAkJbGlua2VkX3N0YXRlLT5zbGF2ZSA9IHRydWU7Cj4gPiAgCQlsaW5rZWRfc3Rh dGUtPmxpbmtlZF9wbGFuZSA9IHBsYW5lOwo+ID4gIAkJY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5l cyB8PSBCSVQobGlua2VkLT5pZCk7Cj4gPiArCQljcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9 IEJJVChsaW5rZWQtPmlkKTsKPiAKPiAuLi4gdGhpcyBpcyB0byBlbnN1cmUgd2Ugc2V0dXAgdGhl IHByb2dyYW1taW5nIGZvciBhbnkgbmV3IHNsYXZlIHBsYW5lcz8KClllcy4KCj4gCj4gCj4gTWF0 dAo+IAo+ID4gIAkJRFJNX0RFQlVHX0tNUygiVXNpbmcgJXMgYXMgWSBwbGFuZSBmb3IgJXNcbiIs IGxpbmtlZC0+YmFzZS5uYW1lLCBwbGFuZS0+YmFzZS5uYW1lKTsKPiA+ICAJfQo+ID4gIAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGluZGV4IDUzMzFiYmVkNWU4Yy4uN2E1NWY1OTIx ZDM0IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtOTI1LDYgKzky NSw5IEBAIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlIHsKPiA+ICAJdTggYWN0aXZlX3BsYW5lczsK PiA+ICAJdTggbnYxMl9wbGFuZXM7Cj4gPiAgCj4gPiArCS8qIGJpdG1hc2sgb2YgcGxhbmVzIHRo YXQgd2lsbCBiZSB1cGRhdGVkIGR1cmluZyB0aGUgY29tbWl0ICovCj4gPiArCXU4IHVwZGF0ZV9w bGFuZXM7Cj4gPiArCj4gPiAgCS8qIEhETUkgc2NyYW1ibGluZyBzdGF0dXMgKi8KPiA+ICAJYm9v bCBoZG1pX3NjcmFtYmxpbmc7Cj4gPiAgCj4gPiAtLSAKPiA+IDIuMTguMQo+ID4gCj4gPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPiAK PiAtLSAKPiBNYXR0IFJvcGVyCj4gR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKPiBJb1RHIFBs YXRmb3JtIEVuYWJsaW5nICYgRGV2ZWxvcG1lbnQKPiBJbnRlbCBDb3Jwb3JhdGlvbgo+ICg5MTYp IDM1Ni0yNzk1CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=