From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 02/14] drm/i915: Clean up
 skl_program_scaler()
Date: Fri, 9 Nov 2018 19:24:01 +0200
Message-ID: <20181109172401.GO9144@intel.com>
References: <20181101150605.18235-3-ville.syrjala@linux.intel.com>
 <20181101151736.20522-1-ville.syrjala@linux.intel.com>
 <20181101181350.GC2092@intel.com> <20181107182953.GM9144@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 947046E80A
 for <intel-gfx@lists.freedesktop.org>; Fri,  9 Nov 2018 17:24:04 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20181107182953.GM9144@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBOb3YgMDcsIDIwMTggYXQgMDg6Mjk6NTNQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk
IHdyb3RlOgo+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDExOjEzOjUwQU0gLTA3MDAsIFJvZHJp
Z28gVml2aSB3cm90ZToKPiA+IE9uIFRodSwgTm92IDAxLCAyMDE4IGF0IDA1OjE3OjM2UE0gKzAy
MDAsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmls
bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IAo+ID4gPiBSZW1vdmUgdGhlICJzaXpl
cyBhcmUgMCBiYXNlZCIgc3R1ZmYgdGhhdCBpcyBub3QgZXZlbiB0cnVlIGZvciB0aGUKPiA+ID4g
c2NhbGVyLgo+ID4gPiAKPiA+ID4gdjI6IFJlYmFzZQo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1i
eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+
ID4gUmV2aWV3ZWQtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiAK
PiBUaGFua3MuIEZpcnN0IHR3byBwYXRjaGVzIHB1c2hlZC4KCkFuZCBub3cgYWxzbyAzLTUgYW5k
IDguIFRoZSByZXN0IGhhZCBzb21lIGFtb3VudCBvZiBkaXNjdXNzaW9uIHN0aWxsCmhhcHBlbmlu
Zywgc28gSSdsbCByZWZyYWluIGZyb20gcHVzaGluZyBtb3JlIHVudGlsIEkgYWRkcmVzcyBNYXR0
J3MKY29tbWVudHMgYW5kIHJlcG9zdCB0aGUgcmVtYWluaW5nIHBhdGNoZXMuCgpUaGFua3MgZm9y
IHRoZSByZXZpZXdzIHNvIGZhci4KCj4gCj4gPiAKPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYyB8IDE4ICsrKysrLS0tLS0tLS0tLS0tLQo+ID4gPiAg
MSBmaWxlIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gPiA+IAo+
ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3ByaXRlLmMgYi9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zcHJpdGUuYwo+ID4gPiBpbmRleCAzMGI3NDg1ZjE5
OTIuLmE3N2ExN2ZkYTY5MiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfc3ByaXRlLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc3By
aXRlLmMKPiA+ID4gQEAgLTMxMCwxMiArMzEwLDExIEBAIHNrbF9wbGFuZV9tYXhfc3RyaWRlKHN0
cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyB2
b2lkCj4gPiA+IC1za2xfcHJvZ3JhbV9zY2FsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAo+ID4gPiAtCQkgICBzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lLAo+ID4gPiArc2ts
X3Byb2dyYW1fc2NhbGVyKHN0cnVjdCBpbnRlbF9wbGFuZSAqcGxhbmUsCj4gPiA+ICAJCSAgIGNv
bnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gPiAgCQkgICBjb25z
dCBzdHJ1Y3QgaW50ZWxfcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ID4gPiAgewo+ID4gPiAt
CWVudW0gcGxhbmVfaWQgcGxhbmVfaWQgPSBwbGFuZS0+aWQ7Cj4gPiA+ICsJc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShwbGFuZS0+YmFzZS5kZXYpOwo+ID4gPiAg
CWVudW0gcGlwZSBwaXBlID0gcGxhbmUtPnBpcGU7Cj4gPiA+ICAJaW50IHNjYWxlcl9pZCA9IHBs
YW5lX3N0YXRlLT5zY2FsZXJfaWQ7Cj4gPiA+ICAJY29uc3Qgc3RydWN0IGludGVsX3NjYWxlciAq
c2NhbGVyID0KPiA+ID4gQEAgLTMyNywxMCArMzI2LDYgQEAgc2tsX3Byb2dyYW1fc2NhbGVyKHN0
cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gIAl1MTYgeV9ocGhhc2UsIHV2
X3JnYl9ocGhhc2U7Cj4gPiA+ICAJdTE2IHlfdnBoYXNlLCB1dl9yZ2JfdnBoYXNlOwo+ID4gPiAg
Cj4gPiA+IC0JLyogU2l6ZXMgYXJlIDAgYmFzZWQgKi8KPiA+ID4gLQljcnRjX3ctLTsKPiA+ID4g
LQljcnRjX2gtLTsKPiA+ID4gLQo+ID4gPiAgCS8qIFRPRE86IGhhbmRsZSBzdWItcGl4ZWwgY29v
cmRpbmF0ZXMgKi8KPiA+ID4gIAlpZiAocGxhbmVfc3RhdGUtPmJhc2UuZmItPmZvcm1hdC0+Zm9y
bWF0ID09IERSTV9GT1JNQVRfTlYxMiAmJgo+ID4gPiAgCSAgICAhaWNsX2lzX2hkcl9wbGFuZShw
bGFuZSkpIHsKPiA+ID4gQEAgLTM1MCwxNSArMzQ1LDE0IEBAIHNrbF9wcm9ncmFtX3NjYWxlcihz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ICAJfQo+ID4gPiAgCj4gPiA+
ICAJSTkxNV9XUklURV9GVyhTS0xfUFNfQ1RSTChwaXBlLCBzY2FsZXJfaWQpLAo+ID4gPiAtCQkg
ICAgICBQU19TQ0FMRVJfRU4gfCBQU19QTEFORV9TRUwocGxhbmVfaWQpIHwgc2NhbGVyLT5tb2Rl
KTsKPiA+ID4gKwkJICAgICAgUFNfU0NBTEVSX0VOIHwgUFNfUExBTkVfU0VMKHBsYW5lLT5pZCkg
fCBzY2FsZXItPm1vZGUpOwo+ID4gPiAgCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1BXUl9HQVRFKHBp
cGUsIHNjYWxlcl9pZCksIDApOwo+ID4gPiAgCUk5MTVfV1JJVEVfRlcoU0tMX1BTX1ZQSEFTRShw
aXBlLCBzY2FsZXJfaWQpLAo+ID4gPiAgCQkgICAgICBQU19ZX1BIQVNFKHlfdnBoYXNlKSB8IFBT
X1VWX1JHQl9QSEFTRSh1dl9yZ2JfdnBoYXNlKSk7Cj4gPiA+ICAJSTkxNV9XUklURV9GVyhTS0xf
UFNfSFBIQVNFKHBpcGUsIHNjYWxlcl9pZCksCj4gPiA+ICAJCSAgICAgIFBTX1lfUEhBU0UoeV9o
cGhhc2UpIHwgUFNfVVZfUkdCX1BIQVNFKHV2X3JnYl9ocGhhc2UpKTsKPiA+ID4gIAlJOTE1X1dS
SVRFX0ZXKFNLTF9QU19XSU5fUE9TKHBpcGUsIHNjYWxlcl9pZCksIChjcnRjX3ggPDwgMTYpIHwg
Y3J0Y195KTsKPiA+ID4gLQlJOTE1X1dSSVRFX0ZXKFNLTF9QU19XSU5fU1oocGlwZSwgc2NhbGVy
X2lkKSwKPiA+ID4gLQkJICAgICAgKChjcnRjX3cgKyAxKSA8PCAxNil8KGNydGNfaCArIDEpKTsK
PiA+ID4gKwlJOTE1X1dSSVRFX0ZXKFNLTF9QU19XSU5fU1oocGlwZSwgc2NhbGVyX2lkKSwgKGNy
dGNfdyA8PCAxNikgfCBjcnRjX2gpOwo+ID4gPiAgfQo+ID4gPiAgCj4gPiA+ICBzdGF0aWMgdm9p
ZAo+ID4gPiBAQCAtNDQxLDExICs0MzUsOSBAQCBza2xfcHJvZ3JhbV9wbGFuZShzdHJ1Y3QgaW50
ZWxfcGxhbmUgKnBsYW5lLAo+ID4gPiAgCQlJOTE1X1dSSVRFX0ZXKFBMQU5FX0NVU19DVEwocGlw
ZSwgcGxhbmVfaWQpLCBjdXNfY3RsKTsKPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gLQkvKiBwcm9n
cmFtIHBsYW5lIHNjYWxlciAqLwo+ID4gPiAgCWlmIChwbGFuZV9zdGF0ZS0+c2NhbGVyX2lkID49
IDApIHsKPiA+ID4gIAkJaWYgKCFzbGF2ZSkKPiA+ID4gLQkJCXNrbF9wcm9ncmFtX3NjYWxlcihk
ZXZfcHJpdiwgcGxhbmUsCj4gPiA+IC0JCQkJCSAgIGNydGNfc3RhdGUsIHBsYW5lX3N0YXRlKTsK
PiA+ID4gKwkJCXNrbF9wcm9ncmFtX3NjYWxlcihwbGFuZSwgY3J0Y19zdGF0ZSwgcGxhbmVfc3Rh
dGUpOwo+ID4gPiAgCj4gPiA+ICAJCUk5MTVfV1JJVEVfRlcoUExBTkVfUE9TKHBpcGUsIHBsYW5l
X2lkKSwgMCk7Cj4gPiA+ICAJfSBlbHNlIHsKPiA+ID4gLS0gCj4gPiA+IDIuMTguMQo+ID4gPiAK
PiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+
ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwKPiBfX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls
aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBT
eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au
b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt
Z2Z4Cg==