From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: [PATCH] drm/i915: Hide enable_gvt modparam when not compiled in Date: Mon, 19 Nov 2018 10:02:36 +0800 Message-ID: <20181119020236.GX7021@zhen-hp.sh.intel.com> References: <20181116144447.7836-1-joonas.lahtinen@linux.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0661443237==" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ED5189AAE for ; Mon, 19 Nov 2018 02:12:02 +0000 (UTC) In-Reply-To: <20181116144447.7836-1-joonas.lahtinen@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Joonas Lahtinen Cc: Intel graphics driver community testing & development List-Id: intel-gfx@lists.freedesktop.org --===============0661443237== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CVXKxAdNG2kQIXaJ" Content-Disposition: inline --CVXKxAdNG2kQIXaJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2018.11.16 16:44:47 +0200, Joonas Lahtinen wrote: > Hide the enable_gvt modparam in the default scenario where > support has not been compiled in. >=20 > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: Chris Wilson > Signed-off-by: Joonas Lahtinen > --- > drivers/gpu/drm/i915/i915_params.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i9= 15_params.c > index 8d71886b5f03..2e0356561839 100644 > --- a/drivers/gpu/drm/i915/i915_params.c > +++ b/drivers/gpu/drm/i915/i915_params.c > @@ -167,8 +167,10 @@ i915_param_named_unsafe(inject_load_failure, uint, 0= 400, > i915_param_named(enable_dpcd_backlight, bool, 0600, > "Enable support for DPCD backlight control (default:false)"); > =20 > +#if IS_ENABLED(CONFIG_DRM_I915_GVT) > i915_param_named(enable_gvt, bool, 0400, > "Enable support for Intel GVT-g graphics virtualization host support(de= fault:false)"); > +#endif > =20 > static __always_inline void _print_param(struct drm_printer *p, > const char *name, I'm thinking we'd better to remove gvt parameter but depends on kernel config only in considering of current state and be easier to try, or better to be handled by gvt module split which will remove this anyway, so Acked-by: Zhenyu Wang --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --CVXKxAdNG2kQIXaJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCW/IZvAAKCRCxBBozTXgY J11DAJ9AaPFbOUxD/ijY8zlRePSBsmF8tQCgjXLsJHA1D8R7ziHbObB2tQSxe8Y= =3eBi -----END PGP SIGNATURE----- --CVXKxAdNG2kQIXaJ-- --===============0661443237== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0661443237==--