From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/backlight: Fix backlight takeover on LPT Date: Wed, 21 Nov 2018 12:45:36 +0200 Message-ID: <20181121104536.GW9144@intel.com> References: <20181120103926.10117-1-maarten.lankhorst@linux.intel.com> <20181120185121.GV9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 932986E141 for ; Wed, 21 Nov 2018 10:45:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tolga Cakir Cc: jwrdegoede@fedoraproject.org, intel-gfx@lists.freedesktop.org, ericbasil.rabi@gmail.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMjEsIDIwMTggYXQgMDg6MTY6MDZBTSArMDEwMCwgVG9sZ2EgQ2FraXIgd3Jv dGU6Cj4gQW0gRGkuLCAyMC4gTm92LiAyMDE4IHVtIDE5OjUxIFVociBzY2hyaWViIFZpbGxlIFN5 cmrDpGzDpAo+IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT46Cj4gPgo+ID4gT24gVHVl LCBOb3YgMjAsIDIwMTggYXQgMTE6Mzk6MjZBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3Jv dGU6Cj4gPiA+IE9uIGx5bnhwb2ludCB0aGUgYmlvcyBzb21ldGltZXMgc2V0cyB1cCB0aGUgYmFj a2xpZ2h0IHVzaW5nIHRoZSBDUFUKPiA+ID4gZGlzcGxheSwgYnV0IHRoZSBkcml2ZXIgZXhwZWN0 cyB1c2luZyB0aGUgUFdNIFBDSCBvdmVycmlkZSByZWdpc3Rlci4KPiA+ID4KPiA+ID4gUmVhZCB0 aGUgdmFsdWUgZnJvbSB0aGUgQ1BVIHJlZ2lzdGVyLCB0aGVuIGNvbnZlcnQgaXQgdG8gdGhlIG90 aGVyCj4gPiA+IHVuaXRzIGJ5IGNvbnZlcnRpbmcgZnJvbSB0aGUgb2xkIGR1dHkgY3ljbGUsIHRv IGZyZXEsIHRvIHRoZSBuZXcgdW5pdHMuCj4gPiA+Cj4gPiA+IFRoaXMgdmFsdWUgaXMgdGhlbiBw cm9ncmFtbWVkIGluIHRoZSBvdmVycmlkZSByZWdpc3RlciwgYWZ0ZXIgd2hpY2gKPiA+ID4gd2Ug c2V0IHRoZSBvdmVycmlkZSBhbmQgZGlzYWJsZSB0aGUgQ1BVIGRpc3BsYXkgY29udHJvbC4gVGhp cyBhbGxvd3MKPiA+ID4gdXMgdG8gc3dpdGNoIHRoZSBzb3VyY2Ugd2l0aG91dCBmbGlja2VyaW5n LCBhbmQgbWFrZSB0aGUgYmFja2xpZ2h0Cj4gPiA+IGNvbnRyb2xzIHdvcmsgaW4gdGhlIGRyaXZl ci4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4u bGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5m cmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwODIyNQo+ID4gPiBDYzogQmFzaWwgRXJp YyBSYWJpIDxlcmljYmFzaWwucmFiaUBnbWFpbC5jb20+Cj4gPiA+IENjOiBIYW5zIGRlIEdvZWRl IDxqd3JkZWdvZWRlQGZlZG9yYXByb2plY3Qub3JnPgo+ID4gPiBDYzogVG9sZ2EgQ2FraXIgPGNl dmVsbmV0QGdtYWlsLmNvbT4KPiA+ID4gVGVzdGVkLWJ5OiBUb2xnYSBDYWtpciA8Y2V2ZWxuZXRA Z21haWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bh bmVsLmMgfCAzNCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0KPiA+ID4gIDEgZmlsZSBj aGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gPgo+ID4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+ID4gaW5kZXggZTZjZDdiNTVjMDE4Li4zMzU3MjMy ZjFiMGUgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BhbmVs LmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGFuZWwuYwo+ID4gPiBA QCAtMTQ4NSw3ICsxNDg1LDcgQEAgc3RhdGljIGludCBscHRfc2V0dXBfYmFja2xpZ2h0KHN0cnVj dCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVudXMKPiA+ID4gICAgICAg c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjb25uZWN0b3ItPmJh c2UuZGV2KTsKPiA+ID4gICAgICAgc3RydWN0IGludGVsX3BhbmVsICpwYW5lbCA9ICZjb25uZWN0 b3ItPnBhbmVsOwo+ID4gPiAgICAgICB1MzIgcGNoX2N0bDEsIHBjaF9jdGwyLCB2YWw7Cj4gPiA+ IC0gICAgIGJvb2wgYWx0Owo+ID4gPiArICAgICBib29sIGFsdCwgY3B1X21vZGUgPSBmYWxzZTsK PiA+ID4KPiA+ID4gICAgICAgaWYgKEhBU19QQ0hfTFBUKGRldl9wcml2KSkKPiA+ID4gICAgICAg ICAgICAgICBhbHQgPSBJOTE1X1JFQUQoU09VVEhfQ0hJQ0tFTjIpICYgTFBUX1BXTV9HUkFOVUxB UklUWTsKPiA+ID4gQEAgLTE1MDcsMTIgKzE1MDcsNDAgQEAgc3RhdGljIGludCBscHRfc2V0dXBf YmFja2xpZ2h0KHN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm5lY3RvciwgZW51bSBwaXBlIHVu dXMKPiA+ID4KPiA+ID4gICAgICAgcGFuZWwtPmJhY2tsaWdodC5taW4gPSBnZXRfYmFja2xpZ2h0 X21pbl92YnQoY29ubmVjdG9yKTsKPiA+ID4KPiA+ID4gLSAgICAgdmFsID0gbHB0X2dldF9iYWNr bGlnaHQoY29ubmVjdG9yKTsKPiA+ID4gKyAgICAgcGFuZWwtPmJhY2tsaWdodC5lbmFibGVkID0g cGNoX2N0bDEgJiBCTE1fUENIX1BXTV9FTkFCTEU7Cj4gPiA+ICsgICAgIGlmIChwYW5lbC0+YmFj a2xpZ2h0LmVuYWJsZWQgJiYgSEFTX1BDSF9MUFQoZGV2X3ByaXYpICYmCj4gPiA+ICsgICAgICAg ICAoSTkxNV9SRUFEKEJMQ19QV01fQ1BVX0NUTDIpICYgQkxNX1BXTV9FTkFCTEUpICYmCj4gPiA+ ICsgICAgICAgICAhV0FSTl9PTihwY2hfY3RsMSAmIEJMTV9QQ0hfT1ZFUlJJREVfRU5BQkxFKSkg ewo+ID4gPiArICAgICAgICAgICAgIHUzMiBmcmVxOwo+ID4gPiArCj4gPiA+ICsgICAgICAgICAg ICAgY3B1X21vZGUgPSB0cnVlOwo+ID4gPiArICAgICAgICAgICAgIC8qCj4gPiA+ICsgICAgICAg ICAgICAgICogV2UncmUgaW4gY3B1IG1vZGUsIGNvbnZlcnQgdG8gUENIIHVuaXRzLgo+ID4gPiAr ICAgICAgICAgICAgICAqCj4gPiA+ICsgICAgICAgICAgICAgICogQ29udmVydCBDUFUgcHdtIHRp Y2sgYmFjayB0byBoeiwgYmFjayB0byBuZXcgUENIIHVuaXRzIGFnYWluLgo+ID4gPiArICAgICAg ICAgICAgICAqIHRoaXMgaXMgdGhlIHNhbWUgZm9ybXVsYSBhcyBwY2hfaHpfdG9fcHdtLCBidXQg dGhlIG90aGVyIHdheQo+ID4gPiArICAgICAgICAgICAgICAqIGFyb3VuZC4uCj4gPiA+ICsgICAg ICAgICAgICAgICovCj4gPiA+ICsgICAgICAgICAgICAgdmFsID0gcGNoX2dldF9iYWNrbGlnaHQo Y29ubmVjdG9yKTsKPiA+ID4gKyAgICAgICAgICAgICBmcmVxID0gRElWX1JPVU5EX0NMT1NFU1Qo S0h6KGRldl9wcml2LT5yYXdjbGtfZnJlcSksIHZhbCAqIDEyOCk7Cj4gPgo+ID4gVGhlIGRvY3Mg YXJlIHRlbGxpbmcgbWUgdGhhdCBIU1cvQkRXIHVzZSBjZGNsayBmb3IgdGhlIENQVSBiYWNrbGln aHQsCj4gPiBhbmQgdGhlIGluY3JlbWVudCBpcyBjb25maWd1cmFibGUgYXMgd2VsbC4KPiA+Cj4g PiBBbHNvIHdoYXQgYWJvdXQgUzQgcmVzdW1lPyBEb24ndCB3ZSBuZWVkIHRoaXMgdHJpY2sgdGhl cmUgYXMgd2VsbD8KPiA+Cj4gCj4gSGksCj4gCj4gSSBjb3VsZG4ndCB0ZXN0IHRoaXMgcGF0Y2gg Zm9yIFM0IHJlc3VtZSBvbiBteSBEZWxsIE0zODAwIGxhcHRvcCAoQ29yZQo+IGk3LTQ3MDJIUSwg THlueCBQb2ludCksIGFzIGZhc3Rib290PTEgZG9lc24ndCB3b3JrIGZvciBTNCByZXN1bWUsIG9u bHkKPiBub3JtYWwgYm9vdC4gVGhlcmVmb3JlLCB0aGVyZSBhcmUgbm8gaXNzdWVzIG9uIFM0IHdh a2UgYWZ0ZXIKPiBoaWJlcm5hdGUuIEJhY2tsaWdodCBjb250cm9scyBldGMuIHdvcmsgYXMgZXhw ZWN0ZWQ7IGp1c3QgbGlrZQo+IGZhc3Rib290PTAuCgpJIHRoaW5rIGZhc3Rib290IHNob3VsZCB3 b3JrIHRoZSBzYW1lIGZvciBzNCByZXN1bWUgYXMgYm9vdCwgYnV0Cm9ubHkgaWYgeW91ciBib290 IGtlcm5lbCBkb2Vzbid0IGxvYWQgaTkxNS5rby4gVGhhdCB3YXkgdGhlCnJlc3VtaW5nIGtlcm5l bCB3aWxsIGRpcmVjdGx5IHRha2Ugb3ZlciBmcm9tIHRoZSBCSU9TIHByb2dyYW1tZWQKZGlzcGxh eSBjb25maWd1cmF0aW9uLiBPVE9IIGlmIHRoZSBib290IGtlcm5lbCBsb2FkcyBpOTE1IHRoZW4K aXQgd2lsbCBzaHV0IGRvd24gYWxsIGRpc3BsYXlzIGJlZm9yZSBoYW5kaW5nIGNvbnRyb2wgb3Zl ciB0bwp0aGUgcmVzdW1pbmcga2VybmVsLgoKPiAKPiBJIGhhdmUgYXBwbGllZCAiWzEvMl0gZHJt L2k5MTU6IEVuYWJsZSBmYXN0c2V0IGZvciBub24tYm9vdCBtb2Rlc2V0cyIKPiBieSBNYWFydGVu LCBidXQgdGhhdCBkb2Vzbid0IGdpdmUgbWUgZmFzdGJvb3QgZm9yIFM0IHJlc3VtZSBhc3dlbGwu Cj4gU2FtZSBiZWhhdmlvciBhcyB1bnBhdGNoZWQgb24gbXkgc3lzdGVtLgo+IAo+IFBsZWFzZSBs ZXQgbWUga25vdywgd2hlbiB0aGVyZSBpcyBtb3JlIEkgY2FuIHRlc3QuCj4gCj4gQ2hlZXJzLAo+ IFRvbGdhCj4gCj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICB2YWwgPSBscHRfaHpfdG9fcHdt KGNvbm5lY3RvciwgZnJlcSk7Cj4gPiA+ICsgICAgIH0gZWxzZQo+ID4gPiArICAgICAgICAgICAg IHZhbCA9IGxwdF9nZXRfYmFja2xpZ2h0KGNvbm5lY3Rvcik7Cj4gPiA+ICAgICAgIHZhbCA9IGlu dGVsX3BhbmVsX2NvbXB1dGVfYnJpZ2h0bmVzcyhjb25uZWN0b3IsIHZhbCk7Cj4gPiA+ICAgICAg IHBhbmVsLT5iYWNrbGlnaHQubGV2ZWwgPSBjbGFtcCh2YWwsIHBhbmVsLT5iYWNrbGlnaHQubWlu LAo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFuZWwtPmJhY2ts aWdodC5tYXgpOwo+ID4gPgo+ID4gPiAtICAgICBwYW5lbC0+YmFja2xpZ2h0LmVuYWJsZWQgPSBw Y2hfY3RsMSAmIEJMTV9QQ0hfUFdNX0VOQUJMRTsKPiA+ID4gKyAgICAgaWYgKGNwdV9tb2RlKSB7 Cj4gPiA+ICsgICAgICAgICAgICAgdTMyIHRtcDsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAg IC8qIFVzZSBQV00gbW9kZSwgaW5zdGVhZCBvZiBjcHUgY2xvY2sgKi8KPiA+ID4gKyAgICAgICAg ICAgICBscHRfc2V0X2JhY2tsaWdodChjb25uZWN0b3ItPmJhc2Uuc3RhdGUsIHBhbmVsLT5iYWNr bGlnaHQubGV2ZWwpOwo+ID4gPiArICAgICAgICAgICAgIEk5MTVfV1JJVEUoQkxDX1BXTV9QQ0hf Q1RMMSwgcGNoX2N0bDEgfCBCTE1fUENIX09WRVJSSURFX0VOQUJMRSk7Cj4gPiA+ICsKPiA+ID4g KyAgICAgICAgICAgICB0bXAgPSBJOTE1X1JFQUQoQkxDX1BXTV9DUFVfQ1RMMik7Cj4gPiA+ICsg ICAgICAgICAgICAgSTkxNV9XUklURShCTENfUFdNX0NQVV9DVEwyLCB0bXAgJiB+QkxNX1BXTV9F TkFCTEUpOwo+ID4gPiArICAgICB9Cj4gPiA+Cj4gPiA+ICAgICAgIHJldHVybiAwOwo+ID4gPiAg fQo+ID4gPiAtLQo+ID4gPiAyLjE5LjEKPiA+ID4KPiA+ID4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+ ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+IGh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gPgo+ID4gLS0KPiA+ IFZpbGxlIFN5cmrDpGzDpAo+ID4gSW50ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==