* [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC
@ 2018-12-01 1:04 Manasi Navare
2018-12-01 1:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-03 12:05 ` [PATCH] " Ville Syrjälä
0 siblings, 2 replies; 4+ messages in thread
From: Manasi Navare @ 2018-12-01 1:04 UTC (permalink / raw)
To: intel-gfx
Fix the intel_link_compute_m_n in case of display stream
compression. This patch passes the compressed_bpp to
intel_link_compute_m_n if compression is enabled.
Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 38a6e82153fd..a6907a1761ab 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -2173,7 +2173,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
&pipe_config->dp_m_n,
constant_n);
else
- intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
+ intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
pipe_config->lane_count,
adjusted_mode->crtc_clock,
pipe_config->port_clock,
--
2.19.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/dp: Fix link compute m_n calc for DSC
2018-12-01 1:04 [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC Manasi Navare
@ 2018-12-01 1:34 ` Patchwork
2018-12-03 12:05 ` [PATCH] " Ville Syrjälä
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-12-01 1:34 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dp: Fix link compute m_n calc for DSC
URL : https://patchwork.freedesktop.org/series/53347/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5237 -> Patchwork_10988
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53347/revisions/1/mbox/
Known issues
------------
Here are the changes found in Patchwork_10988 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bsw-n3050: PASS -> FAIL [fdo#108656]
* igt@gem_exec_suspend@basic-s4-devices:
- fi-ivb-3520m: PASS -> FAIL [fdo#108880]
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-cfl-8109u: PASS -> FAIL [fdo#103375]
* {igt@runner@aborted}:
- {fi-icl-y}: NOTRUN -> FAIL [fdo#108070]
#### Possible fixes ####
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
[fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880
Participating hosts (49 -> 44)
------------------------------
Additional (1): fi-icl-y
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
Build changes
-------------
* Linux: CI_DRM_5237 -> Patchwork_10988
CI_DRM_5237: 2f99c4889e4124f9cf50b745d037f432318c4bb4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4736: 285ebfb3b7adc56586031afa5150c4e5ad40c229 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10988: d36517e4c2d25c792b3f38d9c55aed08962f8325 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d36517e4c2d2 drm/i915/dp: Fix link compute m_n calc for DSC
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10988/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC
2018-12-01 1:04 [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC Manasi Navare
2018-12-01 1:34 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-03 12:05 ` Ville Syrjälä
2018-12-03 20:02 ` Manasi Navare
1 sibling, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2018-12-03 12:05 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
On Fri, Nov 30, 2018 at 05:04:12PM -0800, Manasi Navare wrote:
> Fix the intel_link_compute_m_n in case of display stream
> compression. This patch passes the compressed_bpp to
> intel_link_compute_m_n if compression is enabled.
>
> Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 38a6e82153fd..a6907a1761ab 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -2173,7 +2173,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> &pipe_config->dp_m_n,
> constant_n);
> else
> - intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
> + intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
> pipe_config->lane_count,
> adjusted_mode->crtc_clock,
> pipe_config->port_clock,
> --
> 2.19.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC
2018-12-03 12:05 ` [PATCH] " Ville Syrjälä
@ 2018-12-03 20:02 ` Manasi Navare
0 siblings, 0 replies; 4+ messages in thread
From: Manasi Navare @ 2018-12-03 20:02 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Thanks fo rthe reviw, pushed to dinq!
Manasi
On Mon, Dec 03, 2018 at 02:05:42PM +0200, Ville Syrjälä wrote:
> On Fri, Nov 30, 2018 at 05:04:12PM -0800, Manasi Navare wrote:
> > Fix the intel_link_compute_m_n in case of display stream
> > compression. This patch passes the compressed_bpp to
> > intel_link_compute_m_n if compression is enabled.
> >
> > Fixes: a4a157777c80 ("drm/i915/dp: Compute DSC pipe config in atomic check")
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > ---
> > drivers/gpu/drm/i915/intel_dp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 38a6e82153fd..a6907a1761ab 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -2173,7 +2173,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
> > &pipe_config->dp_m_n,
> > constant_n);
> > else
> > - intel_link_compute_m_n(pipe_config->dsc_params.compression_enable,
> > + intel_link_compute_m_n(pipe_config->dsc_params.compressed_bpp,
> > pipe_config->lane_count,
> > adjusted_mode->crtc_clock,
> > pipe_config->port_clock,
> > --
> > 2.19.1
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-03 20:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-01 1:04 [PATCH] drm/i915/dp: Fix link compute m_n calc for DSC Manasi Navare
2018-12-01 1:34 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-03 12:05 ` [PATCH] " Ville Syrjälä
2018-12-03 20:02 ` Manasi Navare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).