From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH v6] drm/i915/dsc: Add Per connector debugfs node for DSC support/enable Date: Wed, 5 Dec 2018 11:29:41 -0800 Message-ID: <20181205192940.GC2462@intel.com> References: <20181204030749.29103-1-manasi.d.navare@intel.com> <20181204195537.5274-1-manasi.d.navare@intel.com> <0c4d34a69ba1a56e7be0d8932c1e057b37be03c3.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 17CF96E4C3 for ; Wed, 5 Dec 2018 19:27:27 +0000 (UTC) Content-Disposition: inline In-Reply-To: <0c4d34a69ba1a56e7be0d8932c1e057b37be03c3.camel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lyude Paul Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBEZWMgMDUsIDIwMTggYXQgMDI6MDA6MzlQTSAtMDUwMCwgTHl1ZGUgUGF1bCB3cm90 ZToKPiBMb29rcyBnb29kLCBzb21lIHNtYWxsIG5pdHBpY2tzCj4gCj4gT24gVHVlLCAyMDE4LTEy LTA0IGF0IDExOjU1IC0wODAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ID4gRFNDIGNhbiBiZSBz dXBwb3J0ZWQgcGVyIERQIGNvbm5lY3Rvci4gVGhpcyBwYXRjaCBhZGRzIGEgcGVyIGNvbm5lY3Rv cgo+ID4gZGVidWdmcyBub2RlIHRvIGV4cG9zZSBEU0Mgc3VwcG9ydCBjYXBhYmlsaXR5IGJ5IHRo ZSBrZXJuZWwuCj4gPiBUaGUgc2FtZSBub2RlIGNhbiBiZSB1c2VkIGZyb20gdXNlcnNwYWNlIHRv IGZvcmNlIERTQyBlbmFibGUuCj4gPiAKPiA+IGZvcmNlX2RzY19lbiB3cml0dGVuIHRocm91Z2gg dGhpcyBkZWJ1Z2ZzIG5vZGUgaXMgdXNlZCB0byBmb3JjZQo+ID4gRFNDIGV2ZW4gZm9yIGxvd2Vy IHJlc29sdXRpb25zLgo+ID4gCj4gPiB2NjoKPiA+ICogUmVhZCBmZWNfY2FwYWJsZSBvbmx5IGZv ciBub24gZWRwIChNYW5hc2kpCj4gPiB2NToKPiA+ICogTmFtZSBpdCBkc2Mgc2luayBzdXBwb3J0 IGFuZCBhbHNvIGFkZAo+ID4gZmVjIHN1cHBvcnQgaW4gdGhlIHNhbWUgbm9kZSAoVmlsbGUpCj4g PiB2NDoKPiA+ICogQWRkIG1pc3NlZCBjb25uZWN0b3Jfc3RhdHVzIGNoZWNrIChNYW5hc2kpCj4g PiAqIENyZWF0ZSBpOTE1X2RzY19zdXBwb3J0IG5vZGUgb25seSBmb3IgR2VuID49MTAgKG1hbmFz aSkKPiA+ICogQWNjZXNzIGludGVsX2RwLT5kc2NfZHBjZCBvbmx5IGlmIGl0cyBub3QgTlVMTCAo TWFuYXNpKQo+ID4gdjM6Cj4gPiAqIENvbWJpbmUgRm9yY2VfZHNjX2VuIHdpdGggdGhpcyBwYXRj aCAoVmlsbGUpCj4gPiB2MjoKPiA+ICogVXNlIGtzdHJ0b2Jvb2xfZnJvbV91c2VyIHRvIGF2b2lk IGV4cGxpY2l0IGVycm9yIGNoZWNraW5nIChMeXVkZSkKPiA+ICogUmViYXNlIG9uIGRybS10aXAg KE1hbmFzaSkKPiA+IAo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNv bT4KPiA+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4K PiA+IENjOiBBbnVzaGEgU3JpdmF0c2EgPGFudXNoYS5zcml2YXRzYUBpbnRlbC5jb20+Cj4gPiBD YzogTHl1ZGUgUGF1bCA8bHl1ZGVAcmVkaGF0LmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IE1hbmFz aSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8IDgwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICAgfCAgMyArLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgIHwgIDMgKysKPiA+ICAzIGZp bGVzIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiBpbmRleCAxMjliOWE2ZjgzMDkuLmVj MTBhYjAyN2QxOCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVi dWdmcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+ID4g QEAgLTUwODYsNiArNTA4Niw3OSBAQCBzdGF0aWMgaW50IGk5MTVfaGRjcF9zaW5rX2NhcGFiaWxp dHlfc2hvdyhzdHJ1Y3QKPiA+IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ID4gIH0KPiA+ICBE RUZJTkVfU0hPV19BVFRSSUJVVEUoaTkxNV9oZGNwX3NpbmtfY2FwYWJpbGl0eSk7Cj4gPiAgCj4g PiArc3RhdGljIGludCBpOTE1X2RzY19mZWNfc3VwcG9ydF9zaG93KHN0cnVjdCBzZXFfZmlsZSAq bSwgdm9pZCAqZGF0YSkKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0 b3IgPSBtLT5wcml2YXRlOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciA9IGlu dGVsX2F0dGFjaGVkX2VuY29kZXIoY29ubmVjdG9yKTsKPiA+ICsJc3RydWN0IGludGVsX2RwICpp bnRlbF9kcCA9Cj4gPiArCQllbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJhc2UpOwo+ID4gKwlz dHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YzsKPiA+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGU7Cj4gPiArCj4gPiArCWlmIChjb25uZWN0b3ItPnN0YXR1cyAhPSBjb25uZWN0b3Jf c3RhdHVzX2Nvbm5lY3RlZCkKPiA+ICsJCXJldHVybiAtRU5PREVWOwo+ID4gKwo+ID4gKwljcnRj ID0gdG9faW50ZWxfY3J0YyhlbmNvZGVyLT5iYXNlLmNydGMpOwo+ID4gKwljcnRjX3N0YXRlID0g dG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNlLnN0YXRlKTsKCkkgYW0gc2VlaW5nIGEga2Vy bmVsIE5VTGwgcG9pbnRlciBkZXJlZmVyZW5jaW5nIGhlcmUgaW4gQ0kgcG9zc2libHkgYmVjYXVz ZQp0aGUgY3J0YyBpcyBOVUxMIGFuZCBhcyBwZXIgVmlsbGUgYW5kIERhbnZldCBJIHNob3VsZCBi ZSBncmFiYmluZyBib3RoIGNvbm5lY3Rpb24gbXV0ZXgKYW5kIGNydGMgbXV0ZXggYW5kIHVzZSB0 aGUgYWNxdWlyZSBjdHggYW5kIGJhY2tvZmYgc3R1ZmYgc28gSSBhbSB0cnlpbmcgdG8gdW5kZXJz dGFuZCB0aGF0IHBhcnQKYW5kIHNlZWluZyBob3cgSSBjYW4gdXNlIHRoYXQuCgpMZXQgbWUga25v dyBpZiB5b3UgaGF2ZSBhbnkgaW5wdXRzL2V4YW1wbGVzIG9uIHRoYXQgdG9vLi4KCj4gPiArCWRy bV9tb2Rlc2V0X2xvY2soJmNydGMtPmJhc2UubXV0ZXgsIE5VTEwpOwo+ID4gKwlzZXFfcHJpbnRm KG0sICJEU0NfRW5hYmxlZDogJXNcbiIsCj4gPiArCQkgICB5ZXNubyhjcnRjX3N0YXRlLT5kc2Nf cGFyYW1zLmNvbXByZXNzaW9uX2VuYWJsZSkpOwo+ID4gKwlpZiAoaW50ZWxfZHAtPmRzY19kcGNk KQo+ID4gKwkJc2VxX3ByaW50ZihtLCAiRFNDX1NpbmtfU3VwcG9ydDogJXNcbiIsCj4gPiArCQkJ ICAgeWVzbm8oZHJtX2RwX3Npbmtfc3VwcG9ydHNfZHNjKGludGVsX2RwLQo+ID4gPmRzY19kcGNk KSkpOwo+ID4gKwlpZiAoIWludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpCj4gPiArCQlzZXFfcHJp bnRmKG0sICJGRUNfU2lua19TdXBwb3J0OiAlc1xuIiwKPiA+ICsJCQkgICB5ZXNubyhkcm1fZHBf c2lua19zdXBwb3J0c19mZWMoaW50ZWxfZHAtCj4gPiA+ZmVjX2NhcGFibGUpKSk7Cj4gPiArCWRy bV9tb2Rlc2V0X3VubG9jaygmY3J0Yy0+YmFzZS5tdXRleCk7Cj4gPiArCj4gPiArCXJldHVybiAw Owo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgc3NpemVfdCBpOTE1X2RzY19mZWNfc3VwcG9ydF93 cml0ZShzdHJ1Y3QgZmlsZSAqZmlsZSwKPiA+ICsJCQkJCSAgY29uc3QgY2hhciBfX3VzZXIgKnVi dWYsCj4gPiArCQkJCQkgIHNpemVfdCBsZW4sIGxvZmZfdCAqb2ZmcCkKPiA+ICt7Cj4gPiArCWJv b2wgZHNjX2VuYWJsZSA9IGZhbHNlOwo+ID4gKwlpbnQgcmV0Owo+ID4gKwlzdHJ1Y3QgZHJtX2Nv bm5lY3RvciAqY29ubmVjdG9yID0KPiA+ICsJCSgoc3RydWN0IHNlcV9maWxlICopZmlsZS0+cHJp dmF0ZV9kYXRhKS0+cHJpdmF0ZTsKPiA+ICsJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIg PSBpbnRlbF9hdHRhY2hlZF9lbmNvZGVyKGNvbm5lY3Rvcik7Cj4gPiArCXN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJhc2UpOwo+ID4gKwo+ID4g KwlpZiAobGVuID09IDApCj4gPiArCQlyZXR1cm4gMDsKPiA+ICsKPiA+ICsJRFJNX0RFQlVHX0RS SVZFUigiQ29waWVkICVkIGJ5dGVzIGZyb20gdXNlciB0byBmb3JjZSBEU0NcbiIsCj4gPiArCQkJ ICh1bnNpZ25lZCBpbnQpbGVuKTsKPiBZb3UgY2FuIGp1c3QgdXNlICV6dSBpbnN0ZWFkIG9mICVk IGhlcmUsIHNlZToKPiAKPiBodHRwczovLzAxLm9yZy9saW51eGdyYXBoaWNzL2dmeC1kb2NzL2Ry bS9jb3JlLWFwaS9wcmludGstZm9ybWF0cy5odG1sCgpDb29sIEkgd2lsbCBtYWtlIHRoaXMgY2hh bmdlLiBUaGFua3MgZm9yIHRoZSByZXZpZXcuCgpSZWdhcmRzCk1hbmFzaQoKPiAKPiBPdGhlciB0 aGVuIHRoYXQsIGxvb2tzIGdvb2QgdG8gbWUhIFdpdGggdGhhdCBjaGFuZ2U6Cj4gCj4gUmV2aWV3 ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+Cj4gCj4gPiArCj4gPiArCXJldCA9 IGtzdHJ0b2Jvb2xfZnJvbV91c2VyKHVidWYsIGxlbiwgJmRzY19lbmFibGUpOwo+ID4gKwlpZiAo cmV0IDwgMCkKPiA+ICsJCXJldHVybiByZXQ7Cj4gPiArCj4gPiArCURSTV9ERUJVR19EUklWRVIo IkdvdCAlcyBmb3IgRFNDIEVuYWJsZVxuIiwKPiA+ICsJCQkgKGRzY19lbmFibGUpID8gInRydWUi IDogImZhbHNlIik7Cj4gPiArCWludGVsX2RwLT5mb3JjZV9kc2NfZW4gPSBkc2NfZW5hYmxlOwo+ ID4gKwo+ID4gKwkqb2ZmcCArPSBsZW47Cj4gPiArCXJldHVybiBsZW47Cj4gPiArfQo+ID4gKwo+ ID4gK3N0YXRpYyBpbnQgaTkxNV9kc2NfZmVjX3N1cHBvcnRfb3BlbihzdHJ1Y3QgaW5vZGUgKmlu b2RlLAo+ID4gKwkJCQkgICAgIHN0cnVjdCBmaWxlICpmaWxlKQo+ID4gK3sKPiA+ICsJcmV0dXJu IHNpbmdsZV9vcGVuKGZpbGUsIGk5MTVfZHNjX2ZlY19zdXBwb3J0X3Nob3csCj4gPiArCQkJICAg aW5vZGUtPmlfcHJpdmF0ZSk7Cj4gPiArfQo+ID4gKwo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3Qg ZmlsZV9vcGVyYXRpb25zIGk5MTVfZHNjX2ZlY19zdXBwb3J0X2ZvcHMgPSB7Cj4gPiArCS5vd25l ciA9IFRISVNfTU9EVUxFLAo+ID4gKwkub3BlbiA9IGk5MTVfZHNjX2ZlY19zdXBwb3J0X29wZW4s Cj4gPiArCS5yZWFkID0gc2VxX3JlYWQsCj4gPiArCS5sbHNlZWsgPSBzZXFfbHNlZWssCj4gPiAr CS5yZWxlYXNlID0gc2luZ2xlX3JlbGVhc2UsCj4gPiArCS53cml0ZSA9IGk5MTVfZHNjX2ZlY19z dXBwb3J0X3dyaXRlCj4gPiArfTsKPiA+ICsKPiA+ICAvKioKPiA+ICAgKiBpOTE1X2RlYnVnZnNf Y29ubmVjdG9yX2FkZCAtIGFkZCBpOTE1IHNwZWNpZmljIGNvbm5lY3RvciBkZWJ1Z2ZzIGZpbGVz Cj4gPiAgICogQGNvbm5lY3RvcjogcG9pbnRlciB0byBhIHJlZ2lzdGVyZWQgZHJtX2Nvbm5lY3Rv cgo+ID4gQEAgLTUwOTgsNiArNTE3MSw3IEBAIERFRklORV9TSE9XX0FUVFJJQlVURShpOTE1X2hk Y3Bfc2lua19jYXBhYmlsaXR5KTsKPiA+ICBpbnQgaTkxNV9kZWJ1Z2ZzX2Nvbm5lY3Rvcl9hZGQo c3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiA+ICB7Cj4gPiAgCXN0cnVjdCBkZW50 cnkgKnJvb3QgPSBjb25uZWN0b3ItPmRlYnVnZnNfZW50cnk7Cj4gPiArCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoY29ubmVjdG9yLT5kZXYpOwo+ID4gIAo+ID4g IAkvKiBUaGUgY29ubmVjdG9yIG11c3QgaGF2ZSBiZWVuIHJlZ2lzdGVyZWQgYmVmb3JlaGFuZHMu ICovCj4gPiAgCWlmICghcm9vdCkKPiA+IEBAIC01MTIyLDUgKzUxOTYsMTEgQEAgaW50IGk5MTVf ZGVidWdmc19jb25uZWN0b3JfYWRkKHN0cnVjdCBkcm1fY29ubmVjdG9yCj4gPiAqY29ubmVjdG9y KQo+ID4gIAkJCQkgICAgY29ubmVjdG9yLAo+ID4gJmk5MTVfaGRjcF9zaW5rX2NhcGFiaWxpdHlf Zm9wcyk7Cj4gPiAgCX0KPiA+ICAKPiA+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTAg JiYKPiA+ICsJICAgIChjb25uZWN0b3ItPmNvbm5lY3Rvcl90eXBlID09IERSTV9NT0RFX0NPTk5F Q1RPUl9EaXNwbGF5UG9ydCB8fAo+ID4gKwkgICAgIGNvbm5lY3Rvci0+Y29ubmVjdG9yX3R5cGUg PT0gRFJNX01PREVfQ09OTkVDVE9SX2VEUCkpCj4gPiArCQlkZWJ1Z2ZzX2NyZWF0ZV9maWxlKCJp OTE1X2RzY19mZWNfc3VwcG9ydCIsIFNfSVJVR08sIHJvb3QsCj4gPiArCQkJCSAgICBjb25uZWN0 b3IsICZpOTE1X2RzY19mZWNfc3VwcG9ydF9mb3BzKTsKPiA+ICsKPiA+ICAJcmV0dXJuIDA7Cj4g PiAgfQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gaW5kZXggYTY5MDdhMTc2MWFi Li4yZTMwOTdjYWUyNzcgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBAQCAt MjA1MSw3ICsyMDUxLDggQEAgaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZyhzdHJ1Y3QgaW50 ZWxfZW5jb2Rlcgo+ID4gKmVuY29kZXIsCj4gPiAgCQkJCQkJCSZsaW1pdHMpOwo+ID4gIAo+ID4g IAkvKiBlbmFibGUgY29tcHJlc3Npb24gaWYgdGhlIG1vZGUgZG9lc24ndCBmaXQgYXZhaWxhYmxl IEJXICovCj4gPiAtCWlmICghcmV0KSB7Cj4gPiArCURSTV9ERUJVR19LTVMoIkZvcmNlIERTQyBl biA9ICVkXG4iLCBpbnRlbF9kcC0+Zm9yY2VfZHNjX2VuKTsKPiA+ICsJaWYgKCFyZXQgfHwgaW50 ZWxfZHAtPmZvcmNlX2RzY19lbikgewo+ID4gIAkJaWYgKCFpbnRlbF9kcF9kc2NfY29tcHV0ZV9j b25maWcoaW50ZWxfZHAsIHBpcGVfY29uZmlnLAo+ID4gIAkJCQkJCSBjb25uX3N0YXRlLCAmbGlt aXRzKSkKPiA+ICAJCQlyZXR1cm4gZmFsc2U7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2 LmgKPiA+IGluZGV4IGY5NGEwNGI0YWQ4Ny4uMGNlZGNlNDM4NDMzIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rydi5oCj4gPiBAQCAtMTIwOSw2ICsxMjA5LDkgQEAgc3RydWN0IGludGVs X2RwIHsKPiA+ICAKPiA+ICAJLyogRGlzcGxheXBvcnQgY29tcGxpYW5jZSB0ZXN0aW5nICovCj4g PiAgCXN0cnVjdCBpbnRlbF9kcF9jb21wbGlhbmNlIGNvbXBsaWFuY2U7Cj4gPiArCj4gPiArCS8q IERpc3BsYXkgc3RyZWFtIGNvbXByZXNzaW9uIHRlc3RpbmcgKi8KPiA+ICsJYm9vbCBmb3JjZV9k c2NfZW47Cj4gPiAgfTsKPiA+ICAKPiA+ICBlbnVtIGxzcGNvbl92ZW5kb3Igewo+IC0tIAo+IENo ZWVycywKPiAJTHl1ZGUgUGF1bAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK