From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 4/7] drm: Move the legacy kms disable_all
 helper to crtc helpers
Date: Tue, 11 Dec 2018 10:53:30 -0500
Message-ID: <20181211155330.GD154160@art_vandelay>
References: <20181210100359.22507-1-daniel.vetter@ffwll.ch>
 <20181210100359.22507-5-daniel.vetter@ffwll.ch>
 <CADnq5_ODEwoeY0uomUYcokYyqP0+e34-hN6i2RJNjPEV1Fs=2w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com
 [IPv6:2607:f8b0:4864:20::b42])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 6FEC86E26B
 for <intel-gfx@lists.freedesktop.org>; Tue, 11 Dec 2018 15:53:33 +0000 (UTC)
Received: by mail-yb1-xb42.google.com with SMTP id d187so6893479ybb.5
 for <intel-gfx@lists.freedesktop.org>; Tue, 11 Dec 2018 07:53:33 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <CADnq5_ODEwoeY0uomUYcokYyqP0+e34-hN6i2RJNjPEV1Fs=2w@mail.gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>, Maxime Ripard <maxime.ripard@bootlin.com>, Chunming Zhou <David1.Zhou@amd.com>, sbobroff@linux.ibm.com, Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, amd-gfx list <amd-gfx@lists.freedesktop.org>, Rex Zhu <Rex.Zhu@amd.com>, Dave Airlie <airlied@linux.ie>, Huang Rui <ray.huang@amd.com>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, nouveau <nouveau@lists.freedesktop.org>, "Deucher,
 Alexander" <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Shaoyun Liu <Shaoyun.Liu@amd.com>, Christian Koenig <christian.koenig@amd.com>, "monk.liu" <Monk.Liu@amd.com>, Ben Skeggs <bskeggs@redhat.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBEZWMgMTAsIDIwMTggYXQgMTA6NTg6MjBBTSAtMDUwMCwgQWxleCBEZXVjaGVyIHdy
b3RlOgo+IE9uIE1vbiwgRGVjIDEwLCAyMDE4IGF0IDU6MDQgQU0gRGFuaWVsIFZldHRlciA8ZGFu
aWVsLnZldHRlckBmZndsbC5jaD4gd3JvdGU6Cj4gPgo+ID4gSXQncyBub3QgYSBjb3JlIGZ1bmN0
aW9uLCBhbmQgdGhlIG1hdGNoaW5nIGF0b21pYyBmdW5jdGlvbnMgYXJlIGFsc28KPiA+IG5vdCBp
biB0aGUgY29yZS4gUGx1cyB0aGUgc3VzcGVuZC9yZXN1bWUgaGVscGVyIGlzIGFsc28gYWxyZWFk
eSB0aGVyZS4KPiA+Cj4gPiBOZWVkcyBhIHRpbnkgYml0IG9mIG9wZW4tY29kaW5nLCBidXQgbGVz
cyBtaWRsYXllciBiZWF0cyB0aGF0IEkgdGhpbmsuCj4gPgo+ID4gQ2M6IFNhbSBCb2Jyb2ZmIDxz
Ym9icm9mZkBsaW51eC5pYm0uY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8
ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gPiBDYzogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0
ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBNYXhpbWUgUmlwYXJkIDxtYXhp
bWUucmlwYXJkQGJvb3RsaW4uY29tPgo+ID4gQ2M6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVu
Pgo+ID4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiA+IENjOiBCZW4gU2tl
Z2dzIDxic2tlZ2dzQHJlZGhhdC5jb20+Cj4gPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIu
ZGV1Y2hlckBhbWQuY29tPgo+ID4gQ2M6ICJDaHJpc3RpYW4gS8O2bmlnIiA8Y2hyaXN0aWFuLmtv
ZW5pZ0BhbWQuY29tPgo+ID4gQ2M6ICJEYXZpZCAoQ2h1bk1pbmcpIFpob3UiIDxEYXZpZDEuWmhv
dUBhbWQuY29tPgo+ID4gQ2M6IFJleCBaaHUgPFJleC5aaHVAYW1kLmNvbT4KPiA+IENjOiBBbmRy
ZXkgR3JvZHpvdnNreSA8YW5kcmV5Lmdyb2R6b3Zza3lAYW1kLmNvbT4KPiA+IENjOiBIdWFuZyBS
dWkgPHJheS5odWFuZ0BhbWQuY29tPgo+ID4gQ2M6IFNoYW95dW4gTGl1IDxTaGFveXVuLkxpdUBh
bWQuY29tPgo+ID4gQ2M6IE1vbmsgTGl1IDxNb25rLkxpdUBhbWQuY29tPgo+ID4gQ2M6IG5vdXZl
YXVAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBDYzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp
Y2UuYyB8ICAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgICAgICAgICAgICAg
ICAgIHwgMzEgLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0
Y19oZWxwZXIuYyAgICAgICAgICB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysKPiA+ICBkcml2
ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXkuYyAgfCAgMiArLQo+ID4gIGRyaXZl
cnMvZ3B1L2RybS9yYWRlb24vcmFkZW9uX2Rpc3BsYXkuYyAgICB8ICAyICstCj4gPiAgaW5jbHVk
ZS9kcm0vZHJtX2NydGMuaCAgICAgICAgICAgICAgICAgICAgIHwgIDIgLS0KPiA+ICBpbmNsdWRl
L2RybS9kcm1fY3J0Y19oZWxwZXIuaCAgICAgICAgICAgICAgfCAgMSArCj4gPiAgNyBmaWxlcyBj
aGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPiA+Cgovc25pcAoKPiA+
IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMgYi9kcml2ZXJz
L2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMKPiA+IGluZGV4IGEzYzgxODUwZTc1NS4uMjMxNTll
YjQ5NGYxIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2hlbHBlci5j
Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaGVscGVyLmMKPiA+IEBAIC05ODQs
MyArOTg0LDM4IEBAIHZvaWQgZHJtX2hlbHBlcl9yZXN1bWVfZm9yY2VfbW9kZShzdHJ1Y3QgZHJt
X2RldmljZSAqZGV2KQo+ID4gICAgICAgICBkcm1fbW9kZXNldF91bmxvY2tfYWxsKGRldik7Cj4g
PiAgfQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX2hlbHBlcl9yZXN1bWVfZm9yY2VfbW9kZSk7Cj4g
PiArCj4gPiArLyoqCj4gPiArICogZHJtX2hlbHBlcl9mb3JjZV9kaXNhYmxlX2FsbCAtIEZvcmNp
Ymx5IHR1cm4gb2ZmIGFsbCBlbmFibGVkIENSVENzCj4gPiArICogQGRldjogRFJNIGRldmljZSB3
aG9zZSBDUlRDcyB0byB0dXJuIG9mZgo+ID4gKyAqCj4gPiArICogRHJpdmVycyBtYXkgd2FudCB0
byBjYWxsIHRoaXMgb24gdW5sb2FkIHRvIGVuc3VyZSB0aGF0IGFsbCBkaXNwbGF5cyBhcmUKPiA+
ICsgKiB1bmxpdCBhbmQgdGhlIEdQVSBpcyBpbiBhIGNvbnNpc3RlbnQsIGxvdyBwb3dlciBzdGF0
ZS4gVGFrZXMgbW9kZXNldCBsb2Nrcy4KPiA+ICsgKgo+ID4gKyAqIE5vdGU6IFRoaXMgc2hvdWxk
IG9ubHkgYmUgdXNlZCBieSBub24tYXRvbWljIGxlZ2FjeSBkcml2ZXJzLiBGb3IgYW4gYXRvbWlj
Cj4gPiArICogdmVyc2lvbiBsb29rIGF0IGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duKCkuCj4g
PiArICoKPiA+ICsgKiBSZXR1cm5zOgo+ID4gKyAqIFplcm8gb24gc3VjY2VzcywgZXJyb3IgY29k
ZSBvbiBmYWlsdXJlLgo+ID4gKyAqLwo+ID4gK2ludCBkcm1faGVscGVyX2ZvcmNlX2Rpc2FibGVf
YWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gCj4gTWF5YmUgcHV0IGNydGMgc29tZXdoZXJl
IGluIHRoZSBmdW5jdGlvbiBuYW1lIHNvIGl0J3MgY2xlYXIgd2hhdCB3ZQo+IGFyZSBkaXNhYmxp
bmcuCgpGV0lXLCBJIHRoaW5rIGl0J3MgbW9yZSBjbGVhciB0aGlzIHdheS4gc2V0X2NvbmZpZ19p
bnRlcm5hbCB3aWxsIHR1cm4gb2ZmCmV2ZXJ5dGhpbmcgYXR0YWNoZWQgdG8gdGhlIGNydGMsIHNv
IF9ldmVyeXRoaW5nXyB3aWxsIGJlIGRpc2FibGVkIGluIHRoaXMgY2FzZS4KCkVpdGhlciB3YXks
CgpSZXZpZXdlZC1ieTogU2VhbiBQYXVsIDxzZWFuQHBvb3JseS5ydW4+CgpTZWFuCgo+IFdpdGgg
dGhhdCBmaXhlZDoKPiBSZXZpZXdlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hl
ckBhbWQuY29tPgo+IAo+ID4gK3sKPiA+ICsgICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjOwo+
ID4gKyAgICAgICBpbnQgcmV0ID0gMDsKPiA+ICsKPiA+ICsgICAgICAgZHJtX21vZGVzZXRfbG9j
a19hbGwoZGV2KTsKPiA+ICsgICAgICAgZHJtX2Zvcl9lYWNoX2NydGMoY3J0YywgZGV2KQo+ID4g
KyAgICAgICAgICAgICAgIGlmIChjcnRjLT5lbmFibGVkKSB7Cj4gPiArICAgICAgICAgICAgICAg
ICAgICAgICBzdHJ1Y3QgZHJtX21vZGVfc2V0IHNldCA9IHsKPiA+ICsgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgLmNydGMgPSBjcnRjLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg
fTsKPiA+ICsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldCA9IGRybV9tb2RlX3NldF9j
b25maWdfaW50ZXJuYWwoJnNldCk7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0
KQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dDsKPiA+ICsgICAg
ICAgICAgICAgICB9Cj4gPiArb3V0Ogo+ID4gKyAgICAgICBkcm1fbW9kZXNldF91bmxvY2tfYWxs
KGRldik7Cj4gPiArICAgICAgIHJldHVybiByZXQ7Cj4gPiArfQo+ID4gK0VYUE9SVF9TWU1CT0wo
ZHJtX2hlbHBlcl9mb3JjZV9kaXNhYmxlX2FsbCk7Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n
cHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vbm91dmVh
dS9ub3V2ZWF1X2Rpc3BsYXkuYwo+ID4gaW5kZXggZjMyNmZmZDg2NzY2Li41ZDI3M2E2NTU0Nzkg
MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbm91dmVhdS9ub3V2ZWF1X2Rpc3BsYXku
Ywo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL25vdXZlYXUvbm91dmVhdV9kaXNwbGF5LmMKPiA+
IEBAIC00NTMsNyArNDUzLDcgQEAgbm91dmVhdV9kaXNwbGF5X2Zpbmkoc3RydWN0IGRybV9kZXZp
Y2UgKmRldiwgYm9vbCBzdXNwZW5kLCBib29sIHJ1bnRpbWUpCj4gPiAgICAgICAgICAgICAgICAg
aWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChkZXYpKQo+ID4gICAgICAgICAgICAgICAg
ICAgICAgICAgZHJtX2F0b21pY19oZWxwZXJfc2h1dGRvd24oZGV2KTsKPiA+ICAgICAgICAgICAg
ICAgICBlbHNlCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBkcm1fY3J0Y19mb3JjZV9kaXNh
YmxlX2FsbChkZXYpOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZHJtX2hlbHBlcl9mb3Jj
ZV9kaXNhYmxlX2FsbChkZXYpOwo+ID4gICAgICAgICB9Cj4gPgo+ID4gICAgICAgICAvKiBkaXNh
YmxlIGZsaXAgY29tcGxldGlvbiBldmVudHMgKi8KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vcmFkZW9uL3JhZGVvbl9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3Jh
ZGVvbl9kaXNwbGF5LmMKPiA+IGluZGV4IGU2OTEyZWI5OWI0Mi4uOTIzMzIyMjZlNWNmIDEwMDY0
NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yYWRlb25fZGlzcGxheS5jCj4gPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3JhZGVvbl9kaXNwbGF5LmMKPiA+IEBAIC0xNjQz
LDcgKzE2NDMsNyBAQCB2b2lkIHJhZGVvbl9tb2Rlc2V0X2Zpbmkoc3RydWN0IHJhZGVvbl9kZXZp
Y2UgKnJkZXYpCj4gPiAgICAgICAgIGlmIChyZGV2LT5tb2RlX2luZm8ubW9kZV9jb25maWdfaW5p
dGlhbGl6ZWQpIHsKPiA+ICAgICAgICAgICAgICAgICBkcm1fa21zX2hlbHBlcl9wb2xsX2Zpbmko
cmRldi0+ZGRldik7Cj4gPiAgICAgICAgICAgICAgICAgcmFkZW9uX2hwZF9maW5pKHJkZXYpOwo+
ID4gLSAgICAgICAgICAgICAgIGRybV9jcnRjX2ZvcmNlX2Rpc2FibGVfYWxsKHJkZXYtPmRkZXYp
Owo+ID4gKyAgICAgICAgICAgICAgIGRybV9oZWxwZXJfZm9yY2VfZGlzYWJsZV9hbGwocmRldi0+
ZGRldik7Cj4gPiAgICAgICAgICAgICAgICAgcmFkZW9uX2ZiZGV2X2ZpbmkocmRldik7Cj4gPiAg
ICAgICAgICAgICAgICAgcmFkZW9uX2FmbXRfZmluaShyZGV2KTsKPiA+ICAgICAgICAgICAgICAg
ICBkcm1fbW9kZV9jb25maWdfY2xlYW51cChyZGV2LT5kZGV2KTsKPiA+IGRpZmYgLS1naXQgYS9p
bmNsdWRlL2RybS9kcm1fY3J0Yy5oIGIvaW5jbHVkZS9kcm0vZHJtX2NydGMuaAo+ID4gaW5kZXgg
YjQ1YmVjMGI3YTljLi44NWFiZDNmZTllODMgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2RybS9k
cm1fY3J0Yy5oCj4gPiArKysgYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gPiBAQCAtMTE0OSw4
ICsxMTQ5LDYgQEAgc3RhdGljIGlubGluZSB1aW50MzJfdCBkcm1fY3J0Y19tYXNrKGNvbnN0IHN0
cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ICAgICAgICAgcmV0dXJuIDEgPDwgZHJtX2NydGNfaW5k
ZXgoY3J0Yyk7Cj4gPiAgfQo+ID4KPiA+IC1pbnQgZHJtX2NydGNfZm9yY2VfZGlzYWJsZV9hbGwo
c3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gPiAtCj4gPiAgaW50IGRybV9tb2RlX3NldF9jb25m
aWdfaW50ZXJuYWwoc3RydWN0IGRybV9tb2RlX3NldCAqc2V0KTsKPiA+ICBzdHJ1Y3QgZHJtX2Ny
dGMgKmRybV9jcnRjX2Zyb21faW5kZXgoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGlkeCk7
Cj4gPgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9jcnRjX2hlbHBlci5oIGIvaW5j
bHVkZS9kcm0vZHJtX2NydGNfaGVscGVyLmgKPiA+IGluZGV4IGQ2NWYwMzQ4NDNjZS4uMGVlOWE5
NmI3MGRhIDEwMDY0NAo+ID4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2NydGNfaGVscGVyLmgKPiA+
ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjX2hlbHBlci5oCj4gPiBAQCAtNTYsNiArNTYsNyBA
QCBib29sIGRybV9oZWxwZXJfZW5jb2Rlcl9pbl91c2Uoc3RydWN0IGRybV9lbmNvZGVyICplbmNv
ZGVyKTsKPiA+ICBpbnQgZHJtX2hlbHBlcl9jb25uZWN0b3JfZHBtcyhzdHJ1Y3QgZHJtX2Nvbm5l
Y3RvciAqY29ubmVjdG9yLCBpbnQgbW9kZSk7Cj4gPgo+ID4gIHZvaWQgZHJtX2hlbHBlcl9yZXN1
bWVfZm9yY2VfbW9kZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiA+ICtpbnQgZHJtX2hlbHBl
cl9mb3JjZV9kaXNhYmxlX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiA+Cj4gPiAgLyog
ZHJtX3Byb2JlX2hlbHBlci5jICovCj4gPiAgaW50IGRybV9oZWxwZXJfcHJvYmVfc2luZ2xlX2Nv
bm5lY3Rvcl9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcgo+ID4gLS0KPiA+IDIuMjAuMC5yYzEK
PiA+Cj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+
ID4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiA+IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1n
ZngKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBP
UwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1n
ZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK