From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: DFSM pipe disable is valid from gen9 onwards
Date: Tue, 11 Dec 2018 19:45:15 +0200 [thread overview]
Message-ID: <20181211174515.GA9144@intel.com> (raw)
In-Reply-To: <20181211173043.137972-1-bob.j.paauwe@intel.com>
On Tue, Dec 11, 2018 at 09:30:43AM -0800, Bob Paauwe wrote:
> It's not just GEN9 platforms that allow for pipes to be disabled via
> the DFSM register, but all later platforms as well.
>
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 1e56319334f3..7ac641e8c0bd 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -811,7 +811,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
> DRM_INFO("PipeC fused off\n");
> info->num_pipes -= 1;
> }
> - } else if (HAS_DISPLAY(dev_priv) && IS_GEN9(dev_priv)) {
> + } else if (HAS_DISPLAY(dev_priv) && (INTEL_GEN(dev_priv) >= 9)) {
^ ^
Drop the pointless parens please. Otherwise seems good.
> u32 dfsm = I915_READ(SKL_DFSM);
> u8 disabled_mask = 0;
> bool invalid;
> --
> 2.17.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-11 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 17:30 [PATCH] drm/i915: DFSM pipe disable is valid from gen9 onwards Bob Paauwe
2018-12-11 17:45 ` Ville Syrjälä [this message]
2018-12-11 17:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-12-11 19:25 ` [PATCH] drm/i915: DFSM pipe disable is valid from gen9 onwards (v2) Bob Paauwe
2018-12-12 0:28 ` Matt Roper
2018-12-11 19:41 ` ✓ Fi.CI.IGT: success for drm/i915: DFSM pipe disable is valid from gen9 onwards Patchwork
2018-12-11 19:51 ` ✓ Fi.CI.BAT: success for drm/i915: DFSM pipe disable is valid from gen9 onwards (rev2) Patchwork
2018-12-12 0:51 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211174515.GA9144@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).