From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v3 3/3] drm/i915: merge gen checks to use range
Date: Wed, 12 Dec 2018 17:01:48 -0800 [thread overview]
Message-ID: <20181213010148.GB10748@intel.com> (raw)
In-Reply-To: <87lg4w5dwy.fsf@intel.com>
On Tue, Dec 11, 2018 at 04:35:57PM +0200, Jani Nikula wrote:
> On Wed, 05 Dec 2018, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> > Instead of using IS_GEN() for consecutive gen checks, let's pass the
> > range to IS_GEN_RANGE(). By code inspection these were the ranges deemed
> > necessary for spatch:
> >
> > @@
> > expression e;
> > @@
> > (
> > - IS_GEN(e, 3) || IS_GEN(e, 2)
> > + IS_GEN_RANGE(e, 2, 3)
> > |
> > - IS_GEN(e, 3) || IS_GEN(e, 4)
> > + IS_GEN_RANGE(e, 3, 4)
> > |
> > - IS_GEN(e, 5) || IS_GEN(e, 6)
> > + IS_GEN_RANGE(e, 5, 6)
> > |
> > - IS_GEN(e, 6) || IS_GEN(e, 7)
> > + IS_GEN_RANGE(e, 6, 7)
> > |
> > - IS_GEN(e, 7) || IS_GEN(e, 8)
> > + IS_GEN_RANGE(e, 7, 8)
> > |
> > - IS_GEN(e, 8) || IS_GEN(e, 9)
> > + IS_GEN_RANGE(e, 8, 9)
> > |
> > - IS_GEN(e, 10) || IS_GEN(e, 9)
> > + IS_GEN_RANGE(e, 9, 10)
> > |
> > - IS_GEN(e, 9) || IS_GEN(e, 10)
> > + IS_GEN_RANGE(e, 9, 10)
> > )
> >
> > After conversion, checking we don't have any missing IS_GEN_RANGE() ||
> > IS_GEN() was also done.
> >
> > Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Should've just looked at the whole series before commenting on the
> others. It's all
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Thanks.
Pushed.
>
>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 6 +++---
> > drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
> > drivers/gpu/drm/i915/i915_perf.c | 2 +-
> > drivers/gpu/drm/i915/intel_crt.c | 2 +-
> > drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> > drivers/gpu/drm/i915/intel_display.c | 2 +-
> > drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
> > drivers/gpu/drm/i915/intel_fifo_underrun.c | 2 +-
> > drivers/gpu/drm/i915/intel_pipe_crc.c | 4 ++--
> > drivers/gpu/drm/i915/intel_uncore.c | 6 +++---
> > 10 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 53e3f57a13f3..33ff75c6a4a3 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2034,7 +2034,7 @@ static int i915_swizzle_info(struct seq_file *m, void *data)
> > seq_printf(m, "bit6 swizzle for Y-tiling = %s\n",
> > swizzle_string(dev_priv->mm.bit_6_swizzle_y));
> >
> > - if (IS_GEN(dev_priv, 3) || IS_GEN(dev_priv, 4)) {
> > + if (IS_GEN_RANGE(dev_priv, 3, 4)) {
> > seq_printf(m, "DDC = 0x%08x\n",
> > I915_READ(DCC));
> > seq_printf(m, "DDC2 = 0x%08x\n",
> > @@ -4268,7 +4268,7 @@ i915_cache_sharing_get(void *data, u64 *val)
> > struct drm_i915_private *dev_priv = data;
> > u32 snpcr;
> >
> > - if (!(IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7)))
> > + if (!(IS_GEN_RANGE(dev_priv, 6, 7)))
> > return -ENODEV;
> >
> > intel_runtime_pm_get(dev_priv);
> > @@ -4288,7 +4288,7 @@ i915_cache_sharing_set(void *data, u64 val)
> > struct drm_i915_private *dev_priv = data;
> > u32 snpcr;
> >
> > - if (!(IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7)))
> > + if (!(IS_GEN_RANGE(dev_priv, 6, 7)))
> > return -ENODEV;
> >
> > if (val > 3)
> > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> > index ccfd91c72477..581a40ac3591 100644
> > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > @@ -1753,7 +1753,7 @@ static void capture_reg_state(struct i915_gpu_state *error)
> > error->ccid = I915_READ(CCID);
> >
> > /* 3: Feature specific registers */
> > - if (IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7)) {
> > + if (IS_GEN_RANGE(dev_priv, 6, 7)) {
> > error->gam_ecochk = I915_READ(GAM_ECOCHK);
> > error->gac_eco = I915_READ(GAC_ECO_BITS);
> > }
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> > index 6c7992320443..4288c0e02f0c 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -3415,7 +3415,7 @@ void i915_perf_init(struct drm_i915_private *dev_priv)
> > dev_priv->perf.oa.ops.read = gen8_oa_read;
> > dev_priv->perf.oa.ops.oa_hw_tail_read = gen8_oa_hw_tail_read;
> >
> > - if (IS_GEN(dev_priv, 8) || IS_GEN(dev_priv, 9)) {
> > + if (IS_GEN_RANGE(dev_priv, 8, 9)) {
> > dev_priv->perf.oa.ops.is_valid_b_counter_reg =
> > gen7_is_valid_b_counter_addr;
> > dev_priv->perf.oa.ops.is_valid_mux_reg =
> > diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c
> > index bf4fd739b68c..0a41e58d61de 100644
> > --- a/drivers/gpu/drm/i915/intel_crt.c
> > +++ b/drivers/gpu/drm/i915/intel_crt.c
> > @@ -322,7 +322,7 @@ intel_crt_mode_valid(struct drm_connector *connector,
> > * DAC limit supposedly 355 MHz.
> > */
> > max_clock = 270000;
> > - else if (IS_GEN(dev_priv, 3) || IS_GEN(dev_priv, 4))
> > + else if (IS_GEN_RANGE(dev_priv, 3, 4))
> > max_clock = 400000;
> > else
> > max_clock = 350000;
> > diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> > index 332790279e1d..dc4fa83e26ef 100644
> > --- a/drivers/gpu/drm/i915/intel_device_info.c
> > +++ b/drivers/gpu/drm/i915/intel_device_info.c
> > @@ -787,7 +787,7 @@ void intel_device_info_runtime_init(struct intel_device_info *info)
> > DRM_INFO("Display disabled (module parameter)\n");
> > info->num_pipes = 0;
> > } else if (HAS_DISPLAY(dev_priv) &&
> > - (IS_GEN(dev_priv, 7) || IS_GEN(dev_priv, 8)) &&
> > + (IS_GEN_RANGE(dev_priv, 7, 8)) &&
> > HAS_PCH_SPLIT(dev_priv)) {
> > u32 fuse_strap = I915_READ(FUSE_STRAP);
> > u32 sfuse_strap = I915_READ(SFUSE_STRAP);
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 07ddb06fec65..a5816bc4d094 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -10817,7 +10817,7 @@ int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_crtc_stat
> > * the w/a on all three platforms.
> > */
> > if (plane->id == PLANE_SPRITE0 &&
> > - (IS_GEN(dev_priv, 5) || IS_GEN(dev_priv, 6) ||
> > + (IS_GEN_RANGE(dev_priv, 5, 6) ||
> > IS_IVYBRIDGE(dev_priv)) &&
> > (turn_on || (!needs_scaling(old_plane_state) &&
> > needs_scaling(to_intel_plane_state(plane_state)))))
> > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c
> > index 8ff794db7881..66d0ad9c36c4 100644
> > --- a/drivers/gpu/drm/i915/intel_engine_cs.c
> > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c
> > @@ -438,7 +438,7 @@ void intel_engine_init_global_seqno(struct intel_engine_cs *engine, u32 seqno)
> > * the semaphore value, then when the seqno moves backwards all
> > * future waits will complete instantly (causing rendering corruption).
> > */
> > - if (IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7)) {
> > + if (IS_GEN_RANGE(dev_priv, 6, 7)) {
> > I915_WRITE(RING_SYNC_0(engine->mmio_base), 0);
> > I915_WRITE(RING_SYNC_1(engine->mmio_base), 0);
> > if (HAS_VEBOX(dev_priv))
> > diff --git a/drivers/gpu/drm/i915/intel_fifo_underrun.c b/drivers/gpu/drm/i915/intel_fifo_underrun.c
> > index ff2743ccbece..9b39975c8389 100644
> > --- a/drivers/gpu/drm/i915/intel_fifo_underrun.c
> > +++ b/drivers/gpu/drm/i915/intel_fifo_underrun.c
> > @@ -260,7 +260,7 @@ static bool __intel_set_cpu_fifo_underrun_reporting(struct drm_device *dev,
> >
> > if (HAS_GMCH_DISPLAY(dev_priv))
> > i9xx_set_fifo_underrun_reporting(dev, pipe, enable, old);
> > - else if (IS_GEN(dev_priv, 5) || IS_GEN(dev_priv, 6))
> > + else if (IS_GEN_RANGE(dev_priv, 5, 6))
> > ironlake_set_fifo_underrun_reporting(dev, pipe, enable);
> > else if (IS_GEN(dev_priv, 7))
> > ivybridge_set_fifo_underrun_reporting(dev, pipe, enable, old);
> > diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.c b/drivers/gpu/drm/i915/intel_pipe_crc.c
> > index 9e870caf8104..bdabcfab8090 100644
> > --- a/drivers/gpu/drm/i915/intel_pipe_crc.c
> > +++ b/drivers/gpu/drm/i915/intel_pipe_crc.c
> > @@ -433,7 +433,7 @@ static int get_new_crc_ctl_reg(struct drm_i915_private *dev_priv,
> > return i9xx_pipe_crc_ctl_reg(dev_priv, pipe, source, val);
> > else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> > return vlv_pipe_crc_ctl_reg(dev_priv, pipe, source, val);
> > - else if (IS_GEN(dev_priv, 5) || IS_GEN(dev_priv, 6))
> > + else if (IS_GEN_RANGE(dev_priv, 5, 6))
> > return ilk_pipe_crc_ctl_reg(source, val);
> > else
> > return ivb_pipe_crc_ctl_reg(dev_priv, pipe, source, val, set_wa);
> > @@ -550,7 +550,7 @@ intel_is_valid_crc_source(struct drm_i915_private *dev_priv,
> > return i9xx_crc_source_valid(dev_priv, source);
> > else if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> > return vlv_crc_source_valid(dev_priv, source);
> > - else if (IS_GEN(dev_priv, 5) || IS_GEN(dev_priv, 6))
> > + else if (IS_GEN_RANGE(dev_priv, 5, 6))
> > return ilk_crc_source_valid(dev_priv, source);
> > else
> > return ivb_crc_source_valid(dev_priv, source);
> > diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> > index c6eb053a8fad..ec6dde2e59eb 100644
> > --- a/drivers/gpu/drm/i915/intel_uncore.c
> > +++ b/drivers/gpu/drm/i915/intel_uncore.c
> > @@ -528,7 +528,7 @@ check_for_unclaimed_mmio(struct drm_i915_private *dev_priv)
> > if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
> > ret |= vlv_check_for_unclaimed_mmio(dev_priv);
> >
> > - if (IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7))
> > + if (IS_GEN_RANGE(dev_priv, 6, 7))
> > ret |= gen6_check_for_fifo_debug(dev_priv);
> >
> > return ret;
> > @@ -556,7 +556,7 @@ static void __intel_uncore_early_sanitize(struct drm_i915_private *dev_priv,
> > dev_priv->uncore.funcs.force_wake_get(dev_priv,
> > restore_forcewake);
> >
> > - if (IS_GEN(dev_priv, 6) || IS_GEN(dev_priv, 7))
> > + if (IS_GEN_RANGE(dev_priv, 6, 7))
> > dev_priv->uncore.fifo_count =
> > fifo_free_entries(dev_priv);
> > spin_unlock_irq(&dev_priv->uncore.lock);
> > @@ -1437,7 +1437,7 @@ static void intel_uncore_fw_domains_init(struct drm_i915_private *dev_priv)
> > FORCEWAKE_MEDIA_VEBOX_GEN11(i),
> > FORCEWAKE_ACK_MEDIA_VEBOX_GEN11(i));
> > }
> > - } else if (IS_GEN(dev_priv, 10) || IS_GEN(dev_priv, 9)) {
> > + } else if (IS_GEN_RANGE(dev_priv, 9, 10)) {
> > dev_priv->uncore.funcs.force_wake_get =
> > fw_domains_get_with_fallback;
> > dev_priv->uncore.funcs.force_wake_put = fw_domains_put;
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-12-13 1:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 6:11 [PATCH v3 0/3] Make GEN macros more similar Lucas De Marchi
2018-12-06 6:11 ` [PATCH v3 1/3] drm/i915: Rename IS_GEN to IS_GEN_RANGE Lucas De Marchi
2018-12-06 12:28 ` Tvrtko Ursulin
2018-12-11 14:24 ` Jani Nikula
2018-12-06 6:11 ` [PATCH v3 2/3] drm/i915: replace IS_GEN<N> with IS_GEN(..., N) Lucas De Marchi
2018-12-06 12:37 ` Tvrtko Ursulin
2018-12-07 1:17 ` Lucas De Marchi
2018-12-07 11:30 ` Tvrtko Ursulin
2018-12-07 11:42 ` Tvrtko Ursulin
2018-12-07 20:57 ` Lucas De Marchi
2018-12-10 8:27 ` Tvrtko Ursulin
2018-12-11 14:34 ` Jani Nikula
2018-12-06 6:11 ` [PATCH v3 3/3] drm/i915: merge gen checks to use range Lucas De Marchi
2018-12-11 14:35 ` Jani Nikula
2018-12-13 1:01 ` Rodrigo Vivi [this message]
2018-12-06 6:32 ` ✗ Fi.CI.CHECKPATCH: warning for Make GEN macros more similar (rev3) Patchwork
2018-12-06 6:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-12-06 6:49 ` ✓ Fi.CI.BAT: success " Patchwork
2018-12-06 20:20 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213010148.GB10748@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).