From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 1/2] drm: Add color management LUT validation helper (v2) Date: Mon, 17 Dec 2018 15:55:19 +0200 Message-ID: <20181217135519.GN9144@intel.com> References: <20181213215526.31991-1-matthew.d.roper@intel.com> <20181213215526.31991-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181213215526.31991-2-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBEZWMgMTMsIDIwMTggYXQgMDE6NTU6MjVQTSAtMDgwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBTb21lIGhhcmR3YXJlIG1heSBwbGFjZSBhZGRpdGlvbmFsIHJlc3RyaWN0aW9ucyBvbiB0 aGUgZ2FtbWEvZGVnYW1tYQo+IGN1cnZlcyBkZXNjcmliZWQgYnkgb3VyIExVVCBwcm9wZXJ0aWVz LiAgRS5nLiwgdGhhdCBhIGdhbW1hIGN1cnZlIG5ldmVyCj4gZGVjcmVhc2VzIG9yIHRoYXQgdGhl IHJlZC9ncmVlbi9ibHVlIGNoYW5uZWxzIG9mIGEgTFVUJ3MgZW50cmllcyBtdXN0IGJlCj4gZXF1 YWwuICBMZXQncyBhZGQgYSBoZWxwZXIgZnVuY3Rpb24gdGhhdCBkcml2ZXJzIGNhbiB1c2UgdG8g dGVzdCB0aGF0IGEKPiB1c2Vyc3BhY2UtcHJvdmlkZWQgTFVUIGlzIHZhbGlkIGFuZCBkb2Vzbid0 IHZpb2xhdGUgaGFyZHdhcmUKPiByZXF1aXJlbWVudHMuCj4gCj4gdjI6Cj4gIC0gQ29tYmluZSBp bnRvIGEgc2luZ2xlIGhlbHBlciB0aGF0IGp1c3QgdGFrZXMgYSBiaXRtYXNrIG9mIHRoZSB0ZXN0 cwo+ICAgIHRvIGFwcGx5LiAgKEJyaWFuIFN0YXJrZXkpCj4gIC0gQWRkIGFkZGl0aW9uYWwgY2hl Y2sgKGFsd2F5cyBwZXJmb3JtZWQpIHRoYXQgTFVUIHByb3BlcnR5IGJsb2Igc2l6ZQo+ICAgIGlz IGFsd2F5cyBhIG11bHRpcGxlIG9mIHRoZSBMVVQgZW50cnkgc2l6ZS4gIChzdG9sZW4gZnJvbSBB Uk0gZHJpdmVyKQo+IAo+IENjOiBVbWEgU2hhbmthciA8dW1hLnNoYW5rYXJAaW50ZWwuY29tPgo+ IENjOiBTd2F0aSBTaGFybWEgPHN3YXRpMi5zaGFybWFAaW50ZWwuY29tPgo+IENjOiBCcmlhbiBT dGFya2V5IDxCcmlhbi5TdGFya2V5QGFybS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogTWF0dCBSb3Bl ciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieSh2MSk6IEJyaWFuIFN0 YXJrZXkgPGJyaWFuLnN0YXJrZXlAYXJtLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2Ry bV9jb2xvcl9tZ210LmMgfCA2NCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrCj4gIGluY2x1ZGUvZHJtL2RybV9jb2xvcl9tZ210LmggICAgIHwgIDUgKysrKwo+ICAyIGZp bGVzIGNoYW5nZWQsIDY5IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9jb2xvcl9tZ210LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2NvbG9yX21nbXQu Ywo+IGluZGV4IDA3ZGNmNDdkYWFmZS4uNWMyYTJkMjI4NDEyIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fY29sb3JfbWdtdC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9j b2xvcl9tZ210LmMKPiBAQCAtNDYyLDMgKzQ2Miw2NyBAQCBpbnQgZHJtX3BsYW5lX2NyZWF0ZV9j b2xvcl9wcm9wZXJ0aWVzKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJcmV0dXJuIDA7Cj4g IH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fcGxhbmVfY3JlYXRlX2NvbG9yX3Byb3BlcnRpZXMpOwo+ ICsKPiArLyoqCj4gKyAqIGRybV9jb2xvcl9sdXRfY2hlY2sgLSBjaGVjayB2YWxpZGl0eSBvZiBs b29rdXAgdGFibGUKPiArICogQGx1dDogcHJvcGVydHkgYmxvYiBjb250YWluaW5nIExVVCB0byBj aGVjawo+ICsgKiBAdGVzdHM6IGJpdG1hc2sgb2YgdGVzdHMgdG8gcnVuCj4gKyAqCj4gKyAqIEhl bHBlciB0byBjaGVjayB3aGV0aGVyIGEgdXNlcnNwYWNlLXByb3ZpZGVkIGxvb2t1cCB0YWJsZSBp cyB2YWxpZCBhbmQKPiArICogc2F0aXNmaWVzIGFkZGl0aW9uYWwgaGFyZHdhcmUgcmVxdWlyZW1l bnRzLiAgQWxsIHRhYmxlIHNpemVzIHNob3VsZCBiZSBhCj4gKyAqIG11bHRpcGxlIG9mIHNpemVv ZihzdHJ1Y3QgZHJtX2NvbG9yX2x1dCkuICBEcml2ZXJzIHBhc3MgYSBiaXRtYXNrIGluZGljYXRp bmcKPiArICogd2hpY2ggb2YgdGhlIGZvbGxvd2luZyBhZGRpdGlvbmFsIHRlc3RzIHNob3VsZCBh bHNvIGJlIHBlcmZvcm1lZDoKPiArICoKPiArICogIkRSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5F TFMiOgo+ICsgKiAgICAgQ2hlY2tzIHdoZXRoZXIgdGhlIGVudHJpZXMgb2YgYSBMVVQgYWxsIGhh dmUgZXF1YWwgdmFsdWVzIGZvciB0aGUgcmVkLAo+ICsgKiAgICAgZ3JlZW4sIGFuZCBibHVlIGNo YW5uZWxzLiAgSW50ZW5kZWQgZm9yIGhhcmR3YXJlIHRoYXQgb25seSBhY2NlcHRzIGEKPiArICog ICAgIHNpbmdsZSB2YWx1ZSBwZXIgTFVUIGVudHJ5IGFuZCBhc3N1bWVzIHRoYXQgdmFsdWUgYXBw bGllcyB0byBhbGwgdGhyZWUKPiArICogICAgIGNvbG9yIGNvbXBvbmVudHMuCj4gKyAqCj4gKyAq ICJEUk1fQ09MT1JfTFVUX0lOQ1JFQVNJTkciOgo+ICsgKiAgICAgQ2hlY2tzIHdoZXRoZXIgdGhl IGVudHJpZXMgb2YgYSBMVVQgYXJlIGFsd2F5cyBmbGF0IG9yIGluY3JlYXNpbmcKPiArICogICAg IChuZXZlciBkZWNyZWFzaW5nKS4KCkRSTV9DT0xPUl9MVVRfTk9OX0RFQ1JFQVNJTkc/CgpPciBE Uk1fQ09MT1JfTFVUX01PTk9UT05JQ0FMTFlfSU5DUkVBU0lORywgYnV0IHRoYXQncyBnZXR0aW5n CmEgYml0IGxvbmcgOikKCj4gKyAqCj4gKyAqIFJldHVybnMgMCBvbiBzdWNjZXNzLCAtRUlOVkFM IG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtpbnQgZHJtX2NvbG9yX2x1dF9jaGVjayhzdHJ1Y3QgZHJt X3Byb3BlcnR5X2Jsb2IgKmx1dCwKPiArCQkJIHVpbnQzMl90IHRlc3RzKQo+ICt7Cj4gKwlzdHJ1 Y3QgZHJtX2NvbG9yX2x1dCAqZW50cnk7Cj4gKwlpbnQgaTsKPiArCj4gKwlpZiAoIWx1dCkKPiAr CQlyZXR1cm4gMDsKPiArCj4gKwlpZiAobHV0LT5sZW5ndGggJSBzaXplb2Yoc3RydWN0IGRybV9j b2xvcl9sdXQpKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiTFVUIHNpemUgKCVsdSkgaXMgbm90IGEg bXVsdGlwbGUgb2YgTFVUIGVudHJ5IHNpemUgKCVsdSlcbiIsCj4gKwkJCSAgICAgIGx1dC0+bGVu Z3RoLCBzaXplb2Yoc3RydWN0IGRybV9jb2xvcl9sdXQpKTsKPiArCQlyZXR1cm4gLUVJTlZBTDsK PiArCX0KPiArCj4gKwlpZiAoIXRlc3RzKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCWVudHJ5ID0g bHV0LT5kYXRhOwo+ICsJZm9yIChpID0gMDsgaSA8IGRybV9jb2xvcl9sdXRfc2l6ZShsdXQpOyBp KyspIHsKPiArCQlpZiAodGVzdHMgJiBEUk1fQ09MT1JfTFVUX0VRVUFMX0NIQU5ORUxTKSB7Cj4g KwkJCWlmIChlbnRyeVtpXS5yZWQgIT0gZW50cnlbaV0uYmx1ZSB8fAo+ICsJCQkgICAgZW50cnlb aV0ucmVkICE9IGVudHJ5W2ldLmdyZWVuKSB7Cj4gKwkJCQlEUk1fREVCVUdfS01TKCJBbGwgTFVU IGVudHJpZXMgbXVzdCBoYXZlIGVxdWFsIHIvZy9iXG4iKTsKPiArCQkJCXJldHVybiAtRUlOVkFM Owo+ICsJCQl9Cj4gKwkJfQo+ICsKPiArCQlpZiAoaSA+IDAgJiYgdGVzdHMgJiBEUk1fQ09MT1Jf TFVUX0lOQ1JFQVNJTkcpIHsKPiArCQkJaWYgKGVudHJ5W2ldLnJlZCA8IGVudHJ5W2kgLSAxXS5y ZWQgfHwKPiArCQkJICAgIGVudHJ5W2ldLmdyZWVuIDwgZW50cnlbaSAtIDFdLmdyZWVuIHx8Cj4g KwkJCSAgICBlbnRyeVtpXS5ibHVlIDwgZW50cnlbaSAtIDFdLmJsdWUpIHsKPiArCQkJCURSTV9E RUJVR19LTVMoIkxVVCBlbnRyaWVzIG11c3QgbmV2ZXIgZGVjcmVhc2UuXG4iKTsKPiArCQkJCXJl dHVybiAtRUlOVkFMOwo+ICsJCQl9Cj4gKwkJfQo+ICsJfQo+ICsKPiArCXJldHVybiAwOwo+ICt9 Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2NvbG9yX2x1dF9jaGVjayk7Cj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvZHJtL2RybV9jb2xvcl9tZ210LmggYi9pbmNsdWRlL2RybS9kcm1fY29sb3JfbWdtdC5o Cj4gaW5kZXggOTBlZjk5OTZkOWE0Li43ZGUxNmY3MGJjYzMgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS9kcm0vZHJtX2NvbG9yX21nbXQuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jb2xvcl9tZ210 LmgKPiBAQCAtNjksNCArNjksOSBAQCBpbnQgZHJtX3BsYW5lX2NyZWF0ZV9jb2xvcl9wcm9wZXJ0 aWVzKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJCQkJICAgICAgdTMyIHN1cHBvcnRlZF9y YW5nZXMsCj4gIAkJCQkgICAgICBlbnVtIGRybV9jb2xvcl9lbmNvZGluZyBkZWZhdWx0X2VuY29k aW5nLAo+ICAJCQkJICAgICAgZW51bSBkcm1fY29sb3JfcmFuZ2UgZGVmYXVsdF9yYW5nZSk7Cj4g Kwo+ICsjZGVmaW5lIERSTV9DT0xPUl9MVVRfRVFVQUxfQ0hBTk5FTFMgQklUKDApCj4gKyNkZWZp bmUgRFJNX0NPTE9SX0xVVF9JTkNSRUFTSU5HICAgICBCSVQoMSkKPiAraW50IGRybV9jb2xvcl9s dXRfY2hlY2soc3RydWN0IGRybV9wcm9wZXJ0eV9ibG9iICpsdXQsCj4gKwkJCXVpbnQzMl90IHRl c3RzKTsKPiAgI2VuZGlmCj4gLS0gCj4gMi4xNC40Cj4gCj4gX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=